Commit Graph

747 Commits

Author SHA1 Message Date
9417470b3b const poison. (Belatedly goes with my change of 2000-02-23.)
* camel-medium.[ch] (camel_medium_add_header): const poison.
	(Belatedly goes with my change of 2000-02-23.)
	(camel_medium_init): Use g_strcase_{hash,equal} on the header
	array.

svn path=/trunk/; revision=2510
2000-04-19 20:30:53 +00:00
80b463a043 do better reference counting of streams so they actually go away when they
* camel-mime-part.c (my_set_input_stream):
	* camel-data-wrapper.c (set_input_stream, set_output_stream): do
	better reference counting of streams so they actually go away
	when they should.

svn path=/trunk/; revision=2490
2000-04-19 03:20:13 +00:00
fe97fa2fbb kill camel-log
svn path=/trunk/; revision=2487
2000-04-18 19:05:15 +00:00
b0c0886afa added 2nd arg to g_return_val_if_fail so this builds
svn path=/trunk/; revision=2486
2000-04-18 18:22:55 +00:00
bc17057ec5 Clean, polish, document. Most of the gtk-doc comments added to
* camel-data-wrapper.[ch]:
	* camel-simple-data-wrapper.[ch]:
	* camel-medium.[ch]: Clean, polish, document. Most of the gtk-doc
	comments added to camel-data-wrapper.c note serious problems that
	need to be fixed.

svn path=/trunk/; revision=2483
2000-04-18 18:11:24 +00:00
96b306af32 Remove the "session" field from CamelMimeMessage. Nothing uses it, about
* camel-mime-message.[ch]: Remove the "session" field from
	CamelMimeMessage. Nothing uses it, about half of the existing
	calls to camel_mime_message_new_with_session pass NULL, and
	there's no obvious reason for it to be there.

	* others: Use camel_mime_message_new instead of
	camel_mime_message_new_with_session

svn path=/trunk/; revision=2479
2000-04-17 20:23:30 +00:00
4f686ae899 Set the exception if no provider is found.
* camel-session.c (get_store_for_protocol_with_url): Set the
	exception if no provider is found.

svn path=/trunk/; revision=2477
2000-04-17 19:38:16 +00:00
9d802454e6 Add code to encode and decode %-escapes in URLs, and do some additional
2000-04-17  Dan Winship  <danw@helixcode.com>

	* camel-url.c: Add code to encode and decode %-escapes in URLs,
	and do some additional correctness-checking on URL syntax. From
	Tiago Antào with modifications by me.

svn path=/trunk/; revision=2474
2000-04-17 18:14:31 +00:00
bdf982f30a add nntp
* providers/Makefile.am (SUBDIRS): add nntp

svn path=/trunk/; revision=2448
2000-04-15 02:11:28 +00:00
b6bf167857 Fix switch statement.
2000-04-14  Christopher James Lahey  <clahey@helixcode.com>

	* providers/mbox/camel-mbox-folder.c: Fix switch statement.

svn path=/trunk/; revision=2447
2000-04-15 01:54:44 +00:00
566b5183cb always return TRUE for now. we need to check the server response to make
* providers/nntp/camel-nntp-folder.c (_exists): always return TRUE
	for now.  we need to check the server response to make sure the
	group exists.
	(_get_message_by_uid): make sure to account for the \n we add to
	the string after every line.

	* providers/nntp/camel-nntp-utils.c (get_XOVER_headers): function
	to get the headers using the XOVER command.
	(get_HEAD_headers): function to get the headers using the HEAD
	command on each message. slooooooow.
	(camel_nntp_get_headers): make this function use either XOVER or HEAD
	versions depending on whether or not the server extension is present.

svn path=/trunk/; revision=2445
2000-04-15 00:46:30 +00:00
64308c919c packed their bags and moved to ../mail/
svn path=/trunk/; revision=2439
2000-04-14 21:44:03 +00:00
0937d957d6 This didn't belong in Camel. Move to mail/
2000-04-14  Dan Winship  <danw@helixcode.com>

	* camel-formatter.[ch]: This didn't belong in Camel. Move to mail/

	* Makefile.am, camel-types.h: remove references to
	camel-formatter.

svn path=/trunk/; revision=2436
2000-04-14 21:09:19 +00:00
6f7c1a1944 [This was accidentally not committed with its ChangeLog entry somehow...]
* camel-provider.h: Clarify what provider.protocol, provider.name,
	and provider.description should be.

svn path=/trunk/; revision=2434
2000-04-14 20:37:04 +00:00
5bc90b52aa add XXX so i can find this hardcoded string later.
svn path=/trunk/; revision=2433
2000-04-14 20:30:21 +00:00
2395239984 okay. working now.
svn path=/trunk/; revision=2432
2000-04-14 20:29:33 +00:00
ab0e676fd9 initial import of nntp store.
svn path=/trunk/; revision=2430
2000-04-14 19:05:33 +00:00
73b0317b1f + * art/Makefile.am: Add tigert's contact-dlg-related images.
+
+	* addressbook/contact-editor/e-contact-editor.c (_add_images): Add
+	tigert's images.
+
+	* addressbook/contact-editor/Makefile.am: add EVOLUTION_IMAGES.
+
+	* camel-folder-pt-proxy.c (_folder_open_cb): Print warning message
+	for broken function.
+	(_folder_close_cb): Same.
+
+	* filter-arg.c (filter_arg_edit_value): Return a value.

svn path=/trunk/; revision=2408
2000-04-12 13:46:10 +00:00
3ef836d8a7 Fix the embarassing cursor bug.
Fix the embarassing cursor bug.

svn path=/trunk/; revision=2404
2000-04-12 04:50:02 +00:00
50a2e734db fix various bugs in APOP code (still untested) and some of the error
* providers/pop3/camel-pop3-store.c (pop3_connect): fix various
	bugs in APOP code (still untested) and some of the error cases.

svn path=/trunk/; revision=2376
2000-04-10 19:27:29 +00:00
4d2972e69f Clarify what provider.protocol, provider.name, and provider.description
* camel-provider.h: Clarify what provider.protocol, provider.name,
	and provider.description should be.

	* providers/mbox/camel-mbox-provider.c:
	* providers/pop3/camel-pop3-provider.c:
	* providers/sendmail/camel-sendmail-provider.c:
	* providers/smtp/camel-smtp-provider.c: update protocols, names,
	and descriptions

svn path=/trunk/; revision=2365
2000-04-10 18:01:45 +00:00
7d8c98fb7d implement get_message_by_number for the mail fetch code.
* providers/mbox/camel-mbox-folder.c (_get_message_by_number):
	implement get_message_by_number for the mail fetch code.

svn path=/trunk/; revision=2358
2000-04-10 14:27:22 +00:00
325ed84013 o Reformatted providers/smtp/camel-smtp-transport.c to fit the standard
Sun Apr  9 21:23:15 EDT 2000  Jeffrey Stedfast  <fejj@stampede.org>
  o Reformatted providers/smtp/camel-smtp-transport.c to fit the standard indent format used by helix code

svn path=/trunk/; revision=2357
2000-04-10 00:47:57 +00:00
fc87a9ba54 New file with new function to dot-lock an mbox file and copy it to a safe
* camel-movemail.c: New file with new function to dot-lock an mbox
	file and copy it to a safe private directory.

svn path=/trunk/; revision=2356
2000-04-09 22:47:42 +00:00
58e7df4e03 pixmap_DATA isn't defined so don't use it as a variable.
2000-04-08  Christopher James Lahey  <clahey@helixcode.com>

	* art/Makefile.am: pixmap_DATA isn't defined so don't use it as a variable.

	* addressbook/gui/component/,
	addressbook/gui/component/.cvsignore, addressbook/gui/Makefile.am,
	addressbook/gui/component/addressbook-factory.c,
	addressbook/gui/component/addressbook.c,
	addressbook/gui/component/addressbook.gnorba,
	addressbook/gui/component/addressbook.h: New directory to proivde
	the component for contact management.  Simply uses an e-minicard-view.

	* addressbook/gui/minicard/e-minicard-view.c,
	addressbook/gui/minicard/e-minicard-view.h: New subclass of
	e-reflow-sorted that takes an EBook and uses it to compute the
	card data to display.

	* addressbook/gui/minicard/e-minicard.c,
	addressbook/gui/minicard/e-minicard.h: This now backends to a
	ECard instead of a ETableModel.

	* addressbook/gui/minicard/e-reflow.c,
	addressbook/gui/minicard/e-reflow.h: This now has a virtualized
	add method.

	* addressbook/gui/minicard/e-reflow-sorted.c,
	addressbook/gui/minicard/e-reflow-sorted.h: New subclass of
	e-reflow that allows the data to be sorted on the fly.

	* addressbook/gui/minicard/test-minicard-view.c: New test to test
	the new minicard view.

	* addressbook/gui/minicard/test-reflow.c: Uses the new ECard
	backend of the e-minicard.

	* addressbook/gui/minicard/.cvsignore,
	addressbook/gui/minicard/Makefile.am: Added new test.  Fixed
	dependencies.  Added new files.

	* addressbook/gui/, addressbook/gui/Makefile.am,
	addressbook/gui/.cvsignore: New directory for addressbook gui
	bits.  Added subdirectories.  Created an initial .cvsignore.

	* addressbook/Makefile.am (SUBDIRS): Removed demo and added gui.

	* addressbook/backend/pas/pas-backend-file.c: Added code to do
	notification on bookviews when changes in the backend are made.

	* addressbook/backend/pas/pas-book-view.c,
	addressbook/backend/pas/pas-book-view.h: Added helper functions to
	notify the view about the addition or modification of a single
	card.  Fixed a mistaken extra free.

	* addressbook/backend/ebook/e-card-list-iterator.h: Fixed
	incorrect parent class.

	* addressbook/backend/ebook/test-client.c: Made this accept an
	optional parameter that specifies the vcard to add.

	* configure.in: Replaced widgets/e-minicard/Makefile and
	addressbook/demo/Makefile with addressbook/gui/minicard/Makefile
	and addressbook/gui/component/Makefile respectively.

	* widgets/Makefile.am: Removed e-minicard since it's being moved
	to addressbook/gui/minicard.

	* widgets/e-text/e-text.c: Fixed the border width around tooltips
	and made the main tooltip area yellow.

From camel/ChangeLog:

2000-04-08  Christopher James Lahey  <clahey@helixcode.com>

	* providers/smtp/.cvsignore: Added a .cvsignore file.

From calendar/ChangeLog:

2000-04-08  Christopher James Lahey  <clahey@helixcode.com>

	* gui/Makefile.am: Removed linking with libetable and libeminicard
	since they weren't being used.

svn path=/trunk/; revision=2343
2000-04-08 22:10:47 +00:00
6beb74f535 actually record the pid returned by fork(). Noticed by clahey.
* providers/sendmail/camel-sendmail-transport.c (_send_internal):
	actually record the pid returned by fork(). Noticed by clahey.

svn path=/trunk/; revision=2342
2000-04-08 21:53:24 +00:00
15fa20706d #include <sys/param.h> for MAXHOSTNAMELEN. (This is a stopgap: some of the
* providers/smtp/camel-smtp-transport.c: #include <sys/param.h>
	for MAXHOSTNAMELEN. (This is a stopgap: some of the uses of
	MAXHOSTNAMELEN are wrong anyway...)

svn path=/trunk/; revision=2340
2000-04-08 20:32:01 +00:00
c893285da7 o fixed numerous bugs in providers/smtp/camel-smtp-transport.c; should now
Fri Apr  7 16:49:42 EDT 2000  Jeffrey Stedfast <fejj@stampede.org>
  o fixed numerous bugs in providers/smtp/camel-smtp-transport.c; should now build correctly
  o readded smtp to providers/Makefile.am

CVS

svn path=/trunk/; revision=2332
2000-04-07 21:40:56 +00:00
1fc95ea1f5 (pop3_connect): Remember the password after asking for it the
first time.

svn path=/trunk/; revision=2331
2000-04-07 20:41:01 +00:00
5f93b83040 Clarify error messages. (finalize): fix a bug in camel_exception usage
* providers/pop3/camel-pop3-store.c (pop3_connect): Clarify error
	messages.
	(finalize): fix a bug in camel_exception usage

svn path=/trunk/; revision=2329
2000-04-07 19:26:50 +00:00
0dfe829408 Removed smtp for now, its a long way from building. Removed file that
2000-04-07  NotZed  <NotZed@HelixCode.com>

        * providers/Makefile.am: Removed smtp for now, its a long way from
        building.
        * providers/smtp/Makefile.in: Removed file that shouldn't have been
        checked in.

svn path=/trunk/; revision=2324
2000-04-07 15:22:35 +00:00
1c17727799 o Added smtp_helo() request into smtp_connect() (forgott o do this before)
Fri Apr  7 08:01:43 EDT 2000  Jeffrey Stedfast <fejj@stampede.org>
  o Added smtp_helo() request into smtp_connect() (forgott o do this before)
  o Modified smtp_helo() to send EHLO if communicating with an ESMTP server

svn path=/trunk/; revision=2322
2000-04-07 12:51:50 +00:00
234e168fdc fix Makefile.am
svn path=/trunk/; revision=2319
2000-04-07 05:45:32 +00:00
a032d78dae o Added smtp/ to providers tree under camel o Added makefiles and source
Thu Apr  6 22:56:44 EDT 2000  Jeffrey Stedfast <fejj@stampede.org>
  o Added smtp/ to providers tree under camel
  o Added makefiles and source for an smtp module (untested as of yet)

svn path=/trunk/; revision=2317
2000-04-07 03:49:48 +00:00
0bdfacc11b + * camel-folder-pt-proxy.c (_get_full_name): Remove exception param
+	from get_full_name() called, since get_full_name() was changed to
+	not have an exception in the last param (see dan's notes below).
+	(_get_name): same.

svn path=/trunk/; revision=2316
2000-04-06 22:26:02 +00:00
f3f2afef4c Reorganize the folder-fetching methods and implement a folder cache so
2000-04-06  Dan Winship  <danw@helixcode.com>

	* camel-store.[ch]: Reorganize the folder-fetching methods and
	implement a folder cache so that multiple requests for the same
	folder will yield the same CamelFolder object (as long as it
	remains active). Includes some code to remove no-longer-active
	folders from the cache, but it doesn't get used since nothing is
	ever unref'ed in Camel right now...

	* providers/mbox/camel-mbox-store.c:
	* providers/pop3/camel-pop3-store.c: update for CamelStore
	changes.

	* camel-folder.[ch]: Remove the (unused) CamelException argument
	from camel_folder_get_name and camel_folder_get_full_name.
	(camel_folder_set_name): make this go away since changing a
	folder's name after it has been created could result in it
	conflicting with a separately-issued folder.

svn path=/trunk/; revision=2314
2000-04-06 20:10:05 +00:00
2e4a546307 the URL RFC says the port must be numeric, so we don't want to do
* g_url_new really wanted to take a CamelException. So, rename
	Gurl to CamelURL, g_url_* to camel_url_* (with camel_url_new
	taking an exception), and url-util.[ch] to camel-url.[ch]. Also
	force url->port to be numeric and remove camel_service_getport. (I
	was confused before: the URL RFC says the port must be numeric, so
	we don't want to do getportbyname.)

svn path=/trunk/; revision=2300
2000-04-06 03:52:39 +00:00
0c061c7078 fix a warning
svn path=/trunk/; revision=2293
2000-04-05 19:21:04 +00:00
9e7dabfa82 Compare mbox_file_size and mbox_modtime to the results of stat()ing the
* providers/mbox/camel-mbox-folder.c
	(_check_get_or_maybe_generate_summary_file): Compare
	mbox_file_size and mbox_modtime to the results of stat()ing the
	mbox file, not the summary file. Duh.
	(_close): Update the summary's mbox_file_size and mbox_modtime
	before writing it to disk.

	* providers/mbox/camel-mbox-summary.c (camel_mbox_summary_save,
	camel_mbox_summary_load): Wow. I must have been tired when I wrote
	this code. First, the comparison bug above. Second, it was using
	ntohs and htons instead of ntohl and htonl. Third, I was reading
	the status flag byte in two different places and thus getting out
	of sync. Fourth, it was writing out field_length bytes of each
	header field after having converted field_length to network byte
	order, resulting in lots of random crap being appended, and the
	summary files being huge. (Fortunately, since the size/modtime
	comparison was biffed, the garbage summary read from disk was
	always immediately discarded.)

	* providers/mbox/camel-mbox-parser.c (camel_mbox_parse_file): fix
	an off-by-one error that caused the last-used UID to be reused if
	the summary file was regenerated. (That one wasn't my fault. :-)

svn path=/trunk/; revision=2279
2000-04-01 21:58:27 +00:00
30b690a363 implement unimplemented methods
* camel-stream-mem.c: implement unimplemented methods

svn path=/trunk/; revision=2275
2000-04-01 04:44:17 +00:00
74b6039c52 remove debugging printf()s that no longer seem useful
svn path=/trunk/; revision=2274
2000-04-01 04:16:39 +00:00
50c50fee43 Added "convert_newlines_to_br" boolean param, to give the option of not
* camel-formatter.c (text_to_html): Added "convert_newlines_to_br"
	boolean param, to give the option of not converting '\n's to <br>
	tags. This way, when we stick stuff in a <pre> tag, newlines stay
	newlines.

svn path=/trunk/; revision=2270
2000-03-31 21:58:19 +00:00
b642e45d7a Use <pre> tag to force the use of monospaced fonts.
* camel-formatter.c (handle_text_plain): Use <pre> tag to force
	the use of monospaced fonts.

svn path=/trunk/; revision=2260
2000-03-30 20:33:26 +00:00
1f73bf3ba0 Add a htons in the default_number case, and document the fact that the
* camel-service.c (camel_service_getport): Add a htons in the
	default_number case, and document the fact that the function
	returns the port in network byte order.

	* providers/pop3/camel-pop3-store.c (pop3_connect): Revert
	Miguel's change. The port number bug was actually somewhere
	else, and the IP address copying code was fine already.

svn path=/trunk/; revision=2256
2000-03-30 16:40:33 +00:00
88674ff401 Add htons (port), and only copy 4 bytes for the IP address to prevent a
2000-03-29  Miguel de Icaza  <miguel@gnu.org>

	* providers/pop3/camel-pop3-store.c (pop3_connect): Add htons
	(port), and only copy 4 bytes for the IP address to prevent a DNS
	attack.

svn path=/trunk/; revision=2251
2000-03-30 00:41:04 +00:00
6bf6ad1613 make this return a CamelStream rather than a CamelSeekableSubstream,
* camel-seekable-substream.c
	(camel_seekable_substream_new_with_seekable_stream_and_bounds):
	make this return a CamelStream rather than a
	CamelSeekableSubstream, because that's the way Gtk objects tend to
	work.

svn path=/trunk/; revision=2218
2000-03-28 21:15:21 +00:00
c7ae879700 fix warnings
svn path=/trunk/; revision=2217
2000-03-28 21:12:12 +00:00
2076526774 convenience functions to canonicalize the host and port values of a
* camel-service.c (camel_service_gethost,
	camel_service_getport): convenience functions to canonicalize
	the host and port values of a service's URL.
	* providers/pop3/camel-pop3-store.c: use them

svn path=/trunk/; revision=2216
2000-03-28 20:51:58 +00:00
c3b6d117ee Make this work when the inbox file doesn't yet exist.
* providers/mbox/camel-mbox-folder.c
	(_check_get_or_maybe_generate_summary_file): Make this work when
	the inbox file doesn't yet exist.

svn path=/trunk/; revision=2215
2000-03-28 18:01:34 +00:00
b54a0e18c3 uncomment the call to unlink the temp file: there's no way to tell
* providers/mbox/camel-mbox-folder.c (_append_message): uncomment
	the call to unlink the temp file: there's no way to tell
	camel_stream_fs to truncate a file, so reusing the same file was
	resulting in junk at the ends of messages.

svn path=/trunk/; revision=2206
2000-03-28 03:56:06 +00:00