Commit Graph

645 Commits

Author SHA1 Message Date
099d43d698 Remove debugging message.
* e-tree.c (e_tree_drag_unhighlight): Remove debugging message.

svn path=/trunk/; revision=12599
2001-09-04 20:54:18 +00:00
5c1e0a1d9e Strip spaces at the beginning or end as well as changing " " to " ". Fixes
2001-09-02  Christopher James Lahey  <clahey@ximian.com>

	* e-cell-date.c (ecd_get_text): Strip spaces at the beginning or
	end as well as changing "  " to " ".  Fixes Ximian bug #7683.

svn path=/trunk/; revision=12560
2001-09-02 09:26:13 +00:00
06eb6e23fb Rename these functions from ecn_get_text and ecn_free_text.
2001-09-01  Christopher James Lahey  <clahey@ximian.com>

	* e-cell-float.c (ecf_get_text, ecf_free_text): Rename these
	functions from ecn_get_text and ecn_free_text.

	* e-cell-tree.c (ect_height): Make sure the height is a multiple
	of two here.

	* e-table-header-item.c, e-table-header-item.h: Added a "tree"
	argument so that the sorting can be set by right clicking on the
	header item.

	* e-table-item.c (eti_table_model_rows_deleted): Added some
	assertions here.

	* e-tree-selection-model.c (etsm_find_node_unless_equals): Fixed
	indentation.

	* e-tree-table-adapter.c (etta_proxy_node_changed): Rewrote this
	to be more readable.
	(e_tree_table_adapter_node_set_expanded): Added an assertion.

	* e-tree.c, e-tree.h (e_tree_get_spec): Added this function.
	(e_tree_setup_header): Set the tree argument on the
	ETableHeaderItem here.

svn path=/trunk/; revision=12553
2001-09-01 08:03:44 +00:00
1273682db1 Fix this memmove. We've already subtracted the count from eti->rows.
2001-08-31  Christopher James Lahey  <clahey@ximian.com>

	* e-table-item.c (eti_table_model_rows_deleted): Fix this memmove.
	We've already subtracted the count from eti->rows.

svn path=/trunk/; revision=12550
2001-09-01 01:44:58 +00:00
87b3e9277f Patch to fix few 64bit issues
Tue Aug 28 18:29:28 2001  George Lebl <jirka@5z.com>

	Patch to fix few 64bit issues

	* gal/e-table/e-table-header-item.c (ethi_draw) (ethi_start_drag)
	  gal/widgets/e-categories.c (e_categories_value_at)
	  (e_categories_value_to_string):
	  Use GINT_TO_POINTER and GPOINTER_TO_INT to cast between pointers
	  and ints to fix 64bit issues connected with that.

	* gal/e-table/e-table-sorting-utils.c
	  (e_table_sorting_utils_tree_check_position)
	  gal/util/e-sorter-array.c (e_sorter_array_append):
	  Use size_t for size not ints to fix crashes

	* gal/e-text/e-completion-match.c, gal/e-text/e-completion.c:
	  Include <string.h>

svn path=/trunk/; revision=12507
2001-08-29 01:30:26 +00:00
c4b24c895e Fixed this memmove to subtract the count as well as the row for the number
2001-08-27  Christopher James Lahey  <clahey@ximian.com>

	* e-table-item.c (eti_table_model_rows_deleted): Fixed this
	memmove to subtract the count as well as the row for the number of
	rows to move.

svn path=/trunk/; revision=12482
2001-08-27 15:32:14 +00:00
d30a9fe66f Convert UTF-8 strings to locale's encoding before putting them in canvas
* e-table-group-container.c (compute_text):
Convert UTF-8 strings to locale's encoding before putting them in
canvas item.

svn path=/trunk/; revision=12472
2001-08-25 14:21:41 +00:00
59da647724 Fixed typo.
* e-table.c (e_table_init): Fixed typo.

svn path=/trunk/; revision=12467
2001-08-24 23:32:36 +00:00
f7120120cd Added start_drag signals.
2001-08-24  Christopher James Lahey  <clahey@ximian.com>

	* e-table-group-container.c, e-table-group-leaf.c,
	e-table-group-leaf.h, e-table-group.c, e-table-group.h: Added
	start_drag signals.

	* e-table-item.c, e-table-item.h (eti_event): Send the start_drag
	signal.  Fixes Ximian bug #807.

	* e-table.c, e-table.h, e-tree.c, e-tree.h: Added start_drag
	signal.  Made default handler start drag & drop if we're set to
	automatically handle dnd.  Ripped out the code to handle watching
	events for dnd since start_drag does this now.

svn path=/trunk/; revision=12437
2001-08-24 16:33:30 +00:00
a0bfb48ea7 We need to free_gotten_key_func key2, not key! (e_table_without_show):
2001-08-20  Jon Trowbridge  <trow@ximian.com>

	* e-table-without.c (check_with_key): We need to
	free_gotten_key_func key2, not key!
	(e_table_without_show): Renamed, used to be
	e_table_without_remove.  Double-negative function names
	are confusing!
	(e_table_without_hide_adopt): Renamed, used to be
	e_table_without_add_adopt.
	(e_table_without_hide): Renamed, used to be e_table_without_add.

2001-08-20  Jon Trowbridge  <trow@ximian.com>

	* configure.in: Increment version number to 0.10.99.5 for changes
	to ETableWithout api.

svn path=/trunk/; revision=12332
2001-08-21 00:52:33 +00:00
beba0c1009 Added these functions.
2001-08-20  Christopher James Lahey  <clahey@ximian.com>

	* e-table-subset.c, e-table-subset.h
	(e_table_subset_model_to_view_row,
	e_table_subset_view_to_model_row): Added these functions.

svn path=/trunk/; revision=12317
2001-08-20 18:22:46 +00:00
4dd3f5e734 Made this object handle NULLs for all the handler functions.
2001-08-20  Christopher James Lahey  <clahey@ximian.com>

	* e-table-without.c: Made this object handle NULLs for all the
	handler functions.

svn path=/trunk/; revision=12316
2001-08-20 17:13:36 +00:00
ac852ece23 Changed the used parity of the return value of check here.
2001-08-20  Christopher James Lahey  <clahey@ximian.com>

	* e-table-without.c (etw_proxy_model_rows_inserted,
	etw_proxy_model_changed): Changed the used parity of the return
	value of check here.

svn path=/trunk/; revision=12313
2001-08-20 16:31:39 +00:00
7b3fe06340 Chain to the destroy handler in the parent class. Hey, I'm getting used to
2001-08-18  Federico Mena Quintero  <federico@ximian.com>

	* e-table-without.c (etw_destroy): Chain to the destroy handler in
	the parent class.  Hey, I'm getting used to this :)

svn path=/trunk/; revision=12199
2001-08-18 08:03:24 +00:00
31bb4b3f7b Destroy the hash table and all objects in it, as well as the priv
2001-08-17  Christopher James Lahey  <clahey@ximian.com>

	* e-table-without.c (etw_destroy): Destroy the hash table and all
	objects in it, as well as the priv structure.

svn path=/trunk/; revision=12147
2001-08-17 07:23:43 +00:00
dad6d45018 Bumped version number to 0.10.99.4. Fixed some comments.
2001-08-16  Christopher James Lahey  <clahey@ximian.com>

	* configure.in: Bumped version number to 0.10.99.4.  Fixed some
	comments.

	* gal/Makefile.am (libgal_la_LIBADD): Added
	e-table/e-table-without.lo.

From gal/e-table/ChangeLog:

2001-08-16  Christopher James Lahey  <clahey@ximian.com>

	* Makefile.am: Added e-table-without.c and e-table-without.h.

	* e-table-without.c, e-table-without.h: Got this to compile.
	Finished the first version of it.

svn path=/trunk/; revision=12144
2001-08-17 03:38:16 +00:00
23c322c893 Adding the first versions of these files. Doesn't work yet.
2001-08-16  Christopher James Lahey  <clahey@ximian.com>

	* e-table-without.c, e-table-without.h: Adding the first versions
	of these files.  Doesn't work yet.

svn path=/trunk/; revision=12121
2001-08-16 20:16:43 +00:00
0f680dfd18 Destroy, do not unref, the popup_window.
2001-08-14  Federico Mena Quintero  <federico@ximian.com>

	* e-cell-combo.c (e_cell_combo_destroy): Destroy, do not unref,
	the popup_window.

svn path=/trunk/; revision=12021
2001-08-14 18:30:10 +00:00
c4d909a366 Workaround for Ximian bug #6795. Will prevent a crash and doesn't seem to
2001-08-14  Peter Williams  <peterw@ximian.com>

	* e-tree-selection-model.c (etsm_selected_count_recurse):
	Workaround for Ximian bug #6795. Will prevent a crash and
	doesn't seem to cause any problems, but the underlying problem
	still exists.

svn path=/trunk/; revision=12010
2001-08-14 14:33:02 +00:00
6d8437d4a9 Handle GDK_KP_Page_Up, GDK_KP_Page_Down, GDK_KP_Right, and GDK_KP_Left
2001-08-14  Christopher James Lahey  <clahey@ximian.com>

	* e-table.c (group_key_press), e-tree.c (item_key_press): Handle
	GDK_KP_Page_Up, GDK_KP_Page_Down, GDK_KP_Right, and GDK_KP_Left
	here.

svn path=/trunk/; revision=11996
2001-08-14 08:03:25 +00:00
d261f1e17b Got rid of event forwarding for double clicks and releases and such and
2001-08-14  Christopher James Lahey  <clahey@ximian.com>

	* e-table-click-to-add.c (etcta_event): Got rid of event
	forwarding for double clicks and releases and such and for single
	clicks except when first creating the row object.

svn path=/trunk/; revision=11993
2001-08-14 06:33:46 +00:00
1580b0527c If the sort_info can't group, hide the grouping button and label.
2001-08-10  Christopher James Lahey  <clahey@ximian.com>

	* e-table-config.c (setup_gui): If the sort_info can't group, hide
	the grouping button and label.

	* e-table-header-item.c (ethi_header_context_menu): Removed the
	Group By This Field menu item if the sort_info doesn't support
	grouping.

	* e-table-sort-info.c, e-table-sort-info.h
	(e_table_sort_info_get_can_group,
	e_table_sort_info_set_can_group): Added these functions.

	* e-tree.c (e_tree_set_state_object, et_real_construct): Set
	can_group to FALSE for all our sort infos.
	(e_tree_get_state_object): Fixed a potential gtk_object_ref (NULL)
	here.

svn path=/trunk/; revision=11896
2001-08-10 20:49:24 +00:00
2f81032abc new proto and virtual method
2001-08-10  JP Rosevear  <jpr@ximian.com>

	* gal/widgets/e-canvas-vbox.h: new proto and virtual method

	* gal/widgets/e-canvas-vbox.c (e_canvas_vbox_real_add_item_start):
	adds the the item to the beginning
	(e_canvas_vbox_add_item_start): call the virtual method

2001-08-10  JP Rosevear  <jpr@ximian.com>

	* e-table.c (et_build_groups): add the items to the start or end
	based on where the click to add should be
	(e_table_setup_table): ditto
	(et_real_construct): read additional spec flag

	* e-table.h: new flag

	* e-table-specification.c (etsp_init): init new flag
	(e_table_specification_load_from_node): set click to add end flag
	(e_table_specification_save_to_node): write out flag

	* e-table-specification.h: new flag

svn path=/trunk/; revision=11880
2001-08-10 15:47:18 +00:00
70d5ead8bd Initialize ret_val. (do_drag_motion): Same.
2001-08-09  Jeffrey Stedfast  <fejj@ximian.com>

	* e-tree.c (et_drag_drop): Initialize ret_val.
	(do_drag_motion): Same.

svn path=/trunk/; revision=11861
2001-08-10 00:44:56 +00:00
b2a270aa10 Added a "header" argument to these structures which just gets passed
2001-08-09  Christopher James Lahey  <clahey@ximian.com>

	* e-table-field-chooser-dialog.c, e-table-field-chooser-dialog.h,
	e-table-field-chooser.c, e-table-field-chooser.h: Added a "header"
	argument to these structures which just gets passed downwards.

	* e-table-field-chooser-item.c, e-table-field-chooser-item.h:
	Added a "header" argument here.  Made it so that only rows that
	aren't already in the header are shown.

	* e-table-header-item.c: Set the "header" argument on our
	e-table-field-chooser-dialog.  Fixes Ximian bug #2654.

svn path=/trunk/; revision=11828
2001-08-09 10:16:52 +00:00
5e70f5f3dd Chain to the destroy handler in the parent class!
2001-08-08  Federico Mena Quintero  <federico@ximian.com>

	* e-cell-pixbuf.c (pixbuf_destroy): Chain to the destroy handler
	in the parent class!

	* e-table-field-chooser.c (e_table_field_chooser_destroy):
	Likewise.  Sigh.

	* e-table-one.c (one_destroy): Likewise.  Double sigh.

	* e-tree-selection-model.c (etsm_destroy): Likewise.  Triple sigh.

svn path=/trunk/; revision=11811
2001-08-09 03:14:48 +00:00
e9bd546cbe Call the super-class destroy function when done.
2001-08-08  Not Zed  <NotZed@Ximian.com>

        * e-table-sort-info.c (etsi_destroy): Call the super-class destroy
        function when done.

svn path=/trunk/; revision=11782
2001-08-08 10:57:26 +00:00
fe8e487048 Check for row >= 0 here. (etgl_destroy): Disconnect from all the signals
2001-08-08  Christopher James Lahey  <clahey@ximian.com>

	* e-table-group-leaf.c, e-table-group-leaf.h (etgl_key_press):
	Check for row >= 0 here.
	(etgl_destroy): Disconnect from all the signals we connect to on
	our ETableItem here.

svn path=/trunk/; revision=11766
2001-08-08 07:49:24 +00:00
7b0cfb30ea Implemented this function. Fixes Ximian bug #5353.
2001-08-07  Christopher James Lahey  <clahey@ximian.com>

	* e-tree-selection-model.c (etsm_selected_count): Implemented this
	function.  Fixes Ximian bug #5353.

svn path=/trunk/; revision=11753
2001-08-07 23:31:02 +00:00
f453b03db2 Make tree nodes open if you hover over them while drag & dropping.
2001-08-07  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c: Make tree nodes open if you hover over them while drag
	& dropping.

svn path=/trunk/; revision=11746
2001-08-07 22:19:39 +00:00
0cb44895c5 Added scrolling to access nodes that are scrolled off screen for drops.
2001-08-07  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c (scroll_timeout): Added scrolling to access nodes that
	are scrolled off screen for drops.  Fixes Ximian bug #5645.

	* e-table.c, e-table.h (scroll_timeout): Added scrolling to access
	rows that are scrolled off screen for drops.  This doesn't work
	for some reason, but I'm checking the code in.

svn path=/trunk/; revision=11724
2001-08-07 05:55:36 +00:00
ba57a90d93 Implemented these functions.
2001-08-06  Christopher James Lahey  <clahey@ximian.com>

	* e-table.c, e-table.h (e_table_drag_highlight,
	e_table_drag_unhighlight): Implemented these functions.

	* e-tree.c (e_tree_drag_highlight, e_tree_drag_unhighlight):
	Implemented these functions.

svn path=/trunk/; revision=11713
2001-08-06 22:07:28 +00:00
872691b50e Set the hadjustment and vadjustment here. From a patch by Kevin
2001-08-04  Christopher James Lahey  <clahey@ximian.com>

	* e-tree-scrolled.c (e_tree_scrolled_new): Set the hadjustment and
	vadjustment here.  From a patch by Kevin Vandersloot
	<kfv101@psu.edu>.  Fixes Ximian bug #6400.

svn path=/trunk/; revision=11684
2001-08-04 23:09:34 +00:00
966bef8c54 Change these to actually subtract the allocation as they should.
2001-08-03  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c (et_drag_motion, et_drag_drop, et_drag_data_received):
	Change these to actually subtract the allocation as they should.

svn path=/trunk/; revision=11649
2001-08-04 05:38:33 +00:00
edd997c889 e_tree_table_adapter_node_at_row would have pulled data from one past the
2001-08-03  Christopher James Lahey  <clahey@ximian.com>

	* e-tree-table-adapter.c (e_tree_table_adapter_node_at_row):
	e_tree_table_adapter_node_at_row would have pulled data from one
	past the end of its array if you asked it to and the root was
	hidden.  Fixed it.  Fixes Ximian bug #4761.

svn path=/trunk/; revision=11647
2001-08-04 03:14:49 +00:00
96484b3644 Subtracted 27.
2001-08-03  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c (et_drag_motion, et_drag_drop, et_drag_data_received):
	Subtracted 27.

svn path=/trunk/; revision=11624
2001-08-03 21:19:53 +00:00
b6878cb8d3 Make the right and left key presses be marked as handled here (i.e.,
2001-08-02  Christopher James Lahey  <clahey@ximian.com>

	* e-table-item.c (eti_event): Make the right and left key presses
	be marked as handled here (i.e., return 1 always.)  Fixes Ximian
	bug #2090.

svn path=/trunk/; revision=11592
2001-08-02 18:53:37 +00:00
fb0a5ab403 Changed all e_table_model_is_cell_editable calls in this file to be on the
2001-08-02  Christopher James Lahey  <clahey@ximian.com>

	* e-table-item.c: Changed all e_table_model_is_cell_editable calls
	in this file to be on the model column instead of the view column.

svn path=/trunk/; revision=11589
2001-08-02 18:21:45 +00:00
7b8d33db23 Set et->priv to NULL here just to be sure.
2001-08-02  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c (et_destroy): Set et->priv to NULL here just to be
	sure.

svn path=/trunk/; revision=11588
2001-08-02 18:20:46 +00:00
15b98319b3 Don't do most of the work in this function if data->data is NULL. Fixes
2001-08-02  Christopher James Lahey  <clahey@ximian.com>

	* e-table-header-item.c (ethi_drag_data_received): Don't do most
	of the work in this function if data->data is NULL.  Fixes Ximian
	bug #6041.

svn path=/trunk/; revision=11587
2001-08-02 18:18:18 +00:00
342880e798 Set the et->cursor_loc *before* committing the click-to-add to avoid
2001-08-01  Federico Mena Quintero  <federico@ximian.com>

	* e-table.c (group_cursor_change): Set the et->cursor_loc *before*
	committing the click-to-add to avoid reentrancy issues if the
	table model changes while the click-to-add is being committed.

svn path=/trunk/; revision=11564
2001-08-02 03:27:59 +00:00
108958944a Make this function not crash if x somehow doesn't land on some column.
2001-08-01  Christopher James Lahey  <clahey@ximian.com>

	* e-table-header-item.c (ethi_change_sort_state): Make this
	function not crash if x somehow doesn't land on some column.
	Fixes Ximian bug #5957.

	* e-table-header-item.c: Removed a bunch of menu items whose
	functionality won't be ready for 1.0.  Fixes Ximian bug #154.

svn path=/trunk/; revision=11560
2001-08-02 01:24:47 +00:00
01d76f2590 Made this not query the 0th row if there are 0 rows in the table. Fixes
2001-08-01  Christopher James Lahey  <clahey@ximian.com>

	* e-cell-toggle.c (etog_max_width): Made this not query the 0th
	row if there are 0 rows in the table.  Fixes Ximian bug #5640.

svn path=/trunk/; revision=11542
2001-08-01 07:30:11 +00:00
9cf5ba1797 If the CLICK signal gets a return value, so we're going to be return from
2001-07-25  Jason Leach  <jleach@ximian.com>

	* e-table-item.c (eti_event): If the CLICK signal gets a return
	value, so we're going to be return from eti_event immediately
	after, set the eti->click_count to zero.  Fixes bug #811.

svn path=/trunk/; revision=11420
2001-07-26 02:23:33 +00:00
109c8d5aa6 Properly ref the font we pass in as an ARG_FONT_E. (_do_tooltip): Removed
2001-07-25  Jon Trowbridge  <trow@ximian.com>

	* gal/e-text/e-text.c (e_text_set_arg): Properly ref the font we
	pass in as an ARG_FONT_E.
	(_do_tooltip): Removed some crack.  We no longer have to manually
	ref the font. The ref-counting now happens inside the set_arg
	function, as it should.
	(e_text_destroy): Set text->font to NULL after unrefing it.

2001-07-25  Jon Trowbridge  <trow@ximian.com>

        * e-cell-text.c (ect_unrealize): Set text_view->font to NULL
        after we unref it.

svn path=/trunk/; revision=11393
2001-07-25 07:27:04 +00:00
7ab072d87e Handle GDK_KP_* cursor keys as well.
* e-table-item.c (eti_event): Handle GDK_KP_* cursor keys as well.

svn path=/trunk/; revision=11302
2001-07-23 04:59:39 +00:00
2f2b112aec Made these functions return -1 if the x and y aren't over any cell at all.
2001-07-12  Christopher James Lahey  <clahey@ximian.com>

	* e-tree.c (e_tree_get_cell_at): Made these functions return -1 if
	the x and y aren't over any cell at all.

svn path=/trunk/; revision=11077
2001-07-13 02:52:33 +00:00
4da3e76c2c Ignore set_expanded if the node is the root and root_visible is FALSE.
2001-07-12  Christopher James Lahey  <clahey@ximian.com>

	* e-tree-table-adapter.c (e_tree_table_adapter_node_set_expanded):
	Ignore set_expanded if the node is the root and root_visible is
	FALSE.

	* e-tree.c (item_key_press): Don't call set_expanded on NULL
	paths.

svn path=/trunk/; revision=11061
2001-07-12 20:44:02 +00:00
7b9622f8e0 Created this function for key presses that move in some way other than
2001-07-11  Christopher James Lahey  <clahey@ximian.com>

	* gal/widgets/e-selection-model.c, gal/widgets/e-selection-model.h
	(e_selection_model_select_as_key_press): Created this function for
	key presses that move in some way other than just to the next or
	previous row.
	(e_selection_model_key_press): Use
	e_selection_model_select_as_key_press for handling home and end
	here.

svn path=/trunk/; revision=10993
2001-07-11 10:30:51 +00:00
0a71e607b1 Made the amount to scroll by smaller here.
2001-07-11  Christopher James Lahey  <clahey@ximian.com>

	* e-table.c (group_key_press), e-tree.c (item_key_press): Made the
	amount to scroll by smaller here.

svn path=/trunk/; revision=10992
2001-07-11 10:17:52 +00:00