When a multipart message contains signed/encrypted (secure) parts together
with unsigned/unencrypted (insecure) parts, colorize the insecure parts
as 'bad' (red border), for a brief distinguishable way of the parts.
Related to https://gitlab.gnome.org/GNOME/evolution/issues/203
With certain operations interleaving the callback to name-appeared
signal could be called after the object in the user_data had been freed.
Even when the free of the object unwatches the D-Bus name, it's too
late, because the signal callback is already scheduled in the main loop.
Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1677846
This might be a bit more efficient implementation, where instead of
accessing each selected message info as many times as many labels
are defined (until one message with and one without the label is found),
check each message info for the defined labels at once.
When doing searches in the Mail view in other than Current Folder context
and then clearing the search text, the search folder in the background was
not freed, instead of it the real folder, into which the view had been
switched, had been unreffed one more time. That could cause some issue
in the future or at the quit of the application.
Few other things found during this fixed as well.
Related to a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1678440
The previous change missed a fact that the EActionComboBox is used on
various places where always-enabled ellipsizing can cause issues, like
in the composer, where the combox of the message format and the paragraph
mode always used minimum size, thus made those unreadable. This change
enables ellipsizing in the EActionComboBox on demand, with the default
to not ellipsize, which keeps the behavior as before the change for
all but the search bar.
When Evolution detected that the window width would be larger than
screen width it hid the Show combo box to avoid the window oversize,
but users do use this combo for filtering, thus it was not ideal.
Rather than hiding anything, make the combo box texts ellipsizable,
which can save plenty of space without hiding any widget.
Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1678253
No need to preserve Mailer header value as received and constructed
by the sender's software, better to unfold it and left wrapping
on the preview panel.
Parts with Content-ID or Content-Location had been considered as inline
content and not added into real attachments, even when not referenced
in the HTML body. This addresses it in a way that it's only for images
and the worse case is to add it to both inline images and attachments,
to not lose it.
Reported downstream as:
https://bugzilla.redhat.com/show_bug.cgi?id=1666572
In case libical is compiled to keep properties with empty values,
which means icalproperty_get_xxxx() can return NULL instead of an empty
string, the code of the ECellText (aka the List View) could try
to use the NULL value in strcmp(), strlen() and such, which causes
abort of the application.
This had been reported downstream as:
https://bugzilla.redhat.com/show_bug.cgi?id=1658002
The image had been stored as "data:image/...;base64;<data>", which
the context menu Save Image and Copy Image could not handle. This
resulted in a lengthy error message, which could cause a crash.
This commit fixes several things:
a) replace "data:" URI-s with "mail://" URI-s, which means less resources
are needed; it also fixes the Save/Copy Image actions as a side effect;
b) fix memory leak for tiff images;
c) let to Save/Copy Image handle base64-encoded "data:" URI-s (as
the source HTML message can still contain them);
d) shorten the URI in the error message when it's too long;
e) pass also "filename" into the URI, thus the Save Image has prefilled it,
the same as attachment's "Save as" action.
Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1657361
The GSettings values can be changed by anything, which means the user
can override the last stored window size to some large enough that
the gdk (or WebKitGTK+) will fail to allocated such large pixmap,
which can lead to a crash. This size clamp helps to avoid it.
Related to downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1657361
It could happen, in some cases, that the component had already set
X-MICROSOFT-CDO-REPLYTIME property, in which case itip-view added
a new property of the same name at the end. Rather than have there
the duplicates (with different times), remove all existing first.
Added option which defaults to the previous behaviour. To change it run:
gsettings set org.gnome.evolution.mail composer-mark-read-on-reply false
Related to https://gitlab.gnome.org/GNOME/evolution/issues/162
This is to have enabled authentication for the SMTP part, if configured,
thus the first attempt to send a mail would ask for the credentials,
if needed.
Related to https://gitlab.gnome.org/GNOME/evolution/issues/238