Commit Graph

712 Commits

Author SHA1 Message Date
dbeb73ca0d Colorize insecure parts as 'bad' in otherwise secure mail
When a multipart message contains signed/encrypted (secure) parts together
with unsigned/unencrypted (insecure) parts, colorize the insecure parts
as 'bad' (red border), for a brief distinguishable way of the parts.

Related to https://gitlab.gnome.org/GNOME/evolution/issues/203
2019-02-26 17:35:41 +01:00
df483c7124 Fix few memory leaks around mail print 2019-02-26 15:31:47 +01:00
a010fb2a40 Initialize all members of 'struct tm' in e_cert_populate() 2019-02-26 15:22:08 +01:00
b66cdbbe6f I#318 - Search for 'previous' word in message preview behaves like 'next'
Closes https://gitlab.gnome.org/GNOME/evolution/issues/318
2019-02-26 13:56:56 +01:00
bfa7a38979 Bug 791044 - Do not print HTML attachments created by Prefer Plain plugin
Closes https://bugzilla.gnome.org/show_bug.cgi?id=791044
2019-02-26 13:00:11 +01:00
16c338e4a6 I#313 - Allow enter URL without scheme in component editor
Closes https://gitlab.gnome.org/GNOME/evolution/issues/313
2019-02-22 09:41:40 +01:00
d7e3eab132 [EWebKitEditor] Fix few memory leaks
Related to a GVariant returned by e_util_invoke_g_dbus_proxy_call_sync_wrapper_with_error_check().
2019-02-21 15:15:44 +01:00
07a2087169 Use GWeakRef when watching D-Bus bus names
With certain operations interleaving the callback to name-appeared
signal could be called after the object in the user_data had been freed.
Even when the free of the object unwatches the D-Bus name, it's too
late, because the signal callback is already scheduled in the main loop.

Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1677846
2019-02-21 15:00:17 +01:00
4a18836261 Change how label actions are updated in EMailReader
This might be a bit more efficient implementation, where instead of
accessing each selected message info as many times as many labels
are defined (until one message with and one without the label is found),
check each message info for the defined labels at once.
2019-02-21 11:47:53 +01:00
c6cc50c652 I#289 - 'Search web' context menu option for selection in EWebView ][
Fix an issue in the EMailBrowser.

Related to https://gitlab.gnome.org/GNOME/evolution/issues/289
2019-02-21 10:55:26 +01:00
f804af97fe Ref/unref imbalance on a CamelFolder instance
When doing searches in the Mail view in other than Current Folder context
and then clearing the search text, the search folder in the background was
not freed, instead of it the real folder, into which the view had been
switched, had been unreffed one more time. That could cause some issue
in the future or at the quit of the application.

Few other things found during this fixed as well.

Related to a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1678440
2019-02-21 10:17:42 +01:00
30d4b767f5 The 'Show' combo box hidden for small screens in the search bar ][
The previous change missed a fact that the EActionComboBox is used on
various places where always-enabled ellipsizing can cause issues, like
in the composer, where the combox of the message format and the paragraph
mode always used minimum size, thus made those unreadable. This change
enables ellipsizing in the EActionComboBox on demand, with the default
to not ellipsize, which keeps the behavior as before the change for
all but the search bar.
2019-02-20 12:25:58 +01:00
476d40c7ba eds-I#86 - Rejecting connection certificate causes constant connection retries
Related to https://gitlab.gnome.org/GNOME/evolution-data-server/issues/86
2019-02-18 19:05:51 +01:00
9e9cc42454 The 'Show' combo box hidden for small screens in the search bar
When Evolution detected that the window width would be larger than
screen width it hid the Show combo box to avoid the window oversize,
but users do use this combo for filtering, thus it was not ideal.
Rather than hiding anything, make the combo box texts ellipsizable,
which can save plenty of space without hiding any widget.

Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1678253
2019-02-18 15:53:35 +01:00
9454c6091e [em-format] Unfold Mailer header value before using it
No need to preserve Mailer header value as received and constructed
by the sender's software, better to unfold it and left wrapping
on the preview panel.
2019-02-13 09:52:53 +01:00
72eacce096 I#307 - [Composer] Style lost after spellcheck correction
Closes https://gitlab.gnome.org/GNOME/evolution/issues/307
2019-02-08 13:44:25 +01:00
76b6b079b9 I#302 - Improve restore of selected message in the message list after search
Closes https://gitlab.gnome.org/GNOME/evolution/issues/302
2019-02-08 13:19:01 +01:00
9c688da9ee I#306 - Add emailmd5 to mail autoconfig request
Closes https://gitlab.gnome.org/GNOME/evolution/issues/306
2019-02-08 09:31:27 +01:00
24e434f45c Change parentheses in an if() to avoid clang warning 2019-02-04 10:59:10 +01:00
6891c4d9b3 Initialize 'cache' variable in e_http_request_process_sync()
This could be used uninitialized.
2019-02-04 10:04:56 +01:00
a0f102812e I#289 - 'Search web' context menu option for selection in EWebView
Closes https://gitlab.gnome.org/GNOME/evolution/issues/289
2019-01-30 14:46:48 +01:00
89aad544e1 I#297 - Dates in Certificates table do not match locale format
Closes https://gitlab.gnome.org/GNOME/evolution/issues/297
2019-01-28 12:57:10 +01:00
b2949ea2fe I#284 - Busy loop on print of an HTML message with javascript code
Closes https://gitlab.gnome.org/GNOME/evolution/issues/284
2019-01-21 18:58:30 +01:00
17d1497676 I#288 - Fails to extract downloaded remote images from message preview
Closes https://gitlab.gnome.org/GNOME/evolution/issues/288
2019-01-21 16:25:56 +01:00
63f605c410 [Composer] Draft email can lose attachments when opened
Parts with Content-ID or Content-Location had been considered as inline
content and not added into real attachments, even when not referenced
in the HTML body. This addresses it in a way that it's only for images
and the worse case is to add it to both inline images and attachments,
to not lose it.

Reported downstream as:
https://bugzilla.redhat.com/show_bug.cgi?id=1666572
2019-01-18 11:24:30 +01:00
fa1101bc6a I#282 - Do not preview pipe-s in GtkFileChooser
Closes https://gitlab.gnome.org/GNOME/evolution/issues/282
2019-01-16 15:47:24 +01:00
b49a88334b I#279 - [EMailBrowser] Enable Space/Backspace keys to scroll within message
Closes https://gitlab.gnome.org/GNOME/evolution/issues/279
2019-01-14 14:04:14 +01:00
6fefbfd10c I#278 - Ctrl+Shift+Arrow to expand/collapse whole subthread
Closes https://gitlab.gnome.org/GNOME/evolution/issues/278
2019-01-11 14:58:35 +01:00
aff63c3cf5 I#275 - [Composer] Ctrl+Shift+Backspace deletion cannot be undone
Closes https://gitlab.gnome.org/GNOME/evolution/issues/275
2019-01-10 12:32:33 +01:00
9801610587 I#277 - Unescape values in calendars' handle-uri signal handler
Closes https://gitlab.gnome.org/GNOME/evolution/issues/277
2019-01-09 16:53:38 +01:00
543aa80c32 I#76 - Message Source window can close immediately
Closes https://gitlab.gnome.org/GNOME/evolution/issues/76
2019-01-09 14:05:57 +01:00
134f0fb008 I#250 - [Composer] Edit->Paste always pastes into the message body
Closes https://gitlab.gnome.org/GNOME/evolution/issues/250
2019-01-08 18:04:01 +01:00
2aa2017bf9 Event with empty summary can cause crash
In case libical is compiled to keep properties with empty values,
which means icalproperty_get_xxxx() can return NULL instead of an empty
string, the code of the ECellText (aka the List View) could try
to use the NULL value in strcmp(), strlen() and such, which causes
abort of the application.

This had been reported downstream as:
https://bugzilla.redhat.com/show_bug.cgi?id=1658002
2019-01-07 14:31:26 +01:00
65965332b7 I#273 - Set messages also seen in 'Empty Junk'
Closes https://gitlab.gnome.org/GNOME/evolution/issues/273
2019-01-04 15:42:16 +01:00
4dbbc2ccd6 Bump copyright year - the future is now! 2018-12-18 13:23:15 +01:00
0f12f652b1 "Save Image..." fails on shown attached image in message preview
The image had been stored as "data:image/...;base64;<data>", which
the context menu Save Image and Copy Image could not handle. This
resulted in a lengthy error message, which could cause a crash.
This commit fixes several things:
a) replace "data:" URI-s with "mail://" URI-s, which means less resources
   are needed; it also fixes the Save/Copy Image actions as a side effect;
b) fix memory leak for tiff images;
c) let to Save/Copy Image handle base64-encoded "data:" URI-s (as
   the source HTML message can still contain them);
d) shorten the URI in the error message when it's too long;
e) pass also "filename" into the URI, thus the Save Image has prefilled it,
   the same as attachment's "Save as" action.

Reported downstream at:
https://bugzilla.redhat.com/show_bug.cgi?id=1657361
2018-12-10 16:21:39 +01:00
4f2724115c Clamp GSettings values before restoring window size
The GSettings values can be changed by anything, which means the user
can override the last stored window size to some large enough that
the gdk (or WebKitGTK+) will fail to allocated such large pixmap,
which can lead to a crash. This size clamp helps to avoid it.

Related to downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1657361
2018-12-10 11:06:35 +01:00
5e4714c64e I#238 - [ECollectionAccountWizard] Clear old results before starting any worker
Closes https://gitlab.gnome.org/GNOME/evolution/issues/238
2018-12-07 08:05:29 +01:00
8182ef17c7 I#239 - First run wizard doesn't provide a "collection account" option ][
Change the text wording to simpler one.

Related to https://gitlab.gnome.org/GNOME/evolution/issues/239
2018-12-05 19:05:59 +01:00
85d6b65076 I#239 - First run wizard doesn't provide a "collection account" option
Closes https://gitlab.gnome.org/GNOME/evolution/issues/239
2018-12-05 15:44:28 +01:00
1a9ec85311 I#252 - Mail view's magic spacebar executed even when the view is inactive
Closes https://gitlab.gnome.org/GNOME/evolution/issues/252
2018-12-05 14:16:57 +01:00
9a91724212 I#254 - Handle components with no Summary in the To Do bar and Week view
Closes https://gitlab.gnome.org/GNOME/evolution/issues/254
2018-12-04 14:49:59 +01:00
7786985494 I#248 - Option to open Plain Text composer in Preformatted
Closes https://gitlab.gnome.org/GNOME/evolution/issues/248
2018-12-04 14:05:05 +01:00
6cde71f954 I#165 - [Flatpak] Use GtkFileChooserNative for Flatpak portals support
Closes https://gitlab.gnome.org/GNOME/evolution/issues/165
2018-11-30 12:25:02 +01:00
8d6d8d08db I#154 - Mail signature is changed when reopening an email in the Drafts/Outbox
Closes https://gitlab.gnome.org/GNOME/evolution/issues/154
2018-11-27 14:25:37 +01:00
da0a780463 [itip-view] Do not duplicate X-MICROSOFT-CDO-REPLYTIME in replies
It could happen, in some cases, that the component had already set
X-MICROSOFT-CDO-REPLYTIME property, in which case itip-view added
a new property of the same name at the end. Rather than have there
the duplicates (with different times), remove all existing first.
2018-11-26 12:43:00 +01:00
78279047e5 I#168 - Unclear how to specify login name for a free/busy server
Closes https://gitlab.gnome.org/GNOME/evolution/issues/168
2018-11-20 18:42:52 +01:00
a4dbea9f74 I#237 - Run New Collection Account wizard in its own window
Closes https://gitlab.gnome.org/GNOME/evolution/issues/237
2018-11-20 17:21:54 +01:00
0bc7213501 I#162 - Replied to message marked as seen after message send ][
Added option which defaults to the previous behaviour. To change it run:
gsettings set org.gnome.evolution.mail composer-mark-read-on-reply false

Related to https://gitlab.gnome.org/GNOME/evolution/issues/162
2018-11-20 16:03:18 +01:00
dc612a5e44 [SRV config lookup] Preset authentication method for SMTP
This is to have enabled authentication for the SMTP part, if configured,
thus the first attempt to send a mail would ask for the credentials,
if needed.

Related to https://gitlab.gnome.org/GNOME/evolution/issues/238
2018-11-19 21:45:44 +01:00