2003-05-13 Mike Kestner <mkestner@ximian.com>
* e-table-item.c (eti_event): gross hack to work around a
post dispose event emission by gtk2.0/canvas2.0 [#42622]
svn path=/trunk/; revision=21174
2003-05-13 Chris Toshok <toshok@ximian.com>
[ fixes several utf8/pango related problems, including bugs
#41288, #42596, #42604 ]
* configure.in (GAL_CURRENT): bump to 3, per mkestner.
(GAL_REVISION): drop to 0, per mkestner.
* gal/e-text/e-text.c (reset_layout_attrs): we need to convert the
start/end bounds of the object to byte indices for the attribute.
(reset_layout): in the layout == NULL case don't create the layout
then immediately set it again with the same text. also, we need
to convert selection_start to a byte index before calling
pango_layout_get_cursor_pos.
(e_text_draw): remove some #ifdef 0'd code, move the calculation
of our initial clip_rect below the xpos/ypos assignments so we
don't duplicate the expression. Fix the selection drawing in the
multiline case so that it actually works, instead of assuming that
all ETexts only have 1 line *boggle*.
(get_position_from_xy): this needs to return a utf8 offset.
(e_text_copy_clipboard): convert sel_start/sel_end to byte indices
before copying.
(primary_get_cb): same.
(paste_received): validate the input here, and drop the length
parameter from e_text_insert.
(next_word): convert from an utf8 offset on entry to this
function, and return a utf8 offset when we're done. also, remove
the call the g_unichar_validate. we validate at all points where
text is inserted.
(find_offset_into_line): new function used in the backward/forward
line code. find the utf8 offset into a line (the number of utf8
characters from a prior \n or beginning of the string.)
(_get_position): in general there are lots of changes here because
text->selection_start/text->selection_end are utf8 offsets, not
byte offsets. fix E_TEP_START_OF_LINE so that hitting Ctrl-a when
you're at the beginning of a line doesn't take you to the
beginning of the previous line. fix E_TEP_END_OF_LINE in an
analogous fashion. for E_TEP_FORWARD_CHARACTER we just increment
by 1. for E_TEP_BACKWARD_CHARACTER we just decrement by 1. for
E_TEP_BACKWARD_WORD we drop the g_unichar_validate call and
simplify things a bit. reimplement
E_TEP_FORWARD_LINE/E_TEP_BACKWARD_LINE so they find the current
offset into the line, then scan forward/backward for the next/prev
line, and put us at the right offset on that line. fix
E_TEP_SELECT_WORD so double clicking in the space between words
doesn't select both words - if you double click on the trailing
edge of the space, it selects the next word. leading edge selects
the previous one. for E_TEP_SELECT_ALL use g_utf8_strlen.
(e_text_insert): everything that calls this passes a \0 terminated
string, so we assume it's \0 terminated (the old code did as well,
with calls to strlen) and drop the length parameter. also make
sure this is all utf8 happy.
(capitalize): use g_utf8_offset_to_pointer instead of just adding
text->text and start/end, and remove the validate call. also fix
the call to e_text_model_delete and use e_text_model_insert_length
instead of e_text_model_insert.
(e_text_command): for E_TEP_INSERT, validate the input. for
E_TEP_CAPS just use MAX instead of the neat little hack. also,
fix the scrolling so that it scrolls properly in both X and Y
directions (there are still some hiccups but it's much much better
than previously).
(e_text_commit_cb): validate the input here.
* gal/e-text/e-text-model.c (struct _ETextModelPrivate): just use
a GString here and get rid of MAX_LENGTH.
(e_text_model_dispose): free GString.
(e_text_model_real_validate_position): clean this up a bit.
(e_text_model_real_get_text): return the contents of the GString.
(e_text_model_real_get_text_length): use g_utf8_strlen here.
(e_text_model_real_set_text): convert to GString
(e_text_model_real_insert): just call e_text_model_insert_length
here instead of duplicating the function.
(e_text_model_real_insert_length): convert to utf8/gstring.
i.e. convert @position and @length to a bytes and use
g_string_insert_len.
(e_text_model_real_delete): same, with g_string_erase.
(e_text_model_get_text_length): use g_utf8_strlen
(e_text_model_strdup_nth_object): convert the length of the object
to bytes before copying.
(e_text_model_get_nth_object_bounds): calculate start/end properly
for u
svn path=/trunk/; revision=21163
2003-05-09 Mike Kestner <mkestner@ximian.com>
* e-table-item.c (eti_cursor_change): don't return on col == -1.
* e-tree.c (tree_canvas_size_allocate): update the adjustment
to center the cursor.
(hover_timeout): remove unused variable to fix warning
svn path=/trunk/; revision=21142
2003-05-01 Mike Kestner <mkestner@ximian.com>
* gal/e-text/e-completion-callbacks.c (e_completion_callbacks_new):
return the instantiated object. [bug #42156]
2003-05-01 Mike Kestner <mkestner@ximian.com>
* e-cell-combo.c (e_cell_combo_selection_changed): new
(e_cell_combo_init): connect to selection_changed on popup_list
(e_cell_combo_do_popup): block selection_changed while popping up
[bug #40996]
svn path=/trunk/; revision=21042
2003-04-29 Mike Kestner <mkestner@ximian.com>
* e-cell-text.c (build_layout): don't use unicode ellipsis so
that we don't break on broken font setups.
2003-04-29 Mike Kestner <mkestner@ximian.com>
* e-cell-text.c (generate_layout): don't set width on the layout
during edit
svn path=/trunk/; revision=21012
* e-dateedit.c (e_date_edit_forall): Remove this so that
GtkContainer's destroy method will destroy all of the internal
widgets. (This is how other compound-widgets-that-aren't-
meant-to-be-used-as-containers behave.) #41458
svn path=/trunk/; revision=21003
2003-04-23 Jeffrey Stedfast <fejj@ximian.com>
* gal-view-instance.c (load_current_view): Try stat'ing the file
before loading it with xmlParseFile() to avoid warnign spewage
from libxml2 saying that the file doesn't exist.
svn path=/trunk/; revision=20955
2003-04-22 Anna Dirks <anna@ximian.com>
*misc/e-multi-config-dialog.c : add appropriate padding
and spacing to the settings dialog. Fixes#41392.
svn path=/trunk/; revision=20942
2003-04-21 Mike Kestner <mkestner@ximian.com>
* e-cell-text.c (build_layout): use unicode ellipsis char for
breaking lines. Use g_utf8_find_prev_char and check for failure
so that we don't tight loop for small cells that can't display
any chars.
svn path=/trunk/; revision=20924
2003-04-21 Mike Kestner <mkestner@ximian.com>
* e-cell-tree.c (ect_draw): use e_tree_table_adapter_node_get_next
to determine how to draw sibling lines.
(ect_print): ditto
* e-tree-table-adapter.c (e_t_t_a_node_get_next): new
svn path=/trunk/; revision=20902
2003-04-19 Chris Toshok <toshok@ximian.com>
[ fixes evolution bug #40464 ]
* e-table.c (e_table_class_init): use G_SIGNAL_TYPE_STATIC_SCOPE
for the GtkSelectionData args of table_drag_data_get and
table_drag_data_received.
svn path=/trunk/; revision=20900
2003-04-18 Mike Kestner <mkestner@ximian.com>
* e-cell-text.c (build_layout): if the layout splits into more
than one line, shorten it to a single line with elipses.
(generate_layout): don't ref NULL layouts
(ect_enter_edit): use g_new0 for the CellEdit
(get_position_from_xy): use generate_layout since edit->layout
isn't necessarily set here.
svn path=/trunk/; revision=20892
2003-04-16 Mike Kestner <mkestner@ximian.com>
* e-cell-text.c (build_layout): set width and alignment of layout.
(generate_layout): set width on existing layout and pass new width
param to build_layout.
(ect_draw): pass width to generate_layout
(ect_height): pass width to generate_layout
(ect_enter_edit): pass width to generate_layout
(ect_max_width): pass width to generate_layout
(ect_max_width_by_row): pass width to generate_layout
(ect_show_tooltip): pass width to generate_layout
(e_cell_text_view_command): pass width to generate_layout
svn path=/trunk/; revision=20870
2003-04-15 Hans Petter Jansson <hpj@ximian.com>
* e-calendar-item.c (e_calendar_item_update): Unref the metrics.
(e_calendar_item_draw): Re-use the widget's context instead of
creating a new one. Unref the metrics.
(e_calendar_item_draw_month): Unref the metrics. Don't create the
layout where it might be leaked by an early return. Unref the layout
before returning if we're outside the clip area.
(e_calendar_item_draw_day_numbers): Unref the metrics.
(e_calendar_item_recalc_sizes): Unref the metrics.
(e_calendar_item_convert_position_to_day): Unref the metrics.
* e-calendar.c (e_calendar_size_allocate): Unref the metrics.
svn path=/trunk/; revision=20855
2003-04-15 Hans Petter Jansson <hpj@ximian.com>
* gal-view-instance.c (gal_view_instance_get_popup_menu): Free the
id when we're done with it.
svn path=/trunk/; revision=20854
2003-04-15 Hans Petter Jansson <hpj@ximian.com>
* e-table-header-utils.c (e_table_draw_elided_string): Don't unref
the layout that was passed in.
(e_table_header_draw_button): Always unref the layout when we're
done with it.
* e-tree-table-adapter.c (e_tree_table_adapter_load_expanded_state):
Free the id when we're done with it.
svn path=/trunk/; revision=20853
2003-04-15 Mike Kestner <mkestner@ximian.com>
* gal-define-views-dialog.c (g_d_v_d_init): fix padding and
default size. Fixed warnings elsewhere in file.
(g_d_v_d_set_collection): set the dialog title
svn path=/trunk/; revision=20851
2003-04-11 Jeffrey Stedfast <fejj@ximian.com>
* e-filter-bar.c (do_advanced): Change the border width and
padding to comply with the HIG. Fixes bug #41202.
(do_advanced): Changed the button ordering from Cancel/Save/OK to
Save/Cancel/OK to comply with the HIG. Fixes bug #41207.
svn path=/trunk/; revision=20829
2003-04-11 Jeffrey Stedfast <fejj@ximian.com>
* e-filter-bar.c (do_advanced): Change the border width and
padding to comply with the HIG. Fixes bug #41202.
svn path=/trunk/; revision=20828
2003-04-11 JP Rosevear <jpr@ximian.com>
* e-table-one.c (one_dispose): free data here since we don't have
source in finalize
svn path=/trunk/; revision=20817
2003-04-08 Mike Kestner <mkestner@ximian.com>
* e-search-bar.c (set_option): kill an old e_utf8_gtk usage
and remove some straggling e-font.h includes.
svn path=/trunk/; revision=20769
2003-04-07 Chris Toshok <toshok@ximian.com>
* gal/widgets/e-canvas-background.c (ecb_class_init):
fill_color_gdk is a boxed GdkColor, not a pointer.
(ecb_set_property): same.
(ecb_get_property): same.
svn path=/trunk/; revision=20741
