Commit Graph

843 Commits

Author SHA1 Message Date
4889b42644 New arg @row. Highlight that row. (tree_drag_motion): Pass @row to
* e-storage-set-view.c (handle_evolution_path_drag_motion): New
arg @row.  Highlight that row.
(tree_drag_motion): Pass @row to
`handle_evolution_path_drag_motion()'.

svn path=/trunk/; revision=12961
2001-09-18 23:08:06 +00:00
bb51b55bcc #include "e-gtk-utils.h".
* e-splash.c: #include "e-gtk-utils.h".

svn path=/trunk/; revision=12947
2001-09-18 19:43:36 +00:00
9f792d1de5 Make the canvas backing stored.
* e-splash.c (e_splash_construct): Make the canvas backing stored.

svn path=/trunk/; revision=12944
2001-09-18 18:48:53 +00:00
0e432a12de Call `e_make_widget_backing_stored()' on the widget so it refreshes
* main.c (quit_box_new): Call `e_make_widget_backing_stored()' on
the widget so it refreshes properly even when we are busy waiting
on CORBA calls.

svn path=/trunk/; revision=12920
2001-09-17 23:21:34 +00:00
431cf62eb6 New. (quit_box_destroyed_callback): New. (no_views_left_cb): Use these two
* main.c (quit_box_new): New.
(quit_box_destroyed_callback): New.
(no_views_left_cb): Use these two functions to display a warning
message when Evolution is quitting.

svn path=/trunk/; revision=12917
2001-09-17 22:53:40 +00:00
c8c0ecf1a7 Only raise NotReady if the local storage pointer is actually NULL. This
* e-shell.c (impl_Shell_getLocalStorage): Only raise NotReady if
the local storage pointer is actually NULL.  This way it is
possible for the components to access the local storage during
initialization even if the shell is not quite finished
initializing yet.

svn path=/trunk/; revision=12914
2001-09-17 22:02:40 +00:00
1e050bd5f7 [Fix #9060, Shell crash after mailer crash.]
* e-shell-view.c (hash_foreach_destroy_view): Renamed from
`hash_forall_destroy_view'.  Don't free `name'.
(socket_destroy_cb): Use `g_hash_table_lookup()' instead of
`g_hash_table_lookup_extended()'.  Don't free the URI.
(e_shell_view_remove_control_for_uri): Likewise.
(show_existing_view): Use view->uri as the key when inserting the
view.  Remove the old view from the hash when destroying it.
(create_new_view_for_uri): Same here.

svn path=/trunk/; revision=12913
2001-09-17 21:57:33 +00:00
8fcec5b917 Hide the storage_set_view_box *before* getting the child1_size [otherwise,
* e-shell-view.c (e_shell_view_show_folder_bar): Hide the
storage_set_view_box *before* getting the child1_size [otherwise,
the latter will, um, always be zero].

svn path=/trunk/; revision=12902
2001-09-17 17:51:01 +00:00
67b6c40da6 Updated required version of gal to 0.11.99.4.
2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* configure.in: Updated required version of gal to 0.11.99.4.

From calendar/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* gui/dialogs/meeting-page.c (build_etable): Updated this to match
	the new ETableSimple interface.

From mail/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* message-list.c (ml_get_node_by_id): Made save_id const here.

From shell/ChangeLog:

2001-09-16  Christopher James Lahey  <clahey@ximian.com>

	* e-storage-set-view.c (etree_get_node_by_id): Made save_id const
	here.

svn path=/trunk/; revision=12870
2001-09-17 04:00:31 +00:00
9cb86dd0b0 [Automake 1.5 fixes pointed out by Richard Boulton
<richard@tartarus.org>, as per #9258.]

* importer/Makefile.am (CLEANFILES): Assign directly using `=',
instead of `+='.
* Makefile.am (CLEANFILES): Likewise.

svn path=/trunk/; revision=12846
2001-09-14 23:35:28 +00:00
8e88e78fbb Return a proper value. (impl_Shell_createStorageSetView): Likewise.
* e-shell.c (impl_Shell_getLocalStorage): Return a proper value.
(impl_Shell_createStorageSetView): Likewise.
(impl_Shell_setLineStatus): Likewise.
(impl_Shell__get_displayName): Likewise.
(impl_Shell_getComponentByType): Likewise.
(impl_Shell_createNewView): Likewise.
(impl_Shell_handleURI): Likewise.

svn path=/trunk/; revision=12834
2001-09-14 22:38:08 +00:00
2fe3340586 Fix crash and remove warning
svn path=/trunk/; revision=12828
2001-09-14 19:48:10 +00:00
3e92e7a0eb Removed unused variable.
* e-shell-importer.c (start_import): Removed unused variable.

svn path=/trunk/; revision=12827
2001-09-14 19:31:17 +00:00
1b26832f14 [Fix #8204 and the other bugs caused by allowing invocations on
the ::Shell interface to happen before the shell is actually fully
initialized.  This is a lame hack and not a nice, complete
solution for the problem, but it should do for now.]

* e-shell.c: New member `is_initialized' in `EShellPrivate'.
(init): Initialize to %FALSE.
(e_shell_construct): Set `is_initialized' to %TRUE after the
initialization sequence is finished.
(raise_exception_if_not_ready): New utility function to raise the
notReady exception if the shell is not ready.
(impl_Shell__get_displayName): Call it.
(impl_Shell_getComponentByType): Likewise.
(impl_Shell_createNewView): Likewise.
(impl_Shell_handleURI): Likewise.
(impl_Shell_selectUserFolder): Likewise.
(impl_Shell_getLocalStorage): Likewise.
(impl_Shell_createStorageSetView): Likewise.
(impl_Shell_setLineStatus): Likewise.
(e_shell_construct): Print out the repo_id of the exception from
`bonobo_get_object()' if it fails.  Also, register on OAF just
before displaying the splash.

* Evolution-Shell.idl: New exception `NotReady'.  All the CORBA
methods on ::Shell can now raise this exception.

svn path=/trunk/; revision=12826
2001-09-14 19:27:41 +00:00
638ad0ba0b [Fix #5990, Remembering Evolution window geometry.]
* e-shell.c (impl_Shell_createNewView): gtk_widget_show() the new
view returned by `e_shell_create_view()'.
(e_shell_restore_from_settings): Same here, after loading the
settings.

* e-shell-view.c (activate_shortcut_cb): gtk_widget_show() the new
view returned by `e_shell_create_view()'.

* e-shell-view-menu.c (command_open_folder_in_new_window):
gtk_widget_show() the view returned by `e_shell_create_view()'.

* e-shell-folder-commands.c
(e_shell_command_open_folder_in_other_window): gtk_widget_show()
the view returned by `e_shell_create_view()'.

* e-shell.c (e_shell_create_view): Don't show the view
automatically anymore.

* e-shell-view.c (e_shell_view_save_settings): Save the width and
height of the window.
(e_shell_view_load_settings): Restore the width and the height and
gtk_window_set_default_size() based on them.

svn path=/trunk/; revision=12816
2001-09-13 23:46:03 +00:00
81b29a04e5 [Remove a bunch of debugging messages, as per #7741.]
* evolution-wizard.c (impl_GNOME_Evolution_Wizard_notifyAction):
Removed debugging messages.

* e-storage-set.c (storage_removed_folder_cb): Removed debugging
message.

* e-storage-set-view.c (tree_drag_begin): Removed debugging
message.
(tree_drag_data_received): Removed debugging messages.

* e-shortcuts.c (idle_cb): Removed debugging message.

* e-shortcuts-view-model.c (get_icon_for_item): Removed debugging
message.

* e-shell.c (setup_components): Removed debugging message.

* e-shell-startup-wizard.c (druid_event_notify_cb): Removed
debugging message.
(e_shell_startup_wizard_create): Removed debugging message.

* e-shell-offline-handler.c (finalize_offline_hash_foreach):
Removed debugging message.

* e-shell-importer.c (start_import): Removed debugging message.
(item_selected): Same here.

* e-local-storage.c (async_xfer_folder_step): Removed debugging
message.

* e-corba-storage.c (impl_StorageListener_notifyFolderCreated):
Changed the error from a g_print() into a g_warning().  Removed
debugging message.

* e-corba-storage-registry.c (impl_StorageRegistry_addStorage):
Removed debugging message.
(impl_StorageRegistry_removeStorageByName): Likewise.

* e-component-registry.c (component_free): Removed debugging
message.
(register_component): Don't printf() about the registered folder
type.
(register_component): Don't printf() about the registered schema
type.

svn path=/trunk/; revision=12811
2001-09-13 21:26:42 +00:00
c788ba0faf Disable DnD on the EStorageSetView to avoid strange behaviors.
* e-shell-view.c (pop_up_folder_bar): Disable DnD on the
EStorageSetView to avoid strange behaviors.
(reparent_storage_set_view_box_and_destroy_popup): Re-enable DnD
here.
(popdown_transient_folder_bar): And here as well.

* evolution-storage-set-view-factory.c
(evolution_storage_set_view_factory_new_view): Disable DnD on the
EStorageSetView.

* e-shell-folder-selection-dialog.c
(e_shell_folder_selection_dialog_construct): Disable DnD on the
EStorageSetView.

* e-shell-folder-creation-dialog.c (add_storage_set_view): Disable
DnD on the EStorageSetView.

* e-storage-set-view.c: New member `allow_dnd' in
`EStorageSetViewPrivate'.
(init): Init to `allow_dnd' %TRUE.
(tree_start_drag): If `allow_dnd' is false, don't start the drag
and return %FALSE.
(tree_drag_motion): If `allow_dnd' is false, return %FALSE.
(e_storage_set_view_get_allow_dnd): New.
(e_storage_set_view_set_allow_dnd): New.

svn path=/trunk/; revision=12810
2001-09-13 21:11:22 +00:00
11de2d8861 Add SUB_VERSION to the version string passed to
* main.c (main): Add SUB_VERSION to the version string passed to
`gnome_init_with_popt_table()'.

svn path=/trunk/; revision=12792
2001-09-13 01:26:17 +00:00
49510132a1 only allow importing to /local folders.
2001-09-12  Chris Toshok  <toshok@ximian.com>

	* e-shell-importer.c (start_import): only allow importing to
	/local folders.

svn path=/trunk/; revision=12790
2001-09-13 00:02:18 +00:00
d90320e221 [Fix #4962, "Highlighting is left after a drag".]
* e-storage-set-view.c (tree_drag_motion): Only highlight when
moving over allowed targets.

svn path=/trunk/; revision=12789
2001-09-12 23:09:30 +00:00
2b03fcd918 Only gtk_widget_destroy() the icon_widget if it's not NULL.
* e-shell-folder-title-bar.c (unrealize): Only
gtk_widget_destroy() the icon_widget if it's not NULL.

svn path=/trunk/; revision=12788
2001-09-12 22:28:13 +00:00
0ab127f884 Remove spew
svn path=/trunk/; revision=12785
2001-09-12 21:49:08 +00:00
30d3750b07 Oops. Remove duplicate free.
* e-shell-view.c (socket_destroy_cb): Oops. Remove duplicate free.

svn path=/trunk/; revision=12732
2001-09-10 16:34:37 +00:00
afdc8acc65 Purify run. All small leaks.
* e-shell-folder-commands.c
	(folder_selection_dialog_folder_selected_callback): Free the
	folder_command_data when destroying the dialog.

	* e-local-storage.c (remove_folder): Free physical_uri if we
	allocated it.

	* e-shortcuts-view.c (pop_up_right_click_menu_for_group): Unref
	the popup menu, don't destroy it.
	(destroy_group_cb): Free the question string.
	(rename_group_cb): Free the new_name.

	* e-shell-importer.c (create_plugin_menu): Free the list of
	importers.
	(get_iid_for_filetype): Likewise.
	(import_druid_finish): #ifdef out some g_strdups that are only
	used by other #ifdef'ed-out code.

	* e-shell-view.c: Make sure the keys in the uri_to_view hash get
	freed.

	* e-shell-folder-title-bar.c (set_title_bar_label_style): Unref
	the style after setting it on the widget.

	* e-shell-offline-handler.c (impl_destroy): free priv.

	* e-storage-set-view.c (tree_drag_data_received): Make sure
	target_type always gets freed.

	* e-shell-folder-creation-dialog.c (add_folder_types): Don't leak
	the type names.

svn path=/trunk/; revision=12715
2001-09-09 18:24:15 +00:00
000be30129 New design
svn path=/trunk/; revision=12690
2001-09-07 22:20:24 +00:00
bde685165f Changed this to use the new ETable/ETree drag stuff.
2001-09-07  Christopher James Lahey  <clahey@ximian.com>

	* e-storage-set-view.c (tree_start_drag): Changed this to use the
	new ETable/ETree drag stuff.

svn path=/trunk/; revision=12686
2001-09-07 21:11:57 +00:00
330abd5609 Remove the "see previous error messages?" comment from the error message
* evolution-shell-component-client.c
	(evolution_shell_component_client_new): Remove the "see previous
	error messages?" comment from the error message when starting a
	component, since oafd eats the output of the components it
	launches now, so it's just misleading.

svn path=/trunk/; revision=12673
2001-09-07 14:45:22 +00:00
38353e7c03 change to match create_folder. (e_marshal_NONE__POINTER_POINTER_POINTER):
2001-09-06  Chris Toshok  <toshok@ximian.com>

	* evolution-storage.c (impl_Storage_async_remove_folder): change
	to match create_folder.
	(e_marshal_NONE__POINTER_POINTER_POINTER): new marshaller for
	remove_folder.
	(class_init): make sure to use the right marshaller for
	create/remove_folder.

	* evolution-storage.h: change the signature of both the
	create_folder and remove_folder signals to be more in line with
	what's in evolution-storage.c.  They both take a Bonobo_Listener
	which the signal func notifies, instead of synchronously returning
	the result.

svn path=/trunk/; revision=12667
2001-09-07 01:58:00 +00:00
c79ee4fb9a Allow a value of -1.0 for @progress [which means "unknown progress"].
* evolution-activity-client.c (evolution_activity_client_update):
Allow a value of -1.0 for @progress [which means "unknown
progress"].

svn path=/trunk/; revision=12659
2001-09-06 20:56:54 +00:00
56ed3ed3b9 [Fix #958, ShellComponents should not be created by factories, for
the test component.]

* GNOME_Evolution_TestComponent.oaf: Remove the factory.

* evolution-test-component.c (COMPONENT_FACTORY_ID): Removed.
(component_factory_init): Removed.
(register_component): Rename from `component_fn'.  No args, no
return value.  Register the thing on OAF by yourself instead of
using a factory.

svn path=/trunk/; revision=12639
2001-09-05 22:58:45 +00:00
e9a3200abe New. (get_efolder_from_shortcut): Removed. (impl_shortcut_dropped): Use
* e-shortcuts-view.c (get_shortcut_info): New.
(get_efolder_from_shortcut): Removed.
(impl_shortcut_dropped): Use `get_shortcut_info()' instead.

svn path=/trunk/; revision=12628
2001-09-05 20:42:57 +00:00
000b01e9a1 Replace "Evolution" with "Ximian Evolution" in a bunch of user-visible
places.

svn path=/trunk/; revision=12625
2001-09-05 19:27:03 +00:00
cb704fd31b [Fix #6474 and friends, crash when selecting things from the
context activity context menu.]

* e-activity-handler.c: New member `menu' in struct
`ActivityInfo'.
(activity_info_new): Init to NULL.
(show_cancellation_popup): Set the `menu' member to point to this
newly created pop-up, use `gnome_popup_menu_do_popup_modal()'
instead of `gnome_popup_menu_do_popup()', and set the `menu'
member to NULL when the menu is gone.
(activity_info_free): Destroy `menu' member.
(impl_requestDialog): Return
`GNOME_Evolution_Activity_DIALOG_ACTION_ERROR' instead of nothing.

svn path=/trunk/; revision=12624
2001-09-05 18:55:28 +00:00
bc21d949ca [Fix #6971, Default folder should be the Summary.]
* main.c (idle_cb): s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell.c (e_shell_create_view):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell-view.c (socket_destroy_cb):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.
(e_shell_view_save_settings): Likewise.

* e-shell-folder-commands.c (e_shell_command_delete_folder):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell-view.h (DEFAULT_URI): Rename to
`E_SHELL_VIEW_DEFAULT_URI'.  Change from "evolution:/local/Inbox"
to be "evolution:/summary".

svn path=/trunk/; revision=12618
2001-09-05 00:10:03 +00:00
e68545150a [Fix ^#7675, Crashes trying to empty trash folder.]
* e-shortcuts.c (e_shortcuts_construct): Use
`gtk_signal_connect_while_alive()' so we don't invoke the
callbacks on dead EShortcuts objects.

svn path=/trunk/; revision=12612
2001-09-04 23:12:51 +00:00
4a0b4b24d0 Report errors in the dialog
svn path=/trunk/; revision=12611
2001-09-04 23:11:18 +00:00
fef8a88102 Just ignore the request if the activity handler has the
* e-activity-handler.c (impl_operationProgressing): Just ignore
the request if the activity handler has the GTK_OBJECT_DESTROYED()
flag set.  This should prevent crashes like #7542 and friends when
the components are not well-behaved enough to respect the Bonobo
refcounting.
(impl_operationStarted): Likewise.
(impl_operationFinished): Likewise.
(impl_requestDialog): Likewise.

svn path=/trunk/; revision=12609
2001-09-04 22:57:18 +00:00
00164176ef Check the file exists before trying to import it
svn path=/trunk/; revision=12603
2001-09-04 21:42:45 +00:00
012f7f454a Shut down other components correctly when cancelling the first time startup dialog
svn path=/trunk/; revision=12600
2001-09-04 21:20:57 +00:00
1b240a84be Remove debugging message. (tree_drag_motion): Likewise.
* e-storage-set-view.c (tree_drag_motion): Remove debugging
message.
(tree_drag_motion): Likewise.

svn path=/trunk/; revision=12598
2001-09-04 20:53:22 +00:00
3e05c18406 Add the root node to the hash. (e_storage_set_view_set_show_folders):
* e-storage-set-view.c (e_storage_set_view_construct): Add the
root node to the hash.
(e_storage_set_view_set_show_folders): Likewise.

svn path=/trunk/; revision=12594
2001-09-04 19:54:48 +00:00
3b17294f86 Remove the folder from the EvolutionStorage as well as the EStorage.
2001-08-30  Peter Williams  <peterw@ximian.com>

	* e-local-storage.c (async_xfer_folder_complete): Remove the folder from
	the EvolutionStorage as well as the EStorage.

2001-08-29  Peter Williams  <peterw@ximian.com>

	* e-storage-set-view.c (etree_node_destroy_func): Only call
	remove_node_from_hash if it's not the root node.
	(removed_storage_cb): Don't remove the node from the hash here,
	because it will be removed in the node_destroyed callback.
	(removed_folder_cb): Same.

	* e-shell-view.c (e_shell_view_remove_control_for_uri): Disconnect
	from the destroy signal so as not to confuse ourselves. Also, the
	page remove in the notebook destroys the control and the socket, so don't
	do that explicitly.

	* e-shell-folder-commands.c
	(folder_selection_dialog_folder_selected_callback): Remove the control
	for the source view if we're moving.

svn path=/trunk/; revision=12578
2001-09-04 15:30:13 +00:00
578b942b6a Don't convert folder name to UTF-8 manually... (setup_stock_folders): ...
* e-local-storage.c
(setup_folder_as_stock): Don't convert folder name to UTF-8 manually...
(setup_stock_folders): ... just use U_() here.
(impl_get_display_name): Marked string for translation (with U_).

* e-storage-set-view.c
(storage_sort_callback): s/strcasecmp/g_utf8_collate/
(folder_sort_callback): ditto

* e-summary-storage.c (impl_get_display_name):
Marked string for translation (with U_).

svn path=/trunk/; revision=12546
2001-08-31 21:44:24 +00:00
553de94865 Fix the Pine and Netscape importers. Give them a nice progress reporting GUI.
Revert Jason's changes so that creating a folder works again.

svn path=/trunk/; revision=12536
2001-08-30 23:21:56 +00:00
8ece4a0086 Check for \r in the folder name, this is an invalid char. Also take a
2001-08-30  Jeffrey Stedfast  <fejj@ximian.com>

	* e-shell-folder-creation-dialog.c (entry_name_is_valid): Check
	for \r in the folder name, this is an invalid char. Also take a
	"reason" argument so we can inform the user why his folder name is
	invalid.
	(dialog_clicked_cb): Tell the user why the folder name is invalid.

svn path=/trunk/; revision=12533
2001-08-30 21:04:45 +00:00
5248c1282c Handle the case when there is no URI without crashing. Only add shortcuts
* e-shortcuts.c (load_shortcuts): Handle the case when there is no
URI without crashing.  Only add shortcuts when they are evolution:
URIs.

svn path=/trunk/; revision=12506
2001-08-29 00:21:44 +00:00
d671e29102 Studlycapsize all the IDs that are not. Likewise. Updated accordingly.
* Evolution-ShellComponent.idl: Studlycapsize all the IDs that are
not.
* Evolution-common.idl: Likewise.
* evolution-activity-client.c: Updated accordingly.
* evolution-shell-component.c: Likewise.
* evolution-storage.c: Likewise.
* e-activity-handler.c: Likewise.
* e-component-registry.c: Likewise.
* e-corba-storage.c: Likewise.
* e-shell-user-creatable-items-handlers.c: Likewise.

* e-local-storage.c (remove_folder): Remove unused variable.

* e-shell-view.c (update_for_current_uri): Assign zero to
`unread_count', not NULL.

* e-shell-importer.c (import_druid_finish): Remove unused
variable.

* e-shell-user-creatable-items-handler.c: #include
"e-corba-utils.h".

* e-shell-startup-wizard.c: #include "e-shell-startup-wizard.h".

* e-shell-startup-wizard.h: #include <glib.h>

* e-summary-weather.c (weather_make_html): Make local variable
`icon_name' const.  Remove unused variable `uri'.

* e-summary.h: Reformatted in GTK+ style.
(e_summary_remove_online_connection): Added prototype.

* e-summary-preferences.c (fill_mail_shown_clist): Constify local
variable `name'.

* e-summary-mail.c: #include "e-util/e-path.h".  Updated to match
the new studlyCapsification in shell/Evolution*.idl.

* mail-local.c: Match the studlyCapsification of
shell/Evolution*.idl.

* mail-config-druid.h: Change type of `event_source' from
`Bonobo_EventSource *' to `Bonobo_EventSource'.

* mail-accounts.c (mail_delete): Remove unused local variable
`label'.

* folder-info.c (do_get_info): `#if 0' unused variables.

* gui/component/addressbook-component.c: Get rid of a warning by
initializing the closing NULL element in folder_types correctly.

* gui/component/select-names/e-select-names.c: Updated to match
the studlyCapsification of attributes in shell/Evolution*.idl.

svn path=/trunk/; revision=12495
2001-08-28 00:18:34 +00:00
bcb7c5c83e Remove the stupid "do you want me to initialize stuff?" dialog.
* e-setup.c (copy_default_stuff): Remove the stupid "do you want
me to initialize stuff?" dialog.

svn path=/trunk/; revision=12465
2001-08-24 23:07:22 +00:00
bebd05b36a Change the `selected_row_path' to be non-const. (destroy): Free it.
* e-storage-set-view.c: Change the `selected_row_path' to be
non-const.
(destroy): Free it.
(e_storage_set_view_set_current_folder): Set the selected_row_path
to be this path.
(tree_drag_begin): Free the selected_row_path and strdup() the
value we assign.

svn path=/trunk/; revision=12463
2001-08-24 22:50:14 +00:00
17a85e8669 Ooops. Save the pointer to the control for use after the view struct is
* e-shell-view.c (e_shell_view_remove_control_for_uri): Ooops.
Save the pointer to the control for use after the view struct is
freed.

svn path=/trunk/; revision=12458
2001-08-24 21:38:15 +00:00