Commit Graph

361 Commits

Author SHA1 Message Date
244694ee58 s/apply/flush/. (e_msg_composer_flush_pending_body): renamed from apply
001-10-15  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer.c (e_msg_composer_add_message_attachments):
	s/apply/flush/.
	(e_msg_composer_flush_pending_body): renamed from apply now takes
	apply as an argument.
	(e_msg_composer_show_sig_file): s/g_assert/g_return_if_fail/
	warnings make for less painful bugs than crashes.
	(set_editor_text): s/g_assert/g_return_if_fail/

svn path=/trunk/; revision=13681
2001-10-15 19:48:06 +00:00
da2d6ee08c Don't pop up an "unable to retrieve message" if the composer never
* e-msg-composer.c (autosave_manager_unregister): Don't pop up an
	"unable to retrieve message" if the composer never finished
	initializing.
	(init): Don't call autosave_manager_register here: wait until the
	end of create_composer.
	(create_composer): Remove the distinction between this and
	e_msg_composer_construct since there's no need for the latter. Use
	e_activation_failure_dialog if either the selectnames component or
	the gtkhtml editor fails.

	* e-msg-composer-hdrs.c (setup_corba): Don't g_warn if the oaf
	activation fails. create_composer() will tell the user.

svn path=/trunk/; revision=13661
2001-10-13 17:35:40 +00:00
bde8795c94 Deleted declaration of len.
2001-10-11  Jeffrey Stedfast  <fejj@ximian.com>

	* listener.c (impl_event): Deleted declaration of len.

	* e-msg-composer.c (e_msg_composer_add_message_attachments): Take
	a settext argument.
	(e_msg_composer_new_with_message): Updated to pass the settext argument.

svn path=/trunk/; revision=13595
2001-10-11 19:39:07 +00:00
7e628d1745 Check for either a matching account name, or for a matching e-mail address
2001-10-10  Jon Trowbridge  <trow@ximian.com>

        * e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_from_account):
        Check for either a matching account name, or for a matching e-mail
        address embedded in the passed-in string. (Fixes half of bug
        #3255)
        (destroy): Call bonobo_object_release_unref on corba_select_names,
        not CORBA_Object_release.  Otherwise we leak stuff all over the
        place. (Bug #11878)

        * e-msg-composer.c (e_msg_composer_new_with_message): If our message
        doesn't contain an X-Evolution-Account header, pass in the From
        header as the account name.  (Fixes the other half of #3255)

svn path=/trunk/; revision=13567
2001-10-10 20:47:46 +00:00
fee8a6f66d add prototype.
2001-10-10  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer.h: add prototype.

	* e-msg-composer.c (e_msg_composer_add_message_attachments): new
	function to copy attachments from the a message to a composer.
	(e_msg_composer_set_pending_body): make simple function to
	abstract this.
	(e_msg_composer_apply_pending_body): apply the pending body to
	the composer.
	(e_msg_composer_new_with_message): use
	e_msg_composer_add_message_attachments to copy attachments.

svn path=/trunk/; revision=13563
2001-10-10 20:35:33 +00:00
45a3bf8c45 If the attachment fails, report the error to the user.
2001-10-09  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (add_from_file): If the
	attachment fails, report the error to the user.

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new): Now
	takes a CamelException argument.

svn path=/trunk/; revision=13537
2001-10-10 00:10:02 +00:00
a7282ea415 Pass /menu/Edit as the menu path to e_charset_picker thingy.
2001-10-09  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (setup_ui): Pass /menu/Edit as the menu path to
	e_charset_picker thingy.

svn path=/trunk/; revision=13529
2001-10-09 22:00:33 +00:00
88a34e292b fix cut&pasteo.
2001-10-05  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer-attachment-bar.c
	(e_msg_composer_attachment_bar_find_message): fix cut&pasteo.

svn path=/trunk/; revision=13447
2001-10-05 17:50:16 +00:00
a1750a292e remove unused variable.
2001-10-05  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	remove unused variable.

	* e-msg-composer-attachment-bar.c
	(e_msg_composer_attachment_bar_find_message): generalize this to
	lookup content locations as well.

	* e-msg-composer-attachment-bar.h: change prototype to match the
	new function.

	* listener.c (impl_event): handle the url_requested event, look up
	parts in the attachment part and feed them down the stream if it
	is found.

	* e-msg-composer.c (handle_multipart_alternative): delay setting
	the body text.
	(handle_multipart): delay setting body text
	(e_msg_composer_new_with_message): set the body text from the
	object data.  Doing this ensures that we will have the attachments
	processed before we try to look them up.

svn path=/trunk/; revision=13445
2001-10-05 16:57:01 +00:00
45a6a71ecd change to return a CamelMimePart.
2001-10-04  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer-attachment-bar.c
	(e_msg_composer_attachment_bar_find_content_id): change to return
	a CamelMimePart.

	* e-msg-composer-attachment-bar.h: update prototype.

svn path=/trunk/; revision=13437
2001-10-05 05:15:09 +00:00
0f0efa5e77 look up an attachment by it's content id.
2001-10-04  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer-attachment-bar.c
	(e_msg_composer_attachment_bar_find_content_id): look up an
	attachment by it's content id.

	* e-msg-composer-attachment-bar.h: add prototype for
	e_msg_composer_attachment_bar_find_content_id.

svn path=/trunk/; revision=13436
2001-10-05 04:09:41 +00:00
1d4100c58a Make sure to unref the message object so we don't leak it or any
2001-10-03  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (autosave_save_draft): Make sure to unref the
	message object so we don't leak it or any references to
	attachments (child mime parts).

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	Unref the mime part after passing it along to new_from_mime_part.

svn path=/trunk/; revision=13402
2001-10-04 01:53:36 +00:00
c44b422cd6 Pass an empty flags argument to mail_get_folder.
2001-10-02  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (save_draft): Pass an empty flags argument to
	mail_get_folder.

svn path=/trunk/; revision=13352
2001-10-02 21:59:54 +00:00
11c665c925 Use bonobo_ui_component_new_default()', not bonobo_ui_component_new()'.
* e-shell-view.c (e_shell_view_construct): Use
`bonobo_ui_component_new_default()', not
`bonobo_ui_component_new()'.

* mail-account-gui.c (launch_signature_editor): Use
`bonobo_ui_component_new_default()', not
`bonobo_ui_component_new()'.

* e-msg-composer.c (setup_ui): Use
`bonobo_ui_component_new_default()', not
`bonobo_ui_component_new()'.

* gui/dialogs/comp-editor.c (setup_widgets): Use
`bonobo_ui_component_new_default()', not
`bonobo_ui_component_new()'.

svn path=/trunk/; revision=13306
2001-10-02 18:33:34 +00:00
9fda060c7e Don't set Content-Ids on these parts since they are not contained within a
2001-09-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	Don't set Content-Ids on these parts since they are not contained
	within a multipart/related - this fixes bug #10032.

svn path=/trunk/; revision=13195
2001-09-27 19:30:11 +00:00
96ccc526ae Fixes glitch in mailto: url parsing that caused it to fail when recipient
2001-09-26  Jon Trowbridge  <trow@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): Fixes glitch in
	mailto: url parsing that caused it to fail when recipient names
	contained commas. (Bug #10796)

svn path=/trunk/; revision=13156
2001-09-26 19:35:41 +00:00
bfc5551e12 Update to reflect changes to mail_get_folder.
2001-09-20  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (save_draft): Update to reflect changes to
	mail_get_folder.

svn path=/trunk/; revision=13028
2001-09-20 23:35:47 +00:00
c503814d7f Create nonexistant files.
svn path=/trunk/; revision=13021
2001-09-20 22:51:19 +00:00
e8d33a0308 Attach an X-Evolution-Format header so if people re-edit a message in say
2001-09-18  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): Attach an X-Evolution-Format
	header so if people re-edit a message in say their Sent folder, we
	will preserve format preferences.
	(e_msg_composer_get_message_draft): Don't attach
	X-Evolution-Format headers here since it is now done in
	build_message().
	(e_msg_composer_new_with_message): Make sure to remove *all*
	X-Evolution headers by using the mail-tools functions.

svn path=/trunk/; revision=12958
2001-09-18 21:45:23 +00:00
7054bd6586 Don't gtk_object_destroy() the pixbuf loader, unref it instead.
2001-09-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (update): Don't
	gtk_object_destroy() the pixbuf loader, unref it instead.

	* e-msg-composer-hdrs.c (destroy): Don't forget to free the
	private structure.

svn path=/trunk/; revision=12862
2001-09-16 20:54:07 +00:00
8eac276f02 [Automake 1.5 fixes pointed out by Richard Boulton
<richard@tartarus.org>, as per #9258.]

* Makefile.am (CLEANFILES): Set directly with `=' instead of `+='.

svn path=/trunk/; revision=12844
2001-09-14 23:32:16 +00:00
638b60e50d free the text values we get from the property bag and release the property
2001-09-13  Larry Ewing  <lewing@ximian.com>

	* e-msg-composer.c (map_default_cb): free the text values we get
	from the property bag and release the property bag properly.

svn path=/trunk/; revision=12794
2001-09-13 08:04:16 +00:00
551fd78d30 null terminate the destination vector
2001-09-12  JP Rosevear  <jpr@ximian.com>

	* evolution-composer.c (corba_recipientlist_to_destv): null
	terminate the destination vector

svn path=/trunk/; revision=12773
2001-09-12 05:55:24 +00:00
d200d93b12 Don't call new_with_sig_file, it no longer exists.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* evolution-composer.c (init): Don't call new_with_sig_file, it no
	longer exists.

	* e-msg-composer.c (setup_ui): Make sure that the session is
	non-NULL.
	(menu_file_send_cb): And here too.
	(e_msg_composer_new_with_sig_file): Removed.

svn path=/trunk/; revision=12753
2001-09-10 23:27:49 +00:00
b5297de4c4 Make sure that the session is non-NULL. (menu_file_send_cb): And here too.
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (setup_ui): Make sure that the session is
	non-NULL.
	(menu_file_send_cb): And here too.

svn path=/trunk/; revision=12746
2001-09-10 22:34:08 +00:00
9013c9cbd6 Wrap the S/MIME code in ifdef SMIME_SUPPORTED which isn't defined but by
2001-09-10  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): Wrap the S/MIME code in ifdef
	SMIME_SUPPORTED which isn't defined but by some later version will
	be.
	(setup_ui): And again here.

svn path=/trunk/; revision=12742
2001-09-10 20:05:42 +00:00
bd7c5f322f Add VFS_CFLAGS so things don't break when the gnome-vfs headers move.
* Makefile.am: Add VFS_CFLAGS so things don't break when the
	gnome-vfs headers move.

svn path=/trunk/; revision=12720
2001-09-09 23:55:09 +00:00
936f363f4f Originally was corba_recipientlist_to_glist. (impl_Composer_set_headers):
2001-09-08  Jon Trowbridge  <trow@ximian.com>

	* evolution-composer.c (corba_recipientlist_to_destv): Originally
	was corba_recipientlist_to_glist.
	(impl_Composer_set_headers): Use corba_recipientlist_to_destv, new
	destination-based api.

	* e-msg-composer.c (build_message): Get rid of that 'sending'
	stuff.  That was a bad idea.
	(e_msg_composer_new_with_message): Apply the revised api and work
	with vectors of destinations rather than just lists.
	(e_msg_composer_get_recipients): Added.  Returns the full set of
	recipient destinations in a vector.

	* e-msg-composer-hdrs.c: Removed free_destv function.  We use
	e_destination_freev instead.
	(e_msg_composer_hdrs_get_to): Changed to return a vector of
	EDestinations.  This function now works.
	(e_msg_composer_hdrs_get_cc): Ditto.
	(e_msg_composer_hdrs_get_bcc): Ditto.
	(e_msg_composer_hdrs_get_recipients): Added.  Returns a vector of
	EDestinations that is the union of the to, cc and bcc lines.
	(e_msg_composer_hdrs_set_to): Changed to take a vector of
	EDestinations, rather than a GList.
	(e_msg_composer_hdrs_set_cc): Ditto.
	(e_msg_composer_hdrs_set_bcc): Ditto.
	(e_msg_composer_hdrs_to_message): Use our new, improved API, rather
	than a bunch of poking around in BonoboPropertyBags, etc.

svn path=/trunk/; revision=12711
2001-09-09 04:10:54 +00:00
7028220378 Remove some debugging messages that don't check for NULL strings and crash
* e-msg-composer-hdrs.c (set_recipients_from_destv): Remove some
	debugging messages that don't check for NULL strings and crash
	Solaris.

svn path=/trunk/; revision=12701
2001-09-08 03:54:33 +00:00
2b0ac4817c (handle_multipart_alternative, handle_multipart,
e_msg_composer_new_with_message): Update for mail_get_message_body
	change.

svn path=/trunk/; revision=12658
2001-09-06 20:54:24 +00:00
042a789d76 Have to specify a mode when using O_CREAT.
* e-msg-composer.c (save): Have to specify a mode when using
	O_CREAT.

svn path=/trunk/; revision=12652
2001-09-06 18:24:19 +00:00
000b01e9a1 Replace "Evolution" with "Ximian Evolution" in a bunch of user-visible
places.

svn path=/trunk/; revision=12625
2001-09-05 19:27:03 +00:00
8c22a4d62e Pass in FALSE as the 'sending' arg to e_msg_composer_get_message.
2001-08-29  Jon Trowbridge  <trow@ximian.com>

	* e-msg-composer.c (e_msg_composer_get_message_draft): Pass
	in FALSE as the 'sending' arg to e_msg_composer_get_message.
	(build_message): Added a 'sending' arg, which is passed to
	e_msg_composer_get_message.
	(e_msg_composer_get_message): Added a 'sending' arg,
	which gets passed directly on to build_message.

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_to_message): Added
	a "sending" arg, which should be TRUE if the message is being
	sent now (rather than being autosaved, etc.).  The address
	use scores are only updated when sending. (Bug #8332)
	Removed obsolete (#if 0/#endif-ed) code.

2001-08-29  Jon Trowbridge  <trow@ximian.com>

	* mail-callbacks.c (composer_get_message): When calling
	e_msg_composer_get_message, pass in TRUE for the 'sending' arg.
	(Part of the fix for bug #8332)

svn path=/trunk/; revision=12518
2001-08-29 21:21:22 +00:00
6fba7d7077 In the GUI, the toggle is labelled "hide addresses", not "show addresses"
2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * gui/contact-list-editor/e-contact-list-editor.c (extract_info):
        In the GUI, the toggle is labelled "hide addresses", not "show
        addresses" -- so we have to reverse the boolean value we read in.
        (fill_in_info): Same bug as before: since the GUI reads "hide", we
        have to initialize the toggle to '!show_addresses', not
        'show_addresses'.

        * backend/ebook/e-destination.c
        (e_destination_list_show_addresses): Added.
        (e_destination_xml_encode): Encode the value of
        e_destination_list_show_addresses into the XML.
        (e_destination_xml_decode): Read and store the "show_addresses"
        flag.

2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * e-msg-composer-hdrs.c (set_recipients_from_destv): Added.  Try
        to properly handle contact lists in which the addresses of the
        list members should be hidden.
        (e_msg_composer_hdrs_to_message): Changed to extract the
        destination data from the entries and pass it along to
        set_recipients_from_destv.


2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * mail-callbacks.c (ask_confirm_for_only_bcc): Provide alternative
        text for this dialog for the case when a message has only Bcc
        recipients because of a hidden contact list's addresses being
        moved from To/Cc to Bcc.
        (composer_get_message): Try to detect when our message has only
        Bcc recipients because of moving addresses around due to a hidden
        contact list, and show the dialog with the revised wording in this
        case.

svn path=/trunk/; revision=12414
2001-08-23 02:58:14 +00:00
6fea277b7a When reporting an error, use my_file_name instead of file_name since
2001-08-22  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (save): When reporting an error, use
	my_file_name instead of file_name since file_name can be NULL.

svn path=/trunk/; revision=12387
2001-08-22 18:37:03 +00:00
6af9655777 s/attempt recovery/try to recover them/.
* e-msg-composer.c (autosave_manager_query_load_orphans):
s/attempt recovery/try to recover them/.

svn path=/trunk/; revision=12356
2001-08-21 20:27:04 +00:00
a2b0fea026 Reset the "changed" state to FALSE after a successful save.
2001-08-19  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (save_draft): Reset the "changed" state to
	FALSE after a successful save.

svn path=/trunk/; revision=12224
2001-08-19 19:10:55 +00:00
49bce76449 formatted code nicer
svn path=/trunk/; revision=12181
2001-08-17 21:34:50 +00:00
d398be6895 Toggle the View->Attachments menu item. This fixes bug #6107.
2001-08-17  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (show_attachments): Toggle the
	View->Attachments menu item. This fixes bug #6107.

svn path=/trunk/; revision=12177
2001-08-17 21:09:39 +00:00
827e944ea0 YESS!
2001-07-12  Peter Williams  <peterw@ximian.com>

	* e-msg-composer.c (map_default_cb): New function. Figure out
	which widget gets the default and assign it. Harder to do than
	it sounds.
	(e_msg_composer_construct): Hook map_default_cb up to the "map"
	signal.
	(set_focus_to_editor): Removed.
	(set_focus_to_editor_idle): Removed.

svn path=/trunk/; revision=12037
2001-08-14 22:27:42 +00:00
78544223ad Removed comment about the need to resolve nicknames properly, because we
2001-08-10  Jon Trowbridge  <trow@ximian.com>

	* e-msg-composer-hdrs.c (set_recipients): Removed comment about
	the need to resolve nicknames properly, because we now do that.

2001-08-10  Jon Trowbridge  <trow@ximian.com>

        * e-filter-bar.h: Set the subitems to NULL in the pre-defined
        ESearchBarItems.

        * e-filter-bar.c (rule_editor_clicked): Set the ESearchBarItem's
        subitems to NULL.
        (build_items): Set the ESearchBarItem's subitems to NULL.
        (e_filter_bar_new): Set the ESearchBarItem's subitems to NULL.

        * e-search-bar.c: Added support for subitems, so that a search
        option can key off of another option menu rather than just an
        entry.

2001-08-10  Jon Trowbridge  <trow@ximian.com>

        * gui/component/addressbook.c: Set the ESearchBarItem
        subitems explicitly to NULL.

2001-08-10  Jon Trowbridge  <trow@ximian.com>

        * gui/cal-search-bar.c: Where we have ESearchBarItems, set their
        subitems to NULL.

2001-08-10  Jon Trowbridge  <trow@ximian.com>

        * folder-browser.c: Set our ESearchBarItems subitems to NULL.

svn path=/trunk/; revision=11904
2001-08-10 22:36:41 +00:00
79265bbca3 new helper function, just setup idle callback to grab focus
2001-08-09  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (set_focus_to_editor): new helper function,
	just setup idle callback to grab focus
	(set_focus_to_editor_idle): grab focus for editor, before we have
	better solution, it run grab-focus command on editor control
	(e_msg_composer_construct): call prepare_engine here, set focus to
	editor

svn path=/trunk/; revision=11875
2001-08-10 07:17:54 +00:00
2bd1cd5f39 Don't forget to closedir() when we finish with dir.
2001-08-10  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (autosave_manager_query_load_orphans): Don't
	forget to closedir() when we finish with dir.

svn path=/trunk/; revision=11872
2001-08-10 05:18:59 +00:00
6b0d359b25 Set the smime/pgp always-sign options when here so it updates when the
2001-08-09  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (from_changed_cb): Set the smime/pgp
	always-sign options when here so it updates when the user changes
	his/her identity.

svn path=/trunk/; revision=11840
2001-08-09 19:10:45 +00:00
e239e423dd Set the PGP/MIME and S/MIME options to FALSE before getting the message
2001-08-08  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_get_message_draft): Set the
	PGP/MIME and S/MIME options to FALSE before getting the message
	draft and restore the values afterward.

svn path=/trunk/; revision=11802
2001-08-08 21:11:29 +00:00
5949b39e34 Use g_basename(). (setup_ui): Get the default charset from the mail config
2001-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (add_inlined_image): Use g_basename().
	(setup_ui): Get the default charset from the mail config db.

svn path=/trunk/; revision=11716
2001-08-06 22:57:28 +00:00
2b450081f6 handle delete event
2001-08-06  Radek Doulik  <rodo@ximian.com>

	* listener.c (impl_event): handle delete event

svn path=/trunk/; revision=11700
2001-08-06 16:46:10 +00:00
993a74a8c0 More updates to icons, this time the Save, Save As, and Search icons for
a few places.

svn path=/trunk/; revision=11544
2001-08-01 09:11:56 +00:00
c36ab4adbc ui:
2001-07-31  Peter Williams  <peterw@ximian.com>

	* evolution-message-composer.xml: Add "Customize Toolbars" menu item
	and command.

composer:

2001-07-31  Peter Williams  <peterw@ximian.com>

	* e-msg-composer.c (setup_ui): Set the config path for the composer so
	that the customize toolbar command works.

svn path=/trunk/; revision=11529
2001-07-31 19:01:59 +00:00
86dfaaef76 Use the new Send and Send Later icons for the toolbar and menus in the
composer.  (Beautiful work Tuomas and Jakub!)

svn path=/trunk/; revision=11511
2001-07-31 15:19:47 +00:00