Commit Graph

474 Commits

Author SHA1 Message Date
6e5686598a Get rid of the unused exception variable.
2002-12-03  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (message_rfc822_dnd): Get rid of the unused
	exception variable.

svn path=/trunk/; revision=18997
2002-12-03 18:45:47 +00:00
aececffc14 removed warning about e_notice. its used too much, its here to stay.
2002-11-27  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (save): removed warning about e_notice.  its
        used too much, its here to stay.

        * *.[ch]: run fix.sh over everything.

svn path=/trunk/; revision=18973
2002-12-02 03:07:59 +00:00
ec93568b79 removed merge conflicts
svn path=/trunk/; revision=18970
2002-12-01 18:52:52 +00:00
b625bdfa46 s/g_str[n]casecmp/str[n]casecmp
2002-12-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c: s/g_str[n]casecmp/str[n]casecmp

svn path=/trunk/; revision=18969
2002-12-01 18:52:28 +00:00
66442571c9 properly chain finalise.
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (composer_finalise): properly chain finalise.

svn path=/trunk/; revision=18918
2002-11-26 06:39:18 +00:00
8896a36925 Remove the window size setting. (e_msg_composer_attachment_bar_new): Move
2002-11-25  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (init): Remove the window size
        setting.
        (e_msg_composer_attachment_bar_new): Move the window size setting
        here.  Also set icon width based on 15 approximate characters, so
        the icon text is more readable.

svn path=/trunk/; revision=18906
2002-11-25 02:22:38 +00:00
2fd9ea3c7e rewrote most of this. Just use gtkfileselection directly, no
2002-11-22  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-select-file.c: rewrote most of this.  Just use
        gtkfileselection directly, no e-file-selector, much
        smaller/simpler.

2002-11-21  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (remove_attachment): fix
        g_signal_emit params, detail in wrong spot.
        (add_common): Same.

        * e-icon-list.c (icon_new_from_pixbuf): remove the
        'use_broken_event_handling' set.
        (emit_select): Add detail to signal emit.
        (text_changed): Same.

        * e-msg-composer.c (subject_changed_cb): Duh!  dont free subject &
        simplify logic a little.

svn path=/trunk/; revision=18904
2002-11-25 00:12:09 +00:00
7d4c791a79 Duh! dont free subject & simplify logic a little.
2002-11-21  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (subject_changed_cb): Duh!  dont free subject &
        simplify logic a little.

2002-11-20  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-hdrs.c (entry_changed): duh, emit the signal
        using an initialised value(!).

svn path=/trunk/; revision=18873
2002-11-20 23:46:04 +00:00
ccbfa5da03 applied plain_signature_fix.patch
svn path=/trunk/; revision=18841
2002-11-19 18:42:41 +00:00
6cd18c10d9 dont unref after destroy. duh.
2002-11-19  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (add_from_file): dont unref
        after destroy. duh.

        * e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_to): Add type
        code to set_property call.
        (e_msg_composer_hdrs_set_cc): "
        (e_msg_composer_hdrs_set_bcc): "
        (e_msg_composer_hdrs_get_to): Do the same for get_property calls.
        (init): ref/sink the tooltip object.
        (e_msg_composer_hdrs_get_type): fix return type.

        * e-msg-composer.c (GNOME_GTKHTML_EDITOR_CONTROL_ID): we want
        version 3.0 not 1.1.
        (create_composer): Add type code to set property call.
        (autosave_manager_query_load_orphans): my bad, we dont unref
        dialog's once we've destroyed 'em.
        (build_message): "
        (get_file_content): "
        (save): "
        (do_exit): "
        (composer_dispose): moved the autosave shutdown here.

svn path=/trunk/; revision=18836
2002-11-19 04:58:22 +00:00
dbcfcb84f3 Remove check for gtk_main_level(). as far as i can tell it serves no real
2002-11-18  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (create_composer): Remove check for
        gtk_main_level().  as far as i can tell it serves no real purpose,
        and i think gtkmain is now redundant.
        (e_msg_composer_new_with_message): Same here.
        (destroy): moved some stuff into finalise, and made destroy
        mulitcall safe.

svn path=/trunk/; revision=18819
2002-11-18 11:19:30 +00:00
d0aff59f86 Removed {BEGIN,END}_GNOME_DECLS.
* listener.h: Removed {BEGIN,END}_GNOME_DECLS.

* e-msg-composer-select-file.c: Do not #include
<libgnome/gnome-defs.h>.
* e-msg-composer.c: Likewise.
* listener.h: Likewise.

svn path=/trunk/; revision=18738
2002-11-13 16:46:43 +00:00
316e12adf3 bonobo api changes.
2002-11-13  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (setup_ui): bonobo api changes.

svn path=/trunk/; revision=18733
2002-11-13 09:39:00 +00:00
4dece89160 Use the right object_new method.
2002-11-13  Not Zed  <NotZed@Ximian.com>

        * e-icon-list.c (e_icon_list_new): Use the right object_new method.

        * e-icon-list.h: get rid of BEGIN/END_GNOME_DECLS stuff.

svn path=/trunk/; revision=18730
2002-11-13 04:21:22 +00:00
8657f5bbf2 Remove some unused ehaders and ones that cause compilation failures (such
2002-11-11  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c: Remove some unused ehaders and
	ones that cause compilation failures (such as gnome-defs.h).

	* e-icon-list.h: Same.

svn path=/trunk/; revision=18694
2002-11-11 15:56:29 +00:00
234540a383 Fix bonobo object setup.
2002-11-08  Not Zed  <NotZed@Ximian.com>

        * listener.c: Fix bonobo object setup.

        * e-msg-composer-hdrs.c: Remove oaf stuff, fix destroy to be
        multi-call safe.

        * e-msg-composer-attachment.c (e_msg_composer_attachment_new):
        Remove utf8 from locale conversions, & glib api changes.
        (ok_cb): "

        * e-msg-composer-attachment-bar.c (add_from_file): gtk message
        dialog.
        (pixbuf_for_mime_type): glib,gnome-vfs api changes.
        (init): Estimate the icon_height based on the pango font
        description size, this is probably not correct.
        (properties_cb):
        (remove_cb): Changed signature for gnomeui callbacks.
        (popup_icon_context_menu):
        (popup_context_menu): popup_menu api change
        (destroy): Protect from multiple calls.
        (e_msg_composer_attachment_bar_new): Remove push/pop
        visual/colormap stuff.

        * composer-marshal.list: The list of marshallers used by the
        composer.

        * Makefile.am (composer-marshal.h): Added composer marshal builder.

        * evolution-composer.c (class_init): bonobo object epv setup change.
        (factory_fn): Fix changes to factory callback.

        * e-icon-list.c: (icon_get_height): Use bounding box to calc
        height.
        (icon_event): drop gtk_selection_extended.
        (e_icon_list_remove): "
        (select_icon):
        (unselect_icon): "

        * e-msg-composer.c (autosave_save_draft): Dup fd rather than poke
        camel_stream_fd's data.  Also, use camel_stream_close() rather
        than flush.
        (autosave_manager_query_load_orphans): Port to gtk dialog.
        (autosave_query_cb): Removed, redundant.
        (save): Port to gtkdialog.
        (prepare_engine): Fix bonobo-object-client code.
        (get_file_content): gtk dialog
        (do_exit): gtk dialog.
        (setup_signatures_menu): dump gtkutf8 stuff.
        (marshal_NONE__NONE_INT): What WAS jeff thinking?  Removed :)
        (class_init): g object setup.
        (e_msg_composer_get_type): "
        (create_composer): remove bonobo_window_construct, use create
        property instead.  g_signal stuff.  bonobo stuff.
        (is_special_header): Use ascii_strncasecmp
        (e_msg_composer_set_pending_body): gtk->g_object_get/set_data.
        (e_msg_composer_set_body): use ascii_strncasecmp
        (e_msg_composer_add_inline_image_from_mime_part): make cid const.
        (autosave_manager_register):
        (autosave_manager_unregister): Use g_path_get_basename() & account
        for differences.
        (composer_shutdown): rename to finalise/etc.
        (class_init): Use object:finalize instead of shutdown.
        (e_msg_composer_set_body): Use _() rather than U_().
        (build_message): gtk dialog.

2002-11-06  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (pixbuf_for_mime_type): Add
        error return to gdk_pixbuf_new_from_file().

svn path=/trunk/; revision=18659
2002-11-08 06:49:14 +00:00
9e8d970488 Add support for an attach option in the mailto: url.
2002-11-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): Add support for
	an attach option in the mailto: url.

svn path=/trunk/; revision=18489
2002-11-01 20:26:54 +00:00
f3b55ed92d Make sure to save References and In-Reply-To headers. Fixes bug #32932.
2002-10-29  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_with_message): Make sure to
	save References and In-Reply-To headers. Fixes bug #32932.

svn path=/trunk/; revision=18469
2002-10-30 19:47:20 +00:00
d55bf5df7e Don't set the charset param on text parts nor tha rawtext bit on the
2002-10-26  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (attach_to_multipart): Don't set
	the charset param on text parts nor tha rawtext bit on the content
	if a charset for the part is already specified.

svn path=/trunk/; revision=18449
2002-10-28 01:44:36 +00:00
432f75ead1 (size_to_string): Return NULL
instead of the empty string if the size is less than one K.
(update): Only put the size if size_to_string() doesn't return
NULL.  [#32751]

svn path=/trunk/; revision=18439
2002-10-25 20:15:40 +00:00
6dcb454f5a Only add the account address to the list of addresses if it is non-NULL.
2002-10-18  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-hdrs.c (create_from_optionmenu): Only add the
	account address to the list of addresses if it is non-NULL. Fixes
	bug #32446 although it shouldn't ever happen anyway (an account
	address is not allowed to be NULL).

svn path=/trunk/; revision=18401
2002-10-21 16:56:18 +00:00
ed4784f031 We need to treat message/rfc822 streams differently. Fixes bug #32378.
2002-10-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new): We
	need to treat message/rfc822 streams differently. Fixes bug
	#32378.

svn path=/trunk/; revision=18382
2002-10-17 02:13:38 +00:00
8e2daf88d3 Mark the file selector modal. Quick fix for bug #32256.
2002-10-16  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-select-file.c (select_file_internal): Mark the
        file selector modal.  Quick fix for bug #32256.

svn path=/trunk/; revision=18380
2002-10-17 01:43:39 +00:00
988e56a5a9 Set content->rawtext to TRUE for text parts because the content is in its
2002-10-04  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (attach_to_multipart): Set
	content->rawtext to TRUE for text parts because the content is in
	its raw form (since we didn't know the charset when we created
	it). Also only write out the content-object to discover the best
	encoding, we don't want to include the headers of the MIME
	part. Second half of the fix for bug #31655.

svn path=/trunk/; revision=18335
2002-10-07 18:19:34 +00:00
a57815af6b Don't create a new file if the file doesn't exist.
2002-10-02  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (get_file_content): Don't create a new file if
	the file doesn't exist.

svn path=/trunk/; revision=18325
2002-10-04 18:10:44 +00:00
ebbafa91b4 If the user hits cancel when signing/encrypting, don't continue
2002-10-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): If the user hits cancel when
	signing/encrypting, don't continue constructing the message,
	instead abort (and just don't pop up a dialog).

svn path=/trunk/; revision=18291
2002-10-01 21:30:15 +00:00
8427b2c852 When signing/encrypting a part, if a USER_CANCEL occurs, re-use the part
2002-10-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): When signing/encrypting a
	part, if a USER_CANCEL occurs, re-use the part otherwise unref it
	and replace it with the new part.

svn path=/trunk/; revision=18290
2002-10-01 21:21:03 +00:00
43dfa91e96 It's a grand old string-review! Nitpicky and minor changes; details in the appropriate ChangeLog files.
svn path=/trunk/; revision=18268
2002-09-30 20:11:15 +00:00
c53a336be2 let the caller set the "From" account too (by name or address).
* Evolution-Composer.idl (setHeaders): let the caller set the
	"From" account too (by name or address).

	* evolution-composer.c (impl_Composer_set_headers): Update for
	that.

svn path=/trunk/; revision=18260
2002-09-30 14:04:42 +00:00
bb3273ae2f Don't reuse the part that we've signed and/or encrypted, create a new part
2002-09-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): Don't reuse the part that
	we've signed and/or encrypted, create a new part container
	instead. Fixes bug #31379.

svn path=/trunk/; revision=18257
2002-09-28 02:45:50 +00:00
f1877fa23b Use "mail/*" for the allowed_types for the posting folder selector.
* e-msg-composer-hdrs.c (create_headers): Use "mail/*" for the
	allowed_types for the posting folder selector.

svn path=/trunk/; revision=18224
2002-09-25 21:42:06 +00:00
370fd18999 Only append the account name to the end of the From menu item if the email
* e-msg-composer-hdrs.c (create_from_optionmenu): Only append the
	account name to the end of the From menu item if the email address
	is not unique. (That was added for people who have multiple
	accounts with the same email address but different transports. The
	rest of us don't need to be reminded of the account name, and
	having it there can make the window very wide.)

svn path=/trunk/; revision=18207
2002-09-24 21:45:35 +00:00
ce792ef0ec Don't mark empty string with _().
2002-09-24  Zbigniew Chyla  <cyba@gnome.pl>

	* e-msg-composer-attachment-bar.c (size_to_string):
	Don't mark empty string with _().

svn path=/trunk/; revision=18197
2002-09-24 12:20:26 +00:00
9b21f6d8fb Removed a #warning.
* e-icon-list.c (icon_new_from_pixbuf): Removed a #warning.

* e-msg-composer-attachment-bar.c (size_to_string): Don't use dots
here so we don't get funny wrapping from GnomeIconList.  [#236]

svn path=/trunk/; revision=18176
2002-09-23 19:37:11 +00:00
eda4e47a7d Fix non-ANSI switch statement
* e-msg-composer.c (save): Fix non-ANSI switch statement

svn path=/trunk/; revision=18159
2002-09-23 01:36:56 +00:00
3a8fd4e95b allow to select last 2 menu items
2002-09-19  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (signature_cb): allow to select last 2 menu
	items

svn path=/trunk/; revision=18128
2002-09-19 21:27:21 +00:00
85d6c111af Handle multipart/signed and multipart/encrypted parts in a more expected
2002-09-17  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (add_attachments_from_multipart): Handle
	multipart/signed and multipart/encrypted parts in a more expected
	way. Fixes bug #28453.

svn path=/trunk/; revision=18099
2002-09-17 21:27:23 +00:00
a29fc1746b Mark a string for translation.
2002-09-15  Kjartan Maraas  <kmaraas@gnome.org>

	* e-msg-composer.c: Mark a string for translation.

svn path=/trunk/; revision=18072
2002-09-15 23:28:24 +00:00
1fa08a33f8 (composer_key_pressed): Don't chain the event
handler here -- that's just wrong!  Also stop emission of the
signal when we catch Escape.

svn path=/trunk/; revision=17987
2002-09-05 17:29:14 +00:00
f92642ab4f Make it so that the composer will close when the user hits Escape.
2002-09-04  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (create_composer): Make it so that the composer
	will close when the user hits Escape.

svn path=/trunk/; revision=17983
2002-09-04 23:53:00 +00:00
3e580fc532 removed "Set as default" menu item
2002-08-27  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (signature_cb): removed "Set as default" menu
item

svn path=/trunk/; revision=17878
2002-08-27 18:27:14 +00:00
70e176f79d Oops, we were overwriting 'multipart' with our child multipart. Fixes
2002-08-26  Peter Williams  <peterw@ximian.com>

	* e-msg-composer.c (handle_multipart): Oops, we were overwriting
	'multipart' with our child multipart. Fixes 29399.
	(handle_multipart_alternative): Here too.

svn path=/trunk/; revision=17864
2002-08-26 18:34:12 +00:00
b0e603fa0f Fixes bug #29016
2002-08-22  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes bug #29016

	* e-msg-composer.c (e_msg_composer_new_with_message): If the
	X-Evolution-PostTo header exists, then treat this message composer
	as a PostTo composer rather than a mail composer.

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_to_message_internal):
	Set the X-Evolution-PostTo header if that is the mdoe we are in.

svn path=/trunk/; revision=17843
2002-08-22 22:04:36 +00:00
362583b764 Use an EvolutionFolderSelectorButton instead of a label to indicate the
* e-msg-composer-hdrs.c (create_headers): Use an
	EvolutionFolderSelectorButton instead of a label to indicate the
	posting destination. #27920.
	(e_msg_composer_hdrs_set_post_to): Use
	evolution_folder_button_set_uri.
	(e_msg_composer_hdrs_get_post_to): Use
	evolution_folder_button_get_folder.

svn path=/trunk/; revision=17796
2002-08-19 13:27:43 +00:00
419fb428ad Don't turn on pgp signing if this is an iMIP message and pgp_no_imip_sign
* e-msg-composer.c (from_changed_cb): Don't turn on pgp signing if
	this is an iMIP message and pgp_no_imip_sign is set.
	(e_msg_composer_set_body): If setting a text/calendar body and
	pgp_no_imip_sign is true, turn off signing.

svn path=/trunk/; revision=17779
2002-08-15 13:16:26 +00:00
953f044bac Make the warning dialog display the message subject so that it is more
2002-08-13  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (do_exit): Make the warning dialog display the
	message subject so that it is more clear which composer the dialog
	is referring to. Fixes bug #25467.

svn path=/trunk/; revision=17772
2002-08-13 20:57:04 +00:00
0e39518ba7 Set the file-selection window icon. Fixes the mailer part of bug #7368.
2002-08-12  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-select-file.c (create_file_selection): Set the
	file-selection window icon. Fixes the mailer part of bug #7368.

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	Don't call new_from_mime_part() since that function now does some
	copying of the mime part rather than simply reffing it.
	(e_msg_composer_attachment_new_from_mime_part): Make a copy of the
	MIME part so that if the message that this part belongs to gets
	deleted from the the remote store, the composer will still have a
	copy of it. Fixes bug #20308.

svn path=/trunk/; revision=17763
2002-08-12 21:00:58 +00:00
91af634579 Don't call new_from_mime_part() since that function now does some copying
2002-08-12  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	Don't call new_from_mime_part() since that function now does some
	copying of the mime part rather than simply reffing it.
	(e_msg_composer_attachment_new_from_mime_part): Make a copy of the
	MIME part so that if the message that this part belongs to gets
	deleted from the the remote store, the composer will still have a
	copy of it. Fixes bug #20308.

svn path=/trunk/; revision=17760
2002-08-12 19:36:08 +00:00
7f6f1b6844 Parse the auto-cc/bcc recipients and then later when parsing the cc/bcc
2002-07-31  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_with_message): Parse the
	auto-cc/bcc recipients and then later when parsing the cc/bcc
	recipients into EDestination objects, if the address is an
	auto-*cc address, then set auto_recipient to TRUE on that
	EDestination. This fixes bug #28339.

svn path=/trunk/; revision=17664
2002-07-31 23:26:30 +00:00
6cc38b99d6 new helper function (decode_signature_name): new helper function
2002-07-29  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (encode_signature_name): new helper function
	(decode_signature_name): new helper function
	(get_signature_html): use encode_signature_name
	(set_signature_gui): use decode_signature_name

svn path=/trunk/; revision=17636
2002-07-29 21:36:35 +00:00