Commit Graph

26 Commits

Author SHA1 Message Date
23f5773903 Coding style and whitespace cleanup. 2012-02-20 10:04:25 -05:00
49e518ac2b Remove some unnecessary #includes. 2011-11-18 10:10:02 -05:00
126aa2398a Prefer g_simple_async_result_take_error().
Slightly more efficient and convenient than:

    g_simple_async_result_set_from_error (simple, error);
    g_error_free (error);

One less GError to copy and destroy.
2011-10-06 09:37:01 -04:00
938505da18 Let GtkFileChooser track its own last-used-folder.
GtkFileChooser in GTK+ 3.2 now keeps track of the last-used-folder
itself, even across applications, so get out of its way and let it
handle it.
2011-10-06 08:16:21 -04:00
e2b6ff7a6c Miscellaneous cleanups from the account-mgmt branch.
Reducing diff noise so I can see important changes easier when comparing
branches.  A few API changes, but nothing that affects functionality.
2011-09-27 09:31:13 -04:00
8a309aef81 Bug #655252 - Need to escape the comp_uid part of a path 2011-09-26 11:02:47 +02:00
756c8abcb8 Bug #646109 - Fix use of include <config.h> to make sure translations work 2011-05-27 15:23:07 +02:00
c6fd77460f Coding style and whitespace cleanup. 2011-03-05 12:34:28 -05:00
2533e52b8c Do not leak attachments in a mail view 2011-03-02 15:13:40 +01:00
1301cf02ef Bug #614480 - Avoid using G_TYPE_INSTANCE_GET_PRIVATE repeatedly 2011-02-25 16:20:41 +01:00
7a1677520d Remove NULL checks for GObject methods.
As of GLib 2.28 all GObject virtual methods, including constructed(),
are safe to chain up to unconditionally.  Remove unnecessary checks.
2011-02-12 12:54:08 -05:00
22b2d26d04 Free/busy meeting view doesn't work due to non-working extension 2010-12-06 14:23:20 +01:00
83627486d5 Bug 633471 - EAttachmentStore store folder name where uri is expected 2010-10-29 16:41:06 -04:00
ecf3434da0 GObject boilerplate cleanup.
Prefer thread-safe G_DEFINE_TYPE and G_DEFINE_INTERFACE macros over
manual GType registration.

This is just a start... lots more to do.
2010-08-24 14:37:02 -04:00
cae22334fa Remove dead assignments found by clang. 2010-01-15 21:50:05 -05:00
0b98cf60cb Fix some details in our asynchronous functions.
Don't unref the GAsyncResult in finish functions.  Do it after calling
g_simple_async_result_complete().  This allows the GAsyncReadyCallback
to be optional, and we'll still clean up resources properly.

Also, don't call g_simple_async_result_complete_in_idle() unless we're
completing an operation from a separate thread, which we're not in any
of the current cases.
2009-11-20 14:24:45 -05:00
28589a3097 Add e_attachment_store_load_async().
This is a convenience function for adding multiple attachments to a
store and loading them concurrently.

Also included: e_attachment_store_load_finish()
2009-11-19 21:45:26 -05:00
f6ba97d964 Bug 601219 - Transient dialogs in composer window blocks main window 2009-11-09 12:31:31 -05:00
86ecfc5053 Convert some "Save As" actions to run asynchronously.
This introduces e-shell-utils for miscellaneous utility functions
that integrate with the shell or shell settings.  First function
is e_shell_run_save_dialog(), which automatically remembers the
selected folder in the file chooser dialog.

Also, kill some redundant save dialog functions, as well as some
write-this-string-to-disk functions that block.
2009-11-07 14:01:46 -05:00
3c480eccbf Bug 581280 – Wrong attachment name in event 2009-06-02 13:04:49 -04:00
8a7316508e Bug 583991 – "Suggest automatic display of attachment" does not work 2009-05-28 14:21:47 -04:00
6f5464f34c Remove trailing whitespace, again. 2009-05-28 12:13:22 -04:00
68af3e6898 Add e_attachment_store_get_attachments(). 2009-05-14 12:55:33 -04:00
00cf33a815 Bug 582144 – Evolution not showing proper attachment filename 2009-05-13 11:39:18 -04:00
3a87c8d166 Fix an error extracting URIs from local attachments. 2009-05-04 23:32:41 -04:00
e377ea5e61 Bug 516933 – Rewrite attachment UI
Rewrite the attachment UI to better utilize GIO and also to migrate from
GnomeIconList to GtkIconView.  This also introduces a "List View" option
similar to Nautilus, as well as the EAttachmentHandler framework for
extending attachment handling (may eventually replace EMFormatHook).

This commit also fixes a number of secondary attachment bugs:

Bug 311609 – new attachment bar should use regular gtk+ expander
Bug 314923 – Drag and Drop in attachment window is inconsistent and
             requires additional click
Bug 338179 – attachment saving ...
Bug 350364 – Action to get info about attachments
Bug 383047 – Viewing mail attachments
Bug 427235 – Can't copy attachment mime type string
Bug 454091 – Cannot save multiple attachments who have the same name
Bug 494629 – Rethink composer's attachment UI
Bug 553970 – Evolution ignores umask when saving attachments
Bug 577375 – mailto: and attach doesn't URL un-escape
2009-04-27 14:53:18 -04:00