Commit Graph

77 Commits

Author SHA1 Message Date
299521f02c Whitespace cleanup.
Replace 8-space indentation with tab characters, and various other
automated cleanups.
2012-04-01 23:15:38 -04:00
932f7cada8 EConfig: Support custom page skip callbacks.
Add e_config_add_skip_check() to install a callback function to
decide whether to skip a particular page in a GtkAssistant, useful
if a page may be blank in certain conditions.

This feature is not used in Evolution 3.4, but will be used in 3.5.
2012-03-07 11:52:25 -05:00
30869d1fb7 EConfig: Miscellaneous cleanups. 2012-03-07 09:11:24 -05:00
23f5773903 Coding style and whitespace cleanup. 2012-02-20 10:04:25 -05:00
86da0d52fb Don't explicity show the window. We do gtk_widget_show where we'd want
it. The capplet flickrs in Meego. Fixes Meego Bugzilla: #20191
2011-12-01 13:26:03 +02:00
f2b9a4b609 Bug #665103 - Blank composer/mail/network preferences windows 2011-11-29 14:16:55 +01:00
29310c0c67 EConfig: Debugability improvements. 2011-11-12 15:22:50 -05:00
7faa8d19fa a small change 2011-11-09 21:34:37 +05:30
fcbbdfbd18 Coding style and whitespace cleanup. 2011-09-04 07:34:32 -04:00
15376b6657 EConfig: Broadcast abort/commit events by way of signals.
Remove the clumsy abortfunc and commitfunc callback arguments from
e_config_add_items().
2011-08-10 16:13:08 -04:00
1b1697630c Bug 652958 - Evolution Account Assistant jumps steps
The GTK+ patch in bug 653705 is also required for the Account Assistant
to work properly under the new GtkAssistant design in GTK+ 3.1.

This commit only deals with sidebar ordering issues.
2011-06-30 14:19:59 -04:00
61b0e22f3e EConfig: Minor cleanups. 2011-06-30 11:11:45 -04:00
50193c1947 Bug 537691 - Account editor window HIG
Change the OK button to Apply, and fix the padding around the window
edges.  People already bitching about the window being too tall are just
gonna bitch louder now, but it does look better on normal size screens.
2011-05-22 12:58:40 -04:00
8a186c3588 Coding style cleanups. 2011-05-08 13:37:20 -04:00
c6fd77460f Coding style and whitespace cleanup. 2011-03-05 12:34:28 -05:00
1301cf02ef Bug #614480 - Avoid using G_TYPE_INSTANCE_GET_PRIVATE repeatedly 2011-02-25 16:20:41 +01:00
0478e01708 Bug #641011 - Ugly appointment editing windows 2011-02-03 10:45:03 +01:00
ba05584de5 Dialogs no longer have separators. 2011-01-25 10:28:26 -05:00
1e663aa132 Replace EBinding with GBinding.
GObject now does property bindings itself.

Requires GLib >= 2.26.
2010-10-14 07:12:52 -04:00
4c05b9e925 Coding style and whitespace cleanup. 2010-08-29 11:22:28 -04:00
ecf3434da0 GObject boilerplate cleanup.
Prefer thread-safe G_DEFINE_TYPE and G_DEFINE_INTERFACE macros over
manual GType registration.

This is just a start... lots more to do.
2010-08-24 14:37:02 -04:00
240c2a3dc0 Bug 622535 - Account assistant loops on first run
The issue was EConfig's GtkAssistantPageFunc callback assumed the pages
in the GtkAssistant were sorted, but that assumption breaks as EPlugins
with custom EConfigItemFactoryFunc callbacks are introduced and EConfig
has to rebuild its assistant pages.

It's an unnecessary requirement anyway, since EConfig already keeps a
sorted list of widgets internally.  After correcting that assumption a
number of hacks addressing previous page ordering bugs fell out.
2010-06-25 19:53:20 -04:00
7959b11113 Convert "startup-wizard" to an EExtension.
Convert the "startup-wizard" EPlugin to an EExtension, and fix up the
importing UI a bit (but it still needs a lot more love).  Importing
progress is now shown directly in the GtkAssistant window.

Define a new EConfigItem type (E_CONFIG_PAGE_PROGRESS) for creating
progress pages in a GtkAssistant.

Also, change EMAccountEditor semantics slightly: you now have to call
e_config_create_window() manually after creating a new EMAccountEditor
instance.  This allows extra EConfigItems (specifications for the window
content) to be added manually before the window is created.
2010-06-02 16:36:11 -04:00
886a208b1c Hide EConfig sections that have no visible widgets
The EConfig code that creates widgets based on .eplug descriptions will
already hide sections that end up containing no child widgets.

Here we also make that code hide sections that end up containing
only invisible child widgets.  We will use this from the actual
plugins, so that if they decide not to show any widgets in Express
mode, then the corresponding configuration sections will not
show up in the preferences dialog.

EConfig types 'section' and 'section-table' have an internal factory function,
which doesn't return the actual GtkFrame that they create.  Instead, they return
a GtkContainer which is the actual vbox or table used to insert child widgets.

Here we modify the internal factory function to also return the actual GtkFrame
that it creates, so that the calling code can hide *that* frame properly.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
2010-04-13 15:41:46 -05:00
1040078ce6 Update API documentation.
Also, start fixing some Gtk-Doc warnings.  There's a lot.
2010-02-09 18:02:51 -05:00
ec73f5522f Coding style and whitespace cleanup. 2010-01-30 18:09:19 -05:00
b0b61a0724 Fix a potential uninitialized argument in ech_config_section_factory().
Caught by the Clang Static Analyzer.
2010-01-15 21:57:39 -05:00
7013e0891a Bug 600014 - Remove warnings from ech_config_widget_factory() 2009-10-29 08:14:33 -04:00
0d2d45cf9e Bug 599842 - EConfig does not respond to disabling/enabling EPlugins
Requires eplug files to supply <item type="section"> or
<item type="section_table"> for this to work.  The container widget's
"visible" property gets bound to the plugin's "enabled" property.
2009-10-27 21:55:27 -04:00
692df363ee EConfig cleanup. 2009-10-27 09:25:00 -04:00
c655c9f3ec Bug #596720 - Account assistance repeats itself after finishing 2009-10-12 11:44:25 +02:00
5172227bb5 Bug 597108 - E_CONFIG_SECTION headers not properly escaped 2009-10-02 08:39:25 -04:00
a290610bfd Bug 595812 - Crash after finishing account set up 2009-09-28 15:16:21 -04:00
748918c36e Bug 596186 - New Mail account setup Assistant window is blank 2009-09-28 14:34:06 -04:00
f5991437c3 Get EConfig and EEvent hooks working again.
There were a number of problems:

  - Walk the GType tree to find EPluginHook subclasses, instead of
    just registering the immediate children.

  - Some EConfig and EEvent subclasses were not being configured
    properly (particularly the mail and calendar subclasses).

  - Add preference window pages after the main loop starts to make
    sure all plugins and plugin hooks are installed first.
2009-08-31 12:53:52 -04:00
de528db6c1 Bug 567260 - Migrate from GnomeDruid to GtkAssistant 2009-08-18 10:00:23 -04:00
c0d998229d Stop abusing forward declarations. 2009-06-18 16:01:29 -04:00
433eac7844 More code cleanup. 2009-06-02 10:35:03 -04:00
14f8eee012 Whitespace cleanup. 2009-05-28 13:21:01 -04:00
948235c3d1 Prefer GLib basic types over C types. 2009-05-27 10:29:19 -04:00
e4afd3f9fb Remove trailing whitespace, again. 2009-05-26 23:21:02 -04:00
981f6cb4c1 Fix EConfig bugs for Anjal's account setup. 2009-05-22 17:43:57 +05:30
8a072ffc7c GN-bug #572348 - Removed deprecated Gtk+ symbols
Some still left, because those gone in kill-bonobo branch.
2009-04-24 11:45:21 +02:00
ce59fcad4c Use the translated the EConfigItem label when building the UI.
2009-01-01  Matthew Barnes  <mbarnes@redhat.com>

	* e-util/e-config.c (ec_rebuild):
	Use the translated the EConfigItem label when building the UI.


svn path=/trunk/; revision=36961
2009-01-01 22:17:12 +00:00
a75b727efe ** Fix for bug #332729
2008-11-27  Milan Crha  <mcrha@redhat.com>

	** Fix for bug #332729

	* e-config.c: (ep_finalise): Disconnect handlers on the widget before
	freeing the structure it is using.


svn path=/trunk/; revision=36816
2008-11-27 12:59:25 +00:00
14fa5c8a8c Change License from GPL to LGPL. 2nd batch.
More changes to come.

svn path=/trunk/; revision=36247
2008-09-02 16:25:53 +00:00
434bc25ed6 ** Fixes bug #546892
2008-08-11  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #546892

	* e-util/e-icon-factory.c (e_icon_factory_get_image):
	Kill this function.  Use gtk_image_new_from_icon_name().

	* e-util/e-icon-factory.c (e_icon_factory_get_icon_list):
	Kill this function.  Use gtk_window_set_icon_name().

	* widgets/misc/e-activity-handler.c:
	* widgets/misc/e-task-widget.c:
	Purge the GdkPixbuf arguments from the API.  We've been ignoring
	them since the spinner icon was added.

	* addressbook/gui/contact-editor/e-contact-editor-fullname.c:
	* addressbook/gui/contact-editor/e-contact-editor-im.c:
	* addressbook/gui/contact-editor/e-contact-editor-address.c:
	* calendar/gui/alarm-notify/alarm-notify-dialog.c:
	* calendar/gui/dialogs/alarm-dialog.c:
	* calendar/gui/dialogs/alarm-list-dialog.c:
	* calendar/gui/dialogs/cal-attachment-select-file.c:
	* calendar/gui/dialogs/changed-comp.c:
	* calendar/gui/dialogs/delete-error.c:
	* calendar/gui/dialogs/select-source-dialog.c:
	* mail/mail-send-recv.c:
	* mail/message-tag-followup.c:
	* widgets/misc/e-combo-button.c:
	* widgets/misc/e-info-label.c:
	* widgets/misc/e-url-entry.c:
	* widgets/misc/e-task-widget.c:
	Prefer gtk_window_set_icon_name() over gtk_window_set_icon_list().

	* addressbook/gui/contact-editor/e-contact-editor-im.c:
	* calendar/gui/dialogs/event-page.c:
	* calendar/gui/e-timezone-entry.c:
        * e-util/e-gui-utils.c:
        * e-util/e-popup.c:
	* plugins/import-ics-attachments/icsimporter.c:
	* plugins/itip-formatter/itip-view.c:
	* mail/em-folder-browser.c:
	* mail/em-format-html-display.c:
	* mail/mail-send-recv.c:
	* mail/message-tag-followup.c:
	Prefer gtk_image_new_from_icon_name() over e_icon_factory_get_image().

	* calendar/gui/alarm-notify/alarm-queue.c:
	* plugins/mail-notification/mail-notification.c:
	Prefer gtk_status_icon_set_from_icon_name() over
	gtk_status_icon_set_from_pixbuf().

	* addressbook/gui/component/addressbook-view.c:
	* calendar/gui/e-calendar-table.c:
	* calendar/gui/e-calendar-view.c:
	* calendar/gui/e-memo-table.c:
	* mail/mail-mt.c:
	e_activity_handler_operation_started() no longer takes a GdkPixbuf.
	It was ignoring the pixbuf anyway ever since we added a spinner icon.


svn path=/trunk/; revision=35958
2008-08-11 17:04:32 +00:00
abda2bda85 updated novell copyright notices (left others alone)
svn path=/trunk/; revision=35665
2008-06-20 22:26:57 +00:00
4503c052d0 ** Allow evolution to build with G_DISABLE_SINGLE_INCLUDES and
2008-06-06  Matthew Barnes  <mbarnes@redhat.com>

	** Allow evolution to build with G_DISABLE_SINGLE_INCLUDES and
	   GTK_DISABLE_SINGLE_INCLUDES defined.  (#536637)


svn path=/trunk/; revision=35606
2008-06-06 15:12:53 +00:00
a0bb856b78 ** Part of fix for bug #515744
2008-02-18  Milan Crha  <mcrha@redhat.com>

	** Part of fix for bug #515744

	* addressbook/gui/component/addressbook-migrate.c: (get_source_name):
	* plugins/groupwise-features/send-options.c: (get_source):
	* plugins/groupwise-features/share-folder-common.c: (get_container_id):
	* plugins/groupwise-features/install-shared.c: (install_folder_response):
	* plugins/external-editor/external-editor.c: (convert_to_camel_internet_address),
	(org_gnome_external_editor):
	* plugins/itip-formatter/itip-formatter.c: (idle_open_cb):
	* mail/em-folder-view.c: (emfv_setup_view_instance):
	* mail/mail-component.c: (impl_finalize):
	* mail/message-list.c: (ml_tree_value_at):
	* composer/e-msg-composer.c: (drop_action):
	* e-util/e-config.c: (ep_finalise): Use proper member to free.
	* widgets/misc/e-cursors.c: (e_cursors_init):
	* widgets/misc/e-calendar-item.c: (e_calendar_item_draw_month):
	* calendar/gui/dialogs/comp-editor.c: (drop_action):
	* calendar/gui/calendar-config.c:
	(calendar_config_get_hide_completed_tasks_sexp):
	* calendar/gui/comp-editor-factory.c: (edit_existing):
	* calendar/gui/e-day-view.c: (e_day_view_reshape_long_event),
	(e_day_view_on_top_canvas_drag_data_received):
	* calendar/gui/e-day-view-main-item.c:
	(e_day_view_main_item_draw_events_in_vbars),
	(e_day_view_main_item_draw_long_events_in_vbars):
	* calendar/gui/e-day-view-top-item.c: (e_day_view_top_item_draw_long_event):
	* calendar/gui/e-cal-model.c: (redo_queries):
	* calendar/gui/e-calendar-table.c: (e_calendar_table_open_task):
	* calendar/gui/e-memo-table.c: (open_memo):
	* calendar/gui/print.c: (print_todo_details):
	* calendar/gui/migration.c: (get_source_name):
	Memory leak fix.
	* calendar/gui/e-week-view.c: (e_week_view_reshape_events): Simplifies things.


svn path=/trunk/; revision=35044
2008-02-18 11:10:10 +00:00