2002-11-15 Not Zed <NotZed@Ximian.com>
* mail-summary.c (create_summary_view): weak notify -> ref.
* mail-send-recv.c (build_dialogue): weak notify -> ref.
* mail-accounts.c (account_edit_clicked): weak notify -> ref, i
presume this is what jeff meant, 'cause it dont compile otherwise.
svn path=/trunk/; revision=18778
2002-11-14 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_edit_clicked): Use g_object_weak_ref
rather than connecting to destroy.
(account_add_clicked): Same.
* mail-callbacks.c (addrbook_sender): Make this use
g_object_weak_notify also.
(subscribe_dialog_destroy): Add NULL guards here since I think we
really do want to connect to the "destroy" signal in the function
that connects us to that signal.
* mail-config-factory.c (config_control_factory_cb): Same.
* mail-display.c (save_part): Here too.
(make_popup_window): And here.
* mail-send-recv.c (build_dialogue): Same here.
* mail-summary.c (create_summary_view): Use g_object_weak_notify
instead of connecting to the destroy signal.
svn path=/trunk/; revision=18764
2002-11-13 Joe Shaw <joe@ximian.com>
* Makefile.am: Remove a couple backslashes that were causing
automake to complain, even though they were on lines that were
-commented out-. Sigh.
svn path=/trunk/; revision=18746
2002-11-13 Not Zed <NotZed@Ximian.com>
* Makefile.am: Commented out stuff that doesn't build yet. Also
fixed idl build rule. importers still not built.
* main.c (main): bonobactivationise. remove push visual/colormap.
(main): no longer activate activation, let bonobo_init do it.
* mail-signature-editor.c (menu_help): Change help api.
* mail-session.c (user_message_destroy_noreply): removed. Not
used?
* mail-local.c (load_metainfo): xml root->children.
* mail-format.c (g_string_append_len): Removed, it exists now.
2002-11-12 Not Zed <NotZed@Ximian.com>
* subscribe-dialog.c: gnome2ised, use gtkdialog.
(subscribe_get_global_extras): use a weak ref rather than destroy signal.
* message-tag-followup.c: gnome2ised.
* message-tag-editor.c: gnome2ised & converted to gtkdialog.
* message-list.c: gnome2ised.
(message_list_finalise): From destroy method. maybe should be
destroy still.
* message-browser.c: port to gnome2
(message_browser_finalise): renamed from destroy method.
* mail-stream-gtkhtml.c: removed redundant
camel_class_get_global_classfuncs() call.
* mail-signature-editor.c: gtkdialogised, & bonobo api changes.
* mail-search-dialogue.c: gtkdialogised.
* mail-folder-cache.c: cleaned up camel ref/hook casts.
* mail-composer-prefs.c (mail_composer_prefs_get_type): convert to
gtype.
* mail-font-prefs.c (mail_font_prefs_destroy): from finalise.
* mail-config.c: s/bonobo_config/e_config_listener/
Added /apps/Evolution prefix to the evolution keys.
Changed to use e_config_listener, etc.
(mail_config_init): remove bonobo_config stuff.
(mail_config_check_service): gtk dialogise.
(check_response): from check_cancelled.
* mail-config-druid.c (mail_config_druid_destroy): renamed from
_finalize, turned into destroy handler.
(construct): set type to toplevel, GTK_WINDOW_DIALOG no longer exists.
* mail-config-factory.c (mail_config_register_factory): bonobo api
changes.
* mail-crypto.c (mail_crypto_get_pgp_cipher_context): cleaned up
unref casts.
* mail-display.c (write_data_to_file): gnome->gtkdialog.
(on_link_clicked): use ascii_str*cmp on url.
(save_part): g_path stuff.
(launch_cb): gtk dialog.
(pixmap_press): de-oafify.
(pixbuf_for_mime_type): gnome-vfs api changes.
(do_attachment_header): Change the pixmap to a gtkimage.
(do_signature): "
(pixbuf_gen_idle): "
(do_attachment_header): ascii_str*cmp
(do_attachment_header): gnome pixmap->gtkimage.
(mail_display_destroy): protect against gtk mentalness.
(html_button_press_event): ascii_str*cmp
(drag_data_get_cb): added comment for translators of filename.
* mail-format.c (component_supports): de-oafise.
(is_anonymous): ascii_strncmp
(attachment_header): remove utf8<>locale stuff, and gnomevfs api
changes.
(format_mime_part): fix g_strdown call.
(write_field_row_begin): kill utf8->gtk stuff.
(write_address): "
(default_header_index): ascii_strcasecmp
(handle_text_plain): "
(handle_text_enriched): "
(handle_multipart_encrypted): remove utf/gtk stuff.
(handle_message_external_body): ascii_str*cmp
* mail-identify.c (mail_identify_mime_part):
(identify_by_magic): gnome vfs api changes.
* mail-importer.c: Converted.
* mail-local.c (load_metainfo): xml childs -> children.
(mls_get_folder): g_strerror.
(mls_delete_folder): g_strerror.
(reconfigure_got_folder): Gnome->GtkDialog
(reconfigure_response): from reconfigure_clicked.
* mail-mt.c (mail_msg_check_error): gnome -> gtk dialog
(error_response): renmae from error_gone. destroy widget on any
response.
* mail-offline-handler.c (impl_finalise): renamed from
impl_destroy since thats what it should be anyway.
* mail-ops.c: removed utf8 widget conversion & camel_object_un/ref
casts.
* mail-preferences.c (mail_preferences_get_type): glib2'ised.
* mail-search.c (mail_search_finalise): renmaed from destroy &
properly chain.
(mail_search_get_type): glib2 & make gtkdialog parent.
(entry_run_search): run search when entry activated. not sure if
gtkdialog has anohter way to do this on an arbitrary widget.
* mail-send-recv.c (dialogue_response): renamed from clicked. Use
gtkdialog.
* mail-session.c (request_password_deleted): removed, redundant.
(pass_response): rename from pass_got, changed for gtkdialog.
(user_message_destroy): Removed, redundant.
(user_message_response): Renamed from user_message_clicked.
2002-11-11 Not Zed <NotZed@Ximian.com>
* mail-stream-gtkhtml.c (mail_stream_gtkhtml_class_init): dont use
get_global_classfuncs, just get the type
* mail-tools.c: converted gnome2 api's.
* mail-vfolder.c (vfolder_editor_response): clicked->response.
(vfolder_editor_destroy): Removed.
(vfolder_edit): gtk dialog api
(edit_rule_response): clicked->response.
(vfolder_edit_rule): gnomedialog->gtkdialog.
(vfolder_gui_add_rule): "
(new_rule_clicked): clicked->response
svn path=/trunk/; revision=18723
2002-10-28 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser.c (folder_browser_query_changed): No longer need
to check for a CLEAR_ID.
svn path=/trunk/; revision=18463
2002-10-28 Larry Ewing <lewing@ximian.com>
* mail-format.c (handle_multipart_mixed): instead of bailing with
an assertion dump the body.
(handle_multipart_signed): same.
(handle_multipart_alternative): same.
(handle_multipart_appledouble): same.
svn path=/trunk/; revision=18462
2002-10-28 Larry Ewing <lewing@ximian.com>
* mail-format.c (handle_multipart_mixed): instead of bailing with
an assertion dump the body.
svn path=/trunk/; revision=18457
2002-10-27 Larry Ewing <lewing@ximian.com>
* mail-display.c (fetch_next): don't queue the action until we've
added ourselves to the active list, because the fetch_done
callback can fire immediately and we'll end up queueing something
that has already been destroyed.
svn path=/trunk/; revision=18452
2002-10-24 Jeffrey Stedfast <fejj@ximian.com>
Update the upgrade script to handle the new url format introduced
with NotZed's most recent commits.
* upgrade-mailer.c (mailer_upgrade): Save an encoded version of
the namespace too, for use later.
(si_free): Free the encoded namespace too.
(imap_url_upgrade): Use the encoded namespace when creating the
new url.
(shortcuts_upgrade_xml_file): Upgrade the default: urls. Fixes bug
#32127.
svn path=/trunk/; revision=18438
2002-10-25 Not Zed <NotZed@Ximian.com>
* mail-config.c (mail_config_uri_renamed): Always strdup the new
key in the threaded/preview hash/always free the working copy.
For #32799.
svn path=/trunk/; revision=18431
2002-10-24 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (write_data_to_file): Use the mode 0666 when
creating a new file and let the user's umask handle permissions.
* folder-browser.c (message_list_drag_data_get): When using open()
with the O_CREAT flag, we need to pass a mode argument. Also use
O_EXCL.
svn path=/trunk/; revision=18430
2002-10-24 Not Zed <NotZed@Ximian.com>
* subscribe-dialog.c (fe_got_children): Use a hashtable to only
insert nodes we dont have already, rather than relying on the
scanning logic. Also, only re-sort this tree level once done
rather than on each insert.
(folder_etree_init): Setup hash to track nodes setup.
(folder_etree_clear_tree): Reset hash.
(fe_destroy): Free hash.
svn path=/trunk/; revision=18426
2002-10-23 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser.c (folder_browser_query_changed): Only perform
the search if it is either a clear or advanced search.
svn path=/trunk/; revision=18422
2002-10-22 Mike Kestner <mkestner@ximian.com>
* mail-callbacks.c (transfer_msg): pass fb->uri to the folder
selection dialog so the current folder is selected on display.
"fixes" 15966.
svn path=/trunk/; revision=18420
* upgrade-mailer.c (mailer_upgrade): Fix the transport URL on any
Exchange accounts. Fixes#30209, which is to say that it fixes
#28490 correctly.
svn path=/trunk/; revision=18399
2002-10-17 Benjamin Kahn <xkahn@ximian.com>
* mail-format.c (mail_lookup_handler): If the attachment is type
application/octet-stream, sniff the file type even if the user
has a handler for that type.
svn path=/trunk/; revision=18388
2002-10-16 Jeffrey Stedfast <fejj@ximian.com>
* mail-format.c (handle_multipart_signed): Don't need to pass a
path to camel_gpg_context_new () anymore.
(mail_get_message_body): Same here.
(handle_multipart_encrypted): Use camel_gpg_context_new () instead
of mail_crypto_get_pgp_cipher_context ().
* mail-preferences.c (mail_preferences_construct): There's no
security tab anymore.
(mail_preferences_apply): No need to save any pgp config data,
there's nothing to configure!
* mail-crypto.c (mail_crypto_get_pgp_cipher_context): Updated to
not pass a pgp path into camel_gpg_context_new ().
* mail-config.c (mail_config_clear): No need to free a pgp_path
variable anymore, we don't need one.
(config_read): Don't read in a pgp-path or pgp-type anymore.
(mail_config_write_on_exit): Don't save a pgp-path or pgp-type
anymore, we don't use them.
(pgpopen): Removed.
(pgpclose): Removed.
(mail_config_pgp_type_detect_from_path): Removed.
(auto_detect_pgp_variables): Removed.
(mail_config_get_pgp_type): Removed.
(mail_config_set_pgp_type): Removed.
(mail_config_get_pgp_path): Removed.
(mail_config_set_pgp_path): Removed.
svn path=/trunk/; revision=18384
2002-10-16 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): If mode == REPLY_LIST
and the mlist is "" (we only checked NULL before), change the mode
to REPLY_ALL so that we don't accidently reply to the user's
address. Fixes bug #28735
svn path=/trunk/; revision=18381
2002-10-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): If we are trying to
reply to a list, first check that we can by getting the mlist
token (makes it easier to fix the mem leak). If not, then change
the mode to REPLY_ALL. If we can reply to list, the make sure we
free the CamelMessageInfo when we're done so we don't leak.
svn path=/trunk/; revision=18376
2002-10-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): If we are trying to
reply to a list, first check that we can by getting the mlist
token. If not, then change the mode to REPLY_ALL. If we can reply
to list, the make sure we free the CamelMessageInfo when we're
done so we don't leak. Also added a check to see if the mlist
token could be found in the Reply-To ehader (since some mailing
lists override the Reply-To with their address).
svn path=/trunk/; revision=18375
2002-10-15 Jeffrey Stedfast <fejj@ximian.com>
* mail-session.c (main_get_filter_driver): Add the new-mail-notify
rule to the filter driver before adding the user defined filter
rules so that we can be sure that the new-mail-notify rule gets
invoked. Fixes bug #32328.
* mail-composer-prefs.c (mail_composer_prefs_new_signature): Make
sure that name[0] cannot ever be NULL. Should maybe fix bug
#32230.
svn path=/trunk/; revision=18374
* upgrade-mailer.c (shortcuts_upgrade_xml_file): Change the type
in LDAP shortcuts from "ldap-contacts" to "contacts/ldap". Rewrite
this to use libxml since that was easier than trying to make the
old code do both kinds of changes at once.
svn path=/trunk/; revision=18367
2002-10-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-config-druid.c (management_prepare): Only set an account
name if one doesn't already exist. Also use the
e_utf8_gtk_entry_get/set_text functions since account names are
supposed to be in UTF8. Fixes bug #31891.
svn path=/trunk/; revision=18365
2002-10-09 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser.c (main_folder_changed): Don't do anything if the
message_list is NULL (this means the FolderBrowser has been
destroyed). Fixes bug #32002.
svn path=/trunk/; revision=18363
2002-10-08 Jeffrey Stedfast <fejj@ximian.com>
* component-factory.c (storage_remove_folder): The CamelFolderInfo
that we get back has nodes for all parent folders, so do not
delete all folders that have nodes in the returned tree. Instead,
descend into the tree until we find the folder we want to delete
and start deleting from there.
svn path=/trunk/; revision=18357
2002-10-07 Jeffrey Stedfast <fejj@ximian.com>
* mail-composer-prefs.c (spell_load_values): Don't maek "en" for
translation. Fixes bug #31788.
* mail-config.glade: Removed a "xxxxxxxxxxx" string so that
translators don't need to translate it. It was only a filler
string. Fixes bug #31789.
svn path=/trunk/; revision=18350
2002-10-02 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Don't default 'me' to
the source account until after we've tried to detect the account
based on recipients. When adding accounts to the account hash, if
any accounts have identical email addresses, the ones that are
enabled take precedence over ones that aren't. This will hopefully
make everyone happy with reply account picking. Fixes bug #31693.
svn path=/trunk/; revision=18326
2002-10-01 Larry Ewing <lewing@ximian.com>
* mail-display.c (drag_data_get_cb): add support for dragging the
content type directly.
(do_attachment_header): add the target for the mime type to the
drag source.
svn path=/trunk/; revision=18288
