2001-09-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Don't use
new_with_sig_file, that function no longer exists.
(forward_get_composer): Same here.
svn path=/trunk/; revision=12754
2001-09-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Pass along the right
string, this fixes bug #9518.
svn path=/trunk/; revision=12736
* mail-callbacks.c (composer_get_message): Fix obvious dumb
mistake in previous commit that made it *always* complain you had
invalid recipients.
svn path=/trunk/; revision=12733
2001-09-09 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (composer_get_message): Complain if we are
trying to send to invalid recipients. (Bug #8875)
svn path=/trunk/; revision=12721
2001-09-08 Jon Trowbridge <trow@gnu.org>
* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Added.
Shows a (hopefully) informative dialog warning you that some
recipients might not want HTML mail (who are listed), and gives
the option to cancel sending. (FIXME: The wording of this dialog
could use some work.)
(composer_get_message): Check if we are sending HTML to someone
who might not want it, and raise the dialog if we are. Use our
new destination-vector based api when talking to the composer.
Touch our destinations here, boosting their use scores. This is
the right place for this to happen --- closer to the end of the
sending process, where incorrect/artificial use score inflation is
less likely to occur.
* mail-config.c (config_read): Added
/Mail/Format/confirm_unwanted_html key. This flag determines
whether or not we want to see the warning dialog when we send HTML
mail to contacts who don't want it. Default is TRUE.
(mail_config_write_on_exit): Write out the confirm_unwanted_html
key.
(mail_config_get_confirm_unwanted_html): Added.
(mail_config_set_confirm_unwanted_html): Added.
svn path=/trunk/; revision=12712
2749 - Message text not included in reply, but html attachment is
4294 - "forward inline" should quote the same headers as the
normal mail display
6100 - Reply to a forwarded email displays email headers
7255 - Replying to HTML message
7527 - replying to forwarded message w/ attachments does the wrong
thing
* mail-format.c (mail_get_message_rfc822): New function to get
message headers and body together, for inline forwards, or replies
containing attached messages.
(mail_get_message_body): Redo this to always return HTML, but keep
the "want_plain" flag, to decide whether to return HTML that looks
like HTML or HTML that looks like plain text. Use
mail_get_message_rfc822 to handle attached message/rfc822 parts.
Don't include the text of vcard or icalendar attachments. Don't
fail to include text parts just because we found an HTML part.
(Since we're always returning HTML now, this doesn't cause
problems any more.)
* mail-tools.c (mail_tool_quote_message): Simplify greatly.
mail_get_message_body always returns HTML now, and we let it take
care of prepending "> "s too. We then let GtkHTML deal with
converting the HTML to plain text if the user wants to reply in
plain text.
(mail_tool_forward_message): Simplify this a ton too: parts of it
are moved into mail_get_message_rfc822 and parts are now
unnecessary.
* mail-callbacks.c (do_forward_non_attached): Call
mail_tool_forward_message here always, and let it do the "> "
quoting in the "quoted" case, so that we get the headers too when
forwarding quoted. Related to bug #4294.
svn path=/trunk/; revision=12657
2001-08-29 Jon Trowbridge <trow@ximian.com>
* e-msg-composer.c (e_msg_composer_get_message_draft): Pass
in FALSE as the 'sending' arg to e_msg_composer_get_message.
(build_message): Added a 'sending' arg, which is passed to
e_msg_composer_get_message.
(e_msg_composer_get_message): Added a 'sending' arg,
which gets passed directly on to build_message.
* e-msg-composer-hdrs.c (e_msg_composer_hdrs_to_message): Added
a "sending" arg, which should be TRUE if the message is being
sent now (rather than being autosaved, etc.). The address
use scores are only updated when sending. (Bug #8332)
Removed obsolete (#if 0/#endif-ed) code.
2001-08-29 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (composer_get_message): When calling
e_msg_composer_get_message, pass in TRUE for the 'sending' arg.
(Part of the fix for bug #8332)
svn path=/trunk/; revision=12518
2001-08-27 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (mail_generate_reply): Check if we are trying
to reply to a message with no From: field, and try to do something
graceful in that case. (Bug #7028)
* mail-display.c (ebook_callback): Add paranoid checks for the
case of a message with a From: field. (Also maybe bug #7028)
svn path=/trunk/; revision=12490
2001-08-27 Jeffrey Stedfast <fejj@ximian.com>
* mail-tools.c (mail_tool_make_message_attachment): Remove
X-Evolution* headers.
(mail_tool_remove_xevolution_headers): New function to convenience
removing the X-Evolution headers.
(mail_tool_restore_xevolution_headers): New convenience function
to restore the X-Evolution headers.
(mail_tool_destroy_xevolution): New function to cleanup the
structure.
(mail_tool_forward_message): Remove and restore the X-Evolution
headers here too.
svn path=/trunk/; revision=12484
2001-08-22 Jon Trowbridge <trow@ximian.com>
* gui/contact-list-editor/e-contact-list-editor.c (extract_info):
In the GUI, the toggle is labelled "hide addresses", not "show
addresses" -- so we have to reverse the boolean value we read in.
(fill_in_info): Same bug as before: since the GUI reads "hide", we
have to initialize the toggle to '!show_addresses', not
'show_addresses'.
* backend/ebook/e-destination.c
(e_destination_list_show_addresses): Added.
(e_destination_xml_encode): Encode the value of
e_destination_list_show_addresses into the XML.
(e_destination_xml_decode): Read and store the "show_addresses"
flag.
2001-08-22 Jon Trowbridge <trow@ximian.com>
* e-msg-composer-hdrs.c (set_recipients_from_destv): Added. Try
to properly handle contact lists in which the addresses of the
list members should be hidden.
(e_msg_composer_hdrs_to_message): Changed to extract the
destination data from the entries and pass it along to
set_recipients_from_destv.
2001-08-22 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (ask_confirm_for_only_bcc): Provide alternative
text for this dialog for the case when a message has only Bcc
recipients because of a hidden contact list's addresses being
moved from To/Cc to Bcc.
(composer_get_message): Try to detect when our message has only
Bcc recipients because of moving addresses around due to a hidden
contact list, and show the dialog with the revised wording in this
case.
svn path=/trunk/; revision=12414
2001-08-20 Jeffrey Stedfast <fejj@ximian.com>
* component-factory.c (storage_create_folder):
camel_folder_create_folder can now return a heirachial tree so
subscribe to down the tree.
svn path=/trunk/; revision=12257
2001-08-19 Jeffrey Stedfast <fejj@ximian.com>
* mail-mt.c (do_op_status): Allow the activity to be NULL if there
isn't a global_shell_client so that we don't try and report status
updates when the shell is destroyed.
* mail-config.c (add_shortcut_entry): Return if there isn't a
global_shell_client.
* component-factory.c (owner_set_cb): set the global_shell_client
here and connect to the destroy signal.
* mail-vfolder.c (vfolder_create_storage): Use an extern global_shell_client.
svn path=/trunk/; revision=12242
2001-08-19 Christopher James Lahey <clahey@ximian.com>
* mail-callbacks.c (delete_msg): Made delete make the cursor go
backwards if the user is sorting by descending date.
svn path=/trunk/; revision=12236
2001-08-19 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Convert the date string
to UTF-8.
(do_forward_non_attached): Same here.
svn path=/trunk/; revision=12222
2001-08-18 Jeffrey Stedfast <fejj@ximian.com>
* mail-config.c (config_read): Change the default values for
"always-sign" to false.
* mail-callbacks.c (open_msg): if the folder is Outbox, let the
user edit the message(s) too I guess.
svn path=/trunk/; revision=12208
2001-08-16 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (confirm_expunge): Respect the user's desire to
be prompted to confirm that he wants to expunge the blasted
folder. Also, don't set the usize - that's just an evil hack and
you may find it will cut off text once the label has been
translated.
(create_msg_composer): In order for the security options to be
checked when composing a new message, we must set the from account
explicitly even though the composer hdrs sets the default from
account and emits the signal because at that stage the composer
hasn't yet connected to the signals and thus the bonobo menu items
don't get set.
* mail-config.c (mail_config_set_confirm_expunge): New.
(mail_config_get_confirm_expunge): New.
svn path=/trunk/; revision=12141
2001-08-15 Anna Marie Dirks <anna@ximian.com>
* mail-callbacks.c (expunge-folders): Re-added, at Ettore's
request, the confirm-expunge dialog.
svn path=/trunk/; revision=12071
2001-08-14 Peter Williams <peterw@ximian.com>
* mail-callbacks.c (previous_unread_msg): Make previous unread
wrap around too.
svn path=/trunk/; revision=12029
2001-08-13 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (expunge_folder): Confirm that the user really
wants to expunge.
(save_msg_ok): Set the parent window here.
svn path=/trunk/; revision=11949
2001-08-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (transfer_msg): Prepend the uri with evolution:
to fix bug #6916.
svn path=/trunk/; revision=11903
2001-08-10 Jason Leach <jleach@ximian.com>
* mail-callbacks.c (next_unread_msg): Since 'N' keypresses go
through here now, use wrap-around selecting.
(previous_unread_msg): Same for 'P' here.
* message-list.c (on_cursor_activated_idle): Stop this idle timer
when we have multiple items selected, this keeps it from loading
and then marking the last item in your selection list as read.
Bug #4693.
svn path=/trunk/; revision=11895
2001-08-09 Jeffrey Stedfast <fejj@ximian.com>
* message-list.c (mlfe_callback): Added a g_assert_not_reached() -
I'm hoping this will help us track down the "can't delete message
sometimes" (ie bug #6637 and friends) bugs that users have been
reporting. If herein lies the problem, then we can expect some
crashes and some good backtraces, hopefully.
svn path=/trunk/; revision=11854
2001-08-07 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (manage_subscriptions): Hide the app->window.
(do_mail_print): Set the parent of the gnome-dialog to be the
folder-browser so that when evolution is closed, the print dialog
gets destroyed. Should fix bug #4781.
svn path=/trunk/; revision=11757
2001-08-07 Peter Williams <peterw@ximian.com>
* mail-callbacks.c (folder_created): Use bonobo_object_unref on the storage
since it's a bonobo object.
(mail_storage_create_folder): Same.
(folder_deleted): Same.
svn path=/trunk/; revision=11749
2001-08-06 Jeffrey Stedfast <fejj@ximian.com>
* mail-config.glade: Added key accelerators to a bunch of the
config options and moved the Bcc and empty-subject checkboxes to
the composer tab where they belong.
* mail-callbacks.c (providers_config): Raise the dialog if it
exists already.
(manage_subscriptions): Raise the dialog if it already exists.
(main_select_first_unread): Removed (we haven't needed this code
in ages).
(select_first_unread): Same.
(save_msg_ok): If the path is empty, just return.
* mail-local.c (mail_local_reconfigure_folder): Raise the dialog
if it already exists.
svn path=/trunk/; revision=11719
2001-08-06 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (expunge_folder): Set the message-display
message to NULL if we can't get an info too.
svn path=/trunk/; revision=11711
2001-08-06 Jason Leach <jleach@ximian.com>
* mail-callbacks.c (create_folders): Make vtrash folders on other
storages with a "vtrash" type, so they get the little trashcan
icon.
svn path=/trunk/; revision=11709
2001-08-06 Peter Williams <peterw@ximian.com>
* subscribe-dialog.[ch]: Reimplement to be asynchronous and pretty,
with progressive folder loading and all sorts of wonderful
improvements.
* mail-callbacks.c (manage_subscriptions): Change to reflect API
update.
* component-factory.c (mail_load_storages): Don't add the storage
if it has been disabled.
* Makefile.am (etspec_DATA): Add subscribe-dialog.etspec.
(glade_DATA): And the glade file.
* subscribe-dialog.etspec: New file, break out the specification
from inside the subscribe-dialog.c
* subscribe-dialog.glade: Update this, actually use it now.
svn path=/trunk/; revision=11706
2001-08-06 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (empty_trash): Yuck. Special case whether or
not we want to expunge all the trash folders syncronously or
asyncronously based on whether or not we are doing Empty-On-Exit
or emptying trash by user request respectively.
svn path=/trunk/; revision=11701
2001-07-25 Jeffrey Stedfast <fejj@ximian.com>
* mail-session.c (make_key): Don't make the key url:item if we
have the url, just make it url. This fixes bug #5339.
(mail_session_set_password): Removed.
svn path=/trunk/; revision=11411
2001-07-25 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Initialize `me' to NULL.
(forward_attached): If we are only forwarding a single message,
pass the message along as the callback data, else pass NULL.
(do_forward_attach): Updated for changes to
forward_get_composer().
(do_forward_non_attached): Same.
(forward_get_composer): Try to guess which account to forward the
message from if the message passed in is non-NULL.
svn path=/trunk/; revision=11401
2001-07-24 Jason Leach <jleach@ximian.com>
* mail-callbacks.c (delete_msg): If we're the last row and we're
deleting, select the previous message, not next, which actually
selects nothing. Fixes#5323.
svn path=/trunk/; revision=11391
2001-07-24 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (guess_me): Do a case-insensitive comparison.
(mail_generate_reply): Only resort to the source account's
identity if we can't find out which identity to use based on the
recipients of the message first.
* mail-config.c (mail_config_get_default_account): Make sure to
return the 0th account if we don't have a default. We don't want
to return NULL.
* mail-callbacks.c (empty_trash): Use mail_tool_get_trash for the
remote store trash folders.
* mail-tools.c (mail_tool_get_trash): New convenience function.
svn path=/trunk/; revision=11353
2001-07-23 Jeffrey Stedfast <fejj@ximian.com>
* mail-config.glade: Fixed the "Read" to be Read in the glade file
per menesis' request.
* mail-accounts.c (construct): Give the dialog a Close button
instead of an OK button.
(prompt_bcc_only_toggled): New.
(threaded_list_toggled): New.
(show_preview_toggled): New.
(construct): Add code for the bcc-only-prompt, threaded-list, and
show-preview checkboxes.
* mail-ops.c (transfer_messages_transfer): If the source and
destination folders are the same, just mark the uids as undeleted
(in case they were marked as deleted before).
svn path=/trunk/; revision=11327
2001-07-23 Jason Leach <jleach@ximian.com>
[Bug #5225: No UI way to mark as unimportant]
* folder-browser.c (on_right_click): Do the necessary stuff to
show or hide the correct "Mark Important" or "Mark as Unimportant"
menu items depending on the status of messages that are selected.
* folder-browser-ui.c: Add the MarkAsUnimportant verb here.
* mail-callbacks.c (mark_as_unimportant): Simple function that's
the callback for these new menu items.
svn path=/trunk/; revision=11316
2001-07-19 Peter Williams <peterw@ximian.com>
Policy change: NULL url's are no longer allowed in CamelFolderInfos. They used
to signify that the folder was, in IMAP jargon, NoSelect; now the same effect
is achieved by adding a "noselect=yes" parameter to the end of the URL. As far
as I know, IMAP is the only affected provider.
* providers/imap/camel-imap-store.c (delete_folder): New function. Implement
folder deletion.
(camel_imap_store_class_init): Set the delete_folder class function here.
(get_folder_status): New function. Utility wrapper around the STATUS command.
(create_folder): If the parent folder is NoSelect but is empty, delete it
and recreate it as a a subfolder-containing folder. If it is NoSelect but
contains messages, set an exception.
(parse_list_response_as_folder_info): Always set the FolderInfo's URL, but
add a NoSelect parameter if it isn't selectable.
(get_folder_info_online): Change logic of removing the namespace to reflect
URL change. Same for logic of checking unread counts.
(get_folder_info_online): Use get_folder_status to simplify this.
* camel-store.c (camel_folder_info_build): When creating
dummy parents, copy the child's URL and set the NoSelect
parameter.
In mail:
2001-07-19 Peter Williams <peterw@ximian.com>
Track the NoSelect changes in Camel.
* mail-callbacks.c (create_folders): We don't need to check if
the URL is NULL or not anymore.
* component-factory.c (create_noselect_control): New
function. Create a dummy control for folders that can't contain
messages (ie \NoSelect)
(create_view): If the URI says the folder is noselect, make a
dummy control. FIXME: still should merge in the global UI
elements.
(xfer_folder): Don't allow the operation if the destination is
NoSelect.
(destination_folder_handle_motion): Ditto.
(destination_folder_handle_drop): Ditto.
svn path=/trunk/; revision=11237
2001-07-13 Peter Williams <peterw@ximian.com>
* mail-callbacks.c (expunge_folder): Segfault prevention here if no uid is
currently loaded.
svn path=/trunk/; revision=11093
