2001-08-03 Christopher James Lahey <clahey@ximian.com>
* e-storage-set-view.c (tree_drag_data_received): Some paths here
don't set handled properly so lets initialize it to FALSE.
(update_folder_with_unread_hash, etree_value_at): constified
folder_name here.
(init): Initialize priv->drag_path here to NULL.
svn path=/trunk/; revision=11648
2001-08-03 Jason Leach <jleach@ximian.com>
[Removing Evolution::LocalStorage interface, abstracting the
unread counts from a folder's name, also abstract unread counts
from a shortcut's name. Fixes#4489 and #5497]
* e-shortcuts.c (shortcut_item_new): Take an unread_count argument
now.
(shortcut_item_update): Ditto.
* e-shortcuts-view-model.c (get_name_with_unread): Get a string
containing a shortcut name and it's unread, because these are
abstracted now.
(load_group_into_model): Use the above function to make shortcuts
that have unread counts.
* e-storage-set-view.c (update_folder_with_unread_hash): Keep a
hash of folder names with unread counts, because the folder name
and it's unread count are to be separated, only the ETree is
supposed to present it as one string.
* e-shell-view.c: Renamed EShellView::view_title_bar to
folder_title_bar, to closer match the
* e-shell-view-menu.c (new_shortcut_dialog_folder_selected_cb):
Make a shortcut with the unread count.
* e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
Make a shortcut with the unread count.
* e-local-storage.c: Updated for API changes.
* e-folder.c (e_folder_get_unread_count): New function, does what
it says.
(e_folder_set_unread_count): Ditto.
* e-corba-storage.c (impl_StorageListener_new_folder): Renamed to
match the IDL function name.
(impl_StorageListener_update_folder): Ditto.
(impl_StorageListener_removed_folder): Ditto.
* Evolution-Storage.idl (struct Folder): Replace the boolean
highlighted with a long unread_count.
(updateFolder): Brought in from the now dead
Evolution::LocalStorage.
* Evolution-Shell.idl (getLocalStorage): Return a Storage instead
of a LocalStorage.
* Evolution-LocalStorage.idl: Removed, no longer needed, only used
function, updateFolder, has been moved into Evolution::Storage
interface.
* evolution-local-storage.[ch]: Ditto.
* evolution-storage.c (impl_Storage_updateFolder): Implementation
of the updateFolder taken from ::LocalStorage.
(class_init): New "update_folder" signal, taken from
evolution-local-storage.c too.
(evolution_storage_update_folder): Take an @unread_count int
instead of a @highlighted boolean.
(evolution_storage_new_folder): Same for here.
(evolution_storage_update_folder_by_uri): And here.
* evolution-storage-listener.h: "update_folder" signal no longer
sends a @highlighted boolean.
2001-08-03 Jason Leach <jleach@ximian.com>
* e-shell-view-menu.c (update_offline_menu_item): Use Jakub's new
"Work Online" icon and fix a typo.
svn path=/trunk/; revision=11633
* e-shell.c (setup_local_storage): Add an E_STORAGE() cast to
prevent a warning.
* main.c (idle_cb): Only try to activate from the shell ID if the
result is `E_SHELL_CONSTRUCT_RESULT_CANNOTREGISTER'; if there is a
different error, spit out a dialog box with a description of it
and exit instead.
* e-shell.c (e_shell_construct): Return an `EShellConstructResult'
describing what kind of result we had. Show the splash after the
DB has been reached, not before.
(e_shell_construct_result_to_string): New function to get a
descriptive string out of an `EShellConstructResult'.
(e_shell_new): New arg @construct_result_return to return a
description of the result of the operation.
* e-shell.h: New enum `EShellConstructResult'.
* e-shell.c (impl_Shell_createNewView): Raise `InternalError'
instead of crashing if the shell_view returns a CORBA_OBJECT_NIL.
* Evolution-Shell.idl: New exception `InternalError'.
`createNewView' and `handleURI' can raise it.
svn path=/trunk/; revision=11611
* e-shell-offline-handler.c (progress_listener_servant_free):
Actually __fini the servant and deactivate the object too.
(component_info_free): Updated accordingly [i.e. don't do the
deactivation stuff here].
svn path=/trunk/; revision=11607
* e-shell.c (e_shell_construct): Make sure the pointer to the db
object is CORBA_OBJECT_NIL if `bonobo_get_object()' raises an
exception.
svn path=/trunk/; revision=11606
* e-shell-offline-handler.c (component_info_free): Also call
`PortableServer_POA_deactivate_object()' on the progress listener
object so it gets deactivated.
svn path=/trunk/; revision=11605
* e-shell.c (e_shell_construct): Spit out a warning if we cannot
resolve "Bonobo/ConfigDatabase" on "wombat:". Also, register on
OAF only after we are sure we are not going to return FALSE.
svn path=/trunk/; revision=11603
* e-shell-view.c (switch_on_folder_tree_click): Set the
`set_folder_uri' to NULL when freeing it.
* e-task-bar.c (e_task_bar_remove_task): Just destroy the widget.
No need to `gtk_container_remove()' it.
svn path=/trunk/; revision=11597
2001-08-01 Jeffrey Stedfast <fejj@ximian.com>
* e-shell-view-menu.c (command_new_folder): Do a NULL-check on
current_uri - socket is being closed? (as per the comments for the
NULL-check in e-shell-view.c:socket_destroy_cb).
svn path=/trunk/; revision=11557
2001-07-31 Not Zed <NotZed@Ximian.com>
* evolution-activity-client.c (evolution_activity_client_update):
Also update have_pending_update before calling corba, as below.
svn path=/trunk/; revision=11499
* evolution-activity-client.c (update_timeout_callback): Set the
`have_pending_update' flag before doing the CORBA call.
(evolution_activity_client_update): Set the timeout before doing
the CORBA call.
svn path=/trunk/; revision=11498
2001-07-30 Jason Leach <jleach@ximian.com>
* e-shortcuts-view.c (rename_group_cb): Remember the current group
so after renaming a group it doesn't flip to the next group. Bug
#3857.
* e-shortcuts.c (e_shortcuts_rename_group): Comparing two
separately allocated strings, use strcmp() instead of !=.
svn path=/trunk/; revision=11483
2001-07-30 Jason Leach <jleach@ximian.com>
* e-shell-folder-creation-dialog.c (async_create_cb): If we can't
create a folder because it already exists, select that folder that
exists. Bug #1716.
svn path=/trunk/; revision=11482
* evolution-activity-client.c (impl_destroy): Remove the source
for the timeout *before* invoking the CORBA method, as we might
get the timeout callback while invoking the CORBA method, thus
screwing things up.
* evolution-shell-component-client.c (destroy_listener_interface):
New helper function.
(dispatch_callback): Use it.
(impl_destroy): Call it when destroying the listener interface
instead of just freeing the servant.
svn path=/trunk/; revision=11452
2001-07-26 Jason Leach <jleach@ximian.com>
* e-shell-view-menu.c (update_offline_menu_item): Little UI nit:
capitalize the words Offline/Online for the File menu.
svn path=/trunk/; revision=11428
2001-07-25 Jason Leach <jleach@ximian.com>
* e-shell-folder-selection-dialog.c (folder_selected_cb): New
function. When a folder is selected set the OK button to be
sensitive (but before that have it desensitized). Bug #5483.
svn path=/trunk/; revision=11414
2001-07-25 Jason Leach <jleach@ximian.com>
* Makefile.am (INCLUDES): $(BONOBO_CONF_CFLAGS) was here twice,
took out one of them.
* e-shell-view.c (socket_destroy_cb): Mem leak fix. Thanks to the
amazing Jacob B. Bug #5054.
svn path=/trunk/; revision=11402
2001-07-25 Jason Leach <jleach@ximian.com>
* e-task-widget.c: #include <libgnome/gnome-defs.h> and
<libgnome/gnome-i18n.h> instead of the full <libgnome/libgnome.h>,
as noted by a comment here.
svn path=/trunk/; revision=11397
2001-07-24 Jason Leach <jleach@ximian.com>
* e-storage-set-view.c (e_storage_set_view_construct): Add the
"/My Evolution" path to the path_to_etree_node hash so that
storage_set_view_set_current_folder() can select the My Evolution
node when it's the current one. Fixes#5114 and #3956.
svn path=/trunk/; revision=11348
* main.c (development_warning): Only show the warning dialog
instead of using `gnome_dialog_run()' so it is not modal. Modal
would be nice, but unfortunately it works bad with Bonobo. Plus
Sawfish doesn't like to keep the modal dialog on top, so it gets
very confusing for users.
svn path=/trunk/; revision=11334
* main.c (development_warning): Only show the warning dialog
instead of using `gnome_dialog_run()' so it is not modal. Modal
would be nice, but unfortunately it works bad with Bonobo. Plus
Sawfish doesn't like to keep the modal dialog on top, so it gets
very confusing for users.
svn path=/trunk/; revision=11331
the ShellComponent interface. Updated the EvolutionShellComponent
GTK+ wrapper and all the component accordingly. Get the calendar to
use this so it can delete both tasks and calendar folders.
svn path=/trunk/; revision=11300
* evolution-activity-client.c (impl_destroy): Use
`g_source_remove()' instead of `gtk_timeout_remove()' here, as we
are using `g_timeout_add()' and not `gtk_timeout_add()' to set up
the timeout callback.
(update_timeout_callback): Reset `have_pending_update' when
returning %TRUE. Set the timeout id to zero when returning
%FALSE.
svn path=/trunk/; revision=11295
2001-07-20 Jason Leach <jleach@ximian.com>
[Fix a crash if you start evolution with a bad URI.]
* e-shell.c (e_shell_create_view): If we can't display the URI,
display the default uri. This is because it's necessary for
e_shell_view_display_uri() to run all the way through so corba
interfaces get setup.
* e-shell-view.c (e_shell_view_display_uri): If we fail to create
a new view for a URI (happens if you pass in an invalid URI), be
sure to return FALSE.
svn path=/trunk/; revision=11290
2001-07-20 Jason Leach <jleach@ximian.com>
[This is a better way to have "Local Folders" be shown as the
local storage name without breaking current user's shortcuts.]
* e-corba-storage.c (get_display_name): Implement this, but it's
only returning the real name now. Need to change the IDL soon to
let corba storages have separated display names.
* e-shortcuts.c (e_shortcuts_add_default_group): Set these default
shortcut URI's back to evolution:/local/
* e-shell-view.h (DEFAULT_URI): Set this back to
"evolution:/local/Inbox"
* e-storage-set-view.c (etree_value_at): Get the display name for
a storage rather than it's true name.
* e-local-storage.c (impl_get_display_name): Implemented for the
local folder (to return a translated "Local Folders").
* e-storage.c (e_storage_get_display_name): New virtual function
for retrieving the display name.
svn path=/trunk/; revision=11274
2001-07-19 Jason Leach <jleach@ximian.com>
* e-local-storage.h: Make the local storage name "Local Folders"
instead of "local", looks better with "My Evolution", "VFolders",
and "Other Contacts".
* e-shell-view.h: Put the #define DEFAULT_URI here instead of in
e-shell-view.c.
* main.c: Remove the duplicated #define STARTUP_URI, actually make
use of the nice defines.
* e-shell-folder-commands.c (e_shell_command_delete_folder): Use
the DEFAULT_URI here instead of a hard coded string.
* e-shortcuts.c (e_shortcuts_add_default_group): Fix the URI's
here to use "Local Folder".
svn path=/trunk/; revision=11241
2001-07-19 Jason Leach <jleach@ximian.com>
* e-shell-folder-title-bar.c (e_shell_folder_title_bar_construct):
Line up the padding for the folder title bar labels when you have
the folder bar enabled or disabled (previously when disabled it
was padding ~8 pixels to the right while the other had 0).
* e-shell-view.c (setup_widgets): Take out a 2 pixel padding
around the vbox containing the title bar, folder bar, message list
and mail display. Also remove 2 more extra pixels of padding on
the bottom.
svn path=/trunk/; revision=11238
2001-07-12 Jason Leach <jleach@ximian.com>
* e-shell-view-menu.c (command_submit_bug): Because
bugzilla.ximian does have a mail gateway now, we can have
Help->Submit Bug Report open up bug-buddy.
svn path=/trunk/; revision=11075
* e-shell.c (init): Initialize priv->db and priv->iid so that
destroy() won't crash if e_shell_construct bails out before
setting them. Reduces bug #4173 to #4169.
svn path=/trunk/; revision=11044
