Commit Graph

2938 Commits

Author SHA1 Message Date
90b3cda80e Only clear the Mail passwords.
2003-04-02  Not Zed  <NotZed@Ximian.com>

        * mail-session.c (mail_session_forget_passwords): Only clear the
        Mail passwords.

svn path=/trunk/; revision=20632
2003-04-02 04:52:22 +00:00
138b676757 Don't allow the 'prefix' argument to make_safe_filename() be NULL. If we
2003-04-01  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (save_part): Don't allow the 'prefix' argument to
	make_safe_filename() be NULL. If we don't yet have a save_dir in
	gconf, use $HOME, etc. Fixes bug #40608.

svn path=/trunk/; revision=20621
2003-04-01 18:23:57 +00:00
ffabf8684a Call composer_check_autosave if we're going interactive, to check for
2003-04-02  Not Zed  <NotZed@Ximian.com>

	* component-factory.c (interactive_cb): Call
	composer_check_autosave if we're going interactive, to check for
	unsaved files.  Fixes #40300.

svn path=/trunk/; revision=20617
2003-04-01 17:26:15 +00:00
5f2900575a if we're called and the idle handler is set, remove it, so we dont go and
2003-04-01  Not Zed  <NotZed@Ximian.com>

	* mail-display.c (mail_display_redisplay): if we're called and the
	idle handler is set, remove it, so we dont go and redisplay it
	again.  Fixes #40522.

svn path=/trunk/; revision=20609
2003-04-01 06:02:21 +00:00
7bbc53fbef Properly init message_list. Fixed a type-o that initialized it to the
2003-03-31  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c: Properly init message_list. Fixed a type-o that
	initialized it to the password_list.

svn path=/trunk/; revision=20605
2003-03-31 23:28:47 +00:00
eeadfa251c need to check for config_service != NULL, not service != NULL before
2003-03-31  Not Zed  <NotZed@Ximian.com>

	* mail-session.c (pass_response): need to check for config_service
	!= NULL, not service != NULL before calling set_save_password.
	Fix for #40472.

2003-03-28  Not Zed  <NotZed@Ximian.com>

	* folder-browser-ui.c: include e-meta.h

	* folder-browser.c (on_right_click): remove unused var.

svn path=/trunk/; revision=20586
2003-03-31 02:57:41 +00:00
48f9f186fc Declare a prototype for this function prior to fe_got_children() so that
2003-03-28  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c (fe_check_for_children): Declare a prototype
	for this function prior to fe_got_children() so that
	fe_got_children() can call us.

svn path=/trunk/; revision=20558
2003-03-28 16:39:33 +00:00
2c5a425299 remove extra arg to camel_url_encode
* mail-format.c (write_address): remove extra arg to
        camel_url_encode

svn path=/trunk/; revision=20546
2003-03-27 15:38:11 +00:00
40b2d61435 dont set the paned initial size here, but hook onto the realize signal.
2003-03-27  Not Zed  <NotZed@Ximian.com>

	* folder-browser.c (folder_browser_gui_init): dont set the paned
	initial size here, but hook onto the realize signal.
	(paned_realised): set the paned size once we're realised.  Fixes
	#37084, its a bit of a hack, but it seems to work.

svn path=/trunk/; revision=20536
2003-03-27 02:58:23 +00:00
1c1551c97e Fixes bug #40074.
2003-03-26  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes bug #40074.

	* folder-browser-factory.c (control_deactivate): Save message-list
	state.

	* message-list.c (message_list_save_state): Save the various
	states.

svn path=/trunk/; revision=20525
2003-03-26 21:24:45 +00:00
038a6cd0e8 Fixes for bug #39870
2003-03-26  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes for bug #39870

	* message-browser.c (transfer_msg_done): Close the
	message-browser. Since the message doesn't exist anymore, we
	should close it.
	(message_browser_delete): New callback to handle deletion in the
	message-browser window.

svn path=/trunk/; revision=20524
2003-03-26 21:01:27 +00:00
f4e863ea7f If the CamelFolderInfo node doesn't have \NoInferriors set, then check for
2003-03-26  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c (fe_got_children): If the CamelFolderInfo
	node doesn't have \NoInferriors set, then check for
	subfolders. Fixes bug #40314.

svn path=/trunk/; revision=20520
2003-03-26 19:04:42 +00:00
0983e2cf91 Undo jeff's patch below for #40275, the destroy timeout is already removed
2003-03-26  Not Zed  <NotZed@Ximian.com>

	* mail-display.c (popup_window_destroy_cb): Undo jeff's patch
	below for #40275, the destroy timeout is already removed in
	popup_info_free.  Unref the widget 'w' when we're done with it.
	(popup_info_free): Move everything in here to popup_window_destroy
	and remove, since nothing else uses it.
	(make_popup_window): Ref the widget so it doesn't go away before
	we're finished with it.  Really fixes bug #40275/40188.

svn path=/trunk/; revision=20512
2003-03-26 03:38:30 +00:00
992e6be111 Remove the timeout. Should fix bug #40275.
2003-03-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (popup_window_destroy_cb): Remove the
	timeout. Should fix bug #40275.

svn path=/trunk/; revision=20511
2003-03-25 20:51:55 +00:00
2792bf9ffe Remove search entry which never worked right (and can't work as users
2003-03-25  Jeffrey Stedfast  <fejj@ximian.com>

	* subscribe-dialog.c: Remove search entry which never worked right
	(and can't work as users expect anyway, since we don't do
	namespace stripping). Fixes bug #40083.
	(ftree_node_new): Ignore \NoSelect as far as marking it
	"subscribable". Fixes bug #40124.

svn path=/trunk/; revision=20509
2003-03-25 20:33:25 +00:00
fea6083abf Update for e_notice move (apply_changes): Pass a parent_window to e_notice
* mail-account-editor.c: Update for e_notice move
	(apply_changes): Pass a parent_window to e_notice

	* mail-account-gui.c: Update for e_notice move.
	(mail_account_gui_save): Pass a parent_window to e_notice

	* mail-callbacks.c: Update for e_notice move
	* mail-local.c: Likewise
	* mail-signature-editor.c: Likewise
	* mail-vfolder.c: Likewise

svn path=/trunk/; revision=20502
2003-03-25 15:49:19 +00:00
fa7bb395ad Update prototype
* component-factory.c (interactive_cb): Update prototype

svn path=/trunk/; revision=20494
2003-03-25 14:02:34 +00:00
be58e1949e strdup the key before freeing the url as it is probably pointing there.
2003-03-25  Not Zed  <NotZed@Ximian.com>

	* mail-tools.c (meta_data_key): strdup the key before freeing the
	url as it is probably pointing there.

svn path=/trunk/; revision=20491
2003-03-25 01:38:46 +00:00
1f7db78c25 remove a debug printf that made it in a commit.
2003-03-25  Not Zed  <NotZed@Ximian.com>

	* component-factory.c (got_folder): remove a debug printf that
	made it in a commit.

svn path=/trunk/; revision=20480
2003-03-24 13:34:55 +00:00
33e87f5331 Load per-folder setting of show_preview from meta data.
2003-03-25  Not Zed  <NotZed@Ximian.com>

	* folder-browser-ui.c (folder_browser_ui_add_global): Load
	per-folder setting of show_preview from meta data.
	(folder_browser_ui_add_list): Same, for thread_list.

	* mail-tools.c (mail_tool_get_meta_data)
	(mail_tool_delete_meta_data): helpers to lookup/delete meta data.

	* mail-config.c (mail_config_uri_deleted): delete the meta-data
	for the folder.

	* folder-browser.c (folder_browser_reload): dont reload the uri if
	we're in the process of loading it still.
	(folder_browser_new): load the folder meta data before loading the
	folder.
	(folder_browser_toggle_preview):
	(folder_browser_toggle_threads): save change to meta-data.
	(got_folder): Load the metadata if we have a folder to set, and
	the meta-data has changed from initislisation.

svn path=/trunk/; revision=20478
2003-03-24 13:27:32 +00:00
b2602b6c9c pass FALSE for e_destination_get_textrep's include_email arg.
2003-03-23  Chris Toshok  <toshok@ximian.com>

	* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): pass
	FALSE for e_destination_get_textrep's include_email arg.

svn path=/trunk/; revision=20468
2003-03-23 09:19:15 +00:00
d7a4a66632 Default to the charset provied in the MimePart's Content-Type over that of
2003-03-21  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (mail_format_data_wrapper_write_to_stream):
	Default to the charset provied in the MimePart's Content-Type over
	that of the user's mailer charset. Fixes bug #39204.

svn path=/trunk/; revision=20462
2003-03-21 21:26:06 +00:00
3cb47e53a6 "en_us" should not be translated. Fixes bug #40088.
2003-03-21  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-composer-prefs.c (spell_load_values): "en_us" should not be
	translated. Fixes bug #40088.

svn path=/trunk/; revision=20454
2003-03-21 16:22:27 +00:00
53fdce7e28 remember to disconnect the destroy handler if whenever the loader is shut
2003-03-21  Larry Ewing  <lewing@ximian.com>

	* mail-display.c (pixbuf_gen_idle): remember to disconnect the
	destroy handler if whenever the loader is shut down.

svn path=/trunk/; revision=20449
2003-03-21 07:53:13 +00:00
bca5dffbb7 Change the message_destroy callback to just gtk_widget_destroy. No need to
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	* component-factory.c (owner_set_cb): Change the message_destroy
	callback to just gtk_widget_destroy. No need to have a callback
	simply to call this function.
	(warning_response): Removed (see above).

svn path=/trunk/; revision=20447
2003-03-20 22:27:25 +00:00
43561d50ef Don't forget to add the signature to the signature list if it is a valid
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-composer-prefs.c (sig_add_script_response): Don't forget to
	add the signature to the signature list if it is a valid script.

svn path=/trunk/; revision=20444
2003-03-20 20:34:52 +00:00
10325a5d48 Make sure we can find the registered handler before trying to remove it
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_signature_unregister_client): Make
	sure we can find the registered handler before trying to remove it
	from the list.

svn path=/trunk/; revision=20443
2003-03-20 20:25:22 +00:00
d7f89b244f Make the 5th argument to gtk_message_dialog_new() "%s" and move the
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c (do_user_message): Make the 5th argument to
	gtk_message_dialog_new() "%s" and move the m->prompt to arg 6 so
	that we are safe if the prompt string contains any %'s. Also
	connect to the response signal for the user_msg dialog and set the
	callback to gtk_widget_destroy so that the user can actually close
	the dialog. We also need to g_object_weak_ref() the dialog so that
	we can set the global message_dialog pointer back to NULL when it
	gets destroyed. Fixes bug #40043.

svn path=/trunk/; revision=20435
2003-03-20 17:55:12 +00:00
98063be897 Remove this since there's a function in CamelMimeMessage to do it now.
* mail-ops.c (build_from): Remove this since there's a function in
	CamelMimeMessage to do it now.
	(save_messages_save): Use camel_mime_message_build_mbox_from.

svn path=/trunk/; revision=20431
2003-03-20 16:44:05 +00:00
ab6fef7852 updated for gnome spell API 0.3
svn path=/trunk/; revision=20383
2003-03-20 15:00:49 +00:00
1dc4c5de39 ** for mail part of bug #38461.
2003-03-21  Not Zed  <NotZed@Ximian.com>

	** for mail part of bug #38461.

	* importers/evolution-outlook-importer.c (load_file_fn): dont pass
	in create flag to uri_to_folder, the folder must already exist.

	* importers/evolution-mbox-importer.c (folder_created_cb):
	Removed, we now force the caller to create the destination folder
	first.
	(load_file_fn): Dont try and create a folder if it doesn't exist.
	Also, use the uri directly as the destination uri, so we can
	import into any folder.
	(process_item_fn): If we dont have a folder, thats just an error,
	return BAD_FILE.

	* importers/netscape-importer.c (netscape_import_file): As below
	for elm_import_file.
	(import_next): similarly as for pine import_next.
	(importer_cb): just record result.
	(importer_timeout_fn): removed.

	* importers/pine-importer.c (import_next): Similar to below for
	the elm import_next.
	(pine_import_file): As below for elm_import_file.
	(importer_timeout_fn): removed.
	(importer_cb): just record the result, and exit.
	(import_next): change around to behave more like the elm importer,
	cleaning up when we're done.

	* importers/elm-importer.c (elm_import_file): Create the
	destination folder ourselves, dont pass it onto the mbox importer.
	Simplify logic, just do the import within a while loop, polling
	the g main loop as necessary, remove need for idle callbacks and
	other crap.
	(import_next): If elm_import_file fails, then just go straight to
	the next folder, stops it falling in a heap.
	(import_item_idle): removed.
	(importer_cb): just record result/exit.

	* mail-importer.c (mail_importer_create_folder): removed.
	(mail_importer_make_local_folder): new function to create a
	local-only folder from a path.  It runs synchronously by using a
	recursive main loop.
	(folder_created_cb): callback for make_local_folder.

svn path=/trunk/; revision=20379
2003-03-20 10:17:25 +00:00
10ddc8d45b removed a dead header file
svn path=/trunk/; revision=20374
2003-03-19 22:24:36 +00:00
43517230a9 Revert ettore's broken patch.
2003-03-19  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config-druid.c (mail_config_druid_new): Revert ettore's
	broken patch.

	* mail-search-dialogue.c: Removed - nothing uses this.

svn path=/trunk/; revision=20373
2003-03-19 22:21:37 +00:00
2416330235 Revert ettore's broken patch.
2003-03-19  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config-druid.c (mail_config_druid_new): Revert ettore's
	broken patch.

	* mail-search-dialogue.c (mail_search_dialogue_construct): Make
	the default size a little smaller.

svn path=/trunk/; revision=20372
2003-03-19 22:02:18 +00:00
7b8ae9b994 Replace "evolution:menu-name" prop with "evolution:menu_name". [#39692]
* importers/GNOME_Evolution_Mail_Mbox_Importer.server.in.in:
Replace "evolution:menu-name" prop with "evolution:menu_name".
[#39692]
* importers/GNOME_Evolution_Mail_Outlook_Importer.server.in.in:
Likewise.

svn path=/trunk/; revision=20369
2003-03-19 20:29:25 +00:00
28a37c0885 (mail_config_druid_new): Give the druid the
DIALOG hint.  [#39741 and friends.]

svn path=/trunk/; revision=20357
2003-03-19 18:24:30 +00:00
afc9db89eb changed default language to en_us instead of en
2003-03-19  Radek Doulik  <rodo@ximian.com>

	* mail-composer-prefs.c (spell_load_values): changed default
	language to en_us instead of en
	(spell_language_button_press): new handler, ported from 1.2
	(spell_setup): use spell_language_enable and
	spell_language_button_press

svn path=/trunk/; revision=20356
2003-03-19 14:37:32 +00:00
e977f1be9e e_msg_composer_get_subject() now returns a const char *, so update
2003-03-18  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (composer_get_message):
	e_msg_composer_get_subject() now returns a const char *, so update
	appropriately.

svn path=/trunk/; revision=20349
2003-03-18 22:10:38 +00:00
680504834f fix leak, cleanup variable name, and call gtk_window_set_transient_for
2003-03-18  Larry Ewing  <lewing@ximian.com>

	* mail-callbacks.c (do_mail_print): fix leak, cleanup variable
	name, and call gtk_window_set_transient_for with a parent that is
	actually a GtkWindow.
	(mark_as_unseen): use g_source_remove.

svn path=/trunk/; revision=20348
2003-03-18 21:47:43 +00:00
15ba3005bc Set the type hint to DIALOG so that Metacity shows this window on top.
2003-03-18  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config-druid.c (mail_config_druid_new): Set the type hint
	to DIALOG so that Metacity shows this window on top. Fixes bug
	#39914.

svn path=/trunk/; revision=20343
2003-03-18 19:58:02 +00:00
9623072931 validate rule & rule is unique. Workaround for #39464. Should this just
2003-03-18  Not Zed  <NotZed@Ximian.com>

        * mail-vfolder.c (new_rule_clicked): validate rule & rule is
        unique.  Workaround for #39464.  Should this just use
        rule_context_add_rule_gui??

svn path=/trunk/; revision=20333
2003-03-18 08:31:28 +00:00
9ecca5f32e unhook from the html engine signals here, before we redisplay the message.
2003-03-18  Not Zed  <NotZed@Ximian.com>

        * mail-search.c (mail_search_destroy): unhook from the html engine
        signals here, before we redisplay the message.  Also make sure
        this processing only happens once.  For #39759.
        (mail_search_finalise): dont unhook from signals here.

svn path=/trunk/; revision=20326
2003-03-18 00:13:41 +00:00
42508f7a3b use a hack to find out if the message-list was focussed before we
2003-03-12  Not Zed  <NotZed@Ximian.com>

        * mail-callbacks.c (expunge_folder): use a hack to find out if the
        message-list was focussed before we desensitise it.
        (expunged_folder): If the message-list was focussed before,
        re-grab the focus.  For bug #29564.

svn path=/trunk/; revision=20325
2003-03-17 22:44:58 +00:00
bbba025a3f (mail_signature_editor): Give the editor
the GDK_WINDOW_TYPE_HINT_DIALOG hint.  [#38926]

svn path=/trunk/; revision=20320
2003-03-17 21:32:11 +00:00
8b4ca6c023 If we fail to load the pixbuf, don't use it (stops some g_warnings).
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (pixbuf_gen_idle): If we fail to load the pixbuf,
	don't use it (stops some g_warnings).

svn path=/trunk/; revision=20319
2003-03-17 21:08:04 +00:00
c56a8e8c2d Part of a fix for bug #39809
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	Part of a fix for bug #39809

	* mail-vfolder.c (vfolder_edit): Don't add the cancel button here.

	* mail-callbacks.c (filter_edit): Don't add the cancel button here.

svn path=/trunk/; revision=20316
2003-03-17 19:55:25 +00:00
e1328c5de8 Lookup the handler for the type. If we don't have a registered handler or
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (do_external_viewer): Lookup the handler for the
	type. If we don't have a registered handler or if the registered
	handler is not meant to be handled via a bonobo component, don't
	use a bonobo component.

	* mail-format.c (mail_lookup_handler): If we register a new
	handler that is to be handled by a bonobo component, set
	handler->is_bonobo to TRUE.

svn path=/trunk/; revision=20311
2003-03-17 16:45:04 +00:00
dbf748d3d2 Update for EvolutionStorage change
* component-factory.c (storage_connect, storage_connected): Update
	for EvolutionStorage change

svn path=/trunk/; revision=20299
2003-03-14 18:16:44 +00:00
69c9fbff69 reverted mail-display.c and mail-format.c fixes - pondering better fixes
svn path=/trunk/; revision=20279
2003-03-13 20:09:27 +00:00
4b32de61d0 Security vulnerability fixes.
2003-03-12  Jeffrey Stedfast  <fejj@ximian.com>

	Security vulnerability fixes.

	* mail-display.c (do_external_viewer): Make sure that we don't
	launch a bonobo control to view a mime-type that we handle
	internally, otherwise maliciously formed HTML mail using <object>
	tags could potentially launch a bonobo vontrol to view the mime
	part bypassing any checks that Evolution might do on the data
	normally.

svn path=/trunk/; revision=20269
2003-03-12 21:39:09 +00:00