Commit Graph

798 Commits

Author SHA1 Message Date
5248c1282c Handle the case when there is no URI without crashing. Only add shortcuts
* e-shortcuts.c (load_shortcuts): Handle the case when there is no
URI without crashing.  Only add shortcuts when they are evolution:
URIs.

svn path=/trunk/; revision=12506
2001-08-29 00:21:44 +00:00
d671e29102 Studlycapsize all the IDs that are not. Likewise. Updated accordingly.
* Evolution-ShellComponent.idl: Studlycapsize all the IDs that are
not.
* Evolution-common.idl: Likewise.
* evolution-activity-client.c: Updated accordingly.
* evolution-shell-component.c: Likewise.
* evolution-storage.c: Likewise.
* e-activity-handler.c: Likewise.
* e-component-registry.c: Likewise.
* e-corba-storage.c: Likewise.
* e-shell-user-creatable-items-handlers.c: Likewise.

* e-local-storage.c (remove_folder): Remove unused variable.

* e-shell-view.c (update_for_current_uri): Assign zero to
`unread_count', not NULL.

* e-shell-importer.c (import_druid_finish): Remove unused
variable.

* e-shell-user-creatable-items-handler.c: #include
"e-corba-utils.h".

* e-shell-startup-wizard.c: #include "e-shell-startup-wizard.h".

* e-shell-startup-wizard.h: #include <glib.h>

* e-summary-weather.c (weather_make_html): Make local variable
`icon_name' const.  Remove unused variable `uri'.

* e-summary.h: Reformatted in GTK+ style.
(e_summary_remove_online_connection): Added prototype.

* e-summary-preferences.c (fill_mail_shown_clist): Constify local
variable `name'.

* e-summary-mail.c: #include "e-util/e-path.h".  Updated to match
the new studlyCapsification in shell/Evolution*.idl.

* mail-local.c: Match the studlyCapsification of
shell/Evolution*.idl.

* mail-config-druid.h: Change type of `event_source' from
`Bonobo_EventSource *' to `Bonobo_EventSource'.

* mail-accounts.c (mail_delete): Remove unused local variable
`label'.

* folder-info.c (do_get_info): `#if 0' unused variables.

* gui/component/addressbook-component.c: Get rid of a warning by
initializing the closing NULL element in folder_types correctly.

* gui/component/select-names/e-select-names.c: Updated to match
the studlyCapsification of attributes in shell/Evolution*.idl.

svn path=/trunk/; revision=12495
2001-08-28 00:18:34 +00:00
bcb7c5c83e Remove the stupid "do you want me to initialize stuff?" dialog.
* e-setup.c (copy_default_stuff): Remove the stupid "do you want
me to initialize stuff?" dialog.

svn path=/trunk/; revision=12465
2001-08-24 23:07:22 +00:00
bebd05b36a Change the `selected_row_path' to be non-const. (destroy): Free it.
* e-storage-set-view.c: Change the `selected_row_path' to be
non-const.
(destroy): Free it.
(e_storage_set_view_set_current_folder): Set the selected_row_path
to be this path.
(tree_drag_begin): Free the selected_row_path and strdup() the
value we assign.

svn path=/trunk/; revision=12463
2001-08-24 22:50:14 +00:00
17a85e8669 Ooops. Save the pointer to the control for use after the view struct is
* e-shell-view.c (e_shell_view_remove_control_for_uri): Ooops.
Save the pointer to the control for use after the view struct is
freed.

svn path=/trunk/; revision=12458
2001-08-24 21:38:15 +00:00
277ddb9abe New struct View'. Replace uri_to_control' in `EShellViewPrivate' with
* e-shell-view.c: New struct `View'.  Replace `uri_to_control' in
`EShellViewPrivate' with `uri_to_view'.
(view_new): New.
(hash_forall_destroy_view): New, replacing
`hash_forall_destroy_control'.
(destroy): Updated to match the uri_to_control -> uri_to_view
changes.
(socket_destroy_cb): Likewise.
(get_view_for_uri): Renamed from `get_control_for_uri'.  Return a
View instead of a GtkWidget.
(show_existing_view): Updated to use `get_view_from_uri', get a
@view instead of a @control.
(e_shell_view_display_uri): Updated to use `uri_to_view' instead
of `uri_to_control'.
(e_shell_view_remove_control_for_uri): Likewise.

svn path=/trunk/; revision=12457
2001-08-24 21:06:29 +00:00
34f9e86684 Changed to get a @title and a @type. (update_for_current_uri): Updated
* e-shell-view.c (update_folder_title_bar): Changed to get a
@title and a @type.
(update_for_current_uri): Updated accordingly.
(update_window_icon): Get a @type instead of a @folder.
(update_for_current_uri): Updated accordingly.

svn path=/trunk/; revision=12452
2001-08-24 20:08:30 +00:00
059103efde [Fix #5978, "If a component dies, it's toolbar buttons remain".]
* e-shell-view.c (socket_destroy_cb): If the view belongs to a
toplevel storage node, get the right type information with
`e_storage_get_toplevel_node_uri()' instead of trying to get the
[non-existing] folder for it.

svn path=/trunk/; revision=12451
2001-08-24 19:38:55 +00:00
b5f2ca08cf Implement the rest of the Evolution_Wizard events
svn path=/trunk/; revision=12449
2001-08-24 19:19:35 +00:00
31850e8de9 Added accelerators for the right-click shortcut menu.
* e-shortcuts-view.c: Added accelerators for the right-click
shortcut menu.

svn path=/trunk/; revision=12448
2001-08-24 19:15:37 +00:00
99cf86d7dd Added the missing part of my patch:
#include <gal/widgets/e-unicode.h>

svn path=/trunk/; revision=12447
2001-08-24 19:12:51 +00:00
921aa25a35 Convert names of the default group and shortcuts to UTF-8.
2001-08-23  Zbigniew Chyla  <cyba@gnome.pl>

	* e-shortcuts.c (e_shortcuts_add_default_group): Convert names of the
	default group and shortcuts to UTF-8.

svn path=/trunk/; revision=12441
2001-08-24 18:22:42 +00:00
ce251b85ce Convert the name of the group to GTK+ locale before displaying it in a
2001-08-23  Zbigniew Chyla  <cyba@gnome.pl>

	* e-shortcuts-view.c (destroy_group_cb): Convert the name of the group
	to GTK+ locale before displaying it in a dialog.

svn path=/trunk/; revision=12439
2001-08-24 18:07:25 +00:00
94326a9ac8 If we get no data, don't notify the receiving component at all.
* e-storage-set-view.c (tree_drag_data_received): If we get no
data, don't notify the receiving component at all.

svn path=/trunk/; revision=12423
2001-08-23 21:28:43 +00:00
8aecd161b7 [Fix #5736, crashing when copying a message with drag and drop.]
* e-storage-set-view.c (tree_drag_data_received): Handle NULL data
gracefully.

svn path=/trunk/; revision=12422
2001-08-23 21:09:03 +00:00
bb662dceb3 If the remove_source is %TRUE and destination is a descendant of the
* e-storage.c (e_storage_async_xfer_folder): If the remove_source
is %TRUE and destination is a descendant of the parent, pass an
`E_STORAGE_CANTMOVETODESCENDANT' error code to the callback.

* e-storage.h: New value `E_STORAGE_CANTMOVETODESCENDANT' in
`EStorageResult'.

svn path=/trunk/; revision=12397
2001-08-22 21:41:32 +00:00
b6463ef46a Actually return if the folder is being moved into one of its descendants.
* e-shell-folder-commands.c
(folder_selection_dialog_folder_selected_callback): Actually
return if the folder is being moved into one of its descendants.

svn path=/trunk/; revision=12395
2001-08-22 21:29:31 +00:00
26a78dd6c5 `#if 0'ed out. (make_bold): Likewise.
* e-shell-folder-title-bar.c (label_realize_callback): `#if 0'ed
out.
(make_bold): Likewise.
(e_shell_folder_title_bar_construct): Don't call it.

* e-local-storage.c (component_async_remove_folder_callback): Only
remove the directory if the component succeeds.

svn path=/trunk/; revision=12392
2001-08-22 20:49:12 +00:00
3e805202e4 Fix the improper construction of the new folder's physical URI.
2001-08-22  Peter Williams  <peterw@ximian.com>

	* e-local-storage.c (async_xfer_folder_callback): Fix the improper
	construction of the new folder's physical URI.

svn path=/trunk/; revision=12391
2001-08-22 20:30:11 +00:00
57516b50db Don't remove the folder directory here.
* e-local-storage.c (remove_folder): Don't remove the folder
directory here.
(component_async_remove_folder_callback): Remove it here instead.

svn path=/trunk/; revision=12390
2001-08-22 19:19:48 +00:00
5bfca4b535 [Fix #7775, crash trying to do New Task]
* e-shell-user-creatable-items-handler.c (verb_fn): Make sure we
don't pass NULL strings to
`GNOME_Evolution_ShellComponent_userCreateNewItem()'.

svn path=/trunk/; revision=12388
2001-08-22 18:53:47 +00:00
06def2fd56 unref the rc_style.
2001-08-21  Damon Chaplin  <damon@ximian.com>

	* e-gray-bar.c (endarken_style): unref the rc_style.

svn path=/trunk/; revision=12373
2001-08-21 23:05:01 +00:00
bd6877fa15 #include "e-shell-startup-wizard.h".
* e-shell.c: #include "e-shell-startup-wizard.h".

* e-shell-startup-wizard.h: New.

svn path=/trunk/; revision=12359
2001-08-21 20:35:13 +00:00
77ccc83ed0 Add sgmldocs.make' to EXTRA_DIST'.
* Makefile.am: Add `sgmldocs.make' to `EXTRA_DIST'.

svn path=/trunk/; revision=12358
2001-08-21 20:29:51 +00:00
ac60c7f9c9 Show an error dialog when the Evolution Mailer Wizard interface cannot be created
svn path=/trunk/; revision=12354
2001-08-21 20:25:14 +00:00
bf7641addc Fix a leak: unref the EFont after we have used it. Also, don't crash if
* e-shell-folder-title-bar.c (label_realize_callback): Fix a leak:
unref the EFont after we have used it.  Also, don't crash if
`e_font_to_gdk_font()' returns NULL.  [This should fix #7666,
Folder View crashes Evo.]

svn path=/trunk/; revision=12353
2001-08-21 20:18:49 +00:00
fa883ee48a Don't print a NULL. Crashes on Solaris
svn path=/trunk/; revision=12349
2001-08-21 19:22:12 +00:00
f3d8243e63 Do the import correctly.
svn path=/trunk/; revision=12327
2001-08-20 22:28:04 +00:00
ee21a426da Don't set the paneds' positions if the respective left-hand elements [i.e.
* e-shell-view.c (e_shell_view_load_settings): Don't set the
paneds' positions if the respective left-hand elements [i.e. the
shortcut bar and the folder bar] are hidden.
(e_shell_view_show_folder_bar): Set the paned position to zero
when hiding.
(e_shell_view_show_shortcut_bar): Likewise.

svn path=/trunk/; revision=12321
2001-08-20 19:51:59 +00:00
8346dd4f6c Don't free the returned displayname.
* e-shell-startup-wizard.c (finish_func): Don't free the returned
displayname.

svn path=/trunk/; revision=12318
2001-08-20 19:08:55 +00:00
dea477a5a1 Make sure we display a pin when we are popped up.
* e-shell-view.c (pop_up_folder_bar): Make sure we display a pin
when we are popped up.

svn path=/trunk/; revision=12259
2001-08-20 07:31:23 +00:00
fa88272dac Don't set the paned tree position.
* e-shell-view.c (setup_widgets): Don't set the paned tree
position.

svn path=/trunk/; revision=12250
2001-08-20 05:59:16 +00:00
45ca18de52 fill the corba sequence for the accepted_dnd_types.
2001-08-19  Chris Toshok  <toshok@ximian.com>

	* evolution-shell-component.c (impl__get_supported_types): fill
	the corba sequence for the accepted_dnd_types.

svn path=/trunk/; revision=12249
2001-08-20 05:49:12 +00:00
85a2968706 Don't show the vbox here. (setup_widgets): Don't show the
* e-shell-view.c (setup_storage_set_subwindow): Don't show the
vbox here.
(setup_widgets): Don't show the storage_set_view_box here.

svn path=/trunk/; revision=12246
2001-08-20 05:16:14 +00:00
d9ed7a6a63 Added display_name and description to the type.
* evolution-test-component.c: Added display_name and description
to the type.

* evolution-shell-component.c (impl__get_supported_types): Pass
`display_name' and `description' here.
(evolution_shell_component_construct): Likewise.

* evolution-shell-component.h: New members `display_name',
`description' in `EvolutionShellComponentFolderType'.

* e-component-registry.c (register_type): New args @description
and @display_name.  Pass to
`e_folder_type_registry_register_type()'.
(register_component): Pass the values returned in the sequence
from __get_supported_types.

* e-folder-type-registry.c: New members `display_name' and
`description' in `struct _FolderType'.
(folder_type_new): New args @description and @display_name.
Initialize the respective fields in the `FolderType' accordingly.
(folder_type_free): Free `display_name' and `description'.
(register_folder_type): New args @display_name, @description.
(e_folder_type_registry_register_type): New args @display_name,
@description.
(e_folder_type_registry_get_description_for_type): New.
(e_folder_type_registry_get_display_name_for_type): New.

* Evolution-ShellComponent.idl: Added `display_name' and
`description' fields to the `FolderType' struct.

svn path=/trunk/; revision=12245
2001-08-20 04:42:04 +00:00
4d477c4497 Put the bonobo_object_release_unref() for the db at the top in an attempt
* e-shell.c (destroy): Put the bonobo_object_release_unref() for
the db at the top in an attempt to fix #7542.

svn path=/trunk/; revision=12238
2001-08-20 02:58:17 +00:00
8f7f50d30e Change type of toplevel node from "Summary" to "summary". [All the other
* e-summary-storage.c (e_summary_storage_new): Change type of
toplevel node from "Summary" to "summary".  [All the other folder
types use lowercase names.]

* e-shortcuts.c (load_shortcuts): Also use the display name for
the storage.

svn path=/trunk/; revision=12234
2001-08-20 01:58:13 +00:00
e135a96c07 Also use the display name for the storage.
* e-shortcuts.c (load_shortcuts): Also use the display name for
the storage.

svn path=/trunk/; revision=12233
2001-08-20 01:27:59 +00:00
6bf0ba97e2 Use xmlMemStrdup() to override the type as it's expected to be allocated
* e-shortcuts.c (load_shortcuts): Use xmlMemStrdup() to override
the type as it's expected to be allocated by libxml later on.
Also, get the icon for the storage if the shortcut points to a
storage.

* e-storage-set-view.c (etree_icon_at): Don't special case the
Summary storage.  Rather, use `e_storage_get_toplevel_node_type()'
for getting the type of the node.

* e-shortcuts-view-model.c (get_icon_for_item): New helper
function.
(shortcuts_update_shortcut_cb): Use it.
(shortcuts_new_shortcut_cb): Use it.
(load_group_into_model): Use it.

svn path=/trunk/; revision=12232
2001-08-20 01:22:09 +00:00
70e6407e12 New constant `MIN_POPUP_TREE_WIDTH'. (pop_up_folder_bar): Make sure the
* e-shell-view.c: New constant `MIN_POPUP_TREE_WIDTH'.
(pop_up_folder_bar): Make sure the pop-up is always this size or
more.
(setup_widgets): Pass %FALSE for @shrink to `e_paned_pack1()'.
(reparent_storage_set_view_box_and_destroy_popup): Likewise.

svn path=/trunk/; revision=12211
2001-08-18 23:20:16 +00:00
9f79315277 New, replacing `shortcut_bar_mode_changed_cb'.
* e-shell-view-menu.c (shortcut_bar_visibility_changed_cb): New,
replacing `shortcut_bar_mode_changed_cb'.
(folder_bar_visibility_changed_cb): New, replacing
`folder_bar_mode_changed_cb'.
(command_toggle_folder_bar): Use `e_shell_view_show_folder_bar()'
instead of `e_shell_view_set_folder_bar_mode()'.
(command_toggle_shortcut_bar): Use
`e_shell_view_show_shortcut_bar()' instead of
`e_shell_view_set_shortcut_bar_mode()'.
(e_shell_view_menu_setup): Updated for the
"shortcut_bar_visibility_changed" and
"folder_bar_visibility_changed" signals and the above changes.

* e-shell-view.c: New member `folder_bar_popup' in
`EShellViewPrivate'.  Replaced `folder_bar_mode' and
`shortcut_bar_mode' with `folder_bar_shown' and
`shortcut_bar_shown', respectively.
(init): Updated to initialize these correctly.
(reparent): New helper function.
(reparent_storage_set_view_box_and_destroy_popup): New helper
function.
(popdown_transient_folder_bar): Updated to use the
`folder_bar_popup'.
(folder_bar_popup_map_callback): Renamed from
`storage_set_view_box_map_cb'.
(e_shell_view_set_shortcut_bar_mode): Removed.
(e_shell_view_set_folder_bar_mode): Removed.
(e_shell_view_show_shortcut_bar): New.  All the calls to
`e_shell_view_set_shortcut_bar_mode()' replaced with calls to this
one.
(e_shell_view_show_folder_bar): New.  All the calls to
`e_shell_view_set_folder_bar_mode()' replaced with calls to this
one.
(e_shell_view_folder_bar_shown): New.  All the calls to
`e_shell_view_get_folder_bar_mode()' replaced with calls to this
one.
(e_shell_view_shortcut_bar_shown): New.  All the calls to
`e_shell_view_get_shortcut_bar_mode()' replaced with calls to this
one.
(class_init): Replace signal `folder_bar_mode_changed' with
`folder_bar_visibility_changed' and `shortcut_bar_mode_changed'
with `shortcut_visibility_changed'.
(e_shell_view_save_settings): Use keys "ShortcutBarShown" and
"FolderBarShown" instead of "ShortcutBarMode" and "FolderBarMode",
respectively.
(e_shell_view_load_settings): Likewise.

* e-shell-view.h: Removed enum `EShellViewSubwindowMode'.  Renamed
signal `shortcut_bar_mode_changed' to
`shortcut_bar_visibility_changed' and `folder_bar_mode_changed' to
`folder_bar_visibility_changed'.

svn path=/trunk/; revision=12203
2001-08-18 19:59:59 +00:00
bc037887bb Build fix
svn path=/trunk/; revision=12176
2001-08-17 21:05:56 +00:00
f50da39fe3 Add a warning for Ettore
svn path=/trunk/; revision=12174
2001-08-17 20:04:10 +00:00
aeeed3f806 Changelog I forgot
svn path=/trunk/; revision=12173
2001-08-17 19:47:48 +00:00
d5ea07e5be Compile fixes
svn path=/trunk/; revision=12172
2001-08-17 19:44:17 +00:00
690dc0c365 g_return_if_fail(), not g_return_val_if_fail().
* evolution-shell-client.c
(evolution_shell_client_set_line_status): g_return_if_fail(), not
g_return_val_if_fail().

svn path=/trunk/; revision=12167
2001-08-17 18:38:52 +00:00
88a9573572 Added some g_warnings for when we return CORBA_OBJECT_NIL; this might help
* evolution-shell-client.c
(evolution_shell_client_get_local_storage): Added some g_warnings
for when we return CORBA_OBJECT_NIL; this might help to figure out
what is wrong with bug #6625.  Also, added a missing
CORBA_exception_free().

svn path=/trunk/; revision=12165
2001-08-17 18:26:09 +00:00
cc9108e8ab tedfast <fejj@ximian.com>
tedfast  <fejj@ximian.com>

	* e-shell.c (e_shell_construct): Don't destroy the splash twice.

svn path=/trunk/; revision=12161
2001-08-17 17:44:12 +00:00
66659c3812 Don't destroy the splash twice.
2001-08-17  Jeffrey Stedfast  <fejj@ximian.com>

	* e-shell.c (e_shell_construct): Don't destroy the splash twice.

svn path=/trunk/; revision=12160
2001-08-17 17:44:00 +00:00
681d93a44e utf_name should not be const as e_utf8_from_locale_string() returns an
2001-08-17  Jeffrey Stedfast  <fejj@ximian.com>

	* e-local-storage.c (setup_folder_as_stock): utf_name should not
	be const as e_utf8_from_locale_string() returns an allocated
	buffer.

svn path=/trunk/; revision=12158
2001-08-17 17:12:19 +00:00