Commit Graph

430 Commits

Author SHA1 Message Date
5d47e3740b Listen to the "value-changed" signal rather than the "changed" signal.
2003-09-22  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-int.c (get_widget): Listen to the "value-changed" signal
	rather than the "changed" signal. Fixes bug #48166.

svn path=/trunk/; revision=22646
2003-09-22 18:40:41 +00:00
e8c9e32de8 type should be a GType. (rule_context_add_rule_set): Likewise. Update
2003-09-16  Jeremy Katz  <katzj@redhat.com>

	* rule-context.c (rule_context_add_part_set): type should be a GType.
	(rule_context_add_rule_set): Likewise.
	* rule-context.h: Update prototypes.  Use GType instead of int for
	type in _part_set_map and _rule_set_map.

svn path=/trunk/; revision=22593
2003-09-16 21:15:38 +00:00
e62d27cf3c forgot to commit. new search types xml file.
svn path=/trunk/; revision=22586
2003-09-16 16:13:07 +00:00
99274a9570 ** See Natzilla task #47524
2003-09-15  Not Zed  <NotZed@Ximian.com>

        ** See Natzilla task #47524

        * filter-rule.h (FilterRule): add a system bit, for rules that
        shouldn't be edited/saved.

        * rule-context.c (load): check for ruleset maps in the system
        file, and if they exist, load in as system rules.
        (save): ignore system rules if they exist.

        * searchtypes.xml: Added a search-specific types folder.  Also
        contains system searches that cannot be deleted.

svn path=/trunk/; revision=22581
2003-09-15 22:43:15 +00:00
9c6056e601 ** See bug #42636.
2003-08-05  Not Zed  <NotZed@Ximian.com>

        ** See bug #42636.

        * vfoldertypes.xml: Fix some of the subject rules, they were
        missing matching ')'s.

2003-08-01  Not Zed  <NotZed@Ximian.com>

        ** See bug #47208.

        * filter-code.c (build_code): wrap the expression in a match-all
        so boolean expressions work properly for folder searches.

svn path=/trunk/; revision=22090
2003-08-05 21:12:14 +00:00
dbd246a88e Use EVO_MARSHAL_RULE
* Makefile.am: Use EVO_MARSHAL_RULE

svn path=/trunk/; revision=21919
2003-07-23 16:46:16 +00:00
601f9ed9e5 free current_url.
2003-06-13  Larry Ewing  <lewing@ximian.com>

	* filter-source.c (filter_source_finalize): free current_url.

svn path=/trunk/; revision=21435
2003-06-13 17:26:40 +00:00
51ca9977c7 Put the ChangeLog.pre-1-4 in the Makefiles.
svn path=/trunk/; revision=21426
2003-06-12 21:13:59 +00:00
59581dc2d3 stat the user file before parsing.
2003-06-11  Mike Kestner  <mkestner@ximian.com>

	* rule-context.c (load): stat the user file before parsing.

svn path=/trunk/; revision=21408
2003-06-11 15:56:38 +00:00
c67d63acba Fixes some leaks from bug #43883.
2003-06-06  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes some leaks from bug #43883.

	* filter-file.c (xml_decode): Free file->path and set it to
	NULL before entering the loop to decode it. This way if the value
	is already set we don't leak it. Set file->path = g_strdup (str ?
	str : ""); and then xmlFree the str.

2003-05-21  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-source.c (filter_source_get_sources): Same as below.

	* filter-label.c (xml_create): Unref the gconf client when we're
	finished with it.

svn path=/trunk/; revision=21390
2003-06-09 18:17:10 +00:00
fd2f3a6d7a Roll over ChangeLogs.
svn path=/trunk/; revision=21387
2003-06-09 17:31:26 +00:00
433afe99ea Reverted unwanted commit
svn path=/trunk/; revision=21168
2003-05-14 11:06:59 +00:00
a1f14d4b05 Updated NEWS
svn path=/trunk/; revision=21167
2003-05-14 11:01:17 +00:00
3242c9f90c Format the colour string in a way that gdk_color_parse() will handle.
2003-05-05  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-colour.c (format_sexp): Format the colour string in a way
	that gdk_color_parse() will handle. Apparently it no longer
	handles rgb:<red>/<green>/<blue>? Fixes bug #42345.

svn path=/trunk/; revision=21115
2003-05-06 17:54:19 +00:00
8a3def40ba Fix for bug #41578.
2003-04-24  Jeffrey Stedfast  <fejj@ximian.com>

	Fix for bug #41578.

	* rule-editor.c (rule_move): Pass re->source instead of
	re->current->source to rule_context_get_rank_rule(). Also updated
	to pass re->source to rule_context_rank_rule().
	(rule_editor_play_undo): Updated to pass re->source to
	rule_context_rank_rule().

	* rule-context.c (rule_context_rank_rule): Now takes a 'source'
	argument rather than using rule->source (vfolder editor lists
	rules of all sources, not just same-source rules).
	(revert): Pass frule->source/part->source to
	rule_context_rank_rule() - might not be right but should preserve
	the prior behaviour at least.

svn path=/trunk/; revision=21006
2003-04-29 17:08:40 +00:00
36875999d7 removed debug spew.
2003-04-18  Not Zed  <NotZed@Ximian.com>

        * rule-editor.c (d): removed debug spew.

        * addresses #41398

        * vfolder-rule.c (format_source): helper function to decode a url
        into a more user-friendly format.
        (source_add, get_widget): add the formatted data as another
        column to the table.
        (vfolder_editor_sourcelist_new): add another column to the table,
        a formatted uri as well as the raw one.
        (d): turned off debug vomit while i'm here.

svn path=/trunk/; revision=20929
2003-04-23 01:23:42 +00:00
342211ac69 updated the bug list that my last commit fixed (since more bugs have been submitted that were fixed by that previous fix).
svn path=/trunk/; revision=20830
2003-04-11 20:09:26 +00:00
e3f30504ad added more bug #'s
svn path=/trunk/; revision=20826
2003-04-11 19:40:49 +00:00
724b51b4ff Fixes for bugs: #41149, #41150, #41151, #41152, #41153, #41155 and #41156.
2003-04-11  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes for bugs: #41149, #41150, #41151, #41152, #41153, #41155 and
	#41156.

	* filter-filter.c (get_widget): Same as with filter-rule.

	* filter-rule.c (get_widget): Changed border widths of frame
	vboxes and other padding to comply with the HIG.

	* rule-editor.c (rule_add): Change window border and padding
	around the 'rules' widget to comply with the HIG.
	(rule_edit): Same.
	(rule_editor_construct): Same here as well.

	* filter.glade: Many HIG compliance fixes.

svn path=/trunk/; revision=20823
2003-04-11 19:11:50 +00:00
ce898884dc cast warning.
2003-03-28  Not Zed  <NotZed@Ximian.com>

	* filter-datespec.c (button_clicked): cast warning.

svn path=/trunk/; revision=20555
2003-03-27 23:54:16 +00:00
4d4d2a9114 Loop over child nodes here too in order to not be affected by libxml2
2003-03-26  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-file.c (xml_decode): Loop over child nodes here too in
	order to not be affected by libxml2 crack.

	* filter-source.c (xml_decode): Fixed to disreguard libxml2 crack.
	(get_widget): Use strcmp instead of e_url_equal().

svn path=/trunk/; revision=20523
2003-03-26 20:28:54 +00:00
ce0fb06f3e (button_clicked): Fix this so we don't get stuck inside
gtk_dialog_run's main loop forever.

svn path=/trunk/; revision=20433
2003-03-20 17:46:43 +00:00
d8dbc151f0 Change the strings in the timespans array from "second" / "seconds" to "1
* filter-datespec.c (timespans, set_button): Change the strings in
	the timespans array from "second" / "seconds" to "1 second ago" /
	"%d seconds ago", etc, and update the code in set_button that uses
	them. Fixes #36245, translation clash between the "second" here
	and the one in the calendar (where it's used as "2nd").

svn path=/trunk/; revision=20432
2003-03-20 17:09:47 +00:00
1bef6b2b8c Don't return here - this is a void function. (rule_editor_set_source):
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-editor.c (rule_editor_set_sensitive): Don't return here -
	this is a void function.
	(rule_editor_set_source): Same.

svn path=/trunk/; revision=20429
2003-03-20 15:52:00 +00:00
3a1c2dfaef use the same code as in filter-rule to enforce unique names for all
2003-03-18  Not Zed  <NotZed@Ximian.com>

        * rule-context.c (new_rule_response): use the same code as in
        filter-rule to enforce unique names for all rules/vfolders.

svn path=/trunk/; revision=20332
2003-03-18 08:21:34 +00:00
8febd0e5ac Set the default window size to something reasonable (350x400?). Fixes bug
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-editor.c (rule_editor_construct): Set the default window
	size to something reasonable (350x400?). Fixes bug #39808.

svn path=/trunk/; revision=20323
2003-03-17 22:22:33 +00:00
13398c9928 Fixed to work properly. Fixes bug #39654.
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	* vfolder-rule.c (source_remove): Fixed to work properly. Fixes
	bug #39654.

svn path=/trunk/; revision=20321
2003-03-17 21:44:44 +00:00
32f1cfd13f Always add a Cancel button here, but if !enable_undo - make the response
2003-03-17  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-editor.c (rule_editor_construct): Always add a Cancel
	button here, but if !enable_undo - make the response id
	GTK_RESPONSE_CANCEL rather than GTK_RESPONSE_REJECT (which does
	undo). This mimics the behaviour that was done in the mail/ code
	previously. Fixes bug #39809.

svn path=/trunk/; revision=20315
2003-03-17 19:53:56 +00:00
d51c9927e5 go to the proper level of child node before looking for rule sets, fix for
2003-03-11  Not Zed  <NotZed@Ximian.com>

        * rule-context.c (revert): go to the proper level of child node
        before looking for rule sets, fix for #39165 to make 'cancel' work.

svn path=/trunk/; revision=20230
2003-03-10 08:15:01 +00:00
d8298a3e80 Fixes for bug #39170
2003-03-06  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes for bug #39170

	* filter-element.c (filter_element_xml_create): Remove return
	keyword.
	(filter_element_build_code): Same.
	(filter_element_format_sexp): Here too.

svn path=/trunk/; revision=20189
2003-03-06 14:51:36 +00:00
87f2abd1f0 Change to use EAccountList, etc.
2003-02-20  Not Zed  <NotZed@Ximian.com>

        * filter-source.c (filter_source_get_sources): Change to use
        EAccountList, etc.

svn path=/trunk/; revision=20014
2003-02-24 02:47:20 +00:00
1d869c5796 Get rid of the need for the GTK_WIDGET_DESTROYED() check.
2003-02-12  Jeffrey Stedfast  <fejj@ximian.com>

	* vfolder-rule.c (source_add): Get rid of the need for the
	GTK_WIDGET_DESTROYED() check.

svn path=/trunk/; revision=19898
2003-02-12 20:42:35 +00:00
8d7130fe72 Use g_object_new() instead of gtk_type_new().
2003-02-07  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-editor.c (filter_editor_new): Use g_object_new()
	instead of gtk_type_new().

	* vfolder-editor.c (vfolder_editor_new): Use g_object_new()
	instead of gtk_type_new().

	* score-editor.c (score_editor_new): Use g_object_new() instead of
	gtk_type_new().

	* rule-editor.c (rule_editor_new): Use g_object_new() instead of
	gtk_type_new().
	(rule_add): Use gtk_window_set_resizable() instead of the
	deprecated gtk_window_set_policy().
	(rule_edit): Same here.
	(rule_editor_construct): Here too.

	* rule-context.c (rule_context_add_rule_gui): Use
	gtk_window_set_resizable() instead of the deprecated
	gtk_window_set_policy().

svn path=/trunk/; revision=19847
2003-02-07 21:51:51 +00:00
66802f088f Defined in configure.in now (filterdir): Define using privdatadir
* Makefile.am (gladedir): Defined in configure.in now
	(filterdir): Define using privdatadir

svn path=/trunk/; revision=19776
2003-02-05 22:37:03 +00:00
5dadc27fb9 (gladedir): Version using $(BASE_VERSION).
(filterdir): Likewise.

svn path=/trunk/; revision=19559
2003-01-22 20:10:31 +00:00
ad1fe3bc9c dont re-use 'widget', its the return value!
2003-01-15  Not Zed  <NotZed@Ximian.com>

        * vfolder-rule.c (get_widget): dont re-use 'widget', its the
        return value!

svn path=/trunk/; revision=19488
2003-01-15 22:25:48 +00:00
3a08c59b32 Back to using e_xml_save_file().
2003-01-15  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-context.c (save): Back to using e_xml_save_file().

svn path=/trunk/; revision=19483
2003-01-15 20:40:44 +00:00
8c18975c23 Change dialog from OK/Cancel to Cancel/OK to match HIG. (rule_edit):
* rule-editor.c (rule_add): Change dialog from OK/Cancel to
Cancel/OK to match HIG.
(rule_edit): Likewise.
(rule_editor_construct): Likewise.

* rule-context.c (rule_context_add_rule_gui): Change dialog from
OK/Cancel to Cancel/OK to match HIG.

* filter-datespec.c (button_clicked): Change dialog from OK/Cancel
to Cancel/OK to match HIG.

svn path=/trunk/; revision=19470
2003-01-14 22:47:19 +00:00
1e42c9e6ff more bug #'s
svn path=/trunk/; revision=19229
2003-01-03 20:16:15 +00:00
9eceff66b1 added a bug # that was fixed
svn path=/trunk/; revision=19227
2003-01-03 20:01:58 +00:00
4aa0c65063 Scroll to the newly added row. (rule_delete): Scroll to the selected row.
2003-01-03  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-editor.c (add_editor_response): Scroll to the newly added
	row.
	(rule_delete): Scroll to the selected row.
	(rule_move): After moving the row, re-select it and then scroll to
	make sure that it is still visible.

svn path=/trunk/; revision=19226
2003-01-03 20:00:46 +00:00
c43efddd13 more fixes
svn path=/trunk/; revision=19203
2003-01-02 18:33:06 +00:00
901d85f456 Fixed to build with -DG_DISABLE_DEPRECATED and -DGTK_DISABLE_DEPRECATED
2003-01-02  Jeffrey Stedfast  <fejj@ximian.com>

	Fixed to build with -DG_DISABLE_DEPRECATED and
	-DGTK_DISABLE_DEPRECATED

svn path=/trunk/; revision=19202
2003-01-02 17:06:18 +00:00
f6232508a1 Use an easier method for getting the iter.
2002-12-12  Jeffrey Stedfast  <fejj@ximian.com>

	* rule-editor.c (cursor_changed): Use an easier method for getting
	the iter.

svn path=/trunk/; revision=19108
2002-12-13 02:14:17 +00:00
dc41429125 New custom function for creating the source_list widget. (get_widget):
2002-12-12  Jeffrey Stedfast  <fejj@ximian.com>

	* vfolder-rule.c (vfolder_editor_sourcelist_new): New custom
	function for creating the source_list widget.
	(get_widget): Removed the source_list creation code.

	* rule-editor.c (rule_editor_construct): Listen to row-activated
	for double-click events. Also, removed the model creation code out
	of here.
	(rule_editor_treeview_new): Moved the treeview and model creation
	code into here instead, and made the glade widgets into custom
	widgets.

svn path=/trunk/; revision=19106
2002-12-13 00:32:28 +00:00
66c09e1229 updated
svn path=/trunk/; revision=19004
2002-12-04 16:42:36 +00:00
efcca0533d Add a textcellrenderer to display the folders. (get_widget): Remove FIXME
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * vfolder-rule.c (get_widget): Add a textcellrenderer to display
        the folders.
        (get_widget): Remove FIXME which was wrong.

svn path=/trunk/; revision=18924
2002-11-26 11:52:31 +00:00
9372387769 FILTER_RULE_CLASS -> _GET_CLASS
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * filter-rule.c (filter_rule_validate): FILTER_RULE_CLASS ->
        _GET_CLASS

        * rule-context.c (rule_context_save): RULE_CONTEXT_CLASS ->
        RULE_CONTEXT_GET_CLASS
        (rule_context_revert): "

        * *.[ch]: Ran fix.sh over all files.

        * rule-editor.c (rule_add): widget:set_parent ->
        window:set_transient_for
        (editor_response): renamed from editor_clicked, handle gtk dialog
        response codes.
        (rule_edit): connect to response rather than clicked.
        (rule_editor_construct): Setup a text column in the tree view.
        Not sure if this can be handled via glade.

svn path=/trunk/; revision=18922
2002-11-26 11:25:51 +00:00
37cdfc6c84 free the list data
svn path=/trunk/; revision=18862
2002-11-20 20:24:24 +00:00
83f24bfbbf gconfify.
2002-11-20  Jeffrey Stedfast  <fejj@ximian.com>

	* filter-label.c (xml_create): gconfify.

svn path=/trunk/; revision=18861
2002-11-20 19:49:55 +00:00