Commit Graph

418 Commits

Author SHA1 Message Date
4a28f62c6c Don't allow the returned charset to be NULL. (get_file_content): Make sure
2003-03-04  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset_setting): Don't
	allow the returned charset to be NULL.
	(get_file_content): Make sure there is buffered data before trying
	to convert it to UTF-8.

svn path=/trunk/; revision=20139
2003-03-04 18:31:35 +00:00
e5f2139df7 Same as below.
2003-02-25  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c: Same as below.

	* e-msg-composer-attachment-bar.c: Go back to using
	e_iconv_charset_name().

svn path=/trunk/; revision=20059
2003-02-25 20:54:19 +00:00
afea60336c Make sure the url is != NULL? I can't think of anything else in this code
2003-02-24  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (drag_data_received): Make sure the url is !=
	NULL? I can't think of anything else in this code that could
	possibly cause bug #38382.

svn path=/trunk/; revision=20046
2003-02-24 22:15:26 +00:00
1247dfa0f3 Don't save the HTML format setting to gconf. This option menu is meant for
2003-02-22  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_set_send_html): Don't save the
	HTML format setting to gconf. This option menu is meant for a
	per-essage setting (ie. once the composer closes, the next
	composer will again use the default and not what the user chose
	last time).

svn path=/trunk/; revision=20004
2003-02-23 04:17:03 +00:00
74171b6c89 Same as below.
2003-02-20  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset_setting): Same as
	below.

	* e-msg-composer-attachment-bar.c (get_default_charset): Use
	camel_charset_canonical_name() rather than e_iconv_charset_name()
	as the latter will be removed shortly.

svn path=/trunk/; revision=19979
2003-02-20 21:46:51 +00:00
1907e1a2d7 default_account is now a string value, not an int.
2003-02-18  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_from_account):
	default_account is now a string value, not an int.
	(create_from_optionmenu): Same.
	(header_new_recipient): Use g_signal_connect_data() instead of the
	now deprecated gtk_signal_connect_full().

svn path=/trunk/; revision=19934
2003-02-18 20:50:23 +00:00
50ff525b79 clean up
* Makefile.am: clean up

        * e-msg-composer.c (autosave_manager_query_load_orphans): #include
        string.h
        (menu_file_send_cb): s/gtk_signal_emit/g_signal_emit/

        * e-msg-composer-attachment.c: #include string.h
        (e_msg_composer_attachment_edit): s/E_GLADEDIR/EVOLUTION_GLADEDIR
        * e-msg-composer-attachment-bar.c: #include string.h
        (pixbuf_for_mime_type): s/ICONSDIR/IMAGESDIR/

        * e-msg-composer-hdrs.c: #include string.h

        * e-msg-composer-select-file.c (run_selector): Remove unused var

        * evolution-composer.c: #include string.h
        (evolution_composer_init): Remove unused var
        * listener.c: #include string.h
        (listener_new): Remove unused var

svn path=/trunk/; revision=19804
2003-02-06 15:50:31 +00:00
999cf94d61 Split out the mailto handling code from here so we can use it in the
2003-02-05  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): Split out the
	mailto handling code from here so we can use it in the drag-n-drop
	code too.
	(drag_data_received): If we find a mailto: url in the
	text/uri-list drop, pass that off to handle_mailto() so it can
	fill in the fields for us.

svn path=/trunk/; revision=19768
2003-02-05 20:16:44 +00:00
a5e82f72f8 updated for e scroll frame --> gtk scrolled window
svn path=/trunk/; revision=19736
2003-02-04 19:03:02 +00:00
8644df4c44 If the subject or body components of the mailto url are not in UTF-8,
2003-01-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): If the subject
	or body components of the mailto url are not in UTF-8, convert
	them to UTF-8.

svn path=/trunk/; revision=19662
2003-01-28 04:04:51 +00:00
cf7ef09cd0 Load the view menu states from gconf. (e_msg_composer_set_send_html): Save
2003-01-23  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_load_config): Load the view
	menu states from gconf.
	(e_msg_composer_set_send_html): Save the setting via gconf instead
	of bonobo-config.
	(e_msg_composer_set_view_from): Same.
	(e_msg_composer_set_view_replyto): Here too.
	(e_msg_composer_set_view_cc): Again here.
	(e_msg_composer_set_view_bcc): And finally here.
	(setup_ui): Fixed a #warning - use gconf instead of bonobo-conf.
	(destroy): No need to sync/destroy the bonobo-conf db, we don't
	use it anymore.

svn path=/trunk/; revision=19606
2003-01-23 22:02:44 +00:00
1ac51fc577 *** empty log message ***
svn path=/trunk/; revision=19555
2003-01-22 20:09:10 +00:00
f4a030d2fa Updated to use EAccountList and iterators. (evolution_composer_init):
2003-01-17  Jeffrey Stedfast  <fejj@ximian.com>

	* evolution-composer.c (impl_Composer_set_headers): Updated to use
	EAccountList and iterators.
	(evolution_composer_init): Updated to use EAccount.

	* e-msg-composer.c (from_changed_cb): Updated to use the EAccount
	object.
	(e_msg_composer_new_with_message): Same.
	(e_msg_composer_get_preferred_account): Updated to return an
	EAccount object.
	(set_editor_signature): Updated to use an EAccountIdentity pointer.
	(get_signature_html): Same.

	* e-msg-composer-hdrs.c (create_from_optionmenu): Updated to use
	EAccount and EAccountList foo.
	(destroy): Same here.
	(e_msg_composer_hdrs_set_from_account): Here too.
	(e_msg_composer_hdrs_get_from): Updated.

svn path=/trunk/; revision=19511
2003-01-17 23:32:07 +00:00
2224fbc745 mail_config_get_signature_list now returns a GSList.
2003-01-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (signature_cb): mail_config_get_signature_list
	now returns a GSList.
	(setup_signatures_menu): Same.
	(set_signature_gui): Here too.

svn path=/trunk/; revision=19498
2003-01-16 20:49:18 +00:00
c0e8918f76 (do_exit): Make dialog HIG compliant
[Discard/Cancel/Save].

svn path=/trunk/; revision=19471
2003-01-14 22:50:36 +00:00
47ad4c65d3 use the composer's charset gconf key
svn path=/trunk/; revision=19274
2003-01-08 06:14:52 +00:00
a7c452fa57 Convenience function. (get_file_content): Use the convenience function to
2003-01-07  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset): Convenience
	function.
	(get_file_content): Use the convenience function to get the
	default charset setting.
	(best_charset): Same.
	(e_msg_composer_new): Use gconf to get the send_html setting.
	(e_msg_composer_new_post): Same.

svn path=/trunk/; revision=19269
2003-01-08 01:27:05 +00:00
6221468fa0 fixes
svn path=/trunk/; revision=19206
2003-01-02 20:05:58 +00:00
aed127b4f4 Use camel_text_to_html(). (e_msg_composer_new_from_url): Same.
2002-12-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (get_signature_html): Use camel_text_to_html().
	(e_msg_composer_new_from_url): Same.

	* evolution-composer.c (impl_Composer_set_body): Use
	camel_text_to_html().

svn path=/trunk/; revision=19127
2002-12-16 19:23:18 +00:00
6e5686598a Get rid of the unused exception variable.
2002-12-03  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (message_rfc822_dnd): Get rid of the unused
	exception variable.

svn path=/trunk/; revision=18997
2002-12-03 18:45:47 +00:00
aececffc14 removed warning about e_notice. its used too much, its here to stay.
2002-11-27  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (save): removed warning about e_notice.  its
        used too much, its here to stay.

        * *.[ch]: run fix.sh over everything.

svn path=/trunk/; revision=18973
2002-12-02 03:07:59 +00:00
b625bdfa46 s/g_str[n]casecmp/str[n]casecmp
2002-12-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c: s/g_str[n]casecmp/str[n]casecmp

svn path=/trunk/; revision=18969
2002-12-01 18:52:28 +00:00
66442571c9 properly chain finalise.
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (composer_finalise): properly chain finalise.

svn path=/trunk/; revision=18918
2002-11-26 06:39:18 +00:00
7d4c791a79 Duh! dont free subject & simplify logic a little.
2002-11-21  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (subject_changed_cb): Duh!  dont free subject &
        simplify logic a little.

2002-11-20  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-hdrs.c (entry_changed): duh, emit the signal
        using an initialised value(!).

svn path=/trunk/; revision=18873
2002-11-20 23:46:04 +00:00
ccbfa5da03 applied plain_signature_fix.patch
svn path=/trunk/; revision=18841
2002-11-19 18:42:41 +00:00
6cd18c10d9 dont unref after destroy. duh.
2002-11-19  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (add_from_file): dont unref
        after destroy. duh.

        * e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_to): Add type
        code to set_property call.
        (e_msg_composer_hdrs_set_cc): "
        (e_msg_composer_hdrs_set_bcc): "
        (e_msg_composer_hdrs_get_to): Do the same for get_property calls.
        (init): ref/sink the tooltip object.
        (e_msg_composer_hdrs_get_type): fix return type.

        * e-msg-composer.c (GNOME_GTKHTML_EDITOR_CONTROL_ID): we want
        version 3.0 not 1.1.
        (create_composer): Add type code to set property call.
        (autosave_manager_query_load_orphans): my bad, we dont unref
        dialog's once we've destroyed 'em.
        (build_message): "
        (get_file_content): "
        (save): "
        (do_exit): "
        (composer_dispose): moved the autosave shutdown here.

svn path=/trunk/; revision=18836
2002-11-19 04:58:22 +00:00
dbcfcb84f3 Remove check for gtk_main_level(). as far as i can tell it serves no real
2002-11-18  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (create_composer): Remove check for
        gtk_main_level().  as far as i can tell it serves no real purpose,
        and i think gtkmain is now redundant.
        (e_msg_composer_new_with_message): Same here.
        (destroy): moved some stuff into finalise, and made destroy
        mulitcall safe.

svn path=/trunk/; revision=18819
2002-11-18 11:19:30 +00:00
d0aff59f86 Removed {BEGIN,END}_GNOME_DECLS.
* listener.h: Removed {BEGIN,END}_GNOME_DECLS.

* e-msg-composer-select-file.c: Do not #include
<libgnome/gnome-defs.h>.
* e-msg-composer.c: Likewise.
* listener.h: Likewise.

svn path=/trunk/; revision=18738
2002-11-13 16:46:43 +00:00
316e12adf3 bonobo api changes.
2002-11-13  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (setup_ui): bonobo api changes.

svn path=/trunk/; revision=18733
2002-11-13 09:39:00 +00:00
234540a383 Fix bonobo object setup.
2002-11-08  Not Zed  <NotZed@Ximian.com>

        * listener.c: Fix bonobo object setup.

        * e-msg-composer-hdrs.c: Remove oaf stuff, fix destroy to be
        multi-call safe.

        * e-msg-composer-attachment.c (e_msg_composer_attachment_new):
        Remove utf8 from locale conversions, & glib api changes.
        (ok_cb): "

        * e-msg-composer-attachment-bar.c (add_from_file): gtk message
        dialog.
        (pixbuf_for_mime_type): glib,gnome-vfs api changes.
        (init): Estimate the icon_height based on the pango font
        description size, this is probably not correct.
        (properties_cb):
        (remove_cb): Changed signature for gnomeui callbacks.
        (popup_icon_context_menu):
        (popup_context_menu): popup_menu api change
        (destroy): Protect from multiple calls.
        (e_msg_composer_attachment_bar_new): Remove push/pop
        visual/colormap stuff.

        * composer-marshal.list: The list of marshallers used by the
        composer.

        * Makefile.am (composer-marshal.h): Added composer marshal builder.

        * evolution-composer.c (class_init): bonobo object epv setup change.
        (factory_fn): Fix changes to factory callback.

        * e-icon-list.c: (icon_get_height): Use bounding box to calc
        height.
        (icon_event): drop gtk_selection_extended.
        (e_icon_list_remove): "
        (select_icon):
        (unselect_icon): "

        * e-msg-composer.c (autosave_save_draft): Dup fd rather than poke
        camel_stream_fd's data.  Also, use camel_stream_close() rather
        than flush.
        (autosave_manager_query_load_orphans): Port to gtk dialog.
        (autosave_query_cb): Removed, redundant.
        (save): Port to gtkdialog.
        (prepare_engine): Fix bonobo-object-client code.
        (get_file_content): gtk dialog
        (do_exit): gtk dialog.
        (setup_signatures_menu): dump gtkutf8 stuff.
        (marshal_NONE__NONE_INT): What WAS jeff thinking?  Removed :)
        (class_init): g object setup.
        (e_msg_composer_get_type): "
        (create_composer): remove bonobo_window_construct, use create
        property instead.  g_signal stuff.  bonobo stuff.
        (is_special_header): Use ascii_strncasecmp
        (e_msg_composer_set_pending_body): gtk->g_object_get/set_data.
        (e_msg_composer_set_body): use ascii_strncasecmp
        (e_msg_composer_add_inline_image_from_mime_part): make cid const.
        (autosave_manager_register):
        (autosave_manager_unregister): Use g_path_get_basename() & account
        for differences.
        (composer_shutdown): rename to finalise/etc.
        (class_init): Use object:finalize instead of shutdown.
        (e_msg_composer_set_body): Use _() rather than U_().
        (build_message): gtk dialog.

2002-11-06  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (pixbuf_for_mime_type): Add
        error return to gdk_pixbuf_new_from_file().

svn path=/trunk/; revision=18659
2002-11-08 06:49:14 +00:00
9e8d970488 Add support for an attach option in the mailto: url.
2002-11-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): Add support for
	an attach option in the mailto: url.

svn path=/trunk/; revision=18489
2002-11-01 20:26:54 +00:00
f3b55ed92d Make sure to save References and In-Reply-To headers. Fixes bug #32932.
2002-10-29  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_with_message): Make sure to
	save References and In-Reply-To headers. Fixes bug #32932.

svn path=/trunk/; revision=18469
2002-10-30 19:47:20 +00:00
a57815af6b Don't create a new file if the file doesn't exist.
2002-10-02  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (get_file_content): Don't create a new file if
	the file doesn't exist.

svn path=/trunk/; revision=18325
2002-10-04 18:10:44 +00:00
ebbafa91b4 If the user hits cancel when signing/encrypting, don't continue
2002-10-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): If the user hits cancel when
	signing/encrypting, don't continue constructing the message,
	instead abort (and just don't pop up a dialog).

svn path=/trunk/; revision=18291
2002-10-01 21:30:15 +00:00
8427b2c852 When signing/encrypting a part, if a USER_CANCEL occurs, re-use the part
2002-10-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): When signing/encrypting a
	part, if a USER_CANCEL occurs, re-use the part otherwise unref it
	and replace it with the new part.

svn path=/trunk/; revision=18290
2002-10-01 21:21:03 +00:00
43dfa91e96 It's a grand old string-review! Nitpicky and minor changes; details in the appropriate ChangeLog files.
svn path=/trunk/; revision=18268
2002-09-30 20:11:15 +00:00
bb3273ae2f Don't reuse the part that we've signed and/or encrypted, create a new part
2002-09-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (build_message): Don't reuse the part that
	we've signed and/or encrypted, create a new part container
	instead. Fixes bug #31379.

svn path=/trunk/; revision=18257
2002-09-28 02:45:50 +00:00
eda4e47a7d Fix non-ANSI switch statement
* e-msg-composer.c (save): Fix non-ANSI switch statement

svn path=/trunk/; revision=18159
2002-09-23 01:36:56 +00:00
3a8fd4e95b allow to select last 2 menu items
2002-09-19  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (signature_cb): allow to select last 2 menu
	items

svn path=/trunk/; revision=18128
2002-09-19 21:27:21 +00:00
85d6c111af Handle multipart/signed and multipart/encrypted parts in a more expected
2002-09-17  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (add_attachments_from_multipart): Handle
	multipart/signed and multipart/encrypted parts in a more expected
	way. Fixes bug #28453.

svn path=/trunk/; revision=18099
2002-09-17 21:27:23 +00:00
a29fc1746b Mark a string for translation.
2002-09-15  Kjartan Maraas  <kmaraas@gnome.org>

	* e-msg-composer.c: Mark a string for translation.

svn path=/trunk/; revision=18072
2002-09-15 23:28:24 +00:00
1fa08a33f8 (composer_key_pressed): Don't chain the event
handler here -- that's just wrong!  Also stop emission of the
signal when we catch Escape.

svn path=/trunk/; revision=17987
2002-09-05 17:29:14 +00:00
f92642ab4f Make it so that the composer will close when the user hits Escape.
2002-09-04  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (create_composer): Make it so that the composer
	will close when the user hits Escape.

svn path=/trunk/; revision=17983
2002-09-04 23:53:00 +00:00
3e580fc532 removed "Set as default" menu item
2002-08-27  Radek Doulik  <rodo@ximian.com>

	* e-msg-composer.c (signature_cb): removed "Set as default" menu
item

svn path=/trunk/; revision=17878
2002-08-27 18:27:14 +00:00
70e176f79d Oops, we were overwriting 'multipart' with our child multipart. Fixes
2002-08-26  Peter Williams  <peterw@ximian.com>

	* e-msg-composer.c (handle_multipart): Oops, we were overwriting
	'multipart' with our child multipart. Fixes 29399.
	(handle_multipart_alternative): Here too.

svn path=/trunk/; revision=17864
2002-08-26 18:34:12 +00:00
b0e603fa0f Fixes bug #29016
2002-08-22  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes bug #29016

	* e-msg-composer.c (e_msg_composer_new_with_message): If the
	X-Evolution-PostTo header exists, then treat this message composer
	as a PostTo composer rather than a mail composer.

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_to_message_internal):
	Set the X-Evolution-PostTo header if that is the mdoe we are in.

svn path=/trunk/; revision=17843
2002-08-22 22:04:36 +00:00
419fb428ad Don't turn on pgp signing if this is an iMIP message and pgp_no_imip_sign
* e-msg-composer.c (from_changed_cb): Don't turn on pgp signing if
	this is an iMIP message and pgp_no_imip_sign is set.
	(e_msg_composer_set_body): If setting a text/calendar body and
	pgp_no_imip_sign is true, turn off signing.

svn path=/trunk/; revision=17779
2002-08-15 13:16:26 +00:00
953f044bac Make the warning dialog display the message subject so that it is more
2002-08-13  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (do_exit): Make the warning dialog display the
	message subject so that it is more clear which composer the dialog
	is referring to. Fixes bug #25467.

svn path=/trunk/; revision=17772
2002-08-13 20:57:04 +00:00
0e39518ba7 Set the file-selection window icon. Fixes the mailer part of bug #7368.
2002-08-12  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-select-file.c (create_file_selection): Set the
	file-selection window icon. Fixes the mailer part of bug #7368.

	* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
	Don't call new_from_mime_part() since that function now does some
	copying of the mime part rather than simply reffing it.
	(e_msg_composer_attachment_new_from_mime_part): Make a copy of the
	MIME part so that if the message that this part belongs to gets
	deleted from the the remote store, the composer will still have a
	copy of it. Fixes bug #20308.

svn path=/trunk/; revision=17763
2002-08-12 21:00:58 +00:00
7f6f1b6844 Parse the auto-cc/bcc recipients and then later when parsing the cc/bcc
2002-07-31  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_with_message): Parse the
	auto-cc/bcc recipients and then later when parsing the cc/bcc
	recipients into EDestination objects, if the address is an
	auto-*cc address, then set auto_recipient to TRUE on that
	EDestination. This fixes bug #28339.

svn path=/trunk/; revision=17664
2002-07-31 23:26:30 +00:00