2003-09-24 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (get_default_charset): Same as
below.
* e-msg-composer.c (composer_get_default_charset_setting): Handle
empty-string as the charset value gotten from gconf as this can
happen. Partial fix for bug #47638.
svn path=/trunk/; revision=22692
2003-09-13 Charles Zhang <charles.zhang@sun.com>
* e-msg-composer-attachment-bar.c (remove_attachment): Add some
assertion. Send Close response signal to the properties dialog
while removeing an attachment.
* e-msg-composer-attachment-bar.c (remove_selected): Fix a re-
remove-attachment bug. [#48466]
svn path=/trunk/; revision=22656
2003-08-25 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c: updated for namespace changed
made to camel-mime-utils.[c,h]
* e-msg-composer-attachment.c: updated for namespace changed made
to camel-mime-utils.[c,h]
* e-msg-composer.c: updated for namespace changed made to
camel-mime-utils.[c,h]
svn path=/trunk/; revision=22356
2003-08-13 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (update): This needs to use
camel_data_wrapper_decode_to_stream() rather than
write_to_stream(). Also simplify a bit - no sense looping to load
the pixbuf data into the gdk-pixbuf loader 4K at a time when we
have the whole thing in a memory buffer already. Once done, unref
the stream instead of closing it so we don't leak.
(attach_to_multipart): Use decode_to_stream().
* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
Avoid constructing thwe data-wrapper from the stream twice for
message/rfc822 parts.
svn path=/trunk/; revision=22213
2003-07-16 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (attach_to_multipart): don't set
the rawtext bit anymore.
* e-msg-composer.c (build_message): Convert the plain part's
content stream from UTF-8 to whatever charset we want.
svn path=/trunk/; revision=22172
2003-07-16 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (attach_to_multipart): don't set
the rawtext bit anymore.
* e-msg-composer.c (build_message): Convert the plain part's
content stream from UTF-8 to whatever charset we want.
2003-07-16 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (popup_menu_event): Fix warnings
and other breakage introduced by Maxx.
svn path=/trunk/; revision=21843
2002-07-14 Maxx Cao <maxx.cao@sun.com>
** For bug #45826
* e-msg-composer-attachment-bar.c (class_init): connect the
"popup_menu" signal, so that S-F10 keybinding will work.
(popup_menu_event): funcion added to handle "popup_menu" (S-F10 key).
(popup_menu_placement_callback): function added to place the popup
menu to the center of attachment icon, in case it is activated by
keyboard.
svn path=/trunk/; revision=21812
2003-05-21 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (composer_get_default_charset_setting): Same as
the rest.
(setup_ui): We didn't even seem to be using the gconf client
here. Removed.
(e_msg_composer_load_config): Unref the gconf client after we're
finished.
(e_msg_composer_new): Same.
(e_msg_composer_new_post): Here too.
(e_msg_composer_set_view_from): And here.
(e_msg_composer_set_view_replyto): And here.
(e_msg_composer_set_view_cc): Here too.
(e_msg_composer_set_view_bcc): Again here.
* e-msg-composer-hdrs.c (create_from_optionmenu): Same as below.
(e_msg_composer_hdrs_set_from_account): Here too.
* e-msg-composer-attachment-bar.c (get_default_charset): Unref the
gconf client.
svn path=/trunk/; revision=21391
2003-04-25 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (pixbuf_for_mime_type): If we
fail to load the icon that gnome_vfs_get_icon() gave us, the
default back to gnome-unknown.png. This is the only POSSIBLE way
for Anna to be getting a NULL pixbuf if she has gnome-unknown.png
that I can see. Should fix bug #41513.
svn path=/trunk/; revision=20982
2003-04-09 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (composer_get_default_charset_setting): Use
e_iconv_locale_charset() instead of e_iconv_locale_name(), dunno
what I was thinking. locale_name() doesn't even exist.
* e-msg-composer-attachment-bar.c (get_default_charset): Same.
svn path=/trunk/; revision=20793
2003-04-09 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (composer_get_default_charset_setting): Same as
with attachment-bar's get_default_charset().
(setup_ui): Instead of pulling the default charset from gconf,
call our helper function above.
* e-msg-composer-attachment-bar.c (get_default_charset): If gconf
returns a NULL string, default back to the locale charset.
svn path=/trunk/; revision=20775
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c: Use GnomeIconList instead of
EIconList so we don't have to maintain an exact copy/paste of
GnomeIconList ourselves. I don't udnerstand why we ever did.
* e-icon-list.[c,h]: Removed.
svn path=/trunk/; revision=20251
2003-02-25 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c: Same as below.
* e-msg-composer-attachment-bar.c: Go back to using
e_iconv_charset_name().
svn path=/trunk/; revision=20059
2003-02-20 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (composer_get_default_charset_setting): Same as
below.
* e-msg-composer-attachment-bar.c (get_default_charset): Use
camel_charset_canonical_name() rather than e_iconv_charset_name()
as the latter will be removed shortly.
svn path=/trunk/; revision=19979
2002-11-25 Not Zed <NotZed@Ximian.com>
* e-msg-composer-attachment-bar.c (init): Remove the window size
setting.
(e_msg_composer_attachment_bar_new): Move the window size setting
here. Also set icon width based on 15 approximate characters, so
the icon text is more readable.
svn path=/trunk/; revision=18906
2002-11-22 Not Zed <NotZed@Ximian.com>
* e-msg-composer-select-file.c: rewrote most of this. Just use
gtkfileselection directly, no e-file-selector, much
smaller/simpler.
2002-11-21 Not Zed <NotZed@Ximian.com>
* e-msg-composer-attachment-bar.c (remove_attachment): fix
g_signal_emit params, detail in wrong spot.
(add_common): Same.
* e-icon-list.c (icon_new_from_pixbuf): remove the
'use_broken_event_handling' set.
(emit_select): Add detail to signal emit.
(text_changed): Same.
* e-msg-composer.c (subject_changed_cb): Duh! dont free subject &
simplify logic a little.
svn path=/trunk/; revision=18904
2002-11-19 Not Zed <NotZed@Ximian.com>
* e-msg-composer-attachment-bar.c (add_from_file): dont unref
after destroy. duh.
* e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_to): Add type
code to set_property call.
(e_msg_composer_hdrs_set_cc): "
(e_msg_composer_hdrs_set_bcc): "
(e_msg_composer_hdrs_get_to): Do the same for get_property calls.
(init): ref/sink the tooltip object.
(e_msg_composer_hdrs_get_type): fix return type.
* e-msg-composer.c (GNOME_GTKHTML_EDITOR_CONTROL_ID): we want
version 3.0 not 1.1.
(create_composer): Add type code to set property call.
(autosave_manager_query_load_orphans): my bad, we dont unref
dialog's once we've destroyed 'em.
(build_message): "
(get_file_content): "
(save): "
(do_exit): "
(composer_dispose): moved the autosave shutdown here.
svn path=/trunk/; revision=18836
2002-11-11 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c: Remove some unused ehaders and
ones that cause compilation failures (such as gnome-defs.h).
* e-icon-list.h: Same.
svn path=/trunk/; revision=18694
2002-11-08 Not Zed <NotZed@Ximian.com>
* listener.c: Fix bonobo object setup.
* e-msg-composer-hdrs.c: Remove oaf stuff, fix destroy to be
multi-call safe.
* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
Remove utf8 from locale conversions, & glib api changes.
(ok_cb): "
* e-msg-composer-attachment-bar.c (add_from_file): gtk message
dialog.
(pixbuf_for_mime_type): glib,gnome-vfs api changes.
(init): Estimate the icon_height based on the pango font
description size, this is probably not correct.
(properties_cb):
(remove_cb): Changed signature for gnomeui callbacks.
(popup_icon_context_menu):
(popup_context_menu): popup_menu api change
(destroy): Protect from multiple calls.
(e_msg_composer_attachment_bar_new): Remove push/pop
visual/colormap stuff.
* composer-marshal.list: The list of marshallers used by the
composer.
* Makefile.am (composer-marshal.h): Added composer marshal builder.
* evolution-composer.c (class_init): bonobo object epv setup change.
(factory_fn): Fix changes to factory callback.
* e-icon-list.c: (icon_get_height): Use bounding box to calc
height.
(icon_event): drop gtk_selection_extended.
(e_icon_list_remove): "
(select_icon):
(unselect_icon): "
* e-msg-composer.c (autosave_save_draft): Dup fd rather than poke
camel_stream_fd's data. Also, use camel_stream_close() rather
than flush.
(autosave_manager_query_load_orphans): Port to gtk dialog.
(autosave_query_cb): Removed, redundant.
(save): Port to gtkdialog.
(prepare_engine): Fix bonobo-object-client code.
(get_file_content): gtk dialog
(do_exit): gtk dialog.
(setup_signatures_menu): dump gtkutf8 stuff.
(marshal_NONE__NONE_INT): What WAS jeff thinking? Removed :)
(class_init): g object setup.
(e_msg_composer_get_type): "
(create_composer): remove bonobo_window_construct, use create
property instead. g_signal stuff. bonobo stuff.
(is_special_header): Use ascii_strncasecmp
(e_msg_composer_set_pending_body): gtk->g_object_get/set_data.
(e_msg_composer_set_body): use ascii_strncasecmp
(e_msg_composer_add_inline_image_from_mime_part): make cid const.
(autosave_manager_register):
(autosave_manager_unregister): Use g_path_get_basename() & account
for differences.
(composer_shutdown): rename to finalise/etc.
(class_init): Use object:finalize instead of shutdown.
(e_msg_composer_set_body): Use _() rather than U_().
(build_message): gtk dialog.
2002-11-06 Not Zed <NotZed@Ximian.com>
* e-msg-composer-attachment-bar.c (pixbuf_for_mime_type): Add
error return to gdk_pixbuf_new_from_file().
svn path=/trunk/; revision=18659
2002-10-26 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (attach_to_multipart): Don't set
the charset param on text parts nor tha rawtext bit on the content
if a charset for the part is already specified.
svn path=/trunk/; revision=18449
instead of the empty string if the size is less than one K.
(update): Only put the size if size_to_string() doesn't return
NULL. [#32751]
svn path=/trunk/; revision=18439
2002-10-04 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (attach_to_multipart): Set
content->rawtext to TRUE for text parts because the content is in
its raw form (since we didn't know the charset when we created
it). Also only write out the content-object to discover the best
encoding, we don't want to include the headers of the MIME
part. Second half of the fix for bug #31655.
svn path=/trunk/; revision=18335
* e-icon-list.c (icon_new_from_pixbuf): Removed a #warning.
* e-msg-composer-attachment-bar.c (size_to_string): Don't use dots
here so we don't get funny wrapping from GnomeIconList. [#236]
svn path=/trunk/; revision=18176
2002-08-12 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-select-file.c (create_file_selection): Set the
file-selection window icon. Fixes the mailer part of bug #7368.
* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
Don't call new_from_mime_part() since that function now does some
copying of the mime part rather than simply reffing it.
(e_msg_composer_attachment_new_from_mime_part): Make a copy of the
MIME part so that if the message that this part belongs to gets
deleted from the the remote store, the composer will still have a
copy of it. Fixes bug #20308.
svn path=/trunk/; revision=17763
* e-msg-composer-attachment-bar.c (pixbuf_for_mime_type):
Special-case message/digest and give it a nice icon. [#9786]
* Makefile.am (INCLUDES): Add -D for EVOLUTION_ICONSDIR.
svn path=/trunk/; revision=17609
2002-04-16 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-hdrs.c (destroy): Unref the priv->tooltips object
here.
* e-msg-composer-attachment-bar.c (destroy): Free the priv struct.
* e-msg-composer.c (set_editor_signature): We don't need a 'name'?
So don't strdup it.
svn path=/trunk/; revision=16485
001-12-11 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment.c (e_msg_composer_attachment_edit):
Attach to the parent widget's destroy signal - when that gets
destroyed, we need to cancel the editor dialog too. Also connect
to our parent window's "hide" signal so that when the composer
gets hidden (ie, it's being sent), we also close the dialogs.
* e-msg-composer.c (init): Default composer->enable_autosave to
TRUE.
svn path=/trunk/; revision=15016
2001-12-10 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (add_from_user):
select_file_attachments now returns a GPtrArray so handle that and
loop until we've added all the attachment files.
* e-msg-composer-select-file.c (confirm): Add an evil kludge to
get a list of filenames from the GtkFileSelection widget based on
the label in the history option menu item and the base filenames
of the selected items in the filename clist.
(create_file_selection): Setup the clist to allow multiple
selection.
(file_selection_info_destroy_notify): Destroy the GPtrArray
containing the list of xselected files.
(select_file_internal): Return a GPtrArray of files instead of a
char *.
svn path=/trunk/; revision=14968
attachments. Also, I think this should make replies to HTML
messages containing inline images referenced via Content-Location
work, but that's not tested.
* e-msg-composer.c (various): Keep two hash tables of inline image
data: one mapping from cid: URLs to CamelMimeParts for all
attachments, the other mapping from file: and Content-Location
urls to CamelMimeParts (for those inline images that came from a
file or have a Content-Location).
(add_inlined_images): Simplify. Most of this code is in
e_msg_composer_add_inline_image_from_file() now.
(e_msg_composer_add_message_attachments, handle_multipart): Change
"attach_all" arg to "just_inlines". If it is set, call
e_msg_composer_add_inline_image_from_mime_part on any attachment
with a Content-Id or Content-Location.
(e_msg_composer_add_inline_image_from_file): Create a mime part
from a file and add it to the inline images hash.
(e_msg_composer_add_inline_image_from_mime_part): Add a mime part
directly to the inline images hash.
* listener.c (resolve_image_url): If asked to resolve a file: URL
that isn't in the inline images hash, call
e_msg_composer_add_inline_image_from_file to get a cid for it.
(impl_event): Look up the URL in the inline_images and
inline_images_by_url hashes.
* e-msg-composer-attachment-bar.c
(e_msg_composer_attachment_bar_find_message): Gone. No longer
used.
svn path=/trunk/; revision=13852
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer.c (best_encoding): Don't use a
g_return_val_if_fail after iconv_open, this is a valid error
condition and so should use check it for real.
* e-msg-composer-attachment-bar.c (attach_to_multipart): Correctly
set the charset parameter and use camel's bestenc filter to
determine which content transfer encoding to use.
svn path=/trunk/; revision=13784
2001-10-09 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (add_from_file): If the
attachment fails, report the error to the user.
* e-msg-composer-attachment.c (e_msg_composer_attachment_new): Now
takes a CamelException argument.
svn path=/trunk/; revision=13537
2001-10-05 Larry Ewing <lewing@ximian.com>
* e-msg-composer-attachment.c (e_msg_composer_attachment_new):
remove unused variable.
* e-msg-composer-attachment-bar.c
(e_msg_composer_attachment_bar_find_message): generalize this to
lookup content locations as well.
* e-msg-composer-attachment-bar.h: change prototype to match the
new function.
* listener.c (impl_event): handle the url_requested event, look up
parts in the attachment part and feed them down the stream if it
is found.
* e-msg-composer.c (handle_multipart_alternative): delay setting
the body text.
(handle_multipart): delay setting body text
(e_msg_composer_new_with_message): set the body text from the
object data. Doing this ensures that we will have the attachments
processed before we try to look them up.
svn path=/trunk/; revision=13445
2001-10-04 Larry Ewing <lewing@ximian.com>
* e-msg-composer-attachment-bar.c
(e_msg_composer_attachment_bar_find_content_id): look up an
attachment by it's content id.
* e-msg-composer-attachment-bar.h: add prototype for
e_msg_composer_attachment_bar_find_content_id.
svn path=/trunk/; revision=13436
2001-07-02 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c (attach_to_multipart): Set the
user-chosen charset.
* e-msg-composer.c (menu_change_charset_cb): New callback function
to get the user-set charset.
(init): Set the charset to NULL.
(best_charset): Take a default_charset param that holds the value
the user set for this particular message using the menu.
(destroy): Free the charset.
svn path=/trunk/; revision=10704