Commit Graph

245 Commits

Author SHA1 Message Date
64977cb1bc Massive code cleanup (bug #429422)
svn path=/trunk/; revision=33432
2007-04-19 18:53:33 +00:00
cba3097cad ** Fixes bug #419524
2007-03-20  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #419524

	* Include <glib/gi18n.h> instead of <libgnome/gnome-i18n.h>.

	* e-util/e-xml-utils.c (e_xml_get_child_by_name_by_lang_list):
	* mail/em-migrate.c (emm_setup_initial):
	* shell/e-component-registry.c (query_components):
	* shell/e-shell-settings-dialog.c (load_pages):
	* shell/e-shell-window-commands.c (command_quick_reference):
	* tools/killev.c (main):
	Use g_get_language_names() instead of gnome_i18n_get_language_list().

	* e-util/e-util.c: Remove e_gettext().

	* e-util/Makefile.am: Remove e-i18n.h.


svn path=/trunk/; revision=33319
2007-03-20 17:23:58 +00:00
433790881e Fixes bug #381642.
2006-12-04  Harish Krishnaswamy  <kharish@novell.com>

	* e-table.c: (canvas_vbox_event), (click_to_add_event):
	Fixes bug #381642.

svn path=/trunk/; revision=33043
2006-12-04 14:09:54 +00:00
7a205fe6d0 ** Fixes bug #352450
2006-08-23  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #352450

	* misc/e-canvas-background.c:
	* misc/e-cursors.c:
	* misc/e-map.c:
	* misc/e-reflow.c:
	* misc/e-task-widget.c:
	* misc/gal-combo-box.c:
	* table/e-cell-text.c:
	* table/e-cell-toggle.c:
	* table/e-table-field-chooser-item.c:
	* table/e-table-field-chooser.c:
	* table/e-table-header-item.c:
	* table/e-table-header-utils.c:
	* table/e-table-item.c:
	* table/e-table.c:
	* table/e-tree-memory.c:
	* table/e-tree-sorted.c:
	* table/e-tree.c:
	* table/e-text.c:
	Replace deprecated GLib and GDK function calls.

svn path=/trunk/; revision=32783
2006-09-18 13:06:49 +00:00
4a4b322c39 Tons of cleanups of the following sort: - remove unused vars - remove
2006-01-30  Kjartan Maraas  <kmaraas@gnome.org>

	* e-timezone-dialog/e-timezone-dialog.c: (get_zone_from_point):
	* menus/gal-view-menus.c:
	* misc/e-attachment-bar.c: (calculate_height_width),
	(update_remote_file), (e_attachment_bar_get_attachment),
	(class_init):
	* misc/e-attachment.c: (async_progress_update_cb),
	(download_to_local_path):
	* misc/e-calendar-item.c: (e_calendar_item_get_arg),
	(e_calendar_item_realize), (e_calendar_item_ensure_days_visible):
	* misc/e-calendar.c: (e_calendar_drag_motion),
	(e_calendar_drag_leave), (e_calendar_focus):
	* misc/e-canvas-background.c: (ecb_get_property):
	* misc/e-canvas.c: (e_canvas_class_init), (pick_current_item):
	* misc/e-cell-date-edit.c: (e_cell_date_edit_do_popup),
	(e_cell_date_edit_show_popup):
	* misc/e-cell-percent.c:
	* misc/e-charset-picker.c: (e_charset_picker_bonobo_ui_populate):
	* misc/e-config-page.c: (e_config_page_class_init):
	* misc/e-dateedit.c: (e_date_edit_set_date),
	(e_date_edit_set_date_and_time_of_day),
	(on_date_popup_date_selected):
	* misc/e-dropdown-button.c: (e_dropdown_button_class_init):
	* misc/e-expander.c: (get_expander_bounds), (e_expander_expose),
	(is_in_expander_panel):
	* misc/e-filter-bar.c: (option_changed), (build_items):
	* misc/e-image-chooser.c: (e_image_chooser_init),
	(image_drag_data_received_cb):
	* misc/e-map.c: (e_map_size_allocate), (e_map_button_press),
	(e_map_button_release), (e_map_motion), (e_map_zoom_to_location),
	(e_map_zoom_out), (update_render_point), (repaint_point),
	(zoom_in_smooth):
	* misc/e-multi-config-dialog.c: (impl_response):
	* misc/e-reflow.c: (e_reflow_realize), (e_reflow_event):
	* misc/e-search-bar.c: (clear_search), (search_now_verb_cb),
	(entry_activated_cb), (activate_button_clicked_cb),
	(clear_button_clicked_cb):
	* misc/e-selection-model.c: (e_selection_model_key_press):
	* misc/e-send-options.c: (delay_until_date_changed_cb),
	(e_sendoptions_get_need_general_options):
	* misc/e-unicode.c: (e_stripped_char):
	* table/e-cell-progress.c: (eprog_draw_border), (eprog_draw),
	(eprog_event):
	* table/e-cell-spin-button.c: (ecsb_event), (ecsb_focus),
	(ecsb_unfocus), (ecsb_dispose):
	* table/e-cell-text.c: (ect_draw), (ect_show_tooltip):
	* table/e-cell-toggle.c: (etog_draw), (etog_event):
	* table/e-cell-tree.c: (ect_max_width):
	* table/e-cell-vbox.c:
	* table/e-table-click-to-add.c: (etcta_event):
	* table/e-table-config.c: (create_global_store):
	* table/e-table-field-chooser-dialog.c:
	* table/e-table-field-chooser-item.c: (etfci_find_button),
	(etfci_reflow), (etfci_get_property), (etfci_realize):
	* table/e-table-field-chooser.c:
	(e_table_field_chooser_class_init):
	* table/e-table-group-container.c: (etgc_unrealize):
	* table/e-table-group.c: (e_table_group_new):
	* table/e-table-header-item.c: (e_table_header_item_get_height),
	(ethi_realize), (ethi_event):
	* table/e-table-header-utils.c: (e_table_draw_elided_string),
	(e_table_header_draw_button):
	* table/e-table-item.c: (eti_set_property), (eti_get_property),
	(eti_draw), (eti_event), (eti_cursor_change):
	* table/e-table-scrolled.c: (e_table_scrolled_class_init):
	* table/e-table-search.c:
	* table/e-table-sort-info.c: (e_table_sort_info_save_to_node):
	* table/e-table.c: (table_canvas_reflow_idle),
	(table_canvas_size_allocate), (canvas_vbox_event),
	(click_to_add_event), (do_drag_motion), (e_table_class_init):
	* table/e-tree-scrolled.c: (e_tree_scrolled_class_init):
	* table/e-tree.c: (tree_canvas_reflow_idle),
	(tree_canvas_size_allocate), (e_tree_drag_get_data),
	(do_drag_motion), (e_tree_class_init):
	* text/e-text.c: (e_text_set_property), (e_text_draw),
	(_do_tooltip), (primary_clear_cb), (_get_position),
	(e_text_command): Tons of cleanups of the following sort:
	- remove unused vars
	- remove extraneous semi-colons
	- add some comments where assignments were done without using
	  the results later
	- remove break; statements after return foo;
	- add casts in some places to be more type correct
	- rename variables with name clashes
	- s/if/ifdef in some cases
	- mark some code static
	- remove some unused functions
	- use guint for 1-bit bitfields

svn path=/trunk/; revision=31371
2006-01-30 12:28:21 +00:00
2b1cf9db64 fixed one typo. Fixes bug 306118 partially.
2005-12-23  Andre Klapper <a9016009@gmx.de>
	* e-table.c: fixed one typo.
          Fixes bug 306118 partially.

svn path=/trunk/; revision=30939
2005-12-23 02:43:37 +00:00
a4c6645e87 e-table.c (e_table_load_specification) e-table-specification.c
2005-09-29  Tor Lillqvist  <tml@novell.com>

	* e-table.c (e_table_load_specification)
	* e-table-specification.c (e_table_specification_load_from_file)
	* e-tree-table-adapter.c (open_file): Use
	g_win32_locale_filename_from_utf8() from GLib 2.8 instead of
	gnome_win32_locale_filename_from_utf8() which was temporarily in
	libgnome.

svn path=/trunk/; revision=30421
2005-09-29 18:00:17 +00:00
df07f02cae Added widgets in INCLUDES.
2005-06-23  Kaushal Kumar  <kakumar@novell.com>

        * e-util/Makefile.am, widgets/e-timezone-dialog/Makefile.am,
        addressbook/gui/search/Makefile.am,
        plugins/groupwise-features/Makefile.am: Added widgets in INCLUDES.

        Updated the include paths to use misc instead of widgets/misc.

svn path=/trunk/; revision=29574
2005-06-23 09:11:11 +00:00
27a61acf27 Retired GAL from Head. The relevant files have moved inside evolution.
2005-06-17  Kaushal Kumar  <kakumar@novell.com>

        * Retired GAL from Head. The relevant files have moved inside
        evolution. Thanks to JP Rosevear for performing the cvs surgery. The
        files have been moved in the following order.

        evolution/e-util <- gal/gal/util
        evolution/a11y <-  gal/gal/a11y
        evolution/a11y/e-table <- gal/gal/a11y/e-table
        evolution/a11y/e-text <- gal/gal/a11y/e-text
        evolution/widgets/table <- gal/gal/e-table
        evolution/widgets/text <- gal/gal/e-text
        evolution/widgets/misc <- gal/gal/widgets
        evolution/widgets/misc/pixmaps <- gal/gal/widgets/pixmaps
        evolution/widgets/menus <- gal/gal/menus

        Following is the summary of changes done to fix the build:-
        - New files added to cvs repository,
                - a11y/e-table/Makefile.am
                - a11y/e-text/Makefile.am
                - widgets/table/Makefile.am
                - widgets/text/Makefile.am
                - widgets/misc/pixmaps/Makefile.am
                - iconv-detect.h
                - iconv-detect.c
        - Updated configure.in.
        - Updated all the relevant Makefile.am files.
        - Updated the include paths to replace all gal references.
        - Updated the marshal list to suit gal files requirements.

svn path=/trunk/; revision=29522
2005-06-17 15:20:35 +00:00
a5b8cdfdbe Check for NULL string before passing to dgettext. Fixes a crash on
2005-05-06  Sarfraaz Ahmed <asarfraaz@novell.com>

        * gal/e-table/e-table.c (et_real_construct) : Check for NULL string
        before passing to dgettext. Fixes a crash on Solaris. #260312. Patch
        submitted by Suresh Chandrasekharan <suresh.chandrasekharan@sun.com>

svn path=/trunk/; revision=29280
2005-05-06 04:46:07 +00:00
2decafb544 Port to Windows, initial commit:
2005-04-29  Tor Lillqvist  <tml@novell.com>

	Port to Windows, initial commit:

	* configure.in: Check for Win32, define Automake conditional
	OS_WIN32. Check for regexec() perhaps in separate -lregex, define
	REGEX_LIBS if so. Require glib-2.0 >= 2.6 (and thus also gtk+-2.0
	>= 2.6) so that we can use the gstdio wrappers for full support of
	non-ASCII filenames on Win32. Don't use -D_REENTRANT on Win32, has
	ne special meaning.

	* gal.pc.in: Require gtk+-2.0 >= 2.6 also here for consistency.

	* gal-zip.in: New file, used to build zipfile format distribution
	of gal for Win32.

	* configure.in
	* Makefile.am: Add gal-zip(.in).

	* */Makefile.am
	* */*.c: Harmonize -I and #include conventions. (Of course, this
	hasn't anything to do with Windows porting as such, I just got
	carried away...) Use only -I$(top_srcdir). Use paths to gal
	headers staring with "gal", except for headers from the same
	directory as the .c file, which are included as such. Include all
	gal headers using doublequotes. Sort #includes and remove
	duplicates and obvious redundancies. Include config.h first
	without any HAVE_CONFIG_H, then system headers, then other GNOME
	lib headers, than gal's own headers. Just include gtk.h instead of
	separate gtk*.h headers. Don't include gi18n.h, include e-i18n.h
	to use e_gettext() consistently.

	* gal/Makefile.am: Use -no-undefined on Win32 so that libtool
	agrees to build a shared library. Because of the bidirectional
	dependency between libgal and libgal-a11y we can build libgal-a11y
	sanely as a shared library on Win32, so we don't install any
	separate libgal-a11y at all. So, on Win32, link the stuff that
	goes into libgal-a11y also into libgal. Link with REGEX_LIBS.

	* gal/a11y/Makefile.am: See above. Just build a dummy static
	libgal-a11y on Win32 (can't convince Automake not to build the
	library at all on one platform using Automake ifdef,
	apparently). Then (this is a gross hack) explicitly remove the
	library after installation in the install-data-local rule.

	* gal/e-table/Makefile.am
	* gal/e-table/e-table-config.c: Rename ETABLE_GLADEDIR to
	GAL_GLADEDIR for consistency.

	* gal/e-table/e-cell-date.c: No localtime_r() in Microsoft's C
	library, but its localtime() *is* thread-safe.

	* gal/e-table/e-cell-text.c
	* gal/e-table/e-cell-tree.c
	* gal/e-table/e-cell-vbox.c
	* gal/e-text/e-text.c
	* gal/widgets/e-unicode.c: Remove unnecessary inclusion of gdkx.h.

	* gal/e-table/e-cell-tree.c (ect_realize): Instead of the Xlib
	macro None (whose value is zero), use the corresponding
	zero-valued enums from the appropriate GDK type.

	* gal/e-table/e-table-config.c
	* gal/e-table/e-table-field-chooser.c
	* gal/menus/gal-define-views-dialog.c
	* gal/menus/gal-view-instance-save-as-dialog.c
	* gal/menus/gal-view-new-dialog.c
	* gal/widgets/e-categories-master-list-array.c
	* gal/widgets/e-categories-master-list-dialog.c
	* gal/widgets/e-categories.c: Use g_build_filename() to construct
	pathnames at run-time instead of compile-time. On Windows the
	macros GAL_GLADEDIR and GAL_IMAGESDIR expand to function calls, in
	order to support installing in a freely chosen location.

	* gal/e-table/e-table-item.c
	* gal/e-table/e-cell-vbox.c: Instrad of the Xlib GrabSuccess, use
	GDK_GRAB_SUCCESS (which has the same value).

	* gal/e-table/e-table-specification.c (e_table_specification_load_from_file)
	* gal/e-table/e-table.c (e_table_load_specification)
	* gal/e-table/e-tree-table-adapter.c (open_file)
	* gal/menus/gal-view-instance.c (load_current_view)
	* gal/menus/gal-view-instance.c (load_current_view): On Win32,
	convert filename to the locale character set before passing to
	xmlParseFile() which doesn't use UTF-8 filenames. Use gstdio
	wrappers.

	* gal/util/Makefile.am: Define GAL_PREFIX as $prefix. Define
	GAL_LOCALEDIR, GAL_GLADEDIR and GAL_IMAGESDIR also here for
	e-win32-reloc.c. Include e-win32-reloc.c on Win32.

	* gal/util/e-iconv.c (e_iconv_init): Use g_win32_getlocale() on
	Windows.

	* gal/util/e-util.c
	* gal/util/e-xml-utils.c: Use g_mkstemp() instead of non-portable
	mkstemp(). Use GLib pathname manipulation functions. Use gstdio
	wrappers.

	* gal/util/e-util-private.h: New file. Contains just Win32 bits
	for now that redefine the directory names from the Makefile as
	functions calls.

	* gal/util/e-win32-reloc.c: New file. Contains a minimal DllMain()
	and functions to support freely chosen installation location on
	Windows.

	* gal/util/e-xml-utils.c: No fsync() in the Microsoft C library.

	* gal/windgets/Makefile.am: Add -I$(top_srcdir)/gal for
	consistency with the sibling Makefile.am files.

	* gal/widgets/e-canvas.c: Instead of the Xlib AlreadyGrabbed, use
	GDK_GRAB_ALREADY_GRABBED.

svn path=/trunk/; revision=29249
2005-04-29 14:18:18 +00:00
8b7b24623a Some code clean work.
2005-01-27  Harry Lu <harry.lu@sun.com>

        Some code clean work.

        * e-table-click-to-add.c: (etcta_class_init): move a11y registry
        call to a11y code.
        * e-table.c: (e_table_class_init): ditto.
        * e-tree.c: (e_tree_class_init): ditto.

svn path=/trunk/; revision=28701
2005-02-04 04:49:02 +00:00
d8d481373f add an a11y name for the popup list. make shortcut key ALT+Arrow work.
2005-01-27  Li Yuan  <li.yuan@sun.com>

	* e-cell-combo.c: (e_cell_combo_init), (e_cell_combo_do_popup),
	(e_cell_combo_list_button_press), (e_cell_combo_button_press),
	(e_cell_combo_button_release), (e_cell_combo_key_press):
	add an a11y name for the popup list.
	make shortcut key ALT+Arrow work.
	Fixes #70261
	* e-cell-text.c: (e_cell_text_class_init), (_delete_selection),
	(_insert):
	add "text_inserted" and "text_deleted" signals to notify the
	text has been changed.
	(e_cell_text_get_text_by_view):
	new helper function to get the text being editted.
	* e-cell-text.h:
	add signal declaration.
	* e-cell-toggle.c: (etog_draw):
	add range check for negative values.
	* e-cell-vbox.c: (e_cell_vbox_class_init):
	* e-cell-vbox.h:
	make ECellVboxView public since it will be used in a11y part.
	* e-table-click-to-add.c: (etcta_style_set),
	(create_rect_and_text), (etcta_realize), (etcta_class_init),
	(e_table_click_to_add_commit):
	add "style_set" signal to click_to_add and implement
	the style_set function.
	(etcta_init):
	add a11y name to click to add.
	* e-table-click-to-add.h:
	add "style_set" signal to click_to_add and implement
	the style_set function.
	* e-table-config.c: (config_button_up), (config_button_down):
	check whether the columns are empty.
	* e-table-group-container.c:
	* e-table-group-container.h:
	make ETableGroupContainerChildNode public since it
	will be used in a11y part.
	* e-table-item.c: (eti_init):
	init eti->cols.
	(eti_event):
	at GDK_KEY_PRESS event and GDK_Down key pressed, we check
	view_col value before we pass it to eti_e_cell_event.
	(eti_class_init):
	call the new initialize function
	* e-table.c: (table_canvas_focus_event_cb):
	if canvas has a focused item but the etable does not
	have a cursor row, just focus the first item after check
	whether the click_to_add should get the focus.

svn path=/trunk/; revision=28571
2005-01-27 05:16:19 +00:00
ca14465d46 check whether header_canvas and table_canvas is NULL.
2004-11-24  Li Yuan  <li.yuan@sun.com>

        * e-table.c: (e_table_get_cell_geometry):
        check whether header_canvas and table_canvas is NULL.

svn path=/trunk/; revision=27980
2004-11-24 10:34:55 +00:00
236a904db3 if canvas has a focused item but the etable does not have a cursor row,
2004-11-04  Li Yuan  <li.yuan@sun.com>

        * gal/e-table/e-table.c: (table_canvas_focus_event_cb):
        if canvas has a focused item but the etable does not have a cursor row,
        just focus the first item.

svn path=/trunk/; revision=27828
2004-11-04 02:10:17 +00:00
da657db101 return FALSE so we don't kill the focus event chain
2004-10-19  JP Rosevear  <jpr@novell.com>

	* e-table.c (table_canvas_focus_event_cb): return FALSE so we
	don't kill the focus event chain

svn path=/trunk/; revision=27625
2004-10-19 16:12:32 +00:00
91b30fc6b8 Fixes #51626
2004-04-22  Bruce Tao  <bruce.tao@sun.com>

       Fixes #51626

        * e-table-click-to-add.c: (etcta_event):
       Add an entry for focus_in event, do the same thing as button_press event.

        * e-table-item.c: (eti_event):
       Mask the Ctrl+Tab processing routine.

        * e-table.c: (table_canvas_focus_event_cb), (canvas_vbox_event),
        (click_to_add_event), (e_table_setup_table):
       Enable you to navigate between click_to_add and the existing tasks by
       pressing Ctrl+Tab. However, if there is no existing task, you can still jump
       out of click_to_add by this way.

svn path=/trunk/; revision=25831
2004-05-10 10:13:57 +00:00
6434d2b055 Fixed Bug 51252, 51254, 51255. add some code deal with key press event.
2003-11-23 Andrew Wu <yang.wu@sun.com>

       Fixed Bug 51252, 51254, 51255.
        * gal/e-table/e-table-header-item.c:
        (ethi_event):add some code deal with key press event.
        * gal/e-table/e-table-header-item.h
        add a member "selected_col" for keyboard navigation.
        * gal/e-table/e-table.c
        (e_table_setup_header):make header can focus.

svn path=/trunk/; revision=23572
2003-12-02 07:55:14 +00:00
0517e6655c Support for preedit in e-text widgets.
2003-10-14  Suresh Chandrasekharan  <suresh.chandrasekharan@sun.com>

	* Support for preedit in e-text widgets.

	* gal/gal/e-text/e-text.c: Added e_text_preedit_changed_cb and
	insert_preedit_text.

	* Modified the following functions.
	(e_text_draw) Calls insert_preedit_text also cursor pos @ the end of
	text->selection_start + text->preedit_len

	(e_text_event) Added hooks for preedit_cb
	(e_text_init) Inits text->preedit_len
	(e_text_retrieve_surrounding_cb) Removed printf
	(e_text_delete_surrounding_cb) Correct params for
	gtk_editable_delete_text to make it work.

	* gal/gal/e-text/e-text.h: Added preedit_len in struct _EText


2003-09-25  Suresh Chandrasekharan  <suresh.chandrasekharan@sun.com>

	* Fix for "44222 task summary entry widget not i18ned". The following
	files are changed.

	* gal/gal/e-table/e-cell-text.c: Lots of changes for i18n
	selection/input support. Added these functions for input method support.

	(e_cell_text_preedit_changed_cb)
	(e_cell_text_commit_cb)
	(e_cell_text_retrieve_surrounding_cb)
	(e_cell_text_delete_surrounding_cb)

	(layout_with_preedit) This function inserts the preedit string
	with the right attribs to the layout text.

	(build_attr_list) Creates the PangoAttrList with bold/stikeout/underline
	as applicable for the current ECellText.

	The following functions are modified.

	(ect_stop_editing): disconnect signal handlers when editing stops

	(ect_draw): Changes for including the preedit only to the currently
	selected row/col. Also display the cursor at the end of preedit text.

	(ect_event): Connects the IM callbacks to the key press event.
	Disconnect when not in editing mode. Also a special flag to see
	when Enter key pressed in preedit mode, the text is committed only
	not a new row is created. This woks in conjunction with the changes
	made in the eti_event in e-table-item.c file and e-cell.h.

	(ect_height): Changes due to parameters changing for generate_layout

	(ect_enter_edit): Initialization of im_context for a cell text and
	assoociated flags.

	(ect_max_width):  Changes due to parameters changing for
	generate_layout.

	(ect_max_width_by_row):  Changes due to parameters changing for
	generate_layout.

	(ect_show_tooltip): Changes due to parameters changing for
	generate_layout.

	(e_cell_text_construct): check whether paramters are NULL.

	(get_position_from_xy): Changes due to parameters changing for
	generate_layout.

	(_insert): Set the selection_start as the minimum of strlen(edit->text)
	and selection_start. Used to correct the preedit_string length
	which may have added to the selection_start.

	(e_cell_text_view_command): When inserting, if in the preedit mode
	do not delete the selection.

	(_selection_get): Set utf8 data instead of string data.

	(_selection_received): Take in UTF8_ATOM inaddition to
	GDK_SELECTION_TYPE_STRING.

	(e_cell_text_view_get_selection): Make utf8 data when acting as a
	selection source.

	* gal/e-table/e-cell-text.h : Included <gtk/gtkmenu.h>

	* gal/e-table/e-cell.h: Added enum E_CELL_PREEDIT to ECellFlags

	* gal/e-table/e-table-item.c: (eti_event) Changes for not committing
	the edited text as a seperate row in preedit mode.

	* gal/e-table/e-table.c: (table_canvas_focus_event_cb) To have
	proper im_context focus for the ecanvas holding the e-table.

svn path=/trunk/; revision=22882
2003-10-14 18:20:18 +00:00
227f47b1aa add e-table atk support to libgal a11y add atk registration for
2003-09-05  Gilbert Fang  <gilbert.fang@sun.com>

        * gal/a11y/Makefile.am: add e-table atk support to libgal a11y
        * gal/e-table/e-table.c: (e_table_class_init): add atk registration
        for GalA11yETable (#47780)

svn path=/trunk/; revision=22466
2003-09-05 04:41:40 +00:00
cfacfc319d Initialize some missing fields. Fixes "no handler with id" warnings at evo
* e-tree.c (e_tree_init): Initialize some missing fields. Fixes
        "no handler with id" warnings at evo shutdown
        (ETreePriv): remove unused table_rows_{inserted,deleted}_id
        (et_disconnect_from_etta): remove refs to them

        * e-table.c (e_table_drag_source_unset): free site->target_list if
        it's set.

svn path=/trunk/; revision=21705
2003-07-01 13:16:43 +00:00
f64e3ca963 remove extra ref, the count starts at one.
2003-06-19  Larry Ewing  <lewing@ximian.com>

	* e-table-specification.c (e_table_specification_load_from_node):
	remove extra ref, the count starts at one.

	* e-table-utils.c (e_table_spec_to_full_header): add_column adds a
	reference, so drop the intial reference.

	* e-table.c (et_real_construct):remove extra ref, count starts at
	one.

svn path=/trunk/; revision=21479
2003-06-19 15:31:31 +00:00
16bfd2b973 remove gratuitous ref
2003-05-01  JP Rosevear  <jpr@ximian.com>

	* e-table.c (et_real_construct): remove gratuitous ref

svn path=/trunk/; revision=21041
2003-05-01 18:02:17 +00:00
6c7b3b17ed [ fixes evolution bug #40464 ] use G_SIGNAL_TYPE_STATIC_SCOPE for the
2003-04-19  Chris Toshok  <toshok@ximian.com>

	[ fixes evolution bug #40464 ]
	* e-table.c (e_table_class_init): use G_SIGNAL_TYPE_STATIC_SCOPE
	for the GtkSelectionData args of table_drag_data_get and
	table_drag_data_received.

svn path=/trunk/; revision=20900
2003-04-20 22:08:00 +00:00
8b67c6478d fix UMR.
2003-03-23  Chris Toshok  <toshok@ximian.com>

	* e-table.c (do_drag_motion): fix UMR.

svn path=/trunk/; revision=20469
2003-03-23 09:57:10 +00:00
63aef14c02 i18n fix
2003-03-04  Dmitry Mastrukov  <dmitry@taurussoft.org>

	* gal/widgets/e-unicode.c : i18n fix

2003-03-04  Dmitry Mastrukov  <dmitry@taurussoft.org>

	* e-cell-date.c (ecd_get_text): i18n fix
	* e-table.c (et_real_construct): i18n fix
	* e-table-config.c (create_global_store): i18n fix
	* e-table-utils.c (et_col_spec_to_col): i18n fix

2003-03-04  Mike Kestner  <mkestner@ximian.com>

	* e-tree-selection-model.c : some cursor fixes

svn path=/trunk/; revision=20156
2003-03-04 22:09:44 +00:00
dd2a35e673 remove alloc-based transform (et_drag_data_received): ditto
2003-02-28  Mike Kestner  <mkestner@ximian.com>

	* e-table.c (et_drag_motion): remove alloc-based transform
	(et_drag_data_received): ditto
	(et_drag_drop): ditto
	(do_drag_motion): ditto

svn path=/trunk/; revision=20100
2003-02-28 17:09:42 +00:00
ddc321dd76 remove obvious double g_strdup.
2002-12-16  Chris Toshok  <toshok@ximian.com>

	* e-table.c (et_real_construct): remove obvious double g_strdup.

	* e-table-header-item.c (ethi_header_context_menu): ref/sink the
	popup.

	* e-table-field-chooser.c (e_table_field_chooser_init): use
	gtk_widget_show_all so our custom widget gets displayed.

svn path=/trunk/; revision=19135
2002-12-16 20:43:50 +00:00
200071108f Don't leak old sort info.
2002-12-03  Hans Petter Jansson  <hpj@ximian.com>

        * e-table.c (e_table_get_state_object): Don't leak old sort info.

2002-12-03  Hans Petter Jansson  <hpj@ximian.com>

        * gal/widgets/e-canvas-background.c (ecb_destroy): Don't leak
        private structure.

svn path=/trunk/; revision=18999
2002-12-03 23:09:17 +00:00
a01751b83a check for table->table_canvas == NULL.
2002-11-16  Chris Toshok  <toshok@ximian.com>

	* e-table.c (set_scroll_adjustments): check for
	table->table_canvas == NULL.

	* e-table-item.c (eti_dispose): guard eti->tooltip.

svn path=/trunk/; revision=18807
2002-11-17 05:29:05 +00:00
0bbe38655b GObject port work.
2002-11-16  Chris Toshok  <toshok@ximian.com>

	* e-cell-checkbox.[ch]: GObject port work.

	* e-cell-combo.[ch]: same.

	* e-cell-date.[ch]: same.

	* e-cell-float.[ch]: same.

	* e-cell-number.[ch]: same.

	* e-cell-pixbuf.[ch]: same.

	* e-cell-popup.[ch]: same.

	* e-cell-progress.[ch]: same.

	* e-cell-size.[ch]: same.

	* e-cell-spin-button.[ch]: same.

	* e-cell-text.[ch]: same.

	* e-cell-toggle.[ch]: same.

	* e-cell-tree.[ch]: same.

	* e-cell-vbox.[ch]: same.

	* e-cell.[ch]: same.

	* e-table-col.c: same.

	* e-table-column.c: same.

	* e-table-config-field.[ch]: same.

	* e-table-config.c: same.

	* e-table-config.glade: same.

	* e-table-field-chooser-dialog.[ch]: same.

	* e-table-field-chooser-item.[ch]: same.

	* e-table-field-chooser.[ch]: same.

	* e-table-group-container.[ch]: same.

	* e-table-group-leaf.[ch]: same.

	* e-table-group.[ch]: same.

	* e-table-header-item.[ch]: same.

	* e-table-header-utils.[ch]: same.

	* e-table-header.c: same.

	* e-table-item.[ch]: same.

	* e-table-scrolled.[ch]: same.

	* e-table-utils.c: same.

	* e-table.[ch]: same.

	* e-tree-memory-callbacks.h: same.

	* e-tree-scrolled.[ch]: same.

	* e-tree-sorted-variable.c: same.

	* e-tree.[ch]: same.

	* test-check.c: same.

	* test-cols.c: same.

	* test-table.c: same.

svn path=/trunk/; revision=18801
2002-11-17 00:02:53 +00:00
f60cb1f537 ETableConfig derives from GObject (fix warnings).
2002-11-14  Chris Toshok  <toshok@ximian.com>

	* e-table-header-item.c (ethi_popup_customize_view): ETableConfig
	derives from GObject (fix warnings).

	* e-table.c: deal with ESorter deriving from GObject.

	* e-table-sorter.[ch]: this derives from GObject now.

svn path=/trunk/; revision=18775
2002-11-15 02:49:15 +00:00
b9b2089527 deal with ESelectionModel no longer deriving from GtkObject.
2002-11-14  Chris Toshok  <toshok@ximian.com>

	* e-table-item.c: deal with ESelectionModel no longer deriving
	from GtkObject.

	* e-table.c: same.

	* e-tree.c: same.

	* e-table-config.c (do_fields_config_dialog): use GtkDialog's
	reponse instead of GnomeDialog's button.

	* e-table-click-to-add.[ch]: GObjectify this.

	* e-table-selection-model.[ch]: this derives from GObject now.

	* e-tree-selection-model.[ch]: same.

svn path=/trunk/; revision=18773
2002-11-15 02:22:00 +00:00
d020bcad5c add more marshallers for e-table.
2002-11-13  Chris Toshok  <toshok@ximian.com>

	* gal/util/e-marshal.list: add more marshallers for e-table.

svn path=/trunk/; revision=18750
2002-11-14 01:56:40 +00:00
9b97a17eb7 GObjectify GObjectify GObjectify use GObject api for models use GObject
2002-11-05  Mike Kestner  <mkestner@ximian.com>

	* e-table-col.[ch] : GObjectify
	* e-table-column-specification.[ch] : GObjectify
	* e-table-config.[ch] : GObjectify
	* e-table-group-leaf.c : use GObject api for models
	* e-table-group.c : use GObject api for models
	* e-table-header-item.c : use GObject api for models
	* e-table-header.c : use GObject api for models
	* e-table-selection-model.c : use GObject api for models
	* e-table-sort-info.[ch] : GObjectify
	* e-table-sorted.[ch] : GObjectify
	* e-table-sorter.c : use GObject api for models
	* e-table-specification.c : use GObject api for models
	* e-table-state.[ch] : GObjectify
	* e-table-subset-variable.[ch] : GObjectify
	* e-table-subset.[ch] : GObjectify
	* e-table.c : use GObject api for models

svn path=/trunk/; revision=18571
2002-11-05 22:53:40 +00:00
65269c6882 use GObject api for ETableHeader use GObject api on ETableHeader
2002-11-04  Mike Kestner  <mkestner@ximian.com>

	* e-table-group.c : use GObject api for ETableHeader
	* e-table-header-item.c : use GObject api on ETableHeader
	* e-table-header.[ch] : GObjectify
	* e-table-item.c : use GObject api on ETableHeader
	* e-table-search.[ch] : GObjectify
	* e-table-sorted.c : use GObject api for ETableHeader
	* e-table-sorter.c : use GObject api for ETableHeader
	* e-table-specification.[ch] : GObjectify
	* e-table-utils.c : use GObject api for ETableHeader
	* e-tree-sorted.c : use GObject api for ETableHeader
	* e-tree.c : use GObject api on Header, Spec, and Search

svn path=/trunk/; revision=18531
2002-11-04 16:18:45 +00:00
613453b109 merging the gal-2 branch back to the trunk.
merging the gal-2 branch back to the trunk.

svn path=/trunk/; revision=18471
2002-10-31 21:30:57 +00:00
c480805ecc Set the selection model's selection_mode after setting the table model, or
* e-table.c (et_real_construct): Set the selection model's
	selection_mode after setting the table model, or things will break
	in the GTK_SELECTION_SINGLE case if the table doesn't start out
	empty.

svn path=/trunk/; revision=18121
2002-09-19 18:28:24 +00:00
7cc54f371c And finally here.
2002-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* e-tree-table-adapter.c
	(e_tree_table_adapter_save_expanded_state): And finally here.

	* e-table-state.c (e_table_state_save_to_file): Same here.

	* e-table-specification.c (e_table_specification_save_to_file): No
	need to save to a temp file first here either since
	e_xml_save_file now does that for us.

	* e-table.c (e_table_save_specification): No need to handle
	writing to a temp file first anymore, since I've updated
	e_xml_save_file() to handle that for us.

svn path=/trunk/; revision=17724
2002-08-07 03:37:40 +00:00
71eabe9f8c #include <string.h> for memset
2002-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* e-cell-progress.c: #include <string.h> for memset

	* e-table.c (e_table_save_specification): Updated to use
	e_xml_save_file() instead of xmlSaveFile(). Also fixed to save to
	a tmp file first.

	* e-table-specification.c (e_table_specification_save_to_file):
	Same as above.

	* e-table-state.c (e_table_state_save_to_file): Same here.

	* e-tree-table-adapter.c
	(e_tree_table_adapter_save_expanded_state): And here too.

svn path=/trunk/; revision=17717
2002-08-06 20:31:40 +00:00
150129e103 Patch by clahey.
2002-06-18  JP Rosevear  <jpr@ximian.com>

	Patch by clahey.

	* e-table.c (et_get_arg): get the use_click_to_add value
	(et_set_arg): set the use_click_to_add_value, and either display
	the item or destroy it
	(e_table_class_init): add the use_click_to_add arg

svn path=/trunk/; revision=17218
2002-06-18 15:46:26 +00:00
bfccd5b470 Don't draw or interact with the popup button if a cell isn't editable
2002-06-14  Christopher James Lahey  <clahey@ximian.com>

	* e-cell-popup.c (ecp_draw, ecp_event): Don't draw or interact
	with the popup button if a cell isn't editable (based on a patch
	by JPR.)

	* e-table-col.c, e-table-col.h: Added the compare_col field to
	this structure.  Added a GtkArg to set it.

	* e-table-column-specification.c, e-table-column-specification.h:
	Added the compare_col field here.  Made it load properly from xml.

	* e-table-sorting-utils.c: Sort based on the compare_col in the
	ETableCol instead of the col_idx.

	* e-table-utils.c (et_col_spec_to_col): Set the compare_col field
	in the ETableCol properly.

	* e-table.c, e-table.h: Removed the drag_get_data_row and
	drag_get_data_col fields since they're not used any longer.
	(e_table_construct): If specification loading fails, return a NULL
	ETable instead of just ignoring it.
	(e_table_drag_highlight): Only destroy table->drop_highlight if it
	exists.

svn path=/trunk/; revision=17190
2002-06-14 22:26:43 +00:00
75a1cb19cd Added this function.
2002-06-04  Christopher James Lahey  <clahey@ximian.com>

	* e-table-header.c, e-table-header.h
	(e_table_header_prioritized_column_selected): Added this function.

	* e-table-utils.c, e-table-utils.h
	(e_table_util_calculate_current_search_col): Added this function.

	* e-table.c, e-table.h, e-tree.c: Added a "always_search"
	argument.  If this is off, then searches only occur if there's
	sort.  If it's on, sort takes precendence in doing searches,
	followed by the highest priority column shown.

svn path=/trunk/; revision=17109
2002-06-04 21:24:19 +00:00
cad5e25f86 Added horizontal dividers to this item when in table mode.
2002-05-02  Christopher James Lahey  <clahey@ximian.com>

	* e-table-click-to-add.c: Added horizontal dividers to this item
	when in table mode.

	* e-table.c, e-tree.c: Made the background be an
	e-canvas-background instead of a

	* e-tree.c, e-tree.h: Added a white_space_event for feature parity
	with ETable.

svn path=/trunk/; revision=16667
2002-05-02 18:45:19 +00:00
e1f208de7d Set the gettext-domain here.
2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* gal/e-text/e-completion-view.c (simple_spec),
	gal/widgets/e-categories-master-list-dialog.c (SPEC),
	gal/widgets/e-categories.c (INITIAL_SPEC): Set the gettext-domain
	here.

	* gal/util/e-i18n.h (E_I18N_DOMAIN): #define as makes sense in the
	different cases.

From gal/e-table/ChangeLog:

2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* e-table-config.c, e-table-config.h, e-table-specification.c,
	e-table-specification.h, e-table-utils.c, e-table-utils.h,
	e-table.c, e-table.h: Made these pay attention to the
	gettext-domain in the etspec.

	* e-table-config.c: Set the gettext-domain in the etspec here.

From gal/menus/ChangeLog:

2002-05-01  Christopher James Lahey  <clahey@ximian.com>

	* gal-define-views-dialog.c (SPEC),
	gal-view-instance-save-as-dialog.c (SPEC): Set the gettext-domain
	here.

svn path=/trunk/; revision=16658
2002-05-01 23:26:42 +00:00
b036c8392d Ansification patch from danw.
2002-04-25  Christopher James Lahey  <clahey@ximian.com>

	* e-cell-checkbox.c, e-cell-combo.c, e-cell-date.c,
	e-cell-float.c, e-cell-number.c, e-cell-pixbuf.c, e-cell-popup.c,
	e-cell-size.c, e-cell-spin-button.c, e-cell-text.c,
	e-cell-toggle.c, e-cell-tree.c, e-cell.c, e-cell.h,
	e-table-click-to-add.c, e-table-col.c,
	e-table-column-specification.c, e-table-config-field.c,
	e-table-config.c, e-table-extras.c,
	e-table-field-chooser-dialog.c, e-table-field-chooser-item.c,
	e-table-field-chooser.c, e-table-group-container.c,
	e-table-group-leaf.c, e-table-group.c, e-table-header-item.c,
	e-table-header.c, e-table-item.c, e-table-memory-callbacks.c,
	e-table-model.c, e-table-scrolled.c, e-table-selection-model.c,
	e-table-sort-info.c, e-table-sorted-variable.c, e-table-sorted.c,
	e-table-sorter.c, e-table-specification.c, e-table-state.c,
	e-table-subset-variable.c, e-table-subset.c, e-table-without.c,
	e-table.c, e-table.h, e-tree-scrolled.c, e-tree-selection-model.c,
	e-tree-sorted-variable.c, e-tree-sorted.c, e-tree-table-adapter.c,
	e-tree.c: Ansification patch from danw.

svn path=/trunk/; revision=16586
2002-04-25 19:56:41 +00:00
0479b8d9a0 Fixed a memory leak here by using the "selection-done" signal.
2002-04-11  Christopher James Lahey  <clahey@ximian.com>

	* e-table-header-item.c (ethi_header_context_menu): Fixed a memory
	leak here by using the "selection-done" signal.

	* e-table.c, e-table.h (white_item_event): Added the
	"white_space_event" signal.

svn path=/trunk/; revision=16439
2002-04-11 20:02:31 +00:00
a17d29d26c New function that returns the total minimum width of all the columns.
2002-03-15  Christopher James Lahey  <clahey@ximian.com>

	* e-table-header.c, e-table-header.h (e_table_header_min_width):
	New function that returns the total minimum width of all the
	columns.

	* e-table.c, e-table.h (set_header_width): Call
	e_table_header_min_width here instead of total_width.
	(et_size_request): Override the size_request method instead of
	doing set_usize.

svn path=/trunk/; revision=16175
2002-03-15 20:36:07 +00:00
4f298eab9e Made this return a boolean that returns whether the ETableSearch used the
2002-03-14  Christopher James Lahey  <clahey@ximian.com>

	* e-table-search.c, e-table-search.h (e_table_search_backspace):
	Made this return a boolean that returns whether the ETableSearch
	used the backspace at all.

	* e-table.c (group_key_press), e-tree.c (item_key_press): Used the
	new return value from e_table_search_backspace.

svn path=/trunk/; revision=16166
2002-03-14 20:40:21 +00:00
87c61411fa Don't search if any modifier but SHIFT or LOCK is pressed.
* e-tree.c (item_key_press): Don't search if any modifier but
SHIFT or LOCK is pressed.

* e-table.c (group_key_press): Don't search if any modifier but
SHIFT or LOCK is pressed.

svn path=/trunk/; revision=16161
2002-03-14 19:18:39 +00:00