Commit Graph

659 Commits

Author SHA1 Message Date
ee16607d42 A warning fix from Jacob. Bug #5057.
2001-07-25  Jason Leach  <jleach@ximian.com>

	* e-shortcuts-view.c (icon_callback): A warning fix from Jacob.
	Bug #5057.

svn path=/trunk/; revision=11403
2001-07-25 17:45:57 +00:00
fcfda658fd $(BONOBO_CONF_CFLAGS) was here twice, took out one of them.
2001-07-25  Jason Leach  <jleach@ximian.com>

	* Makefile.am (INCLUDES): $(BONOBO_CONF_CFLAGS) was here twice,
	took out one of them.

	* e-shell-view.c (socket_destroy_cb): Mem leak fix.  Thanks to the
	amazing Jacob B. Bug #5054.

svn path=/trunk/; revision=11402
2001-07-25 16:55:28 +00:00
4de97d0b5b #include <libgnome/gnome-defs.h> and <libgnome/gnome-i18n.h> instead of
2001-07-25  Jason Leach  <jleach@ximian.com>

	* e-task-widget.c: #include <libgnome/gnome-defs.h> and
	<libgnome/gnome-i18n.h> instead of the full <libgnome/libgnome.h>,
	as noted by a comment here.

svn path=/trunk/; revision=11397
2001-07-25 15:08:11 +00:00
c2ba0b6c6b fix some warnings.
svn path=/trunk/; revision=11371
2001-07-24 23:31:06 +00:00
3c69c8b3cc Add the "/My Evolution" path to the path_to_etree_node hash so that
2001-07-24  Jason Leach  <jleach@ximian.com>

	* e-storage-set-view.c (e_storage_set_view_construct): Add the
	"/My Evolution" path to the path_to_etree_node hash so that
	storage_set_view_set_current_folder() can select the My Evolution
	node when it's the current one. Fixes #5114 and #3956.

svn path=/trunk/; revision=11348
2001-07-24 18:59:46 +00:00
752ea282fb Only show the warning dialog instead of using `gnome_dialog_run()' so it
* main.c (development_warning): Only show the warning dialog
instead of using `gnome_dialog_run()' so it is not modal.  Modal
would be nice, but unfortunately it works bad with Bonobo.  Plus
Sawfish doesn't like to keep the modal dialog on top, so it gets
very confusing for users.

svn path=/trunk/; revision=11334
2001-07-24 02:23:14 +00:00
8dd7c75d29 Only show the warning dialog instead of using `gnome_dialog_run()' so it
* main.c (development_warning): Only show the warning dialog
instead of using `gnome_dialog_run()' so it is not modal.  Modal
would be nice, but unfortunately it works bad with Bonobo.  Plus
Sawfish doesn't like to keep the modal dialog on top, so it gets
very confusing for users.

svn path=/trunk/; revision=11331
2001-07-24 01:33:43 +00:00
ce1e7cbcf1 Uhm, set the usize to `1, -1' instead.
* e-task-widget.c (e_task_widget_construct): Uhm, set the usize to
`1, -1' instead.

svn path=/trunk/; revision=11318
2001-07-23 19:52:38 +00:00
adbf1e2b83 Set the usize for the contained hbox to 0x0.
* e-task-widget.c (e_task_widget_construct): Set the usize for the
contained hbox to 0x0.

svn path=/trunk/; revision=11311
2001-07-23 18:55:26 +00:00
51a223f8ac Get the manuals from the `evolution-guide' dir as that's where they get
* e-shell-view-menu.c: Get the manuals from the `evolution-guide'
dir as that's where they get installed.

svn path=/trunk/; revision=11309
2001-07-23 18:21:42 +00:00
d5a23e6131 Don't handle button events whose button number is not 1.
* e-shell-view.c (storage_set_view_box_button_release_event_cb):
Don't handle button events whose button number is not 1.

svn path=/trunk/; revision=11305
2001-07-23 17:49:55 +00:00
97cc1d57ad Add an extra @type arg to the xferFolder and removeFolder methods in
the ShellComponent interface.  Updated the EvolutionShellComponent
GTK+ wrapper and all the component accordingly.  Get the calendar to
use this so it can delete both tasks and calendar folders.

svn path=/trunk/; revision=11300
2001-07-23 02:04:14 +00:00
ced2af3321 Add a `user_creatable' property to folder types and make components
use it, so that e.g. you cannot create a folder of type "mailstorage"
or "vtrash".

svn path=/trunk/; revision=11298
2001-07-22 03:50:07 +00:00
0fbe9a34ff Use g_source_remove()' instead of gtk_timeout_remove()' here, as we are
* evolution-activity-client.c (impl_destroy): Use
`g_source_remove()' instead of `gtk_timeout_remove()' here, as we
are using `g_timeout_add()' and not `gtk_timeout_add()' to set up
the timeout callback.
(update_timeout_callback): Reset `have_pending_update' when
returning %TRUE.  Set the timeout id to zero when returning
%FALSE.

svn path=/trunk/; revision=11295
2001-07-22 01:40:25 +00:00
dd6f646f8f [Fix a crash if you start evolution with a bad URI.]
2001-07-20  Jason Leach  <jleach@ximian.com>

	[Fix a crash if you start evolution with a bad URI.]

	* e-shell.c (e_shell_create_view): If we can't display the URI,
	display the default uri.  This is because it's necessary for
	e_shell_view_display_uri() to run all the way through so corba
	interfaces get setup.

	* e-shell-view.c (e_shell_view_display_uri): If we fail to create
	a new view for a URI (happens if you pass in an invalid URI), be
	sure to return FALSE.

svn path=/trunk/; revision=11290
2001-07-20 21:42:46 +00:00
c49f665c56 [This is a better way to have "Local Folders" be shown as the local
2001-07-20  Jason Leach  <jleach@ximian.com>

        [This is a better way to have "Local Folders" be shown as the
        local storage name without breaking current user's shortcuts.]

        * e-corba-storage.c (get_display_name): Implement this, but it's
	only returning the real name now.  Need to change the IDL soon to
	let corba storages have separated display names.

        * e-shortcuts.c (e_shortcuts_add_default_group): Set these default
	shortcut URI's back to evolution:/local/

        * e-shell-view.h (DEFAULT_URI): Set this back to
	"evolution:/local/Inbox"

        * e-storage-set-view.c (etree_value_at): Get the display name for
	a storage rather than it's true name.

        * e-local-storage.c (impl_get_display_name): Implemented for the
	local folder (to return a translated "Local Folders").

        * e-storage.c (e_storage_get_display_name): New virtual function
        for retrieving the display name.

svn path=/trunk/; revision=11274
2001-07-20 21:15:57 +00:00
c604cce9c6 Make the local storage name "Local Folders" instead of "local", looks
2001-07-19  Jason Leach  <jleach@ximian.com>

	* e-local-storage.h: Make the local storage name "Local Folders"
	instead of "local", looks better with "My Evolution", "VFolders",
	and "Other Contacts".

	* e-shell-view.h: Put the #define DEFAULT_URI here instead of in
	e-shell-view.c.

	* main.c: Remove the duplicated #define STARTUP_URI, actually make
	use of the nice defines.

	* e-shell-folder-commands.c (e_shell_command_delete_folder): Use
	the DEFAULT_URI here instead of a hard coded string.

	* e-shortcuts.c (e_shortcuts_add_default_group): Fix the URI's
	here to use "Local Folder".

svn path=/trunk/; revision=11241
2001-07-19 21:55:47 +00:00
a8f8067a0a Line up the padding for the folder title bar labels when you have the
2001-07-19  Jason Leach  <jleach@ximian.com>

	* e-shell-folder-title-bar.c (e_shell_folder_title_bar_construct):
	Line up the padding for the folder title bar labels when you have
	the folder bar enabled or disabled (previously when disabled it
	was padding ~8 pixels to the right while the other had 0).

	* e-shell-view.c (setup_widgets): Take out a 2 pixel padding
	around the vbox containing the title bar, folder bar, message list
	and mail display.  Also remove 2 more extra pixels of padding on
	the bottom.

svn path=/trunk/; revision=11238
2001-07-19 21:41:21 +00:00
8b11e79c4b Removed. (load_shortcuts): Don't call it.
* e-shortcuts.c
(override_shortcut_name_and_type_from_storage_set): Removed.
(load_shortcuts): Don't call it.

svn path=/trunk/; revision=11120
2001-07-16 09:31:14 +00:00
68651fc4a8 [Fix #4387, Shortcut bar items don't keep the name after rename.]
* e-shortcuts.c (update_shortcuts_by_path): Do not change the name
of the shortcut if the folder's name changes.

svn path=/trunk/; revision=11115
2001-07-15 12:41:13 +00:00
694b8bf34f Display an icon for nodes at depth greater than 2 in the tree view as
well.

svn path=/trunk/; revision=11113
2001-07-15 09:54:25 +00:00
05877aea9b Fix a crash that could happen by closing one or more views, and then
clicking on the off-line button.

svn path=/trunk/; revision=11107
2001-07-15 05:18:49 +00:00
d2309f2ab5 Because bugzilla.ximian does have a mail gateway now, we can have
2001-07-12  Jason Leach  <jleach@ximian.com>

	* e-shell-view-menu.c (command_submit_bug): Because
	bugzilla.ximian does have a mail gateway now, we can have
	Help->Submit Bug Report open up bug-buddy.

svn path=/trunk/; revision=11075
2001-07-12 23:53:51 +00:00
3ce970fde7 Remove warning
svn path=/trunk/; revision=11072
2001-07-12 23:02:46 +00:00
026065f2fd Initialize priv->db and priv->iid so that destroy() won't crash if
* e-shell.c (init): Initialize priv->db and priv->iid so that
	destroy() won't crash if e_shell_construct bails out before
	setting them. Reduces bug #4173 to #4169.

svn path=/trunk/; revision=11044
2001-07-12 16:36:19 +00:00
c4ad1ccccd DONT ASK ME AGAIN!
svn path=/trunk/; revision=11012
2001-07-11 19:21:05 +00:00
a74afe6c19 Mark a string for translation.
2001-07-11  Kjartan Maraas  <kmaraas@gnome.org>

	* importers/intelligent.c: Mark a string for translation.

svn path=/trunk/; revision=11001
2001-07-11 14:45:10 +00:00
fbb2f1feb0 Make sure to create ~/evolution/config/ if it doesn't exist. (ShellView
2001-07-11  Jason Leach  <jleach@ximian.com>

	* e-shell-view.c (e_shell_view_save_settings): Make sure to create
	~/evolution/config/ if it doesn't exist.  (ShellView settings get
	saved before component settings, so when the mailer comes around
	to saving ETree stuff, this dir will be there). Fixes bug #4279.

svn path=/trunk/; revision=10991
2001-07-11 09:29:53 +00:00
e10ca4852b Add a temporary block of code to not use the
2001-07-10  Jason Leach  <jleach@ximian.com>

	* e-setup.c (copy_default_stuff): Add a temporary block of code to
	not use the $GNOME/share/evolution/default_user/shortcuts.xml for
	users who might be upgrading, so they'll get the shell-generated
	default set of shortcuts.  See notes on #4394.

svn path=/trunk/; revision=10981
2001-07-11 02:24:43 +00:00
c263befd20 convert the folder name from utf8 before displaying them in the dialog and
2001-07-09  Larry Ewing  <lewing@ximian.com>

	* e-shell-folder-commands.c (delete_dialog): convert the folder
	name from utf8 before displaying them in the dialog and set the
	dialog parent.

svn path=/trunk/; revision=10943
2001-07-10 02:04:46 +00:00
7367ac4cb6 Make the "Rename" item be a GNOMEUIINFO_ITEM_NONE() since we don't have a
2001-07-09  Federico Mena Quintero  <federico@ximian.com>

	* e-shortcuts-view.c: Make the "Rename" item be a
	GNOMEUIINFO_ITEM_NONE() since we don't have a stock icon; likewise
	for the "Open in New Window".  This gets rid of warnings from
	gnome-libs.  Use a better stock icon for the "Remove" command, and
	add a stock icon to the "Open" command.

svn path=/trunk/; revision=10938
2001-07-09 23:07:57 +00:00
39440346cf It's very possible that get_storage_set_path_from_uri() returns NULL (5 of
2001-07-09  Jason Leach  <jleach@ximian.com>

	* e-shell-view.c (updated_folder_cb): It's very possible that
	get_storage_set_path_from_uri() returns NULL (5 of the 6 return
	cases), so check that it's not NULL before trying to strcmp() it.
	Fixes a startup crash.

svn path=/trunk/; revision=10935
2001-07-09 21:54:53 +00:00
7fa7518bd6 Return a gboolean saying whether or not the shortcut changed. Use strcmp
* e-shortcuts.c (shortcut_item_update): Return a gboolean saying
	whether or not the shortcut changed. Use strcmp rather than
	pointer comparisons to determine this.
	(update_shortcut_and_emit_signal): propagate the gboolean from
	shortcut_item_update (and only emit the signal if it's TRUE).
	(update_shortcuts_by_path): Only call make_dirty if something
	changed.
	(storage_set_new_folder_callback,
	storage_set_updated_folder_callback): Don't call make_dirty:
	update_shortcuts_by_path will have called it if necessary.

	* e-shell-view.c (updated_folder_cb): Don't call
	update_for_current_uri if the folder that was updated isn't the
	one being displayed.

svn path=/trunk/; revision=10912
2001-07-09 15:20:54 +00:00
90f4c18deb Little UI tweak for right click menu, pronouns shouldn't be capitalized
2001-07-06  Jason Leach  <jleach@ximian.com>

	* e-shortcuts-view.c: Little UI tweak for right click menu,
	pronouns shouldn't be capitalized ("This" in this case).

svn path=/trunk/; revision=10871
2001-07-06 22:09:41 +00:00
489fe60f9e [Misc fixes and part of #2228, There should be no dialog boxes during
2001-07-06  Jason Leach  <jleach@ximian.com>

	[Misc fixes and part of #2228, There should be no dialog boxes
	during startup.]

	* e-setup.c (e_setup): Check for searches.xml instead of
	shortcuts.xml, since shortcuts.xml doesn't really need to exist
	(and thus wouldn't be a necessary test whether ~/evolution was
	invalid) because shell can generate shortcuts.
	(copy_default_stuff): For first time users, only present a dialog
	if a problem occurred.  We've already clicked "Ok" on a dialog
	about copying files.
	(check_evolution_directory): Take out the "successfully installed"
	dialog on updates too.

svn path=/trunk/; revision=10864
2001-07-06 21:44:35 +00:00
6741277bdc [This should fix #3873, Bizzarre crash after deleting a few
folders.]

* e-local-storage.c (remove_folder): Don't free the
`physical_path' on error, as it gets freed when freeing the
callback data.

svn path=/trunk/; revision=10842
2001-07-06 08:43:53 +00:00
8053d484f9 Added error dialogs for when the user tries to copy/move a folder over
itself, or move it under one of its descendants.  [Fixes #3959,
copying a folder over itself crashes Evolution.]

svn path=/trunk/; revision=10841
2001-07-06 08:35:27 +00:00
25ea88907d Special case the My Evolution uri so that the correct icon appears in the
shortcut bar.

svn path=/trunk/; revision=10822
2001-07-05 19:25:28 +00:00
d02ed3c293 Get the File -> Folder -> Properties menu item work again for the
mailer.

svn path=/trunk/; revision=10793
2001-07-05 11:19:19 +00:00
1e5fac65aa set "pixname" value only if pixbuf was loaded successfully. Otherwise
2001-07-04  Gediminas Paulauskas <menesis@delfi.lt>

	* evolution-shell-component-utils.c (e_pixmaps_update): set
	"pixname" value only if pixbuf was loaded successfully. Otherwise
	component crashes if image is not found. Should be checked for
	sanity in bonobo_ui_component_set_prop IMHO.

2001-07-04  Gediminas Paulauskas <menesis@delfi.lt>

	* Makefile.am: install apply-filters-16.xpm

2001-07-04  Gediminas Paulauskas <menesis@delfi.lt>

	* evolution-mail-message.xml: MessageApplyFilters now has an icon.

2001-07-04  Gediminas Paulauskas <menesis@delfi.lt>

	* folder-browser-ui.c (message_pixcache): set icon for ApplyFilters
	command.

svn path=/trunk/; revision=10783
2001-07-04 20:46:15 +00:00
e77e11490f Revised to make it less scary.
2001-07-03  Aaron Weber  <aaron@ximian.com>

	* main.c (development_warning): Revised to make it less scary.

svn path=/trunk/; revision=10775
2001-07-03 23:11:34 +00:00
3fe9876bc7 [Fix a problem with not being able to save a newly created
`shortcuts.xml' file, and another bug that caused the default
group to be added at every start-up, even there were groups
already.]

* e-shortcuts.c (e_shortcuts_new): If loading the shortcuts fails,
set the file_name.
(load_shortcuts): Update `num_groups'.

svn path=/trunk/; revision=10763
2001-07-03 19:40:31 +00:00
b7dede1a27 use bonobo-conf everywhere
2001-07-03  Dietmar Maurer  <dietmar@ximian.com>

	* *: use bonobo-conf everywhere

svn path=/trunk/; revision=10760
2001-07-03 18:15:31 +00:00
3f3936e0f9 More BonoboConf work
svn path=/trunk/; revision=10752
2001-07-03 16:40:01 +00:00
8a9d50f560 [The following makes the shell able to create the `shortcuts.xml'
file by itself when the file is not present or corrupted.  Fixes
#3668, failure to handle malformed shortcuts.xml file.]

* e-shell.c (e_shell_construct): If the `e_shortcuts_new()'
returns an object with no shortcuts in it, fill it in with
`e_shortcuts_add_default_group()'.

* e-shortcuts.c: New member `num_groups' in EShortcutsPrivate.
(init): Init to zero.
(e_shortcuts_add_group): Increment.
(e_shortcuts_remove_group): Decrement.
(e_shortcuts_get_num_groups): New.
(e_shortcuts_add_default_group): New function to set up the
default shortcuts.
(e_shortcuts_new): Return an empty EShortcuts object if loading
the file files, instead of returning NULL.

svn path=/trunk/; revision=10744
2001-07-03 13:29:12 +00:00
9786eb1d7a Ref/unref the handler so the signal handlers can unref it safely. Also, if
* e-shell-offline-handler.c
(e_shell_offline_handler_put_components_offline): Ref/unref the
handler so the signal handlers can unref it safely.  Also, if
`prepare_for_offline()' fails, don't say that there was an
internal error, as that's confusing.  Just say we couldn't put the
components off-line.

[Fix #3758, clicking on the online/offline button crashed
Evolution.]

* Evolution-Offline.idl: Don't derive OfflineProgressListener from
Bonobo::Unknown.

svn path=/trunk/; revision=10742
2001-07-03 12:24:29 +00:00
dcd5194f42 [Fixed #3643, Shell crash when component crashed]
* e-shell-view.c (socket_destroy_cb): Fix Jason's broken fix for
#3205 that was causing #3643.  It is not safe to strcmp() the
return value from `e_shell_view_get_current_uri()' as it might be
NULL already.

svn path=/trunk/; revision=10739
2001-07-03 11:26:20 +00:00
fd6ad06df5 Made evolution depend on bonobo-conf 0.2.
2001-07-02  Christopher James Lahey  <clahey@ximian.com>

	* configure.in: Made evolution depend on bonobo-conf 0.2.

From calendar/ChangeLog:

2001-07-02  Christopher James Lahey  <clahey@ximian.com>

	* gui/Makefile.am (INCLUDES): Added $(BONOBO_CONF_CFLAGS).
	(evolution_calendar_LDADD): Added $(BONOBO_CONF_LIBS).

From composer/ChangeLog:

2001-07-02  Christopher James Lahey  <clahey@ximian.com>

	* Makefile.am (INCLUDES): Added $(BONOBO_CONF_CFLAGS).

From shell/ChangeLog:

2001-07-02  Christopher James Lahey  <clahey@ximian.com>

	* Makefile.am (INCLUDES): Added $(BONOBO_CONF_CFLAGS).
	(evolution_LDADD): Added $(BONOBO_CONF_LIBS).

svn path=/trunk/; revision=10718
2001-07-03 02:55:58 +00:00
7657ec4a52 Don't assert that there is a handler, so we don't crash if user clicks on
* e-storage-set-view.c (popup_folder_menu): Don't assert that
there is a handler, so we don't crash if user clicks on a folder
whose type we cannot handle for some reason [such as an
uninstalled component].

* evolution-test-component.c (activity_client_cancel_callback):
New callback for the "cancel" signal on the
EvolutionActivityClient object.
(activity_client_show_details_callback): New callback for the
"show_details" signal.
(timeout_callback_1): Connect these two signal handlers.

* e-activity-handler.c (task_widget_button_press_event_callback):
Ahem, right-click is button 3, not button 2.
(show_cancellation_popup): Actually pop up the menu.
(get_corba_null_value): New helper function to create a CORBA_any
null value.
(report_task_event): New helper function to report events to the
listener.
(task_widget_cancel_callback): Use it.  Report "Cancel" instead of
"Cancelled".
(task_widget_show_details_callback): New, callback for the "Show
Details" right-click menu item.

* evolution-activity-client.c: Updated to dispatch the "Cancel"
and "ShowDetails" events as "cancel" and "show_details" signals.
(class_init): Install the signals.
(listener_callback): Updated to update the signals corresponding
to the "ShowDetails" and "Cancel" events.

* Evolution-Activity.idl: Changed the docs about the events sent
to the Bonobo::Listener.  We now only have "ShowDetails" and
"Cancelled".

* evolution-test-component.c (timeout_callback_1): Make the
activity cancellable so we can test the right-click cancel menu
too.

* main.c (idle_cb): Actually exit if we cannot reach to the shell.

svn path=/trunk/; revision=10684
2001-07-02 17:06:08 +00:00
acb62e85ec Make the EUriSchemaRegistry object non-floating at construction time.
svn path=/trunk/; revision=10658
2001-07-01 18:49:29 +00:00