Commit Graph

1364 Commits

Author SHA1 Message Date
Matthew Barnes ebdaad049d Remove e_get_subscribable_accounts().
Another EAccount utility function down...
2011-06-29 18:42:21 +02:00
Matthew Barnes f043e3c748 Including <glib-object.h> directly is rarely needed. 2011-06-29 18:42:21 +02:00
Matthew Barnes 7132d0f0c2 Including <glib.h> directly is rarely needed. 2011-06-29 18:42:21 +02:00
Milan Crha c24038c4f6 Bug #646109 - Fix use of include <config.h> to make sure translations work 2011-06-29 18:42:20 +02:00
Matthew Barnes b0f826ba58 Bug 537691 - Account editor window HIG
Change the OK button to Apply, and fix the padding around the window
edges.  People already bitching about the window being too tall are just
gonna bitch louder now, but it does look better on normal size screens.
2011-06-29 18:42:19 +02:00
Matthew Barnes 5146ff4c53 Coding style and whitespace cleanup. 2011-06-29 18:42:17 +02:00
Matthew Barnes 76ca149448 Bug 649990 - Remove get_font_options() from e-util.c.
Not only is get_font_options() no longer needed, it's actually doing the
wrong thing by reading settings through GConfClient instead of GSettings.

But it turns out, thanks to the tighter Cairo integration in GTK3, the
widgets that call get_font_options() can be made to work correctly by
simply removing this hack.  Love it when that happens.
2011-06-29 18:42:16 +02:00
Matthew Barnes f96a45d4bf Remove unused e_get_gnome2_user_dir(). 2011-06-29 18:42:16 +02:00
Matthew Barnes fb38ed0bf5 Add e_activity_handle_cancellation().
Convenience function for use in GAsyncReadyCallback functions.

This acknowledges the cancellation, so that the activity's description
changes from "(cancelling)" to "(cancelled)" and the description appears
crossed out in the UI for a moment before disappearing.
2011-06-29 18:42:12 +02:00
Matthew Barnes 54da4fc09c Coding style cleanups. 2011-06-29 18:42:11 +02:00
Matthew Barnes 9327f255b9 MailFolderCache: Drop folder URI in "folder-changed" signal.
We already include a CamelStore and folder name string in the signal
arguments, so it's trivial to reconstruct the URI if it's needed.
2011-06-29 18:42:10 +02:00
Matthew Barnes 3d651e44f4 Remove e_get_account_by_source_url().
Function is no longer used, or wanted.
2011-06-29 18:42:10 +02:00
Matthew Barnes c7398b967e Fix compiler warnings.
Mostly dead assignments.
2011-06-29 18:42:06 +02:00
Matthew Barnes 1879122b18 EMailShellView: Open the selected folder ourselves.
This one's a little involved:

 - EMailShellView now obtains a CamelFolder itself in response to
   EMFolderTree::folder-selected signals.  Uses EActivity to do so.

 - Revise EMFolderTree::folder-selected signal arguments to be more
   useful: emit a CamelStore object instead of a folder URI.

 - Also revise EMFolderTree::folder-activiated signal arguments the
   same way while we're at it.

 - Remove the "folder_uri" argument from e_mail_reader_set_folder().
   If you have a CamelFolder object you can obtain the URI string by
   calling camel_folder_get_uri().
2011-06-29 18:42:05 +02:00
Matthew Barnes 96ac557716 Remove e_get_account_by_transport_url().
Function is no longer used, or wanted.
2011-06-29 18:42:05 +02:00
Matthew Barnes c54a329d96 e_get_account_by_uid(): Also handle CamelTransport UIDs.
Enhance e_get_account_by_uid() to also accept CamelTransport UIDs.

The convention we use to distinguish them is simple:

   Given an EAccount UID:

   - The CamelStore UID is the EAccount UID verbatim.

   - The CamelTransport UID is the EAccount UID + "-transport".

So just check for a "-transport" suffix and truncate it.
2011-06-29 18:42:04 +02:00
Matthew Barnes 0be9b1f878 Adapt to CamelService changes. 2011-06-29 18:41:55 +02:00
Matthew Barnes 27d6ca4b21 Bug 647708 - e_plugin_xml_prop() can return libxml2 allocated memory
Always copy the xmlChar property into GLib-allocated memory.
g_mem_is_system_malloc() has nothing to do with libxml2.
2011-06-29 18:41:55 +02:00
Matthew Barnes adb682530f Don't crash on missing EAlert definitions. 2011-06-29 18:41:54 +02:00
Matthew Barnes 57ea14220e Remove the profiler plugin.
This plugin was for developers, but no one uses it anymore.  Plus the
only profiling hooks left in Evolution were in the MessageList widget,
which performs fine.  There's better ways to collect profiling data
these days anyway (sysprof, systemtap, etc.).
2011-06-29 18:41:50 +02:00
Matthew Barnes c1259e5a08 EAlertBar: Make warnings time out after 5 minutes
Warnings are generally meant for transient errors.  No need to leave
them up indefinitely.  Close them automatically if the user hasn't
responded after a reasonable period of time has elapsed.
2011-06-29 18:41:49 +02:00
Matthew Barnes 566bb2aedf Change the accelerator map file location.
From: $HOME/.gnome2/accels/evolution
  To: $XDG_CONFIG_HOME/evolution/accels

Custom keyboard accelerator maps is a well-hidden feature these
days, especially in GNOME 3.  Not worth migrating the old file.
2011-06-29 18:41:49 +02:00
Matthew Barnes eccfd921ed Fix alignment of extra widgets in EAlertDialogs.
Add e_alert_dialog_get_content_area(), which returns the GtkVBox
containing the primary and secondary labels.  Use this instead of
gtk_dialog_get_content_area() to maintain the dialog's left margin
beneath the image.
2011-06-29 18:41:47 +02:00
Milan Crha 25f7db861c Fix build break after recent eds changes 2011-06-29 18:41:45 +02:00
Matthew Barnes 7aacf983b3 Coding style and whitespace cleanup. 2011-06-29 18:41:41 +02:00
Milan Crha 095a0e5d65 Fix incorrect use of ngettext from a patch for bug #635414 2011-06-29 18:41:40 +02:00
Milan Crha c003c99a75 Bug #614480 - Avoid using G_TYPE_INSTANCE_GET_PRIVATE repeatedly 2011-06-29 18:41:39 +02:00
Matthew Barnes 3b6c8972a5 Coding style and whitespace cleanup. 2011-06-29 18:41:36 +02:00
Milan Crha 333ccc8abf Bug #639483 - Category list includes weather information 2011-06-29 18:41:36 +02:00
Milan Crha 3c6cc7e1a7 Slightly nicer EAlertDialog after move to gtk3 2011-06-29 18:41:35 +02:00
Milan Crha a4e2599f95 Fix few memory leaks 2011-06-29 18:41:35 +02:00
Matthew Barnes 274697623e Remove NULL checks for GObject methods.
As of GLib 2.28 all GObject virtual methods, including constructed(),
are safe to chain up to unconditionally.  Remove unnecessary checks.
2011-06-29 18:41:34 +02:00
Kjartan Maraas 8efc1bc6f9 Bug 641756 - Fix warnings from GCC 4.6
GCC learned how to find dead assignments.
2011-06-29 18:41:31 +02:00
Milan Crha 28d1b270ab Bug #641011 - Ugly appointment editing windows 2011-06-29 18:41:31 +02:00
Matthew Barnes dbc22f9de5 More whitespace cleanup. 2011-06-29 18:41:29 +02:00
Matthew Barnes 6af0c53b69 Coding style and whitespace cleanup. 2011-06-29 18:41:29 +02:00
Milan Crha fd695a3677 Various critical warnings about comp-editor-pages and date edit 2011-06-29 18:41:26 +02:00
Rodrigo Moya 594175c3a9 Use latest gnome-desktop API 2011-06-29 18:41:25 +02:00
Matthew Barnes 7a49a21178 Dialogs no longer have separators. 2011-06-29 18:41:25 +02:00
Matthew Barnes a3ba231fcc Drop backward-compatibility cruft. 2011-06-29 18:41:25 +02:00
Milan Crha c36bd27fa8 Bug #634403 - Mails Label popup menu is not updated properly 2011-06-29 18:41:20 +02:00
Matthew Barnes 80bc7035be Fudge GtkScrollable for gtk2.
Yes, the GtkScrollable interface is implemented by more than just
GtkLayout, but it turns out GtkLayout is the only thing Evolution
uses the GtkScrollable API for on the gtk3 branch.
2011-06-29 18:41:19 +02:00
Matthew Barnes 2485ba3936 Fudge gtk_widget_get_preferred_size() for gtk2.
Easy enough to fake gtk_widget_get_preferred_size() in gtk2 using
gtk_widget_size_request().  Reduces diff noise with gtk3 branch.
2011-06-29 18:41:19 +02:00
Milan Crha ea35907c16 Disconnect signal handlers from actions in alert_dispose() 2011-06-29 18:41:13 +02:00
Milan Crha ca3faa17a9 Free/busy meeting view doesn't work due to non-working extension 2011-06-29 18:41:08 +02:00
Milan Crha e0cf91771a Localize few strings with ngettext
Per request of bug #635414
2011-06-29 18:41:06 +02:00
Milan Crha 12a91dbb21 Bug #633779 - GtkComboBoxText issues 2011-06-29 18:41:01 +02:00
Milan Crha 86e6583bc7 Workaround crash when pasting nothing into html message composer 2010-11-09 23:33:24 +01:00
Matthew Barnes dce5bdc369 Move calendar preferences to the calendar module.
Continue replacing the use of calendar-config functions with GObject
property bindings to EShellSettings properties.
2010-11-09 23:33:22 +01:00
Matthew Barnes e3a09eb67c Add GBinding transform funcs for enum types.
We'll want to store enum settings by their nicknames.
2010-11-09 23:33:22 +01:00