Commit Graph

1461 Commits

Author SHA1 Message Date
34af37ee96 fixed a mis-spelling of "Fashion" in the mail accounts window. (See bug
2001-07-25  Anna Marie Dirks <anna@ximian.com>
	* mail-config.glade: fixed a mis-spelling of "Fashion" in
	the mail accounts window. (See bug 5433)

svn path=/trunk/; revision=11412
2001-07-25 20:30:16 +00:00
b0d5e599ce Don't make the key url:item if we have the url, just make it url. This
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c (make_key): Don't make the key url:item if we
	have the url, just make it url. This fixes bug #5339.
	(mail_session_set_password): Removed.

svn path=/trunk/; revision=11411
2001-07-25 20:04:12 +00:00
d15e1ef55f Don't make the key url:item if we have the url, just make it url. This
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c (make_key): Don't make the key url:item if we
	have the url, just make it url. This fixes bug #5339.

svn path=/trunk/; revision=11410
2001-07-25 19:46:33 +00:00
f0e17938dc Make it so Enter always opens the message in another window.
2001-07-25  Peter Williams  <peterw@ximian.com>

	* folder-browser.c (etree_key): Make it so Enter always opens the message
	in another window.

svn path=/trunk/; revision=11409
2001-07-25 19:40:32 +00:00
56d33b7e47 Now take a CamelService parameter (as passed by Camel). Allows us to have
2001-07-25  Peter Williams  <peterw@ximian.com>

	* mail-mt.c (mail_get_password): Now take a CamelService parameter
	(as passed by Camel). Allows us to have a "remember password"
	checkbox that is set correctly and whose settings can be
	propagated back to the proper MailConfigService.
	(do_get_pass): Add a checkbutton allowing the user to change
	whether the password is remembered or not.
	(pass_got): Apply the setting of the "remember password"
	checkbutton (if not cancelled.)

	* mail-mt.h: Update the prototype here.

	* mail-config.c (mail_config_service_set_save_passwd): New function,
	pretty bland.

	* mail-config.h: Prototype our bland new function. (Get it? It's a pun!)

	* mail-session.c (get_password): Pass the service as well.

svn path=/trunk/; revision=11408
2001-07-25 19:05:08 +00:00
32e9b0c202 Now takes a check_supported gboolean argument saying whether or not to
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-account-gui.c (build_auth_menu): Now takes a
	check_supported gboolean argument saying whether or not to disable
	non-supported authtypes.
	(source_type_changed): Update for build_auth_menu.
	(transport_type_changed): Same.
	(service_check_supported): Pass in TRUE for the disable
	non-supported authtypes to build_auth_menu and also disable
	check-supported button and the authtype menu if we get a NULL
	supported auth list.

svn path=/trunk/; revision=11404
2001-07-25 18:27:47 +00:00
0fbf9cd43f Initialize `me' to NULL. (forward_attached): If we are only forwarding a
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Initialize `me' to NULL.
	(forward_attached): If we are only forwarding a single message,
	pass the message along as the callback data, else pass NULL.
	(do_forward_attach): Updated for changes to
	forward_get_composer().
	(do_forward_non_attached): Same.
	(forward_get_composer): Try to guess which account to forward the
	message from if the message passed in is non-NULL.

svn path=/trunk/; revision=11401
2001-07-25 16:33:44 +00:00
661e18ae52 Initialize `me' to NULL.
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Initialize `me' to NULL.

svn path=/trunk/; revision=11400
2001-07-25 16:03:04 +00:00
6de1fcbf3a Um, write the HTML signature settings in the right place. Whoops.
2001-07-24  Peter Williams  <peterw@ximian.com>

	* mail-config.c (mail_config_write): Um, write the HTML signature settings
	in the right place. Whoops.

svn path=/trunk/; revision=11396
2001-07-25 14:57:52 +00:00
b834d6590e If we're the last row and we're deleting, select the previous message, not
2001-07-24  Jason Leach  <jleach@ximian.com>

        * mail-callbacks.c (delete_msg): If we're the last row and we're
	deleting, select the previous message, not next, which actually
	selects nothing.  Fixes #5323.

svn path=/trunk/; revision=11391
2001-07-25 00:39:34 +00:00
bd34e927c7 Pass the O_TRUNC flag to open so that we don't leave trailing garbage at
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (save_part_save): Pass the O_TRUNC flag to open so
	that we don't leave trailing garbage at the end of the file if the
	new file content is shorter than the old file content.

svn path=/trunk/; revision=11373
2001-07-25 00:16:32 +00:00
56edf691d7 Fix for bug #5174.
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* component-factory.c (create_view): Fix for bug #5174.

svn path=/trunk/; revision=11368
2001-07-24 23:01:07 +00:00
fd7b6edb31 Match the prefix for the "remember_passphrase" setting with where it's
2001-07-24  Jason Leach  <jleach@ximian.com>

	* mail-config.c (config_read): Match the prefix for the
	"remember_passphrase" setting with where it's being saved to
	(/Mail/Prompts), so the setting gets loaded correctly.  Fixes
	#5351.

svn path=/trunk/; revision=11360
2001-07-24 21:57:59 +00:00
1dc80dc379 check_specials if this is an application/pgp type as well.
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (handle_text_plain): check_specials if this is an
	application/pgp type as well.

svn path=/trunk/; revision=11357
2001-07-24 21:51:04 +00:00
5c82c66fa7 When dumping the CamelURL to a string, hide all the params.
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (add_vtrash_info): When dumping the CamelURL to a
	string, hide all the params.

svn path=/trunk/; revision=11354
2001-07-24 20:42:47 +00:00
49bad5e10f Do a case-insensitive comparison. (mail_generate_reply): Only resort to
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (guess_me): Do a case-insensitive comparison.
	(mail_generate_reply): Only resort to the source account's
	identity if we can't find out which identity to use based on the
	recipients of the message first.

	* mail-config.c (mail_config_get_default_account): Make sure to
	return the 0th account if we don't have a default. We don't want
	to return NULL.

	* mail-callbacks.c (empty_trash): Use mail_tool_get_trash for the
	remote store trash folders.

	* mail-tools.c (mail_tool_get_trash): New convenience function.

svn path=/trunk/; revision=11353
2001-07-24 20:12:47 +00:00
1ec137b9d6 get_boolean_with_default for the "Mark as read" timeout, not
2001-07-24  Jason Leach  <jleach@ximian.com>

	* mail-config.c (config_read): get_boolean_with_default for the
	"Mark as read" timeout, not get_long_with_default.  Fixes #5176.

svn path=/trunk/; revision=11352
2001-07-24 19:55:53 +00:00
488f755ce8 Don't display "(0 unsent)" if the outbox is empty.
2001-07-24  Peter Williams  <peterw@ximian.com>

	* mail-folder-cache.c (make_folder_name): Don't display "(0 unsent)" if
	the outbox is empty.

svn path=/trunk/; revision=11347
2001-07-24 18:29:23 +00:00
020d3367a8 Set up the local trash in the folder cache.
2001-07-24  Peter Williams  <peterw@ximian.com>

	* mail-local.c (init_trash): Set up the local trash in the folder cache.

svn path=/trunk/; revision=11343
2001-07-24 16:31:54 +00:00
57d3c094da Make the error reporting a little but more descriptive.
2001-07-24  Peter Williams  <peterw@ximian.com>

	* mail-folder-cache.c (update_idle): Make the error reporting a little
	but more descriptive.

svn path=/trunk/; revision=11341
2001-07-24 15:41:31 +00:00
7604a13073 Add new label widgets with a message that SSL isn't supported.
2001-07-24  Peter Williams  <peterw@ximian.com>

	* mail-config.glade: Add new label widgets with a message that SSL
	isn't supported.

	* mail-account-gui.h: Add a new member to the Transport GUI struct
	for the 'SSL is not supported' message.

	* mail-account-gui.c (source_type_changed): Change logic to display
	a message stating that SSL isn't supported if SSL isn't supported.
	(transport_type_changed): Same.
	(mail_account_gui_new): Also load the labels for the the no-SSL
	message.

	* mail-accounts.c (construct): Fix typo.

svn path=/trunk/; revision=11340
2001-07-24 15:33:17 +00:00
b307f4e80d Dont call notifyResult here if we've just launched a thread to do the
2001-07-24  Not Zed  <NotZed@Ximian.com>

        * component-factory.c (create_folder): Dont call notifyResult here
        if we've just launched a thread to do the work, it calls it
        itself.  This apparently breaks the importers, but thats a
        different issue.

svn path=/trunk/; revision=11335
2001-07-24 02:34:43 +00:00
cb4926026f Go back to calling mail_msg_free here. (mail_msg_destroy): Remove the
2001-07-23  Not Zed  <NotZed@Ximian.com>

        * mail-mt.c (mail_msgport_replied): Go back to calling
        mail_msg_free here.
        (mail_msg_destroy): Remove the operation unregistration stuff.
        (mail_msg_received): And put it here, so we unregister as soon as
        the async part of the operation is complete.  I thought about this
        and we should be doing this anyway so we register/unregister
        always in the same thread, although the camel_operation api
        doesn't enforce it, this *is* what it expects.

        * message-list.c (regen_list_regen): re-add reporting to
        rebuilding the message list.  Basically fixes #4931

svn path=/trunk/; revision=11332
2001-07-24 01:36:11 +00:00
2807ad0103 Oops. Uncomment this code since Trow fixed GtkHTML to actually have this
2001-07-23  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-search.c (toggled_fwd_cb): Oops. Uncomment this code since
	Trow fixed GtkHTML to actually have this function now.

svn path=/trunk/; revision=11328
2001-07-24 00:54:20 +00:00
fc59208aa9 Fixed the "Read" to be Read in the glade file per menesis' request.
2001-07-23  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.glade: Fixed the "Read" to be Read in the glade file
	per menesis' request.

	* mail-accounts.c (construct): Give the dialog a Close button
	instead of an OK button.
	(prompt_bcc_only_toggled): New.
	(threaded_list_toggled): New.
	(show_preview_toggled): New.
	(construct): Add code for the bcc-only-prompt, threaded-list, and
	show-preview checkboxes.

	* mail-ops.c (transfer_messages_transfer): If the source and
	destination folders are the same, just mark the uids as undeleted
	(in case they were marked as deleted before).

svn path=/trunk/; revision=11327
2001-07-24 00:53:24 +00:00
8734d20809 If the source and destination folders are the same, just mark the uids as
2001-07-23  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (transfer_messages_transfer): If the source and
	destination folders are the same, just mark the uids as undeleted
	(in case they were marked as deleted before).

svn path=/trunk/; revision=11322
2001-07-23 22:16:56 +00:00
7db908f5f3 Carefully check for NULL everywhere, and do the right thing if the message
2001-07-23  Jon Trowbridge  <trow@ximian.com>

	* mail-search.c (begin_cb): Carefully check for NULL everywhere,
	and do the right thing if the message we are currently looking
	at gets expunged. (Bug #4870)

svn path=/trunk/; revision=11321
2001-07-23 21:46:09 +00:00
b4f3f0c102 [Bug #5225: No UI way to mark as unimportant]
2001-07-23  Jason Leach  <jleach@ximian.com>

	[Bug #5225: No UI way to mark as unimportant]

	* folder-browser.c (on_right_click): Do the necessary stuff to
	show or hide the correct "Mark Important" or "Mark as Unimportant"
	menu items depending on the status of messages that are selected.

	* folder-browser-ui.c: Add the MarkAsUnimportant verb here.

	* mail-callbacks.c (mark_as_unimportant): Simple function that's
	the callback for these new menu items.

svn path=/trunk/; revision=11316
2001-07-23 19:14:53 +00:00
97cc1d57ad Add an extra @type arg to the xferFolder and removeFolder methods in
the ShellComponent interface.  Updated the EvolutionShellComponent
GTK+ wrapper and all the component accordingly.  Get the calendar to
use this so it can delete both tasks and calendar folders.

svn path=/trunk/; revision=11300
2001-07-23 02:04:14 +00:00
ced2af3321 Add a `user_creatable' property to folder types and make components
use it, so that e.g. you cannot create a folder of type "mailstorage"
or "vtrash".

svn path=/trunk/; revision=11298
2001-07-22 03:50:07 +00:00
55c5585679 Change this back to the "evolution:/local/Inbox" URI.
2001-07-20  Jason Leach  <jleach@ximian.com>

	* mail-summary.c (generate_html_summary): Change this back to the
	"evolution:/local/Inbox" URI.

svn path=/trunk/; revision=11276
2001-07-20 21:20:15 +00:00
9690a05034 Don't let the user remove vtrash folders.
2001-07-20  Peter Williams  <peterw@ximian.com>

	* component-factory.c (storage_remove_folder): Don't let the user
	remove vtrash folders.

svn path=/trunk/; revision=11267
2001-07-20 19:37:53 +00:00
fcce65ec8a Fix DanW's fix. Pass the right arguments to mail_msg_destroy.
2001-07-20  Peter Williams  <peterw@ximian.com>

	* mail-mt.c (mail_msgport_replied): Fix DanW's fix. Pass the right
	arguments to mail_msg_destroy.

	* component-factory.c (component_fn): Don't populate the context
	menu; our only action didn't even work.
	(populate_folder_context_menu): Removed. ChangeFolderProperties
	needs a FolderBrowser which we don't have. It didn't even work
	before.

	* mail-local.c (mail_local_reconfigure_folder): Bring the creation
	of the hash table to the beginning to prevent warnings. Complain
	if the mailbox is non-local.

svn path=/trunk/; revision=11266
2001-07-20 19:15:04 +00:00
78cdb79e5a er, unbroke changelog
svn path=/trunk/; revision=11265
2001-07-20 18:26:10 +00:00
8a361c78f0 Don't expunge the source folder if we have a cache.
2001-07-20  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-ops.c (filter_folder_filter): Don't expunge the source
	folder if we have a cache.

svn path=/trunk/; revision=11264
2001-07-20 18:25:45 +00:00
47b817166c Use mail_msg_destroy rather than mail_msg_free, so the cancellation
* mail-mt.c (mail_msgport_replied): Use mail_msg_destroy rather
	than mail_msg_free, so the cancellation operation gets
	unregistered and doesn't leak two file descriptors.

svn path=/trunk/; revision=11263
2001-07-20 18:00:44 +00:00
8a7c9cba6c Update this evolution:/local/ URI to evolution:/Local Folders/ to go along
2001-07-19  Jason Leach  <jleach@ximian.com>

	* mail-summary.c (generate_html_summary): Update this
	evolution:/local/ URI to evolution:/Local Folders/ to go along
	with today's shell changes.

svn path=/trunk/; revision=11253
2001-07-20 03:43:22 +00:00
0ce3b20774 Fix #4605: "Save Image as" should be "Save Image as...".
2001-07-19  Jason Leach  <jleach@ximian.com>

	* mail-display.c: Fix #4605: "Save Image as" should be "Save Image
	as...".

svn path=/trunk/; revision=11248
2001-07-19 23:51:38 +00:00
400b130060 Set the vertical scrolling policy for the mail display to AUTOMATIC, only
2001-07-19  Jason Leach  <jleach@ximian.com>

	* mail-display.c (mail_display_new): Set the vertical scrolling
	policy for the mail display to AUTOMATIC, only get a scrollbar if
	the e-mail is longer than one frame.

	* folder-browser.c (my_folder_browser_init): We were setting the
	policy twice (and to two different things).  Removed this one.

	* message-list.c (message_list_init): Set the policy for the
	message list scroll frame to be horizontal=NEVER,
	vertical=AUTOMATIC (scrollbar only if you have >1 page of
	messages).

svn path=/trunk/; revision=11239
2001-07-19 21:45:06 +00:00
85a02926e6 In camel:
2001-07-19  Peter Williams  <peterw@ximian.com>

	Policy change: NULL url's are no longer allowed in CamelFolderInfos. They used
	to signify that the folder was, in IMAP jargon, NoSelect; now the same effect
	is achieved by adding a "noselect=yes" parameter to the end of the URL. As far
	as I know, IMAP is the only affected provider.

	* providers/imap/camel-imap-store.c (delete_folder): New function. Implement
	folder deletion.
	(camel_imap_store_class_init): Set the delete_folder class function here.
	(get_folder_status): New function. Utility wrapper around the STATUS command.
	(create_folder): If the parent folder is NoSelect but is empty, delete it
	and recreate it as a a subfolder-containing folder. If it is NoSelect but
	contains messages, set an exception.
	(parse_list_response_as_folder_info): Always set the FolderInfo's URL, but
	add a NoSelect parameter if it isn't selectable.
	(get_folder_info_online): Change logic of removing the namespace to reflect
	URL change. Same for logic of checking unread counts.
	(get_folder_info_online): Use get_folder_status to simplify this.

	* camel-store.c (camel_folder_info_build): When creating
	dummy parents, copy the child's URL and set the NoSelect
	parameter.

In mail:

2001-07-19  Peter Williams  <peterw@ximian.com>

	Track the NoSelect changes in Camel.

	* mail-callbacks.c (create_folders): We don't need to check if
	the URL is NULL or not anymore.

	* component-factory.c (create_noselect_control): New
	function. Create a dummy control for folders that can't contain
	messages (ie \NoSelect)
	(create_view): If the URI says the folder is noselect, make a
	dummy control. FIXME: still should merge in the global UI
	elements.
	(xfer_folder): Don't allow the operation if the destination is
	NoSelect.
	(destination_folder_handle_motion): Ditto.
	(destination_folder_handle_drop): Ditto.

svn path=/trunk/; revision=11237
2001-07-19 21:35:43 +00:00
37695c74b7 remvoed register/start/end etc code.
2001-07-19  Not Zed  <NotZed@Ximian.com>

        * mail-local.c (reconfigure_folder_reconfigure): remvoed
        register/start/end etc code.

        * mail-ops.c (get_messages_desc): Add the count here.
        (get_messages_get): Remove the register/start code, its handled
        above us.
        (save_messages_desc): Added count.
        (save_messages_save): Removed register/start/end code.

        * mail-mt.c (mail_msg_received, mail_msg_destroy): Changed to use
        camel_operation rather than mail_status.
        (mail_msgport_received, mail_msgport_replied): Turn of the
        mail_status stuff, we dont need to report on stuff running in the
        gui thread right?
        (retrieve_shell_view_interface_from_control, set_view_data,
        mail_statusf,  mail_status, mail_status_end, mail_status_start,
        status_timeout, do_del_status, set_status_op): removed now
        redundant stuff.
        (mail_msg_free): Removed reference to timeout_id.

svn path=/trunk/; revision=11225
2001-07-19 13:31:22 +00:00
cdea22d886 partial checkin before completing the changes
2001-07-18  Not Zed  <NotZed@Ximian.com>

        * mail-local.c (reconfigure_folder_reconfigure): Changed to use
        camel_operation rathre than mail_status.
        (reconfigure_folder_describe): re-enabled this function.

        * mail-ops.c (get_messages_get): Changed to use camel-progress for
        status reporting.
        (save_messages_save): Likewise.

2001-07-17  Not Zed  <NotZed@Ximian.com>

        * mail-mt.c (struct _mail_msg_priv, destroy_objects, mail_msg_new,
        mail_msg_free, do_op_status): Changed to use an EvolutionActivityClient for
        progress.

svn path=/trunk/; revision=11223
2001-07-19 11:50:49 +00:00
5dc01effa5 Remove this prototype for a function that was removed long ago.
2001-07-18  Jason Leach  <jleach@ximian.com>

	* mail-tools.h (mail_tool_get_local_inbox_url): Remove this
	prototype for a function that was removed long ago.
	(mail_tool_get_local_movemail_url): Ditto.

svn path=/trunk/; revision=11220
2001-07-19 03:41:05 +00:00
c87ef1f0a3 [Simplifying how default account is stored and used internally, fixes
2001-07-18  Jason Leach  <jleach@ximian.com>

	[Simplifying how default account is stored and used internally,
	fixes possabilities of having multiple default accounts and things
	like deleting the current default account]

	* mail-account-gui.c (mail_account_gui_new): Update for new way of
	finding out the default account.
	(mail_account_gui_save): Ditto.

	* mail-accounts.c (load_accounts): Ditto.

	* mail-config-druid.c (make_default_account): Ditto.

	* mail-config.c: Added an int MailConfig::default_account, to be
	used instead of a 'default_account' boolean on each mail account.
	(mail_config_set_default_account_num): New function, facilitates
	things.

	* Mail.idl: removed the Account::default_account boolean.

svn path=/trunk/; revision=11218
2001-07-19 01:25:09 +00:00
6142029e7e Do what was suggested in #4596.
2001-07-18  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-tools.c (mail_tool_generate_forward_subject): Do what was
	suggested in #4596.

svn path=/trunk/; revision=11210
2001-07-18 20:46:35 +00:00
91318dc3cf Add GTK_WIDGET to the charset picker. Reportedly prevent a craash for
2001-07-18  Peter Williams  <peterw@ximian.com>

	* mail-accounts.c (construct): Add GTK_WIDGET to the charset
	picker. Reportedly prevent a craash for someone... ?

svn path=/trunk/; revision=11202
2001-07-18 16:02:59 +00:00
de7088e6b8 Typo fix. Later: And actually fix the typo.
2001-07-18  Peter Williams  <peterw@ximian.com>

      * mail-config.glade: Typo fix.
      Later: And actually fix the typo.

svn path=/trunk/; revision=11199
2001-07-18 15:39:05 +00:00
172a86d679 Typo fix.
2001-07-18  Peter Williams  <peterw@ximian.com>

	* mail-config.glade: Typo fix.

svn path=/trunk/; revision=11198
2001-07-18 14:30:25 +00:00
48654b3b28 Setup the auto-receive here instead.
2001-07-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-accounts.c (mail_delete): Setup the auto-receive here
	instead.

	* mail-config.c (mail_config_remove_account): Don't setup the
	auto-recv here.

svn path=/trunk/; revision=11188
2001-07-18 00:48:28 +00:00
e6ed3915cf Reset the autoreceive when necessary.
svn path=/trunk/; revision=11181
2001-07-17 21:52:06 +00:00