Commit Graph

26 Commits

Author SHA1 Message Date
638ad0ba0b [Fix #5990, Remembering Evolution window geometry.]
* e-shell.c (impl_Shell_createNewView): gtk_widget_show() the new
view returned by `e_shell_create_view()'.
(e_shell_restore_from_settings): Same here, after loading the
settings.

* e-shell-view.c (activate_shortcut_cb): gtk_widget_show() the new
view returned by `e_shell_create_view()'.

* e-shell-view-menu.c (command_open_folder_in_new_window):
gtk_widget_show() the view returned by `e_shell_create_view()'.

* e-shell-folder-commands.c
(e_shell_command_open_folder_in_other_window): gtk_widget_show()
the view returned by `e_shell_create_view()'.

* e-shell.c (e_shell_create_view): Don't show the view
automatically anymore.

* e-shell-view.c (e_shell_view_save_settings): Save the width and
height of the window.
(e_shell_view_load_settings): Restore the width and the height and
gtk_window_set_default_size() based on them.

svn path=/trunk/; revision=12816
2001-09-13 23:46:03 +00:00
afdc8acc65 Purify run. All small leaks.
* e-shell-folder-commands.c
	(folder_selection_dialog_folder_selected_callback): Free the
	folder_command_data when destroying the dialog.

	* e-local-storage.c (remove_folder): Free physical_uri if we
	allocated it.

	* e-shortcuts-view.c (pop_up_right_click_menu_for_group): Unref
	the popup menu, don't destroy it.
	(destroy_group_cb): Free the question string.
	(rename_group_cb): Free the new_name.

	* e-shell-importer.c (create_plugin_menu): Free the list of
	importers.
	(get_iid_for_filetype): Likewise.
	(import_druid_finish): #ifdef out some g_strdups that are only
	used by other #ifdef'ed-out code.

	* e-shell-view.c: Make sure the keys in the uri_to_view hash get
	freed.

	* e-shell-folder-title-bar.c (set_title_bar_label_style): Unref
	the style after setting it on the widget.

	* e-shell-offline-handler.c (impl_destroy): free priv.

	* e-storage-set-view.c (tree_drag_data_received): Make sure
	target_type always gets freed.

	* e-shell-folder-creation-dialog.c (add_folder_types): Don't leak
	the type names.

svn path=/trunk/; revision=12715
2001-09-09 18:24:15 +00:00
bc21d949ca [Fix #6971, Default folder should be the Summary.]
* main.c (idle_cb): s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell.c (e_shell_create_view):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell-view.c (socket_destroy_cb):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.
(e_shell_view_save_settings): Likewise.

* e-shell-folder-commands.c (e_shell_command_delete_folder):
s/DEFAULT_URI/E_SHELL_VIEW_DEFAULT_URI/.

* e-shell-view.h (DEFAULT_URI): Rename to
`E_SHELL_VIEW_DEFAULT_URI'.  Change from "evolution:/local/Inbox"
to be "evolution:/summary".

svn path=/trunk/; revision=12618
2001-09-05 00:10:03 +00:00
3b17294f86 Remove the folder from the EvolutionStorage as well as the EStorage.
2001-08-30  Peter Williams  <peterw@ximian.com>

	* e-local-storage.c (async_xfer_folder_complete): Remove the folder from
	the EvolutionStorage as well as the EStorage.

2001-08-29  Peter Williams  <peterw@ximian.com>

	* e-storage-set-view.c (etree_node_destroy_func): Only call
	remove_node_from_hash if it's not the root node.
	(removed_storage_cb): Don't remove the node from the hash here,
	because it will be removed in the node_destroyed callback.
	(removed_folder_cb): Same.

	* e-shell-view.c (e_shell_view_remove_control_for_uri): Disconnect
	from the destroy signal so as not to confuse ourselves. Also, the
	page remove in the notebook destroys the control and the socket, so don't
	do that explicitly.

	* e-shell-folder-commands.c
	(folder_selection_dialog_folder_selected_callback): Remove the control
	for the source view if we're moving.

svn path=/trunk/; revision=12578
2001-09-04 15:30:13 +00:00
b6463ef46a Actually return if the folder is being moved into one of its descendants.
* e-shell-folder-commands.c
(folder_selection_dialog_folder_selected_callback): Actually
return if the folder is being moved into one of its descendants.

svn path=/trunk/; revision=12395
2001-08-22 21:29:31 +00:00
2c27394b7f Remove unused variable @folder.
2001-08-13  Jason Leach  <jleach@ximian.com>

	* e-local-storage.c (remove_folder_directory): Remove unused
	variable @folder.

	* e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
	Give icons to shortcuts added via Right-click->Add to Shortcut
	Bar.

svn path=/trunk/; revision=11944
2001-08-13 17:59:52 +00:00
51f77f649b [Finally! Fix #413, "Support for stock folders", and #786, "i18n:
default folder names are not translated".]

* e-local-storage.c (setup_folder_as_stock): New helper function.
(setup_stock_folders): Use it to set the default folders as
"stock" folders.  This will give them a translated name and also
make them unmodifiable.
(load_all_folders): Call `setup_stock_folders()' here.

* e-shell-folder-commands.c (delete_cb): Display an error dialog
if the deletion fails.
(e_shell_command_delete_folder): Pass the shell view to the delete
callback.

* e-storage.c (e_storage_result_to_string): Add a string for
`E_STORAGE_CANTCHANGESTOCKFOLDER' as well.

* e-local-storage.c (remove_folder): Don't allow a stock folder to
be removed.
(impl_async_xfer_folder): Don't allow a stock folder to be moved.

* e-corba-storage.c (async_remove_folder): Don't allow a stock
folder to be removed.

* e-storage.h: New enum value `E_STORAGE_CANTCHANGESTOCKFOLDER' in
`EStorageResult'.

* e-folder.c: Make member `self_highlight' a :1 int.  New :1 int
member `is_stock'.
(init): Init `is_stock' to %FALSE.
(e_folder_set_is_stock): New.
(e_folder_get_is_stock): New.

* e-local-storage.c (bonobo_interface_update_folder_cb): For now,
don't set the display name.

svn path=/trunk/; revision=11931
2001-08-12 14:00:02 +00:00
0ea43e6ee7 `#if 0'ed out. (rename_cb): Likewise.
* e-shell-folder-commands.c (rename_clicked): `#if 0'ed out.
(rename_cb): Likewise.

* evolution-shell-component.c (destroy): Fixed a confusion between
GList and GSList.

svn path=/trunk/; revision=11876
2001-08-10 09:13:52 +00:00
02ead26ac7 build fix
svn path=/trunk/; revision=11637
2001-08-03 23:27:58 +00:00
385ba85d42 [Removing Evolution::LocalStorage interface, abstracting the unread counts
2001-08-03  Jason Leach  <jleach@ximian.com>

        [Removing Evolution::LocalStorage interface, abstracting the
        unread counts from a folder's name, also abstract unread counts
        from a shortcut's name.  Fixes #4489 and #5497]

        * e-shortcuts.c (shortcut_item_new): Take an unread_count argument
        now.
        (shortcut_item_update): Ditto.

        * e-shortcuts-view-model.c (get_name_with_unread): Get a string
        containing a shortcut name and it's unread, because these are
        abstracted now.
        (load_group_into_model): Use the above function to make shortcuts
        that have unread counts.

        * e-storage-set-view.c (update_folder_with_unread_hash): Keep a
        hash of folder names with unread counts, because the folder name
        and it's unread count are to be separated, only the ETree is
        supposed to present it as one string.

        * e-shell-view.c: Renamed EShellView::view_title_bar to
        folder_title_bar, to closer match the

        * e-shell-view-menu.c (new_shortcut_dialog_folder_selected_cb):
        Make a shortcut with the unread count.

        * e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
        Make a shortcut with the unread count.

        * e-local-storage.c: Updated for API changes.

        * e-folder.c (e_folder_get_unread_count): New function, does what
        it says.
        (e_folder_set_unread_count): Ditto.

        * e-corba-storage.c (impl_StorageListener_new_folder): Renamed to
        match the IDL function name.
        (impl_StorageListener_update_folder): Ditto.
        (impl_StorageListener_removed_folder): Ditto.

        * Evolution-Storage.idl (struct Folder): Replace the boolean
        highlighted with a long unread_count.
        (updateFolder): Brought in from the now dead
        Evolution::LocalStorage.

        * Evolution-Shell.idl (getLocalStorage): Return a Storage instead
        of a LocalStorage.

        * Evolution-LocalStorage.idl: Removed, no longer needed, only used
        function, updateFolder, has been moved into Evolution::Storage
        interface.

        * evolution-local-storage.[ch]: Ditto.

        * evolution-storage.c (impl_Storage_updateFolder): Implementation
        of the updateFolder taken from ::LocalStorage.
        (class_init): New "update_folder" signal, taken from
        evolution-local-storage.c too.
        (evolution_storage_update_folder): Take an @unread_count int
        instead of a @highlighted boolean.
        (evolution_storage_new_folder): Same for here.
        (evolution_storage_update_folder_by_uri): And here.

        * evolution-storage-listener.h: "update_folder" signal no longer
        sends a @highlighted boolean.

2001-08-03  Jason Leach  <jleach@ximian.com>

        * e-shell-view-menu.c (update_offline_menu_item): Use Jakub's new
        "Work Online" icon and fix a typo.

svn path=/trunk/; revision=11633
2001-08-03 23:08:38 +00:00
c604cce9c6 Make the local storage name "Local Folders" instead of "local", looks
2001-07-19  Jason Leach  <jleach@ximian.com>

	* e-local-storage.h: Make the local storage name "Local Folders"
	instead of "local", looks better with "My Evolution", "VFolders",
	and "Other Contacts".

	* e-shell-view.h: Put the #define DEFAULT_URI here instead of in
	e-shell-view.c.

	* main.c: Remove the duplicated #define STARTUP_URI, actually make
	use of the nice defines.

	* e-shell-folder-commands.c (e_shell_command_delete_folder): Use
	the DEFAULT_URI here instead of a hard coded string.

	* e-shortcuts.c (e_shortcuts_add_default_group): Fix the URI's
	here to use "Local Folder".

svn path=/trunk/; revision=11241
2001-07-19 21:55:47 +00:00
c263befd20 convert the folder name from utf8 before displaying them in the dialog and
2001-07-09  Larry Ewing  <lewing@ximian.com>

	* e-shell-folder-commands.c (delete_dialog): convert the folder
	name from utf8 before displaying them in the dialog and set the
	dialog parent.

svn path=/trunk/; revision=10943
2001-07-10 02:04:46 +00:00
8053d484f9 Added error dialogs for when the user tries to copy/move a folder over
itself, or move it under one of its descendants.  [Fixes #3959,
copying a folder over itself crashes Evolution.]

svn path=/trunk/; revision=10841
2001-07-06 08:35:27 +00:00
d02ed3c293 Get the File -> Folder -> Properties menu item work again for the
mailer.

svn path=/trunk/; revision=10793
2001-07-05 11:19:19 +00:00
d6372c9ae9 This is a first shoot at making shortcuts renameable [#3719];
unfinished.  Also, it causes the shortcut bar to stop displaying
message unread count, but this is unfixable until we get rid of the
::LocalStorage interface, which should hopefully happen soon.

svn path=/trunk/; revision=10621
2001-06-30 02:28:44 +00:00
d77b63aa3c Rename e_shell_new_view()' into e_shell_create_view()' to avoid
confusion with `e_shell_view_new()'.

svn path=/trunk/; revision=10556
2001-06-28 05:56:16 +00:00
be46f0d11c Fix a gazillion warnings.
svn path=/trunk/; revision=10451
2001-06-24 15:32:00 +00:00
602fee638e (Implemented deleting folders in the shell. Files changed that aren't
(Implemented deleting folders in the shell.  Files changed that aren't
 noted below were simply small indentation/space changes.  To play
 with deleting folders, right click on a selected folder in the folder
 tree, then choose Delete.)

2001-06-23  Jason Leach  <jleach@ximian.com>

	* e-shell-folder-selection-dialog.c
	(e_shell_folder_selection_dialog_construct): Make the folder tree
	have a similar expanded state as the shell's folder tree.

	* e-local-storage.c (remove_folder): New function that does the
	meat of actual deletion stuff.
	(remove_folder_directory): A helper function that remove_folder()
	uses.
	(component_async_remove_folder_callback): A new callback to do the
	removing stuff from shell (if there weren't errors from the
	component).
	(impl_async_remove_folder): Implemented this.

	* evolution-shell-component-client.c
	(evolution_shell_component_client_async_remove_folder):
	Implemented this.

	* e-shell-view.c (e_shell_view_remove_control_for_uri): New
	function.

svn path=/trunk/; revision=10446
2001-06-23 18:58:02 +00:00
63f6e70ecc Allow a NULL @shell_view arg in
`e_shell_command_add_to_shortcut_bar()'.

svn path=/trunk/; revision=10160
2001-06-08 18:51:04 +00:00
9a3c412e4f Plug in all the folder tree right click menu verbs so bonobo-warnings
2001-06-05  Jason Leach  <jleach@ximian.com>

	* e-shell-view-menu.c: Plug in all the folder tree right click
	menu verbs so bonobo-warnings aren't emitted (even though the
	respective implementation functions are currently unimplemented).
	(command_delete_folder): New function, see above.
	(command_rename_folder): Ditto.
	(command_folder_properties): Ditto.

	* e-shell-folder-commands.c (e_shell_command_delete_folder): New
	function, currently unimplemented.

svn path=/trunk/; revision=10128
2001-06-06 00:05:53 +00:00
65460ea535 New function (probably should just be static).
2001-05-30  Jason Leach  <jleach@ximian.com>

	* e-shell-view.c (e_shell_view_set_current_shortcuts_group_num):
	New function (probably should just be static).
	(e_shell_view_load_settings): Load the current shortcut group here
	using the above new function.
	(e_shell_view_save_settings): Save current shortcut group in here.

2001-05-30  Jason Leach  <jleach@ximian.com>

	* e-shell-folder-title-bar.c: New 'folder_bar_label' member for
	EShellFolderTitleBar, it's for information that's shown to the
	left of the icon like the dates in the calendar (or, potentially
	total and unread numbers for mailer).
	(e_shell_folder_title_bar_set_folder_bar_label): New function,
	lets others set the title bar extra label.

	* Evolution-ShellView.idl: New method 'setFolderBarLabel' for our
	exposed ShellView interface.

	* evolution-shell-view.c (class_init): New signal
	"set_folder_bar_label" for EvolutionShellViewClass.

	* evolution-shell-view.c (impl_ShellView_set_folder_bar_label):
	Emit the new signal here.

	* e-shell-view.c (setup_corba_interface): Connect the signal here.

	* e-shell-view.c (corba_interface_set_folder_bar_label): New
	function, callback for the above signals, does the actual extra
	label setting for the folder title bar.

	* e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
	Fix a warning here.

svn path=/trunk/; revision=10059
2001-05-31 00:24:59 +00:00
225120f19f Removed an unecessary sleep(2) call, so evolution will start up 2 seconds
2001-05-30  Jason Leach  <jleach@ximian.com>

	* e-shell.c (e_shell_construct): Removed an unecessary sleep(2)
	call, so evolution will start up 2 seconds faster now.

2001-05-30  Jason Leach  <jleach@ximian.com>

	* e-shell-view-menu.c: Connect the AddFolderToShortcutBar verb to
	their implementation functions.

	* e-shell-view.c (e_shell_view_get_current_shortcuts_group_num):
	New function, use it to find out which shourtcut group is
	currently open on the shortcut bar.

	* e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
	Implement this using new function described above.

svn path=/trunk/; revision=10052
2001-05-30 19:39:47 +00:00
9288ec2e2c Added ETSPECDIR. Added e-storage-set-view.etspec to get installed.
2001-05-21  Christopher James Lahey  <clahey@ximian.com>

	* Makefile.am (INCLUDES): Added ETSPECDIR.  Added
	e-storage-set-view.etspec to get installed.

	* e-local-storage.c (remove_folder_directory): Commented out this
	function since it is unused.

	* e-shell-folder-commands.c
	(folder_selection_dialog_folder_selected_callback), e-shell-view.c
	(update_offline_toggle_status): Fixed warnings here by adding a
	return; after the g_assert_not_reached();.

	* e-shell-importer.c (start_import): Got rid of real_folderpath
	here and just reused folderpath (It was causing uninitialized
	variable warnings.)

	* e-shell.c (impl_Shell_getLocalStorage): Use
	bonobo_object_dup_ref here.  It makes things simpler.

	* e-storage-set-view.c: Removed ETREE_SPEC since it's no longer
	needed.
	(convert_corba_drag_action_set_to_gdk,
	folder_context_menu_activate_cb, remove_cb,
	folder_context_menu_remove_cb): Commented out these functions
	since they're unused.
	(new_storage_cb, new_folder_cb, insert_folders, insert_storages):
	Don't bother using insert_id here since it no longer does
	anything.
	(new_storage_cb, removed_storage_cb, removed_folder_cb): Don't
	free the data returned from e_tree_memory_node_remove.
	(e_storage_set_view_construct): Set the destroy func here so that
	memory will automatically get freed when nodes are destroyed.
	g_strdup the root node string here.  Use
	e_tree_construct_from_spec_file here to use an external file.
	(e_storage_set_view_set_show_folders): g_strdup the root node
	string here.

	* e-storage-set-view.etspec: New etspec file.

	* evolution-shell-component-client.c
	(free_ShellComponentListener_servant): Added a prototype here.

svn path=/trunk/; revision=9989
2001-05-25 18:35:40 +00:00
e9a5c3d19c Implemented the "Copy Folder" and "Move Folder" menu items. Untested.
svn path=/trunk/; revision=9899
2001-05-20 14:45:47 +00:00
3e519c4e14 Renamed the "NewWindow" verb into "OpenFolderInNewWindow". Got the
`File -> Folder -> Open in New Window' menu item to work.

svn path=/trunk/; revision=9893
2001-05-19 15:29:19 +00:00
bb6a06a3cb Create new files for the folder commands, and move the "Create new
folder" implementation into them.

svn path=/trunk/; revision=9889
2001-05-19 12:40:00 +00:00