2002-12-13 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (check_send_configuration): Make sure the
folder-browser is not NULL or we'll crash.
svn path=/trunk/; revision=19115
2002-12-13 Jeffrey Stedfast <fejj@ximian.com>
* mail-preferences.c (mail_preferences_construct): Fix the colour
code to get a guint32 rgb correctly (I think - can't test because
the shell keeps crashing, yay).
svn path=/trunk/; revision=19114
2002-12-13 Jeffrey Stedfast <fejj@ximian.com>
* mail-session.c: Get rid of unneeded CamelObject casts.
(user_message_response): Don't unref the dialog object after we've
destroyed it.
* mail-display.c (write_data_to_file): Don't unref the dialog
object after we've destroyed it.
* mail-callbacks.c: Same here.
* component-factory.c: Here too.
* message-tag-editor.c: Added MESSAGE_TAG_EDITOR_GET_CLASS macros.
svn path=/trunk/; revision=19112
2002-12-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_delete_clicked): Get rid of the ETable
#ifdef's - we won't ever be using ETable.
(account_default_clicked): Same.
(account_able_clicked): Here too.
(mail_accounts_load): And here.
(mail_accounts_treeview_new): Renamed from etable_new since we
won't ever be using an etable.
(mail_accounts_tab_construct): And finally here.
svn path=/trunk/; revision=19104
2002-12-11 Jeffrey Stedfast <fejj@ximian.com>
* mail-format.c (mail_format_data_wrapper_write_to_stream): New
function to handle a lot of the filtering/etc that was done in
mail_format_get_data_wrapper_text(). This is the first step toward
getting rid of e-text-to-html crap and using my tohtml stream
filter instead.
(mail_format_get_data_wrapper_text): Use the new function.
(mail_format_raw_message): Use camel streams to write the content
to gtkhtml rather than using get_data_wrapper_text() and then
converting that to html and then writing it to the gtkhtml stream.
svn path=/trunk/; revision=19098
2002-12-10 Not Zed <NotZed@Ximian.com>
* mail-composer-prefs.c (mail_composer_prefs_construct): language
is a treeview now. Not sure what to do with it yet, but get rid
of one warning anyway.
(mail_composer_prefs_construct): Same for sig_clist, but setup
model.
(sig_fill_clist): Change to use a gtktreeview instead of a clist.
(sig_selection_changed): New method to handle signature selection
changes with the new widgets.
(sig_delete): clist -> treeview.
(mail_composer_prefs_new_signature): Same.
(sig_edit): ditto.
(sig_current_sig): removed.
(sig_row_unselect): Removed.
(sig_row_select): Removed, now redundant.
(spell_select_lang): Removed, redundant.
(spell_set_ui_language): New implementation using list model more
effectively.
(spell_get_language_str): Same here.
(spell_set_ui_language): Removed this too, merged into
spell_set_ui, it was just wasting stack space.
(spell_language_selection_changed): renemd from
spell_language_select_row, converted to gtktreeview, etc.
(spell_language_unselect_row): Removed.
(spell_language_enable): Redone to use tree model.
(spell_language_button_press): Removed, i dont think this is
needed anymore.
(spell_setup): dont hook onto redundant signals.
* mail-config-factory.c (config_control_factory_cb): ignore
mail-font-prefs in a different way (so we dont assert)
svn path=/trunk/; revision=19084
2002-12-03 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (guess_me_from_accounts): Use the same logic as
mail_generate_reply(). Fixes bug #34882
Fixes bug #34315
* component-factory.c (message_rfc822_dnd): Return TRUE if we
successfully handled all messages in the mbox stream, or FALSE
otherwise.
(destination_folder_handle_drop): For TEXT_URI_LIST, use the
retval from message_rfc822_dnd() rather than relying on an
exception, because one will not always necessarily be set. For
MESSAGE_RFC822, also use the retval from message_rfc822_dnd().
svn path=/trunk/; revision=18995
2002-12-03 Not Zed <NotZed@Ximian.com>
* folder-browser.c (folder_browser_finalise/destroy): frobbed
around with these till it exits without crashing.
* message-list.c (message_list_destroy): made a destroy
handler again (was dispose). Frobbed around with this and
finalise till it can destroy without crashing.
* message-browser.c (message_browser_new): ref/sink the
folderbrowser.
svn path=/trunk/; revision=18991
2002-11-27 Not Zed <NotZed@Ximian.com>
* message-tag-followup.c (construct): gnome_pixmap -> gtkimage.
(construct): gtk_clist -> gtk_tree_view, setup columns. They dont
size well :-/
(message_tag_followup_append_message): Append using model, remove
clist stuff.
(construct): Show date edit (glade bugs?)
* folder-browser.c (folder_browser_class_init): gtk_marshal -> g_cclosure_marshal
(setup_popup_icons): gnome_pixmap -> gtk_image.
(on_right_click): gtk_pixmap -> gtk_image.
* mail-accounts.c (account_delete_clicked): removed #if 0'd out code.
* mail-send-recv.c (receive_done): remove FIXME and extra unref.
* mail-session.c (request_password): Removed #if 0'd out stuff.
* mail-vfolder.c (new_rule_clicked): proper cast for g_object_get_data.
* mail-local.c (reconfigure_response): cast for g_object_get_data.
* mail-account-editor.c (construct): GNOME_DIALOG -> GTK_DIALOG.
* *.[ch]: re-ran fix.sh for e_notice change
* mail-callbacks.c (save_msg_ok): g_object_get_data +
gtk_object_remove_no_notify -> g_object_steal_data.
(find_socket): gtk_container_children ->
gtk_container_get_children
(edit_msg): gnome_*_dialog -> gtk_message_dialog.
(resent_msg): "
(search_msg): "
(confirm_goto_next_folder): gtkmessagedialogised (even if not
used).
(confirm_expunge): gtkmessagedialogised
(filter_edit): "
(do_mail_print): e_notice -> gtk_message_dialog.
(are_you_sure): removed e_gnome_ok_cancel_dialog crap, replaced
with a gtk dialog.
(are_you_sure): gtkmessagedialogised.
(edit_msg_internal): Dont free uids array, are_you_sure() free's
it.
(resend_msg): Same.
(check_send_configuration): Use e_notice for stuff. Sigh, here we
go again ...!
(e_question): A utility function to ask a question, potentially
with 'dont ask again' as well.
(configure_mail): use e_question to save code. Here we go again,
again ...
(ask_confirm_for_unwanted_html_mail): "
(ask_confirm_for_only_bcc): "
(ask_confirm_for_only_bcc): "
(composer_get_message): Use e_notice.
(composer_save_draft_cb): Use e_question
(edit_msg): use e_notice, & change to an ERROR.
(resend_msg): same.
(save_msg_ok): Properly initialise ret to OK, and use e_question,
and use access() to determine existance/write access rather than
stat, display an error if we can't write to a file that exists,
and print the filename in all dialogues.
(confirm_goto_next_folder): Use e_question.
(confirm_expunge): use e_question.
(filter_edit): Use e_notice.
(do_mail_print): use e_notice.
svn path=/trunk/; revision=18974
2002-11-26 Not Zed <NotZed@Ximian.com>
* mail-vfolder.c (vfolder_gui_add_rule): clicked->response signal
for gtk dialogue.
(new_rule_clicked): Dont unref after destroy (duh, idiot again).
(edit_rule_response): Same here.
(mail_vfolder_delete_uri): Connect response signal to
gtk_widget_destroy directrly using g_signal_connect_swapped.
(close_dialogue): Removed, as no longer needed.
svn path=/trunk/; revision=18925
2002-11-26 Not Zed <NotZed@Ximian.com>
* message-list.c (get_normalised_string): Duh idiot, "un-fixed"
the memleak i added.
* mail-callbacks.c (composer_get_message): Set parent window in
message dialogue & DESTROY_WITH_PARENT flag.
(composer_save_draft_cb):
(configure_mail):
(check_send_configuration): Add DESTROY_WITH_PARENT flag to
gtk_message_dialog's
(local_configure_done): remove some unecessary/wrong casts.
(empty_trash_expunged_cb): "
(do_mail_print): use gtk_window_set_transient_for instead of
e_dialog_set_parent.
svn path=/trunk/; revision=18923
2002-11-26 Not Zed <NotZed@Ximian.com>
* mail-account-editor.c (mail_account_editor_new):
gtk_widget_set_parent_window -> gtk_window_set_transient_for.
* mail-callbacks.c (composer_send_queued_cb): dont unref composer.
* message-browser.c (message_browser_destroy): moved back from
finalise.
2002-11-25 Not Zed <NotZed@Ximian.com>
* message-list.c (message_list_dispose): move saving tree state
here.
(message_list_finalise): And take it from here.
* mail-display.c (mail_display_destroy): @#$@# gtk. changed this
around a bit.
(mail_display_init): Fix prototype, its a gobject.
(mail_display_init): ref/sink the invisible gtkobject.
svn path=/trunk/; revision=18919
2002-11-22 Not Zed <NotZed@Ximian.com>
* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): removed
e_messagebox, and use gtk_message_dialog directly.
(ask_confirm_for_empty_subject): and here.
(ask_confirm_for_only_bcc): And here too.
(msgbox_destroy_cb): Removed, since no longer needed.
svn path=/trunk/; revision=18905
2002-11-15 Harry Lu <harry.lu@sun.com>
* mail-display.c (write_data_to_file): Show file name when prompt
to user for overwrite. Fixes bug #34180.
svn path=/trunk/; revision=18887
2002-11-15 Harry Lu <harry.lu@sun.com>
* mail-display.c (write_data_to_file): Show file name when prompt
to user for overwrite.
svn path=/trunk/; revision=18886
2002-11-21 Harry Lu <harry.lu@sun.com>
* mail-display.c (do_attachment_header): Enable dragging of all
attachments. For bug #34327.
svn path=/trunk/; revision=18882
2002-11-21 Jeffrey Stedfast <fejj@ximian.com>
* mail-preferences.c (mail_preferences_construct): Since the
GSList returned from gconf needs to be free'd by us, we don't need
to strdup the values. Also make sure we don't leak the GSList
itself.
(mail_preferences_apply): Don't leak our GSList data.
svn path=/trunk/; revision=18878
2002-11-20 Not Zed <NotZed@Ximian.com>
* importers/Makefile.am (%.server.in): provide a proper implicit
rule for building .server.in from .server.in.in. The other one
just copied the first target to all destinations(!).
* importers/evolution-outlook-importer.c (outlook_factory_fn):
destroy -> weak ref.
svn path=/trunk/; revision=18855
2002-11-19 Jeffrey Stedfast <fejj@ximian.com>
* mail-preferences.c (mail_preferences_apply): Save the settings
via gconf.
(mail_preferences_construct): Load the values from gconf.
svn path=/trunk/; revision=18848
2002-11-19 Not Zed <NotZed@Ximian.com>
* importers/evolution-mbox-importer.c (mail_importer_module_init):
fix warning message, outlook->mbox.
* importers/Makefile.am: fix serverdir to point to
$libdir/bonobo/servers.
* mail-callbacks.c (addrbook_sender): add type to
bonobo_widget_set_property.
* mail-vfolder.c (vfolder_editor_response): dont unref after destroy.
* mail-session.c (pass_response): dont unref aftrer destroy.
* mail-local.c (reconfigure_response): dont unref after destroy.
* mail-display.c (launch_cb): dont unref after destroy.
(launch_cb): "
(drag_data_get_cb): "
(html_button_press_event): add type to bonobo_widget::set_property
* mail-config.c (mail_config_check_service): dont unref after
destroy.
* component-factory.c (send_receive_cb): dont unref after destroy.
(request_quit): "
* mail-signature-editor.c (mail_signature_editor): Use version 3.0
of gtkhtml editor interfaces.
(do_exit): dont unref after destroy.
(format_html_cb): Add type to bonobo_widget::set_property.
svn path=/trunk/; revision=18837
2002-11-18 Not Zed <NotZed@Ximian.com>
* Makefile.am (evolution_mail_LDADD): Added back
libevolution-importer stuff.
(SUBDIRS): Added back importers.
* importers/evolution-mbox-importer.c (load_file_fn): build the
uri without deprecated funcs.
(load_file_fn): dont free/alloc a camel_exception for no obvious
purpose.
(mbox_factory_fn): use weak_ref rather than destroy.
(importer_destroy_cb): fix signature for weak ref notify.
(mbox_factory_fn): add cid param.
* importers/*.[ch]: ran fix script over everything.
* importers/*.server.in.in: Added bonobo activation files. Moved
evolution-mail to @LIBEXEC@ as below.
* importers/Makefile.am: oaf->bonobo activation stuff.
* importers/evolution-outlook-importer.c (outlook_factory_fn): Add
component id to callback.
svn path=/trunk/; revision=18822
* Makefile.am: Add rules to substitute @LIBEXEC@ in
GNOME_Evolution_Mail.server.in.in and install evolution-mail in
$(libexecdir) instead of $(bindir).
* GNOME_Evolution_Mail.server.in.in: Replaced evolution-mail with
@LIBEXECDIR@/evolution-mail.
svn path=/trunk/; revision=18790
2002-11-15 Not Zed <NotZed@Ximian.com>
* mail-summary.c (create_summary_view): weak notify -> ref.
* mail-send-recv.c (build_dialogue): weak notify -> ref.
* mail-accounts.c (account_edit_clicked): weak notify -> ref, i
presume this is what jeff meant, 'cause it dont compile otherwise.
svn path=/trunk/; revision=18778
2002-11-14 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_edit_clicked): Use g_object_weak_ref
rather than connecting to destroy.
(account_add_clicked): Same.
* mail-callbacks.c (addrbook_sender): Make this use
g_object_weak_notify also.
(subscribe_dialog_destroy): Add NULL guards here since I think we
really do want to connect to the "destroy" signal in the function
that connects us to that signal.
* mail-config-factory.c (config_control_factory_cb): Same.
* mail-display.c (save_part): Here too.
(make_popup_window): And here.
* mail-send-recv.c (build_dialogue): Same here.
* mail-summary.c (create_summary_view): Use g_object_weak_notify
instead of connecting to the destroy signal.
svn path=/trunk/; revision=18764
2002-11-13 Joe Shaw <joe@ximian.com>
* Makefile.am: Remove a couple backslashes that were causing
automake to complain, even though they were on lines that were
-commented out-. Sigh.
svn path=/trunk/; revision=18746
