Commit Graph

147 Commits

Author SHA1 Message Date
Matthew Barnes a211742940 Use GcrCertificateWidget to view certificates.
e_cert_manager_new_certificate_viewer() now builds a simple GtkDialog
with a GcrCertificateWidget showing details about the given ECert.
2013-09-24 16:33:11 -04:00
Matthew Barnes 3da4948c0f Miscellaneous cleanups. 2013-09-07 19:08:54 -04:00
Milan Crha 9b44f89c94 Bug #705814 - Crash in certificate_viewer_new() 2013-08-12 09:06:55 +02:00
Milan Crha 0985c6d801 Ask for a Smart Card password with a token name too
Some cards can have two PINs, one 'global' and one 'application'.
NSS provides which token is required, but Evolution didn't show
that information to a user.
2013-05-31 15:47:04 +02:00
Matthew Barnes 70a9fcdf9c Rename libeshell to libevolution-shell.
To make Evolution's shared libraries more consistent.

Also rename the documentation module to evolution-shell.
2013-05-28 09:56:30 -04:00
Matthew Barnes 6c9a3243c9 Rename libeutil to libevolution-util.
To make Evolution's shared libraries more consistent.

Also rename the documentation module to evolution-util.
2013-05-28 09:56:30 -04:00
Milan Crha 9c6a7673b8 Add comments around g_idle_add() changes 2013-02-08 18:26:49 +01:00
Michel Dänzer eb9e927926 Bug #683867 - Schedule actions with higher idle priority 2013-02-08 18:26:48 +01:00
Matthew Barnes 6ba0a6a95b Revert "Bug #683867 - Schedule actions with higher idle priority"
This reverts commit 2b507716b2.

The commit contains not a single comment as to why these custom priority
values are being used.  The rationale needs to be documented in the code,
either at each call point or preferrably at a centralized priority value
definition.
2013-02-08 07:03:26 -05:00
Michel Dänzer 2b507716b2 Bug #683867 - Schedule actions with higher idle priority 2013-02-08 12:37:30 +01:00
Matthew Barnes b1ed35f70d Coding style and whitespace cleanup. 2013-01-10 11:20:32 -05:00
Matthew Barnes 6faf671382 e-passwords: Remove unused function parameters. 2012-12-16 17:03:54 -05:00
Matthew Barnes bed06d9ec3 Move the contact map widgets to addressbook/gui/widgets.
Move the supporting widgets for the contact maps feature alongside
EABContactDisplay.  Removing them from libeutil helps isolate our usage
of libchamplain so it's not imposed on the entire application, and even
3rd party software.  That libchamplain is an optional dependency only
further complicates the matter.

Ideally I'd like to somehow isolate this feature in an extension module,
but we currently lack sufficient hooks for such an extension.  So this
arrangement will have to suffice for now.
2012-12-12 14:33:47 -05:00
Matthew Barnes d09d8de870 Consolidate base utility libraries into libeutil.
Evolution consists of entirely too many small utility libraries, which
increases linking and loading time, places a burden on higher layers of
the application (e.g. modules) which has to remember to link to all the
small in-tree utility libraries, and makes it difficult to generate API
documentation for these utility libraries in one Gtk-Doc module.

Merge the following utility libraries under the umbrella of libeutil,
and enforce a single-include policy on libeutil so we can reorganize
the files as desired without disrupting its pseudo-public API.

   libemail-utils/libemail-utils.la
   libevolution-utils/libevolution-utils.la
   filter/libfilter.la
   widgets/e-timezone-dialog/libetimezonedialog.la
   widgets/menus/libmenus.la
   widgets/misc/libemiscwidgets.la
   widgets/table/libetable.la
   widgets/text/libetext.la

This also merges libedataserverui from the Evolution-Data-Server module,
since Evolution is its only consumer nowadays, and I'd like to make some
improvements to those APIs without concern for backward-compatibility.

And finally, start a Gtk-Doc module for libeutil.  It's going to be a
project just getting all the symbols _listed_ much less _documented_.
But the skeletal structure is in place and I'm off to a good start.
2012-12-12 14:33:43 -05:00
Milan Crha 8a1eb1f24e Use the same certificate-viewer as the trust-prompt from eds
This way it'll be possible to copy whole files if change in one
of them will be done. A real code reuse, rather than copy, would be
ideal, but the trust-prompt is just a module for evolution-user-prompter.
2012-12-11 19:48:07 +01:00
Milan Crha c180436841 Do not restore certificate manager columns when all are hidden
If all columns are hidden, then header of a GtkTreeView is also hidden,
thus there is no way to show columns again, which results in empty
Certificate Preferences view.
2012-12-11 09:38:46 +01:00
Milan Crha ab3f65a15e Address couple issues found by a Coverity scan 2012-11-30 15:30:45 +01:00
Matthew Barnes d2fb5ee1a8 Avoid using GdkEventButton directly in certain places.
Prefer dealing with GdkEvent pointers and using accessor functions like
gdk_event_get_button().

This is complicated by the fact that some GtkWidget method declarations
still use GdkEventButton pointers, and synthesizing button events pretty
much requires direct GdkEventButton access.  But GDK seems to be nudging
itself toward sealing the GdkEvent union.  Likely to happen in GDK4.

Mainly clean up signal handlers and leave method overrides alone for now.
2012-11-29 13:24:24 -05:00
Matthew Barnes 2c4ae5e768 Coding style and whitespace cleanup. 2012-11-10 15:54:43 -05:00
Matthew Barnes c85109fc32 Coding style and whitespace cleanup. 2012-08-19 14:17:55 -04:00
Matthew Barnes 2a39437ee9 Adapt to single-include E-D-S libraries. 2012-06-03 15:14:03 -04:00
Milan Crha 71924fc487 Fix memory leaks around gtk_tree_model_get() function 2012-05-31 10:44:49 +02:00
Matthew Barnes b4f895265d Add missing linker flags. 2012-03-03 14:11:12 -05:00
Matthew Barnes 23f5773903 Coding style and whitespace cleanup. 2012-02-20 10:04:25 -05:00
H. Habighorst 1600064022 Bug #591436 - Add -avoid-version to LDFLAGS 2012-02-15 11:22:21 +01:00
Gabor Kelemen 4ca964860b Bug 664160 - Untranslated headers in certificates table 2012-02-01 09:13:49 -05:00
Matthew Barnes d6591fc2bd Bug 661650 - "Certificate Authority Trust" strings miss mnemonics 2011-10-13 12:11:11 -04:00
Matthew Barnes 1f38f4d92c Simplify library dependency flags.
We have a confusing array of nearly-identical CFLAGS/LIBS definitions in
configure.ac.  Time to simplify.  Instead let's just have one definition
that includes all the libraries provided by Evolution-Data-Server (incl.
Camel).  That, in combination with GNOME_PLATFORM, gives us most of what
we need for compliation and linking, and we can sprinkle definitions for
additional library dependencies in Makefile.am's as needed.
2011-10-04 22:27:14 -04:00
Dan Vrátil d8487201c1 Bug 660584 - Fix crash when removing user certificate 2011-09-30 23:15:38 +02:00
Matthew Barnes e2b6ff7a6c Miscellaneous cleanups from the account-mgmt branch.
Reducing diff noise so I can see important changes easier when comparing
branches.  A few API changes, but nothing that affects functionality.
2011-09-27 09:31:13 -04:00
Matthew Barnes fcbbdfbd18 Coding style and whitespace cleanup. 2011-09-04 07:34:32 -04:00
Matthew Barnes f59681796d Coding style and whitespace cleanup. 2011-08-13 11:27:51 -04:00
Andre Klapper b6bbbb1c61 Use email instead of e-mail spelling, like anywhere else 2011-07-28 12:35:11 +02:00
Matthew Barnes 4941d7ea79 Coding style and whitespace cleanups. 2011-07-23 11:06:15 -05:00
Matthew Barnes 99d492b828 Adapt to CamelSession and e-passwords changes. 2011-07-04 10:20:54 -04:00
Dan Vrátil f830de2f0a Bug #252670 - Remember columns settings in Certificates tab 2011-06-14 16:15:28 +02:00
Matthew Barnes 8a186c3588 Coding style cleanups. 2011-05-08 13:37:20 -04:00
Matthew Barnes ba05584de5 Dialogs no longer have separators. 2011-01-25 10:28:26 -05:00
Milan Crha b09b3e9cca Bug #633779 - GtkComboBoxText issues 2010-11-18 13:35:36 +01:00
Milan Crha 2de2e7f12f Workaround GtkComboBoxText/GtkComboBoxEntry in .ui files 2010-10-27 21:43:25 +02:00
Matthias Clasen 8da37ea812 Bug 632641 - Handle combo box text API going away 2010-10-20 15:08:16 -04:00
David Woodhouse 75d1c75617 Bug 626066 - log in to NSS database on demand for changing trust 2010-09-13 21:02:57 +01:00
Matthew Barnes cd53ba9900 Coding style cleanups. 2010-09-13 08:28:58 -04:00
David Woodhouse fab32c94a1 Bug 626066 - log in to NSS database before invoking certificate manager 2010-09-12 17:00:44 +01:00
Matthew Barnes e6067ccb6c Bug 616073 - Various translation issues 2010-09-10 18:51:26 -04:00
Matthew Barnes 4e9050bc1e Whitespace and coding style cleanup. 2010-08-13 21:32:32 -04:00
Michael Meeks 18813ccd8f Defer the load / creation of configuration UI with changes to
e_preferences_window to take factory callbacks and store a reference
to the shell. - This makes start-up substantially faster, particularly
on Atom (eg.).

Remove a number of idle handlers used to create these UIs in the
first instance, cleaning the code.
2010-08-10 21:17:40 +01:00
Matthew Barnes d3d4fbbe25 Bug 624237 - Fails to start when smartcard is inserted 2010-07-14 10:40:20 -04:00
Milan Crha 077116eac4 Bug #619218 - Should select imported certificate when succeeded 2010-06-11 19:28:16 +02:00
Philip Withnall 2c90bea1a1 Miscellaneous string fixes
Various small string fixes, from missing "the"s and small typos, to removal
of extraneous "whether or not"s. Helps: bgo#615712
2010-04-18 10:06:43 +01:00