Commit Graph

1795 Commits

Author SHA1 Message Date
996f1063f9 don't do the CURSOR_FIRST checks if cursor is NULL [43523]
2003-06-13  Mike Kestner  <mkestner@ximian.com>

	* e-tree.c (et_search_search): don't do the CURSOR_FIRST
	checks if cursor is NULL [43523]

2003-06-13  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_get_cell_background_color): update to
	an alt row color more consistent with gtktreeview. [44610]

svn path=/trunk/; revision=21440
2003-06-13 22:27:03 +00:00
fd2b10f13c missed the changelog entry last time.
svn path=/trunk/; revision=21432
2003-06-13 15:44:33 +00:00
1377ba2908 i2003-06-13 Larry Ewing <lewing@ximian.com>
* gal/widgets/e-canvas.c (e_canvas_dispose): unref the im_context.

svn path=/trunk/; revision=21430
2003-06-13 15:13:05 +00:00
51ca9977c7 Put the ChangeLog.pre-1-4 in the Makefiles.
svn path=/trunk/; revision=21426
2003-06-12 21:13:59 +00:00
a37e4f4213 guard against NULL strings don't add disabled column titles to the store.
2003-06-12  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (generate_layout): guard against NULL strings
	* e-table-config.c (create_global_store): don't add disabled
	column titles to the store. [44258]
	* e-tree-table-adapter.c (e_t_t_a_node_set_expanded): don't
	warn if we're trying to collapse a node that's not visible.
	* e-tree.c (et_connect_to_etta): don't connect to row_inserted
	and row_deleted. [43893]

svn path=/trunk/; revision=21424
2003-06-12 13:35:46 +00:00
62a2b36c72 take ownership of the duplicate string.
2003-06-11  Larry Ewing  <lewing@ximian.com>

	* e-search-bar.c (impl_get_property): take ownership of the
	duplicate string.

svn path=/trunk/; revision=21417
2003-06-11 21:32:40 +00:00
fd2f3a6d7a Roll over ChangeLogs.
svn path=/trunk/; revision=21387
2003-06-09 17:31:26 +00:00
79f2149fd1 Fixes #43775
2003-05-29  JP Rosevear  <jpr@ximian.com>

	Fixes #43775

	* e-calendar-item.c (layout_set_day_text): calculate the day
	character correctly
	(e_calendar_item_draw_month): use it

	* e-dateedit.c (rebuild_time_popup): use e_utf8_strftime
	(e_date_edit_update_date_entry): ditto
	(e_date_edit_update_time_entry): ditto

	* e-calendar-item.c (layout_set_day_text): calculate the day
	character correctly
	(e_calendar_item_draw_month): use e_utf8_strftime and above
	(e_calendar_item_show_popup_menu): use e_utf8_strftime
	(e_calendar_item_recalc_sizes): use layout_set_day_text

svn path=/trunk/; revision=21352
2003-05-30 17:32:31 +00:00
0701e570aa bump libtool version for api addition new, utf8 in/out
2003-05-28  Mike Kestner  <mkestner@ximian.com>

	* configure.in : bump libtool version for api addition
	* gal/util/e-util.c (e_utf8_strftime): new, utf8 in/out
	(e_utf8_strftime_fix_am_pm): new, utf8 in/out

2003-05-28  Mike Kestner  <mkestner@ximian.com>

	* e-cell-date.c (ecd_get_text): use e_utf8_strftime_fix_am_pm
	and remove locale to utf8 conversion at end.  [43485]

svn path=/trunk/; revision=21343
2003-05-28 21:32:52 +00:00
3c4aef5b41 to really fix 42952 use e_table_item_get_cell_geometry. Also a couple
2003-05-20  Ettore Perazzoli  <ettore@ximian.com>

	* e-tree.c (tree_canvas_size_allocate): to really fix 42952
	use e_table_item_get_cell_geometry.  Also a couple valgrind
	and g_warning fixes related to this change from Mike.

svn path=/trunk/; revision=21303
2003-05-21 16:02:59 +00:00
f6f73451c5 Added HIG-appropriate spacing/ padding to the main hbox into which the
2003-05-19  Anna Marie Dirks  <anna@ximian.com>

	* e-multi-config-dialog.c (init): Added HIG-appropriate spacing/
	padding to the main hbox into which the icons and page widgets
	are packed.

svn path=/trunk/; revision=21265
2003-05-19 18:51:06 +00:00
fcb80018c0 revert a broken CLEAN_FILES change. [42478]
2003-05-19  Mike Kestner  <mkestner@ximian.com>

	* Makefile.am : revert a broken CLEAN_FILES change. [42478]

2003-05-19  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): don't call any line breaking
	or justification code if the width <= 0 since it's pointless
	and apparently pango likes to crash when you do. [43199]

svn path=/trunk/; revision=21260
2003-05-19 18:37:12 +00:00
0a590f3a85 HIG-ified the spacing, padding, alignment of this dialog. Fixes bug #41148
2003-05-19  Anna Marie Dirks  <anna@ximian.com>

	* e-timezone-dialog/e-timezone-dialog.glade: HIG-ified the
	spacing, padding, alignment of this dialog. Fixes bug #41148

svn path=/trunk/; revision=21253
2003-05-19 15:45:55 +00:00
41dba7ad48 port to GtkDialog.
2003-05-19  Larry Ewing  <lewing@ximian.com>

	* e-charset-picker.c: port to GtkDialog.

svn path=/trunk/; revision=21244
2003-05-19 13:54:21 +00:00
d09737dec4 block the signal that got us here until we're done to stop an infinite
2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* gal-view-collection.c (view_changed): block the signal
	that got us here until we're done to stop an infinite
	recursion.  Fixes 43153.

2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (invisible_finalize): kill
	(ect_stop_editing): destroy the invisible, not weak_unref
	(e_cell_text_view_get_invisible): don't weak_ref the invisible
	since we own its ref.

2003-05-16  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_event): fix a couple timer checks
	* e-tree-table-adapter.c (update_node): Traverse POST order
	so that the parent nodes are at the head of the prepended list.
	Don't restore expanded state to nodes that aren't in the tree
	any longer.  Hopefully fixes #42856.

svn path=/trunk/; revision=21229
2003-05-16 21:58:33 +00:00
2d6fce0574 Added appropriate padding/spacing to the categories list dialog. Fixes the
2003-05-16  Anna Marie Dirks  <anna@ximian.com>

	* gal/widgets/e-categories.c: Added appropriate padding/spacing
	to the categories list dialog. Fixes the rest of #41217.

	* gal/widgets/e-categories-master-list-dialog.glade: HIG-ified
	this dialog.

	* gal/widgets/gal-categories.glade: HIG-ified this dialog
	(in terms of spacing/padding). Fixes most of bug #41217

svn path=/trunk/; revision=21228
2003-05-16 20:16:42 +00:00
2679330687 Make sure the galview.xml file exists before trying to parse it with
2003-05-16  Jeffrey Stedfast  <fejj@ximian.com>

	* gal-view-collection.c (load_single_dir): Make sure the
	galview.xml file exists before trying to parse it with
	xmlParseFile() to avoid warning spewage from libxml2.

svn path=/trunk/; revision=21219
2003-05-16 18:27:37 +00:00
7e7b7f49e8 Disable debugging messages.
* gal-view-collection.c (d): Disable debugging messages.

* gal-view-instance.c (d): Disable debugging messages.

svn path=/trunk/; revision=21198
2003-05-15 21:56:40 +00:00
b47a4aa4ee (tree_canvas_size_allocate): Call
tree_canvas_reflow_idle() before deciding whether to move the
adjustment, not afterwards.  [#42952]

svn path=/trunk/; revision=21197
2003-05-15 20:58:15 +00:00
6cdf75996f use weak refs not datasets. (e_tree_dispose): weak_unref the context.
2003-05-14  Mike Kestner  <mkestner@ximian.com>

	* e-tree-c (context_connect): use weak refs not datasets.
	(e_tree_dispose): weak_unref the context.
	Hopefully fixes 42617.

svn path=/trunk/; revision=21195
2003-05-15 18:33:47 +00:00
d49d8a2f15 guard against multiple destroys
2003-05-14  JP Rosevear  <jpr@ximian.com>

	* e-combo-button.c (impl_destroy): guard against multiple destroys

2003-05-14  JP Rosevear  <jpr@ximian.com>

	* menus/gal-view-menus.c (gvm_finalize): unref the component

svn path=/trunk/; revision=21178
2003-05-14 18:42:38 +00:00
6e8895d6e8 gross hack to work around a post dispose event emission by
2003-05-13  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_event): gross hack to work around a
	post dispose event emission by gtk2.0/canvas2.0 [#42622]

svn path=/trunk/; revision=21174
2003-05-14 17:56:50 +00:00
2579e70339 [ fixes several utf8/pango related problems, including bugs #41288,
2003-05-13  Chris Toshok  <toshok@ximian.com>

	[ fixes several utf8/pango related problems, including bugs
	#41288, #42596, #42604 ]

	* configure.in (GAL_CURRENT): bump to 3, per mkestner.
	(GAL_REVISION): drop to 0, per mkestner.

	* gal/e-text/e-text.c (reset_layout_attrs): we need to convert the
	start/end bounds of the object to byte indices for the attribute.
	(reset_layout): in the layout == NULL case don't create the layout
	then immediately set it again with the same text.  also, we need
	to convert selection_start to a byte index before calling
	pango_layout_get_cursor_pos.
	(e_text_draw): remove some #ifdef 0'd code, move the calculation
	of our initial clip_rect below the xpos/ypos assignments so we
	don't duplicate the expression.  Fix the selection drawing in the
	multiline case so that it actually works, instead of assuming that
	all ETexts only have 1 line *boggle*.
	(get_position_from_xy): this needs to return a utf8 offset.
	(e_text_copy_clipboard): convert sel_start/sel_end to byte indices
	before copying.
	(primary_get_cb): same.
	(paste_received): validate the input here, and drop the length
	parameter from e_text_insert.
	(next_word): convert from an utf8 offset on entry to this
	function, and return a utf8 offset when we're done.  also, remove
	the call the g_unichar_validate.  we validate at all points where
	text is inserted.
	(find_offset_into_line): new function used in the backward/forward
	line code.  find the utf8 offset into a line (the number of utf8
	characters from a prior \n or beginning of the string.)
	(_get_position): in general there are lots of changes here because
	text->selection_start/text->selection_end are utf8 offsets, not
	byte offsets. fix E_TEP_START_OF_LINE so that hitting Ctrl-a when
	you're at the beginning of a line doesn't take you to the
	beginning of the previous line.  fix E_TEP_END_OF_LINE in an
	analogous fashion. for E_TEP_FORWARD_CHARACTER we just increment
	by 1.  for E_TEP_BACKWARD_CHARACTER we just decrement by 1.  for
	E_TEP_BACKWARD_WORD we drop the g_unichar_validate call and
	simplify things a bit.  reimplement
	E_TEP_FORWARD_LINE/E_TEP_BACKWARD_LINE so they find the current
	offset into the line, then scan forward/backward for the next/prev
	line, and put us at the right offset on that line.  fix
	E_TEP_SELECT_WORD so double clicking in the space between words
	doesn't select both words - if you double click on the trailing
	edge of the space, it selects the next word.  leading edge selects
	the previous one.  for E_TEP_SELECT_ALL use g_utf8_strlen.
	(e_text_insert): everything that calls this passes a \0 terminated
	string, so we assume it's \0 terminated (the old code did as well,
	with calls to strlen) and drop the length parameter.  also make
	sure this is all utf8 happy.
	(capitalize): use g_utf8_offset_to_pointer instead of just adding
	text->text and start/end, and remove the validate call.  also fix
	the call to e_text_model_delete and use e_text_model_insert_length
	instead of e_text_model_insert.
	(e_text_command): for E_TEP_INSERT, validate the input.  for
	E_TEP_CAPS just use MAX instead of the neat little hack.  also,
	fix the scrolling so that it scrolls properly in both X and Y
	directions (there are still some hiccups but it's much much better
	than previously).
	(e_text_commit_cb): validate the input here.

	* gal/e-text/e-text-model.c (struct _ETextModelPrivate): just use
	a GString here and get rid of MAX_LENGTH.
	(e_text_model_dispose): free GString.
	(e_text_model_real_validate_position): clean this up a bit.
	(e_text_model_real_get_text): return the contents of the GString.
	(e_text_model_real_get_text_length): use g_utf8_strlen here.
	(e_text_model_real_set_text): convert to GString
	(e_text_model_real_insert): just call e_text_model_insert_length
	here instead of duplicating the function.
	(e_text_model_real_insert_length): convert to utf8/gstring.
	i.e. convert @position and @length to a bytes and use
	g_string_insert_len.
	(e_text_model_real_delete): same, with g_string_erase.
	(e_text_model_get_text_length): use g_utf8_strlen
	(e_text_model_strdup_nth_object): convert the length of the object
	to bytes before copying.
	(e_text_model_get_nth_object_bounds): calculate start/end properly
	for u

svn path=/trunk/; revision=21163
2003-05-14 00:42:36 +00:00
990d1ba48a (gal_view_menus_unmerge): Guard against
the BonoboUIComponent not having a container to prevent a warning.

svn path=/trunk/; revision=21155
2003-05-13 16:11:26 +00:00
65fee07a39 [#42628] Call emit_search_activated() instead of emit_query_changed().
[#42628]
* e-search-bar.c (search_now_verb_cb): Call
emit_search_activated() instead of emit_query_changed().

svn path=/trunk/; revision=21154
2003-05-13 16:04:01 +00:00
a972ac3590 [ fixes bug #42177 ] remove the CAN_FOCUS flag.
2003-05-11  Chris Toshok  <toshok@ximian.com>

	[ fixes bug #42177 ]
	* e-dateedit.c (e_date_edit_init): remove the CAN_FOCUS flag.

svn path=/trunk/; revision=21146
2003-05-11 21:57:25 +00:00
b08b55549a add null check for paths (find_prev_in_range): add null check for paths
2003-05-09  Mike Kestner  <mkestner@ximian.com>

	* e-tree.c (find_next_in_range): add null check for paths
	(find_prev_in_range): add null check for paths

svn path=/trunk/; revision=21143
2003-05-09 21:39:56 +00:00
4d31188934 don't return on col == -1. update the adjustment to center the cursor.
2003-05-09  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_cursor_change): don't return on col == -1.
	* e-tree.c (tree_canvas_size_allocate): update the adjustment
	to center the cursor.
	(hover_timeout): remove unused variable to fix warning

svn path=/trunk/; revision=21142
2003-05-09 17:14:17 +00:00
2b99ba904b Fix date in ChangeLog.
svn path=/trunk/; revision=21140
2003-05-09 16:34:22 +00:00
bcbf0b3fb2 *** empty log message ***
svn path=/trunk/; revision=21139
2003-05-09 16:34:04 +00:00
692862c505 trash e_utf8_gtk function (e_search_bar_get_text): ditto
2003-05-07  JP Rosevear  <jpr@ximian.com>

	* e-search-bar.c (e_search_bar_set_text): trash e_utf8_gtk
function
	(e_search_bar_get_text): ditto

svn path=/trunk/; revision=21129
2003-05-08 14:02:52 +00:00
c7431a19ae add missing model_changed (etta_proxy_node_inserted): add missing
2003-05-06  Mike Kestner  <mkestner@ximian.com>

	* e-tree-table-adapter.c (insert_node): add missing model_changed
	(etta_proxy_node_inserted): add missing model_changed
	(etta_proxy_node_removed): add missing model_changed

svn path=/trunk/; revision=21116
2003-05-06 18:19:15 +00:00
7f56d73b7c Use correct macro for int->pointer
2003-05-05  Jeremy Katz  <katzj@redhat.com>

	* e-table-config.c (setup_fields): Use correct macro for int->pointer

svn path=/trunk/; revision=21111
2003-05-06 04:57:48 +00:00
5ebb4e4fe6 Fix prototype. Likewise.
2003-05-05  Jeremy Katz  <katzj@redhat.com>

	* gal/e-text/e-completion-callbacks.c
	(e_completion_callbacks_new): Fix prototype.
	* gal/e-text/e-completion-callbacks.h: Likewise.

svn path=/trunk/; revision=21110
2003-05-06 04:56:21 +00:00
24cb028fe8 Fixed typo in gal/e-text/e-text.c.
svn path=/trunk/; revision=21105
2003-05-05 20:37:20 +00:00
cfd486fdd8 return the instantiated object. [bug #42156]
2003-05-01  Mike Kestner  <mkestner@ximian.com>

	* gal/e-text/e-completion-callbacks.c (e_completion_callbacks_new):
	return the instantiated object. [bug #42156]

2003-05-01  Mike Kestner  <mkestner@ximian.com>

	* e-cell-combo.c (e_cell_combo_selection_changed): new
	(e_cell_combo_init): connect to selection_changed on popup_list
	(e_cell_combo_do_popup): block selection_changed while popping up
	[bug #40996]

svn path=/trunk/; revision=21042
2003-05-01 18:21:35 +00:00
16bfd2b973 remove gratuitous ref
2003-05-01  JP Rosevear  <jpr@ximian.com>

	* e-table.c (et_real_construct): remove gratuitous ref

svn path=/trunk/; revision=21041
2003-05-01 18:02:17 +00:00
c84abc0e0c don't use unicode ellipsis so that we don't break on broken font setups.
2003-04-29  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): don't use unicode ellipsis so
	that we don't break on broken font setups.

2003-04-29  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (generate_layout): don't set width on the layout
	during edit

svn path=/trunk/; revision=21012
2003-04-29 18:27:04 +00:00
fa9dddd005 Remove this so that GtkContainer's destroy method will destroy all of the
* e-dateedit.c (e_date_edit_forall): Remove this so that
        GtkContainer's destroy method will destroy all of the internal
        widgets. (This is how other compound-widgets-that-aren't-
        meant-to-be-used-as-containers behave.) #41458

svn path=/trunk/; revision=21003
2003-04-29 16:59:12 +00:00
5283d07d81 don't do wrapping during edit
2003-04-28  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): don't do wrapping during edit

svn path=/trunk/; revision=20995
2003-04-28 21:03:35 +00:00
8910fc09d9 Don't convert the label charset from UTF-8 into the locale charset.
2003-04-23  Jeffrey Stedfast  <fejj@ximian.com>

	* menus/gal-view-menus.c (build_menus): Don't convert the label
	charset from UTF-8 into the locale charset.

svn path=/trunk/; revision=20985
2003-04-28 17:48:02 +00:00
960163b188 Try stat'ing the file before loading it with xmlParseFile() to avoid
2003-04-23  Jeffrey Stedfast  <fejj@ximian.com>

	* gal-view-instance.c (load_current_view): Try stat'ing the file
	before loading it with xmlParseFile() to avoid warnign spewage
	from libxml2 saying that the file doesn't exist.

svn path=/trunk/; revision=20955
2003-04-24 16:46:50 +00:00
fd2a3bcf17 *misc/e-multi-config-dialog.c : add appropriate padding and spacing to the
2003-04-22  Anna Dirks  <anna@ximian.com>

	*misc/e-multi-config-dialog.c : add appropriate padding
	and spacing to the settings dialog. Fixes #41392.

svn path=/trunk/; revision=20942
2003-04-23 19:17:54 +00:00
1f8aee1ac6 use unicode ellipsis char for breaking lines. Use g_utf8_find_prev_char
2003-04-21  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): use unicode ellipsis char for
	breaking lines. Use g_utf8_find_prev_char and check for failure
	so that we don't tight loop for small cells that can't display
	any chars.

svn path=/trunk/; revision=20924
2003-04-22 18:54:55 +00:00
1eba3d38e0 use e_tree_table_adapter_node_get_next to determine how to draw sibling
2003-04-21  Mike Kestner  <mkestner@ximian.com>

	* e-cell-tree.c (ect_draw): use e_tree_table_adapter_node_get_next
	to determine how to draw sibling lines.
	(ect_print): ditto
	* e-tree-table-adapter.c (e_t_t_a_node_get_next): new

svn path=/trunk/; revision=20902
2003-04-21 14:18:58 +00:00
6c7b3b17ed [ fixes evolution bug #40464 ] use G_SIGNAL_TYPE_STATIC_SCOPE for the
2003-04-19  Chris Toshok  <toshok@ximian.com>

	[ fixes evolution bug #40464 ]
	* e-table.c (e_table_class_init): use G_SIGNAL_TYPE_STATIC_SCOPE
	for the GtkSelectionData args of table_drag_data_get and
	table_drag_data_received.

svn path=/trunk/; revision=20900
2003-04-20 22:08:00 +00:00
474763899f if the layout splits into more than one line, shorten it to a single line
2003-04-18  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): if the layout splits into more
	than one line, shorten it to a single line with elipses.
	(generate_layout): don't ref NULL layouts
	(ect_enter_edit): use g_new0 for the CellEdit
	(get_position_from_xy): use generate_layout since edit->layout
	isn't necessarily set here.

svn path=/trunk/; revision=20892
2003-04-18 19:51:01 +00:00
0407034071 add guarding for row indexing (Bug# 41497)
2003-04-17  JP Rosevear  <jpr@ximian.com>

	* e-table-subset.c : add guarding for row indexing (Bug# 41497)

svn path=/trunk/; revision=20891
2003-04-18 19:45:27 +00:00
faf92fde20 set width and alignment of layout. (generate_layout): set width on
2003-04-16  Mike Kestner  <mkestner@ximian.com>

	* e-cell-text.c (build_layout): set width and alignment of layout.
	(generate_layout): set width on existing layout and pass new width
	param to build_layout.
	(ect_draw): pass width to generate_layout
	(ect_height): pass width to generate_layout
	(ect_enter_edit): pass width to generate_layout
	(ect_max_width): pass width to generate_layout
	(ect_max_width_by_row): pass width to generate_layout
	(ect_show_tooltip): pass width to generate_layout
	(e_cell_text_view_command): pass width to generate_layout

svn path=/trunk/; revision=20870
2003-04-16 21:40:56 +00:00
d4b1e549f6 (remove_bonobo_menus): Only do the actual remove
if the ui component actually has a container; this suppresses a
BonoboUI warning at each folder view switch.

svn path=/trunk/; revision=20861
2003-04-16 14:47:06 +00:00