Commit Graph

3018 Commits

Author SHA1 Message Date
f53bad6e04 Don't display an unread icon for a parent message status if it has unread
2003-06-16  Jeffrey Stedfast  <fejj@ximian.com>

	* message-list.c (ml_tree_value_at): Don't display an unread icon
	for a parent message status if it has unread children but has been
	read itself. Instead, show that we have unread children by just
	making the message test bold (which it was already doing, so
	yay... this was easy). Fixes bug #42630.

svn path=/trunk/; revision=21457
2003-06-17 17:58:34 +00:00
cec1fb093d ** See bug #44609
2003-06-16  Not Zed  <NotZed@Ximian.com>

        ** See bug #44609

        * mail-vfolder.c (vfolder_edit_rule): put the ok/cancel buttons in
        the stupid gnome 2 order.

        ** See bug #33593

        * message-list.c (on_selection_changed_cmd): also listedn to
        selection changed events, since the etable api has changed.
        (get_selected_cb): helper for above.
        (message_list_construct): hook to selection change signal.

        * mail-callbacks.c (composer_send_queued_cb): Unref the composer
        to match the ref composer_send_cb();

        ** See bug #44519

        * message-browser.c (message_browser_message_list_built): We want
        to disconnect from the messagelist, not folderbrowser signal.

svn path=/trunk/; revision=21452
2003-06-17 03:15:46 +00:00
51ca9977c7 Put the ChangeLog.pre-1-4 in the Makefiles.
svn path=/trunk/; revision=21426
2003-06-12 21:13:59 +00:00
5cabf1be00 We only really want to use mail_identify_mime_part() if the content-type
2003-06-11  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-format.c (format_mime_part): We only really want to use
	mail_identify_mime_part() if the content-type is
	application/octet-stream - any other type (if it doesn't have a
	handler) should just force the user to save to disk.
	(handle_text_plain): Only pay attention to format=flowed if the
	mime-type is text/plain (handle_text_plain is the generic text
	handler, so we might be processing parts that are not really
	text/plain, thus the format param may have different meaning for
	those other textual types).

svn path=/trunk/; revision=21419
2003-06-12 04:47:32 +00:00
4c7dc352b6 free the info structure as well.
2003-06-11  Larry Ewing  <lewing@ximian.com>

	* mail-send-recv.c (free_folder_info): free the info structure as
	well.

svn path=/trunk/; revision=21418
2003-06-11 23:02:09 +00:00
d120c67b62 Use mail-config's gconf client. (target_date_new): Same.
2003-06-06  Jeffrey Stedfast  <fejj@ximian.com>

	* message-tag-followup.c (get_week_start_day): Use mail-config's
	gconf client.
	(target_date_new): Same.

	* message-list.c (message_list_set_folder): Use mail-config's
	gconf client.
	(mail_regen_list): Same.

	* mail-tools.c (mail_tool_quote_message): Use mail-config's gconf
	client.
	(mail_tool_forward_message): Same.

	* mail-session.c (main_get_filter_driver): Use mail-config's gconf
	client.

	* mail-preferences.c (mail_preferences_init): Use mail-config's
	gconf client.
	(mail_preferences_finalise): Don't unref the gconf client.

	* mail-format.c (write_headers): Use mail-config's gconf client.
	(mail_format_data_wrapper_write_to_stream): Same.
	(handle_text_plain): And here.

	* mail-display.c (save_data_cb): Use mail-config's gconf client.
	(save_part): Same.
	(on_url_requested): Here too.
	(mail_text_write): And here.
	(mail_display_init): And here.
	(mail_display_destroy): Here too.
	(mail_display_new): Again here.

	* mail-composer-prefs.c (sig_add_cb): Use mail-config's gconf
	client.
	(mail_composer_prefs_construct): Same.

	* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Use
	mail-config's gconf client.
	(ask_confirm_for_empty_subject): Same.
	(ask_confirm_for_only_bcc): Here too.
	(composer_get_message): And here.
	(create_msg_composer): Again here.
	(mail_generate_reply): Same.
	(forward): And here.
	(transfer_msg_done): "
	(delete_msg): "
	(confirm_expunge): "

	* component-factory.c (owner_unset_cb): Use mail-config's gconf
	client.

	* folder-browser-ui.c (folder_browser_ui_add_message): Use the
	mailer's gconf client.
	(folder_browser_ui_add_list): Same.
	(folder_browser_ui_add_global): Here too.

	* folder-browser.c (save_cursor_pos): Use the mailer's gconf
	client.
	(folder_browser_set_message_preview): Same.
	(folder_browser_toggle_preview): Here too.
	(folder_browser_toggle_threads): And here.
	(folder_browser_toggle_hide_deleted): Here as well.
	(folder_browser_set_message_display_style): And here.
	(fb_resize_cb): Here.
	(paned_realised): And here.
	(done_message_selected): And everywhere...

	* mail-account-gui.c (sig_add_new_signature): Use the mailer gconf
	client.

	* mail-config.c (mail_config_get_gconf_client): New function to
	return the global GConfClient used by the mailer.
	(mail_config_write_on_exit): On exit, free our objects and such.
	(mail_config_signature_run_script): Use config->gconf.

2003-06-04  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (invert_selection): Get rid of the if-focused
	code, that will always prevent the etree from getting the
	selection inverted because the menu item will always have focus at
	this time. Fix for bug #43972.


it takes more than good relations to some of the major spirits in this
branch of the multiverse to write apps that don't leak gconf-client
refs, good coding is important, too.

that... or a 100-megaton-kill-o-zap bomb

svn path=/trunk/; revision=21410
2003-06-11 16:19:36 +00:00
f9257aeb4c ** See bug #22542
2003-06-11  Not Zed  <NotZed@Ximian.com>

        ** See bug #22542

        * component-factory.c (storage_create_folder): If we're creating a
        folder on a vstore, popup a vFolder editor rather than failing.

2003-06-05  Not Zed  <NotZed@Ximian.com>

        ** Part of #42691.

        * importers/Makefile.am (BUILT_SOURCES): added server_DATA.

        * Makefile.am (%.server.in): create a proper implicit rule for
        temporary .in file.

2003-06-04  Not Zed  <NotZed@Ximian.com>

        ** See bug #43974

        * mail-tools.c (mail_tool_do_movemail): use a proper CamelURL to
        decode the uri, not hacky strcmp stuff.

        * mail-account-gui.c (extract_values): if we have an conf_entry,
        ignore username, hostname, and path ones, as these are handled
        implicitly in the url itself.  Came about because of the fix for
        #42838.

svn path=/trunk/; revision=21407
2003-06-11 04:28:04 +00:00
fd2f3a6d7a Roll over ChangeLogs.
svn path=/trunk/; revision=21387
2003-06-09 17:31:26 +00:00
a6fcdd3630 Put the buttons in HIG order; don't replace the label of the stock Find
2003-06-03  Federico Mena Quintero  <federico@ximian.com>

	* mail-search.c (mail_search_construct): Put the buttons in HIG
	order; don't replace the label of the stock Find button.  Also,
	add Escape as a keybinding for the Close button (see why GTK+ is
	on crack on b.g.o #74221 and #101293).

svn path=/trunk/; revision=21379
2003-06-03 20:46:35 +00:00
7ca1ee0d21 install gconf schemas even if purify is disabled (oops) :-)
svn path=/trunk/; revision=21371
2003-06-02 18:14:37 +00:00
95d963dec5 ** This and jeffs patch for #43862.
2003-06-02  Not Zed  <NotZed@Ximian.com>

	** This and jeffs patch for #43862.

	* mail-folder-cache.c (store_online_cb): If the store is still
	around, then flow on to a get folderinfo update, otherwise just
	clear up.

	* mail-ops.c (mail_store_set_offline): return the msgid of this so
	it can be cancelled.

2003-05-30  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-folder-cache.c (mail_note_store): If the session is
	'online' and we are noting a CamelDiscoStore, make sure that it is
	changed to online status and call mail_get_folderinfo().

svn path=/trunk/; revision=21369
2003-06-02 17:50:26 +00:00
3bf07b8693 Stat the XML file before trying to parse it to make sure it exists.
2003-05-30  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-local.c (load_metainfo): Stat the XML file before trying to
	parse it to make sure it exists.

svn path=/trunk/; revision=21368
2003-06-02 17:27:27 +00:00
9dd5dd01a2 added server_DATA (*.server) so make clean works. For #42691.
2003-05-29  Not Zed  <NotZed@Ximian.com>

        * Makefile.am (BUILT_SOURCES): added server_DATA (*.server) so
        make clean works.  For #42691.

svn path=/trunk/; revision=21361
2003-06-02 01:35:54 +00:00
6bdca62695 use %02x instead of %2x when formatting color for rc file
2003-05-30  Radek Doulik  <rodo@ximian.com>

	* mail-config.c (config_write_style): use %02x instead of %2x when
	formatting color for rc file

svn path=/trunk/; revision=21356
2003-05-30 18:27:03 +00:00
4a67f45b4a Fixes bug #43805.
2003-05-29  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes bug #43805.

	* mail-session.c (session_system_beep): Proxy the gdk_beep() call
	to the main thread.
	(session_play_sound): Proxy the gnome_sound_play() call to the
	main thread.

svn path=/trunk/; revision=21348
2003-05-30 03:01:47 +00:00
7a623f5d21 removed the help button since it didn't do anything anyway
svn path=/trunk/; revision=21346
2003-05-29 21:44:32 +00:00
d575bb994e set the default open size to something reasonable. For #43410.
2003-05-27  Not Zed  <NotZed@Ximian.com>

	* message-tag-editor.c (message_tag_editor_init): set the default
	open size to something reasonable.  For #43410.

	* mail-signature-editor.c (d): turn off debugging.

	* mail-config.c (mail_config_signature_add): save new signature in
	signature list.  For #43688.

svn path=/trunk/; revision=21340
2003-05-27 23:39:43 +00:00
870f16c1da set signature html flag even if it's newly signature, we don't set it in
2003-05-21  Radek Doulik  <rodo@ximian.com>

	* mail-signature-editor.c (menu_file_save_cb): set signature html
	flag even if it's newly signature, we don't set it in
	format_html_cb as sig could be "live" (when it's not new one)

svn path=/trunk/; revision=21321
2003-05-22 20:08:40 +00:00
051f654615 Updated copyright years.
2003-05-20  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-importer.c: Updated copyright years.

	* mail-callbacks.c (ask_confirm_for_empty_subject): Fixed the
	logic a bit - if the gconf key *isn't* set, we want to return
	TRUE.

	* mail-search.c (mail_search_finalise): We need to weak_unref()
	the mail-display here. Fixes bug #43392.

svn path=/trunk/; revision=21299
2003-05-21 15:27:54 +00:00
4a405c6634 remove link hilighting option that isn't attached to anything.
2003-05-21  Larry Ewing  <lewing@ximian.com>

	* mail-config.glade: remove link hilighting option that isn't
	attached to anything.

svn path=/trunk/; revision=21298
2003-05-21 15:26:24 +00:00
fbe61660d1 filter notification events to keep the redisplay count down.
2003-05-20  Larry Ewing  <lewing@ximian.com>

	* mail-display.c: filter notification events to keep the redisplay
	count down.

svn path=/trunk/; revision=21290
2003-05-20 19:24:35 +00:00
8d75f1b9bc remove references to gtkhtml property manager. Connect to missing
2003-05-20  Larry Ewing  <lewing@ximian.com>

	* mail-composer-prefs.c: remove references to gtkhtml property
	manager.  Connect to missing settings.

	* mail-preferences.c: remove references to gtkhtml property
	manager.  Connect to missing settings.

	* mail-config.glade: remove keybinding setting.

	* mail-display.c (mail_display_destroy): remove notification.
	(display_notify): set animate and redisplay.  We have to redisplay
	because the citation color may have changed.

	* evolution-mail.schemas: add composer and display gconf entries.

svn path=/trunk/; revision=21288
2003-05-20 18:33:33 +00:00
1c147afe15 Only re-add the store to the folder-tree if the account is enabled. Oops.
2003-05-19  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-account-gui.c (mail_account_gui_save): Only re-add the
	store to the folder-tree if the account is enabled. Oops. Fixes
	bug #43214.

svn path=/trunk/; revision=21283
2003-05-20 15:53:45 +00:00
42333eed03 remove references to font prefs.
2003-05-20  Larry Ewing  <lewing@ximian.com>

	* mail-config-factory.c: remove references to font prefs.

	* component-factory.c: Remove stale refernces the the font prefs.
	(make_factory): remove unused variables.

	* mail-config.c (mail_config_init): add a notify callback to the
	spelling color.
	(config_write_style): rename and write out the spell color as
	well.

svn path=/trunk/; revision=21279
2003-05-20 14:54:00 +00:00
330cb00874 ** See bug #43234
2003-05-20  Not Zed  <notzed@lostzed.mmc.com.au>

        ** See bug #43234

        * mail-display.c (mail_display_set_message): if we've been
        destroyed, noop.

svn path=/trunk/; revision=21247
2003-05-19 15:12:12 +00:00
6784da1b28 New async "empty trash" op.
* mail-ops.c (mail_empty_trash): New async "empty trash" op.

	* mail-callbacks.c (empty_trash): Use it rather than requiring
	that mail_tool_get_vtrash() work without blocking. #43091

svn path=/trunk/; revision=21243
2003-05-19 12:44:32 +00:00
81580a0814 gnome_font_get_descender returns negative value
2003-05-16  Radek Doulik  <rodo@ximian.com>

	* mail-callbacks.c (footer_info_new): gnome_font_get_descender
	returns negative value

svn path=/trunk/; revision=21238
2003-05-19 08:39:44 +00:00
bab65bb491 remove font prefs server from the list
2003-05-17  Larry Ewing  <lewing@ximian.com>

        * GNOME_Evolution_Mail.server.in.in: remove font prefs server from
        the list

svn path=/trunk/; revision=21236
2003-05-18 20:20:29 +00:00
a878c6c70b Add #include to fix warning.
2003-05-17  Jeremy Katz  <katzj@redhat.com>

	* mail-offline-handler.c: Add #include to fix warning.

	* mail-mt.c (mail_msg_new): Use glib macros for pointer/int
	conversions.
	(mail_msg_free): Likewise.
	(mail_msg_cancel): Likewise.
	(mail_msg_wait): Likewise.
	(mail_msg_active): Likewise.
	* mail-session.c (main_register_timeout): Likewise.
	(register_timeout): Likewise.
	(main_remove_timeout): Likewise.
	(remove_timeout): Likewise.
	* message-list.c (ml_value_to_string): Likewise.

	* mail-identify.c: Add #include to fix warning.

	* mail-config.c (config_write_fonts): Don't pass extra arguments
	to g_warning.

	* mail-callbacks.c: Add #include to fix warning.

svn path=/trunk/; revision=21222
2003-05-16 18:52:14 +00:00
bf4ef74000 ** See bug #42838.
2003-05-15  Not Zed  <NotZed@Ximian.com>

        ** See bug #42838.

        * mail-account-gui.c (mail_account_gui_build_extra_conf): always
        add the extra entry to the hash table, most paths wouldn't.

svn path=/trunk/; revision=21203
2003-05-15 23:37:02 +00:00
ee8e8b6bae Disabled some debugging messages.
2003-05-14  Jeffrey Stedfast  <fejj@ximian.com>

	* component-factory.c: Disabled some debugging messages.

svn path=/trunk/; revision=21192
2003-05-15 17:58:01 +00:00
946d755adc add proto
2003-05-14  JP Rosevear  <jpr@ximian.com>

	* mail-local.h: add proto

	* mail-local.c (storage_listener_startup): don't listen for
	destruction, because we have a ref and it'll never happen
	(mail_local_storage_shutdown): release and unref the local storage

	* mail-display.c (retrieve_shell_view_interface_from_control):
	return a new copy every time
	(set_status_message): release and unref the shell view

	* folder-browser.c (folder_browser_destroy): guard for multiple
	destroys

	* folder-browser-factory.c (control_activate): release and unref
	the shell view
	(control_destroy_cb): just remove the control from the list
	(folder_browser_factory_new_control): don't weak ref the folder
	browser

	* component-factory.c (owner_unset_cb): shutdown local storage

svn path=/trunk/; revision=21181
2003-05-14 18:47:11 +00:00
cd1b05ca91 Removed. (make_factory): No need to set up the SIGSEGV redirect handler
* component-factory.c (segv_redirect): Removed.
(make_factory): No need to set up the SIGSEGV redirect handler
here, since it's already done in the shell now, and it's in-proc.

* folder-browser-ui.c (folder_browser_ui_rm_all): Only do the
bonobo_ui_component() stuff if the component does have a
container.

svn path=/trunk/; revision=21156
2003-05-13 16:12:10 +00:00
cc7acff2e2 Fix ChangeLog for yesterday's commit.
svn path=/trunk/; revision=21141
2003-05-09 17:11:08 +00:00
38a69e37f2 (request_password): Make sure password_dialog is
NULLified when the dialog is destroyed in any case, using
g_object_add_weak_pointer().  Prevents a crash that could happen
if the shell would quit with the password dialog still up.

svn path=/trunk/; revision=21133
2003-05-08 19:04:38 +00:00
47a4b74f07 Make sure that we haven't been destroyed before we start writing to the
2003-05-07  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-display.c (mail_display_render): Make sure that we haven't
	been destroyed before we start writing to the html engine. Fixes
	bug #42333.

svn path=/trunk/; revision=21132
2003-05-08 17:01:55 +00:00
7c5e55ba41 ** See bug #42456
2003-05-07  Not Zed  <NotZed@Ximian.com>

        ** See bug #42456

        * mail-composer-prefs.c (spell_language_button_press): set the
        enable/disable button to the right text when we toggle a column.
        Added a fixme about the weird code in the whole routine.

svn path=/trunk/; revision=21127
2003-05-08 02:43:10 +00:00
09e2470be4 Correct default for list.
2003-05-07  Jeremy Katz  <katzj@redhat.com>

	* evolution-mail.schemas
	(/schemas/apps/evolution/mail/display/mime_types):  Correct
	default for list.

svn path=/trunk/; revision=21125
2003-05-07 23:40:43 +00:00
ba201c0f99 ** See bug #42400
2003-05-06  Not Zed  <NotZed@Ximian.com>

        ** See bug #42400

        * mail-tools.c (meta_data_key): protect against getting an
        unparsable uri.

svn path=/trunk/; revision=21119
2003-05-07 00:53:40 +00:00
3bf9a7df88 ** See bug #42294.
2003-05-05  Not Zed  <NotZed@Ximian.com>

        ** See bug #42294.

        * mail-config.c (config_write_fonts): Also set the custom font
        style for *BonoboPlug*GtkHTML.

svn path=/trunk/; revision=21109
2003-05-06 00:04:02 +00:00
c85822a98c (request_password): Set OK as the default
response for the password_dialog.

svn path=/trunk/; revision=21104
2003-05-05 18:08:49 +00:00
8a9ec3432e To be consistant with the message-list envelope toggle, undelete the
2003-04-30  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mark_as_unseen): To be consistant with the
	message-list envelope toggle, undelete the message when we unmark
	the Seen flag here as well. Fixes bug #42118.

2003-04-30  Jeffrey Stedfast  <fejj@ximian.com>

	* message-list.c (ml_tree_value_at): Fixed to return the correct
	values (swapped) in order to fix bug #42120.

2003-04-30  Jeffrey Stedfast  <fejj@ximian.com>

	* message-list.c (regen_list_regened): Save the tree state before
	we tear down the tree and then load it back again. yay. Fixes bug
	#42170 and #40074.

svn path=/trunk/; revision=21047
2003-05-02 16:07:18 +00:00
d5ab5576f2 ** See bug #41748
2003-04-30  Not Zed  <NotZed@Ximian.com>

        ** See bug #41748

        * mail-send-recv.c (build_dialogue): make sure we dont add any
        SEND_SEND types to the receive table.  When we add the SEND_SEND
        type, key it on a fixed string SEND_URI_KEY.
        (receive_done): if it is a SEND_SEND type, use SEND_URI_KEY to
        remove it from the active list.
        (mail_receive_uri): make sure we never add a SEND_SEND type to the
        receive list.
        (mail_send): key the send info on SEND_URI_KEY not transport url.

svn path=/trunk/; revision=21038
2003-05-01 02:19:46 +00:00
f3022be64e Don't just blindly cast an int to gpointer, use the proper glib magic
2003-04-29  Jeremy Katz  <katzj@redhat.com>

	* folder-browser-ui.c (fbui_sensitise_item): Don't just blindly
	cast an int to gpointer, use the proper glib magic instead.

svn path=/trunk/; revision=21026
2003-04-30 03:08:47 +00:00
996827b8fc Updated for API change in the filter code.
2003-04-29  Jeffrey Stedfast  <fejj@ximian.com>

	* importers/netscape-importer.c
	(netscape_add_priority_workaround_filters): Updated for API change
	in the filter code.

svn path=/trunk/; revision=21020
2003-04-29 20:23:56 +00:00
36b97dcf5d ** See bug #41972
2003-04-29  Not Zed  <NotZed@Ximian.com>

	** See bug #41972

	* message-list.c (ml_tree_value_at): fix (void *) casts on trinary
	ops.

	* folder-browser.c (on_right_click): Store the label tag in the
	label callback data, not the translated name.

	* mail-config.c (label_defaults[]): Initialise with the tag
	values.
	(config_clear_labels): free tag field.
	(config_cache_labels): setup the tag field based on the position
	of the label name.
	(mail_config_get_label_color_by_name): Lookup colour by the
	untranslated TAG, not the translated/customisable tag.

	* mail-config.h (MailConfigLabel): Add a tag field, we were using
	the translated name as the label(!).

svn path=/trunk/; revision=21008
2003-04-29 18:18:36 +00:00
9d4c20abb6 Remove preceding whitespace
* mail-format.c (write_xmailer_header): Remove preceding whitespace

svn path=/trunk/; revision=21004
2003-04-29 17:00:08 +00:00
e8a5147580 (mail_session_forget_passwords): Forget all
passwords again.  [#41817]

svn path=/trunk/; revision=20986
2003-04-28 18:04:09 +00:00
aea82dfd60 Made toplevel container widgets set a border-width (including toplevel
2003-04-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.glade: Made toplevel container widgets set a
	border-width (including toplevel widgets within frames), set the
	table/hbox/vbox spacings, set the spacing between an image and the
	description text in hboxes to 12pts (as suggested by the HIG),
	Changed Add/Delete buttons to the stock Add/Remove buttons, etc

2003-04-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (mail_config_init): Cache the allowable
	mime-types.
	(mail_config_get_allowable_mime_types): New public function to get
	an array of allowable mime-types.

	* mail-format.c (mail_lookup_handler): Only allow a
	bonobo-component handler if the mime-type is something handled by
	evolution or the user has specifically chosen that type as
	available for viewing with a bonobo component in the gconf
	database.
	(mime_type_uses_evolution_component): New convenience function.
	(mime_type_can_use_component): Checks gconf to see if the user has
	allowed the mime-type to be viewed by a component.

svn path=/trunk/; revision=20983
2003-04-28 16:00:47 +00:00
54ae44bc33 as below (update_active): as below
2003-04-24  Radek Doulik  <rodo@ximian.com>

	* mail-display.c (html_button_press_event): as below
	(update_active): as below

	* folder-browser.c (html_button_press_event): update for changed
	coordinates in gtk-2

svn path=/trunk/; revision=20959
2003-04-24 19:09:04 +00:00