2003-06-06 Jeffrey Stedfast <fejj@ximian.com>
Fixes some leaks from bug #43883.
* filter-file.c (xml_decode): Free file->path and set it to
NULL before entering the loop to decode it. This way if the value
is already set we don't leak it. Set file->path = g_strdup (str ?
str : ""); and then xmlFree the str.
2003-05-21 Jeffrey Stedfast <fejj@ximian.com>
* filter-source.c (filter_source_get_sources): Same as below.
* filter-label.c (xml_create): Unref the gconf client when we're
finished with it.
svn path=/trunk/; revision=21390
2003-05-05 Jeffrey Stedfast <fejj@ximian.com>
* filter-colour.c (format_sexp): Format the colour string in a way
that gdk_color_parse() will handle. Apparently it no longer
handles rgb:<red>/<green>/<blue>? Fixes bug #42345.
svn path=/trunk/; revision=21115
2003-04-24 Jeffrey Stedfast <fejj@ximian.com>
Fix for bug #41578.
* rule-editor.c (rule_move): Pass re->source instead of
re->current->source to rule_context_get_rank_rule(). Also updated
to pass re->source to rule_context_rank_rule().
(rule_editor_play_undo): Updated to pass re->source to
rule_context_rank_rule().
* rule-context.c (rule_context_rank_rule): Now takes a 'source'
argument rather than using rule->source (vfolder editor lists
rules of all sources, not just same-source rules).
(revert): Pass frule->source/part->source to
rule_context_rank_rule() - might not be right but should preserve
the prior behaviour at least.
svn path=/trunk/; revision=21006
2003-04-18 Not Zed <NotZed@Ximian.com>
* rule-editor.c (d): removed debug spew.
* addresses #41398
* vfolder-rule.c (format_source): helper function to decode a url
into a more user-friendly format.
(source_add, get_widget): add the formatted data as another
column to the table.
(vfolder_editor_sourcelist_new): add another column to the table,
a formatted uri as well as the raw one.
(d): turned off debug vomit while i'm here.
svn path=/trunk/; revision=20929
2003-04-11 Jeffrey Stedfast <fejj@ximian.com>
Fixes for bugs: #41149, #41150, #41151, #41152, #41153, #41155 and
#41156.
* filter-filter.c (get_widget): Same as with filter-rule.
* filter-rule.c (get_widget): Changed border widths of frame
vboxes and other padding to comply with the HIG.
* rule-editor.c (rule_add): Change window border and padding
around the 'rules' widget to comply with the HIG.
(rule_edit): Same.
(rule_editor_construct): Same here as well.
* filter.glade: Many HIG compliance fixes.
svn path=/trunk/; revision=20823
2003-03-26 Jeffrey Stedfast <fejj@ximian.com>
* filter-file.c (xml_decode): Loop over child nodes here too in
order to not be affected by libxml2 crack.
* filter-source.c (xml_decode): Fixed to disreguard libxml2 crack.
(get_widget): Use strcmp instead of e_url_equal().
svn path=/trunk/; revision=20523
* filter-datespec.c (timespans, set_button): Change the strings in
the timespans array from "second" / "seconds" to "1 second ago" /
"%d seconds ago", etc, and update the code in set_button that uses
them. Fixes#36245, translation clash between the "second" here
and the one in the calendar (where it's used as "2nd").
svn path=/trunk/; revision=20432
2003-03-18 Not Zed <NotZed@Ximian.com>
* rule-context.c (new_rule_response): use the same code as in
filter-rule to enforce unique names for all rules/vfolders.
svn path=/trunk/; revision=20332
2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* rule-editor.c (rule_editor_construct): Always add a Cancel
button here, but if !enable_undo - make the response id
GTK_RESPONSE_CANCEL rather than GTK_RESPONSE_REJECT (which does
undo). This mimics the behaviour that was done in the mail/ code
previously. Fixes bug #39809.
svn path=/trunk/; revision=20315
2003-03-11 Not Zed <NotZed@Ximian.com>
* rule-context.c (revert): go to the proper level of child node
before looking for rule sets, fix for #39165 to make 'cancel' work.
svn path=/trunk/; revision=20230
2003-02-20 Not Zed <NotZed@Ximian.com>
* filter-source.c (filter_source_get_sources): Change to use
EAccountList, etc.
svn path=/trunk/; revision=20014
2003-02-12 Jeffrey Stedfast <fejj@ximian.com>
* vfolder-rule.c (source_add): Get rid of the need for the
GTK_WIDGET_DESTROYED() check.
svn path=/trunk/; revision=19898
2003-02-07 Jeffrey Stedfast <fejj@ximian.com>
* filter-editor.c (filter_editor_new): Use g_object_new()
instead of gtk_type_new().
* vfolder-editor.c (vfolder_editor_new): Use g_object_new()
instead of gtk_type_new().
* score-editor.c (score_editor_new): Use g_object_new() instead of
gtk_type_new().
* rule-editor.c (rule_editor_new): Use g_object_new() instead of
gtk_type_new().
(rule_add): Use gtk_window_set_resizable() instead of the
deprecated gtk_window_set_policy().
(rule_edit): Same here.
(rule_editor_construct): Here too.
* rule-context.c (rule_context_add_rule_gui): Use
gtk_window_set_resizable() instead of the deprecated
gtk_window_set_policy().
svn path=/trunk/; revision=19847
* rule-editor.c (rule_add): Change dialog from OK/Cancel to
Cancel/OK to match HIG.
(rule_edit): Likewise.
(rule_editor_construct): Likewise.
* rule-context.c (rule_context_add_rule_gui): Change dialog from
OK/Cancel to Cancel/OK to match HIG.
* filter-datespec.c (button_clicked): Change dialog from OK/Cancel
to Cancel/OK to match HIG.
svn path=/trunk/; revision=19470
2003-01-03 Jeffrey Stedfast <fejj@ximian.com>
* rule-editor.c (add_editor_response): Scroll to the newly added
row.
(rule_delete): Scroll to the selected row.
(rule_move): After moving the row, re-select it and then scroll to
make sure that it is still visible.
svn path=/trunk/; revision=19226
2002-12-12 Jeffrey Stedfast <fejj@ximian.com>
* rule-editor.c (cursor_changed): Use an easier method for getting
the iter.
svn path=/trunk/; revision=19108
2002-12-12 Jeffrey Stedfast <fejj@ximian.com>
* vfolder-rule.c (vfolder_editor_sourcelist_new): New custom
function for creating the source_list widget.
(get_widget): Removed the source_list creation code.
* rule-editor.c (rule_editor_construct): Listen to row-activated
for double-click events. Also, removed the model creation code out
of here.
(rule_editor_treeview_new): Moved the treeview and model creation
code into here instead, and made the glade widgets into custom
widgets.
svn path=/trunk/; revision=19106
2002-11-26 Not Zed <NotZed@Ximian.com>
* vfolder-rule.c (get_widget): Add a textcellrenderer to display
the folders.
(get_widget): Remove FIXME which was wrong.
svn path=/trunk/; revision=18924
2002-11-26 Not Zed <NotZed@Ximian.com>
* filter-rule.c (filter_rule_validate): FILTER_RULE_CLASS ->
_GET_CLASS
* rule-context.c (rule_context_save): RULE_CONTEXT_CLASS ->
RULE_CONTEXT_GET_CLASS
(rule_context_revert): "
* *.[ch]: Ran fix.sh over all files.
* rule-editor.c (rule_add): widget:set_parent ->
window:set_transient_for
(editor_response): renamed from editor_clicked, handle gtk dialog
response codes.
(rule_edit): connect to response rather than clicked.
(rule_editor_construct): Setup a text column in the tree view.
Not sure if this can be handled via glade.
svn path=/trunk/; revision=18922
2002-11-13 Not Zed <NotZed@Ximian.com>
* vfolder-rule.c (source_add): comment out gtk_destroyed check.
* filter-label.c: Added back some of the guts. Might not work but
some of the code uses it :-/. Gives u a fixed set of non-editable
labels.
svn path=/trunk/; revision=18729
2002-11-07 Jeffrey Stedfast <fejj@ximian.com>
* vfolder-rule.c (validate): Use a GtkDialog instead of a
GnomeDialog for reporting errors.
* rule-editor.c (rule_add): Use a GtkDialog instead of
GnomeDialog.
(rule_edit): Same.
(add_editor_response): Use a GtkMessageDialog for the error
reporting instead of a GnomeDialog.
(edit_editor_response): Same.
* rule-context.c (rule_context_add_rule_gui): Use a GtkDialog
instead of a GnomeDialog.
* filter-rule.c (validate): Use GtkDialog instead of GnomeDialog
here.
* filter-input.c (validate): Use GtkDialog instead of GnomeDialog
here.
* filter-folder.c (validate): Use GtkDialog instead of GnomeDialog
here.
* filter-file.c (validate): Use GtkDialog instead of GnomeDialog
here.
* rule-editor.c: Subclass GtkDialog instead of GnomeDialog.
* filter-datespec.c (validate): Use GtkDialog instead of
GnomeDialog.
(button_clicked): Same.
svn path=/trunk/; revision=18651
