** Fix for bug #553535
* e-msg-composer.c: (is_top_signature), (get_signature_html),
(set_editor_text), (e_msg_composer_show_sig_file): Do not eat
lines of text when changing signature at top of the message.
Add one extra empty line between the signature and the body
of the mail when placing signature to the bottom.
2009-03-19 Milan Crha <mcrha@redhat.com>
** Fix for bug #574680
* e-msg-composer.c: (is_special_header): Function removed.
* e-msg-composer.c: (e_msg_composer_new_with_message):
Remove all headers except "References" and "In-Reply-To" when
composing from an existing message.
svn path=/trunk/; revision=37462
2009-02-25 Milan Crha <mcrha@redhat.com>
** Fix for bug #551470
* e-composer-private.h:
* e-msg-composer.c: (add_signature_delim), (get_signature_html),
(set_editor_text): Do not force adding "-- \n" above the signature.
svn path=/trunk/; revision=37322
2009-02-12 Milan Crha <mcrha@redhat.com>
** Fix for bug #567089
* e-msg-composer.c: (get_signature_html):
Do not crash when no From set yet.
svn path=/trunk/; revision=37251
2009-01-09 Takao Fujiwara <takao.fujiwara@sun.com>
Reviewed by Matthew Barnes <mbarnes@redhat.com>
* Fix for bug #566011
* addressbook/gui/component/Makefile.am:
* addressbook/gui/component/addressbook-component.c
(addressbook_component_class_init):
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h> and
add bindtextdomain().
* calendar/gui/Makefile.am:
* calendar/gui/calendar-component.c (calendar_component_class_init):
* calendar/gui/dialogs/comp-editor.c:
* calendar/gui/memos-component.c (memos_component_class_init):
* calendar/gui/tasks-component.c (tasks_component_class_init):
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h> and
add bindtextdomain().
* composer/e-composer-header-table.c:
* composer/e-composer-private.h:
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h>.
* mail/mail-component.c (mail_component_class_init):
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h> and
add bindtextdomain().
* shell/e-user-creatable-items-handler.c
(e_user_creatable_items_handler_class_ini):
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h> and
add bindtextdomain().
* widgets/misc/e-charset-picker.c:
* widgets/misc/e-signature-combo-box.c:
Include <glib/gi18n-lib.h> instead of <glib/gi18n.h>.
svn path=/trunk/; revision=37021
2008-12-18 Matthew Barnes <mbarnes@redhat.com>
* e-composer-actions.c:
Change "Save Draft" menu item to "Save as Draft" to be consistent
with "Save as Template". I like that better. But leave the toolbar
button alone.
svn path=/trunk/; revision=36915
2008-12-16 Milan Crha <mcrha@redhat.com>
** Fix for bug #564248
* e-msg-composer.c: (msg_composer_paste_clipboard):
Attach images pasted from a clipboard.
Note: Requires at least gtkhtml revision 9067.
svn path=/trunk/; revision=36906
2008-12-11 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #562450
* composer/e-msg-composer.c (handle_multipart_signed):
Fix a typo that broke "Edit as New Message" for signed messages.
svn path=/trunk/; revision=36869
2008-11-07 Srinivasa Ragavan <sragavan@novell.com>
** Fix for bug #559701
* e-msg-composer.c: (e_load_spell_languages): Don't save when its
NULL.
svn path=/trunk/; revision=36775
2008-11-05 Matthew Barnes <mbarnes@redhat.com>
** Fixes part of bug #559371
* composer/e-msg-composer.c (e_load_spell_languages):
New function loads a list of GtkhtmlSpellLanguage structs from
GConf, taking care of details like converting language codes to
structs and ensuring the returned list is non-empty.
* composer/e-msg-composer.c (e_save_spell_languages):
New function saves a list of GtkhtmlSpellLanguage structs to
GConf, taking care of details like converting the structs to
language codes.
* composer/e-msg-composer.c (msg_composer_constructor):
* mail/em-composer-prefs.c (spell_language_save), (spell_setup):
Simplify the logic by using e_load_spell_languages() and
e_save_spell_languages().
svn path=/trunk/; revision=36743
2008-11-04 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #554450
* composer/e-msg-composer.c (msg_composer_init):
Get drag-and-drop to the attachment bar working again, but see
my note in the source code. I'm still not sure why it broke.
svn path=/trunk/; revision=36741
2008-11-02 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #559028
* composer/e-msg-composer.c (msg_composer_key_press_event):
Skip over the style toolbar when tabbing in reverse.
svn path=/trunk/; revision=36720
2008-10-13 Bharath Acharya <abharath@novell.com>
** Updated fix for bug #555775
* e-composer-private.c: (e_composer_private_init): Reverting a
hunk from the previous patch as suggested by Matthew Barnes.
svn path=/trunk/; revision=36605
2008-10-10 Bharath Acharya <abharath@novell.com>
** Fix for bug #555775
* e-composer-private.c: (e_composer_private_init): Include
e-util-private.h for Win32 redefinition of EVOLUTION_UIDIR and
build the filename using it.
svn path=/trunk/; revision=36587
2008-10-03 Milan Crha <mcrha@redhat.com>
** Fix for bug #554664
* e-composer-actions.c: (action_attach_cb):
Call attach_remote_file when knows the URI points to it.
svn path=/trunk/; revision=36549
2008-10-01 Milan Crha <mcrha@redhat.com>
** Fix for bug #554418
* e-util/e-util.h: (e_util_guess_mime_type):
* e-util/e-util.c: (e_util_guess_mime_type): Guess mime_type based on
the file content only when permitted by the caller, otherwise
check based on the filename only, where it fallbacks if file
content guess fails.
* mail/em-utils.c: (em_utils_snoop_type):
* mail/em-popup.c: (emp_standard_menu_factory):
Guess mime_type based on the filename only.
* composer/e-msg-composer.c: (handle_uri),
(e_msg_composer_add_inline_image_from_file): Guess mime_type based
on the file content, if failed, then on the filename.
* widgets/misc/e-attachment.c: (attachment_guess_mime_type):
Allow guessing mime_type based on the file content.
* calendar/gui/dialogs/comp-editor.c: (set_attachment_list):
* calendar/gui/e-cal-popup.c: (ecalp_standard_menu_factory):
Allow/disallow guessing of the mime_type based on the file content.
svn path=/trunk/; revision=36529
2008-08-01 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #428384
* composer/mail-composer.error.xml:
Improve buttons in the "exit-unsaved" dialog by replacing "Cancel"
with "Continue Editing" and "Save Message" with "Save Draft".
Suggested by bytesmythe.
svn path=/trunk/; revision=35890
2008-07-09 Milan Crha <mcrha@redhat.com>
** Fix for bug #206592
* evolution-composer.ui:
* e-composer-actions.h:
* e-composer-actions.c: (action_new_message_cb), (entries):
Action to invoke New Message window from the composer itself.
svn path=/trunk/; revision=35733
2008-06-30 Matthew Barnes <mbarnes@redhat.com>
* composer/e-composer-post-header.c (composer_post_header_finalize):
Add a finalize() method to free priv->base_url, which was leaking.
svn path=/trunk/; revision=35706
2008-06-21 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #310988
* e-msg-composer.c:
Don't even show the "send-options" action unless an Exchange
or GroupWise account appears in the From combo box.
svn path=/trunk/; revision=35667
2008-06-20 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #538908
* composer/e-composer-actions.h:
Define E_COMPOSER_ACTION_SEND_OPTIONS.
* composer/e-msg-composer.c (msg_composer_account_changed_cb):
Desensitize the "send-options" action unless we've selected an
Exchange or GroupWise account. Based on a patch by Paul Bolle.
svn path=/trunk/; revision=35660
2008-06-13 Milan Crha <mcrha@redhat.com>
** Fix for bug #330597
* e-msg-composer.c: (add_attachments_handle_mime_part): Add all
text/* parts which has a filename set and also attach all submessages.
svn path=/trunk/; revision=35634
2008-05-08 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #525241 (EPluginUI)
* e-util/Makefile.am:
Add e-plugin-ui.[ch].
* e-util/e-plugin.h (EPluginClass):
Add a "get_symbol" method for extracting arbitrary symbols
from an EPlugin. Implementation of the method is optional.
* e-util/e-plugin.c (e_plugin_get_symbol):
New function invokes the new "get_symbol" EPlugin method.
* e-util/e-plugin.c (epl_get_symbol):
New function implements the new "get_symbol" EPlugin method.
It extracts the given symbol name from the GModule.
* e-util/e-plugin-ui.[ch]:
New EPluginHook subclass that allows plugins to extend menus,
toolbars, and popups that are managed by GtkUIManager instead
of BonoboUI. Should eventually replace EMenu/EPopup.
* shell/main.c (main): Register the EPluginUIHook type.
* composer/e-msg-composer.c (msg_composer_destroy),
(msg_composer_init): Rip out the EMenu logic.
* composer/e-msg-composer.c (msg_composer_init):
Register the GtkUIManager with EPluginUI.
* plugins/face/Makefile.am:
* plugins/face/org-gnome-face-ui.xml:
Remove org-gnome-face-ui.xml (obsolete).
* plugins/face/face.c (e_plugin_ui_init):
Initialization callback for EPluginUI. Adds a "face" action to
the EMsgComposer instance's "composer" action group.
* plugins/face/org-gnome-face.eplug.xml:
Replace the "bonobomenu" hook definition with a new one for
EPluginUI. Include the UI definition inline.
svn path=/trunk/; revision=35485
2008-04-28 Matthew Barnes <mbarnes@redhat.com>
* composer/e-composer-actions.c (action_send_options_cb):
Fix a typo in the EError tag.
svn path=/trunk/; revision=35431
2008-04-17 Milan Crha <mcrha@redhat.com>
** Fix for bug #526741 (gnome-vfs to gio/gvfs port)
* configure.in: Drop dependency on gnome-vfs, depend on gio instead.
* addressbook/gui/contact-editor/e-contact-editor.c: Do not include gnome-vfs.
* calendar/gui/e-meeting-store.c: (start_async_read), (freebusy_async),
(async_read): Read data with gio, not with gnome-vfs.
* calendar/gui/e-meeting-store.c: (async_close): Function removed.
* calendar/gui/migration.c:
* calendar/gui/e-memos.c:
* calendar/gui/alarm-notify/notify-main.c:
* calendar/gui/e-tasks.c:
* calendar/gui/main.c:
* calendar/gui/e-meeting-list-view.c:
Do not include gnome-vfs.
* calendar/gui/dialogs/comp-editor.c: (set_attachment_list):
* calendar/gui/dialogs/comp-editor.c: (attachment_guess_mime_type):
Function removed, use e-util function instead.
* calendar/gui/e-cal-popup.c: (temp_save_part):
Reflect changes in CamelStreamVFS.
* calendar/gui/e-cal-popup.c: (ecalp_apps_open_in), (ecalp_apps_popup_free),
(ecalp_standard_menu_factory): Use gio to fill popup and launch app.
* calendar/gui/e-cal-component-preview.h: (e_cal_comp_preview_url_requested_cb):
* calendar/gui/e-cal-component-preview.c: (e_cal_comp_preview_url_requested_cb):
New helper function to manage file:// urls for GtkHTML component.
* calendar/gui/e-cal-component-preview.c: (e_cal_component_preview_init):
* calendar/gui/e-cal-component-memo-preview.c:
(e_cal_comp_preview_url_requested_cb):
Use above helper function.
* calendar/gui/e-cal-component-memo-preview.c: (url_requested_cb):
* calendar/gui/e-cal-component-preview.c: (url_requested_cb): Function removed.
* composer/e-msg-composer.h: (e_msg_composer_guess_mime_type):
* composer/e-msg-composer.c: (e_msg_composer_guess_mime_type), (handle_uri),
(e_msg_composer_add_inline_image_from_file):
Use shared e_util_guess_mime_type instead of its own.
* e-util/e-gui-utils.c: Do not include gnome-vfs.
* e-util/e-util.c: (e_write_file_uri), (e_file_get_save_path):
* e-util/e-dialog-utils.c: (e_file_can_save), (e_file_check_local):
Use gio instead of gnome-vfs.
* e-util/e-util.h:
* e-util/e-util.c: (e_util_guess_mime_type), (e_util_filename_to_uri),
(e_util_uri_to_filename), (e_util_read_file): New helper functions.
* mail/Makefile.am:
* mail/em-vfs-stream.h:
* mail/em-vfs-stream.c: Removed from project, not used anywhere.
* mail/em-menu.c:
* mail/em-config.c: Do not include gnome-vfs.
* mail/mail-ops.c: (save_messages_exec), (save_part_exec):
Changes related to Data Server change of CamelStreamVFS.
* mail/em-format.c: (em_format_describe_part):
* mail/em-format-html-display.c: (efhd_bonobo_object), (efhd_find_handler),
(efhd_use_component), (efhd_bonobo_unknown), (efhd_check_server_prop),
(efhd_format_attachment): Drop use of deprecated gnome-vfs functions.
* mail/em-utils.c: (em_utils_snoop_type): Use gio to guess the mime_type.
* mail/em-popup.c: (emp_apps_open_in), (emp_apps_popup_free),
(emp_standard_menu_factory): Use gio to fill popup and launch app.
* plugins/import-ics-attachments/icsimporter.c: Do not include gnome-vfs.
* plugins/ipod-sync/ical-format.c: (do_save_calendar_ical):
* plugins/ipod-sync/ipod-sync.c: (destination_save_addressbook):
Write to gio GOutputStream instead of gnome-vfs handle.
* plugins/ipod-sync/format-handler.h: (open_for_writing):
* plugins/ipod-sync/ipod-sync.c: (open_for_writing): New helper function.
* plugins/publish-calendar/publish-format-fb.h: (publish_calendar_as_fb):
* plugins/publish-calendar/publish-format-fb.c: (write_calendar), (publish_calendar_as_fb):
* plugins/publish-calendar/publish-format-ical.h: (publish_calendar_as_ical):
* plugins/publish-calendar/publish-format-ical.c: (write_calendar), (publish_calendar_as_ical):
Use gio GOutputStream instead of gnome-vfs handle.
* plugins/publish-calendar/url-editor-dialog.c: (create_uri): Use glib function to escape URI.
* plugins/publish-calendar/publish-location.c: (migrateURI): Use EUri to parse URI.
* plugins/publish-calendar/publish-calendar.c: (publish_online), (unmount_done_cb),
(struct mnt_struct), (mount_ready_cb), (ask_password), (ask_question),
(mount_first), (publish):
Use gio instead of gnome-vfs for opening (remote) files.
* plugins/save-calendar/ical-format.c: (do_save_calendar_ical):
* plugins/save-calendar/csv-format.c: (do_save_calendar_csv):
* plugins/save-calendar/rdf-format.c: (do_save_calendar_rdf):
Use gio GOutpuStream instead of gnome-vfs handle.
* plugins/save-calendar/format-handler.h: (open_for_writing):
* plugins/save-calendar/save-calendar.c: (open_for_writing): New helper function.
* shell/e-shell-window-commands.c: (command_quick_reference):
Use gio instead of gnome-vfs.
* widgets/misc/e-attachment.h: (struct _EAttachment):
* widgets/misc/e-attachment.c: (finalise), (init), (attachment_guess_mime_type),
(e_attachment_new), (struct DownloadInfo), (download_info_free),
(data_ready_cb), (download_to_local_path),
(e_attachment_new_remote_file):
Use gio instead of gnome-vfs to download remote files.
* widgets/misc/e-image-chooser.c: (image_drag_data_received_cb):
Use new util function to read file.
* widgets/misc/e-attachment-bar.c: (size_to_string): Stolen from gnome-vfs.
svn path=/trunk/; revision=35378
M configure.in
M ChangeLog
M composer/evolution-composer.ui
M composer/ChangeLog
M composer/e-composer-actions.c
M composer/e-composer-private.c
M widgets/misc/ChangeLog
M widgets/misc/e-attachment-bar.c
M widgets/misc/e-attachment-bar.h
M calendar/gui/dialogs/comp-editor.c
M calendar/ChangeLog
M ui/ChangeLog
M ui/evolution-editor.xml
svn path=/trunk/; revision=35354
2008-04-08 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #523413
* composer/e-msg-composer.c (msg_composer_dispose):
Use the 'application_exiting' private flag to determine whether
to tell e_composer_autosave_unregister() to delete the autosave
file.
* composer/e-msg-composer.c (msg_composer_class_init),
(e_msg_composer_save_draft):
Remove the 'quit' parameter from the 'save-draft' signal.
* composer/e-msg-composer.c (e_msg_composer_request_close_all):
Take an autosave snapshot before activating the CLOSE action,
and set the private 'application_exiting' flag. This should
avoid prompting the user before shutting down.
* composer/e-composer-actions.c (action_close_cb):
When electing to save a message before closing, hide the window
immediately. The callback function can then check the window's
visibility after the save is complete to know whether to destroy
the window.
* composer/e-composer-autosave.c (e_composer_autosave_unregister):
Add a 'delete_file' boolean parameter to determine whether to
delete the autosave file.
* composer/e-composer-private.h:
Add an 'application_exiting' flag.
* mail/em-composer-utils.c (save_draft_done):
Check the composer window's visibility to determine whether to
destroy the window. See the corresponding composer/ChangeLog
entry to get the full story.
* mail/em-composer-utils.c (em_utils_composer_save_draft_cb):
Remove the 'quit' parameter.
svn path=/trunk/; revision=35346
2008-04-05 Matthew Barnes <mbarnes@redhat.com>
** Fixes part of bug #526152, plus some tangential code cleanup.
* mail/Makefile.am:
Remove all the IDL crud for GnomeSpell.
* mail/em-composer-prefs.c:
* mail/evolution-mail.schemas.in:
* mail/mail-config.c:
Define our own GConf keys for active spell checking languages
and the underline color for misspelled words, instead of relying
on GnomeSpell's GConf keys. The new keys are:
/apps/evolution/mail/composer/spell_color (string)
/apps/evolution/mail/composer/spell_languages (list of strings)
* mail/em-composer-prefs.c:
* mail/em-composer-prefs.h:
Cleanup the logic a bit to improve readability.
* mail/mail-config.c:
Cleanup the GConf notification logic:
- We don't need the notification IDs for GConf keys we're watching.
- Minimize the repetition of GConf keys to reduce the risk of typos.
- Reduce the number of notification callback functions.
* mail/Spell.idl:
Remove this file; we don't use GnomeSpell anymore.
* composer/e-msg-composer.c:
* composer/e-composer-private.h:
Initialize a new composer's spell checking language menu via
our new "spell_languages" GConf key.
* tools/killev.c (main):
No need to continue killing the GnomeSpell Bonobo server.
svn path=/trunk/; revision=35322
2008-04-02 Matthew Barnes <mbarnes@redhat.com>
** Merge the mbarnes-composer branch
* configure.in:
Bump libgtkhtml requirement to 3.19.1.
Add gtkhtml-editor dependency for addressbook, calendar and mail.
Remove print-message plugin; new composer implements this natively.
* tools/Makefile.am:
Remove CORBA rules for the old composer.
* addressbook/gui/widgets/Makefile.am:
Remove CORBA rules for the old composer.
* addressbook/gui/widgets/eab-gui-util.c
(eab_send_to_contact_and_email_num_list),
(eab_send_contact_list_as_attachment):
Adapt to new Bonobo-less composer widget.
* calendar/gui/Makefile.am:
Remove CORBA rules for the old composer.
* calendar/gui/itip-utils.c (comp_from), (comp_to_list),
(comp_subject), (comp_content_type), (comp_filename),
(comp_description), (append_cal_attachments), (itip_send_comp),
(reply_to_calendar_comp):
Adapt to new Bonobo-less composer widget.
* composer/Makefile.am:
Remove CORBA rules for the old composer.
* composer/e-msg-composer.c:
* composer/e-msg-composer.h:
EMsgComposer is now a subclass of GtkhtmlEditor.
Extensive refactoring and cleanup, too much to list in detail.
* composer/e-composer-header.c:
* composer/e-composer-header.h:
Add "sensitive" property along with get/set functions.
* composer/e-composer-from-header.c:
* composer/e-composer-from-header.h:
Propagate "refreshed" signal from EAccountComboBox.
Add function e_composer_from_header_get_account_list().
* composer/e-composer-private.c:
* composer/e-composer-private.h:
New files manage composer's private data.
Allows other composer files to manipulate private data.
* composer/e-msg-composer-hdrs.c:
* composer/e-msg-composer-hdrs.h:
Remove these files; replaced by EComposerHeaderTable widget.
* composer/evolution-composer.c:
* composer/evolution-composer.h:
Remove these files; composer is now a subclass of GtkhtmlEditor.
* composer/e-msg-composer-select-file.c:
* composer/e-msg-composer-select-file.h:
Remove these files; logic moved to e-msg-composer.c.
* composer/listener.c:
* composer/listener.h:
Remove these files; event handlers moved to e-msg-composer.c.
* composer/Composer.idl:
* composer/Evolution-Composer.idl:
Remove these files; composer is no longer a Bonobo object.
* mail/em-composer-prefs (sig_edit_cb),
(em_composer_prefs_new_signature):
Adapt to new Bonobo-less signature editor.
* mail/mail-signature-editor.c:
* mail/mail-signature-editor.h:
Rewrite the signature editor as a subclass of GtkhtmlEditor.
Eliminates Bonobo from the equation.
* mail/em-composer-utils.c (composer_get_message),
(em_utils_composer_send_cb), (save_draft_done),
(em_utils_composer_save_draft_cb), (create_new_composer),
(em_utils_compose_new_message),
(em_utils_compose_new_message_with_mailto), (em_utils_post_to_folder),
(em_utils_post_to_url), (edit_message), (forward_attached),
(forward_non_attached), (reply_get_composer), (composer_set_body),
(em_utils_reply_to_message), (post_reply_to_message):
Adapt to new Bonobo-less composer.
* mail/mail-component-factory.c:
Composer is no longer needs a Bonobo factory.
* mail/mail-config.c:
Fix style pattern for EMsgComposer widgets.
* plugins/groupwise/mail-send-options.c
(org_gnome_composer_send_options):
Adapt to streamlined EMsgComposer API.
* plugins/exchange-operations/Makefile.am:
Add EVOLUTION_MAIL_CFLAGS and EVOLUTION_MAIL_LIBS.
* plugins/exchange-operations/exchange-mail-send-options.c
(append_to_header), (org_gnome_exchange_send_options):
Adapt to streamlined EMsgComposer API.
* plugins/mailing-list-actions/mailing-list-actions.c
(emla_list_action_do):
Adapt to streamlined EMsgComposer API.
* po/POTFILES.in: Update file list for new composer.
* ui/evolution-composer-entries.xml:
Remove this file; obsoleted by new composer.
* widgets/misc/Makefile.am:
Add EVOLUTION_MAIL_LIBS.
* widgets/misc/e-account-combo-box.c:
* widgets/misc/e-account-combo-box.h:
New function e_account_combo_box_get_account_list().
Emit a "refreshed" signal when the EAccountList changes.
Add an internal reverse-lookup index.
* widgets/misc/e-charset-picker.c (e_charser_add_radio_actions):
New function adds radio actions to an action group.
Will eventually replace e_charset_picker_bonobo_ui_populate().
* widgets/misc/e-signature-combo-box.c:
* widgets/misc/e-signature-combo-box.h:
New function e_signature_combo_box_get_signature_list().
... separate issue ...
* configure.in:
Bump eds_minimum_version to 2.23.1 for
CAMEL_FOLDER_JUNKED_NOT_DELETED symbol.
svn path=/trunk/; revision=35313
2008-02-20 Milan Crha <mcrha@redhat.com>
** Part of fix for bug #515744
* composer/e-msg-composer.c: (drop_action):
* calendar/gui/dialogs/comp-editor.c: (drop_action):
Fixing previous fix - do not double free.
svn path=/trunk/; revision=35063
