Commit Graph

363 Commits

Author SHA1 Message Date
9673d07cca Revert fix for Ximian bug #6995.
2001-08-21  Christopher James Lahey  <clahey@ximian.com>

	* Revert fix for Ximian bug #6995.

svn path=/trunk/; revision=12418
2001-08-23 17:24:24 +00:00
6fba7d7077 In the GUI, the toggle is labelled "hide addresses", not "show addresses"
2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * gui/contact-list-editor/e-contact-list-editor.c (extract_info):
        In the GUI, the toggle is labelled "hide addresses", not "show
        addresses" -- so we have to reverse the boolean value we read in.
        (fill_in_info): Same bug as before: since the GUI reads "hide", we
        have to initialize the toggle to '!show_addresses', not
        'show_addresses'.

        * backend/ebook/e-destination.c
        (e_destination_list_show_addresses): Added.
        (e_destination_xml_encode): Encode the value of
        e_destination_list_show_addresses into the XML.
        (e_destination_xml_decode): Read and store the "show_addresses"
        flag.

2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * e-msg-composer-hdrs.c (set_recipients_from_destv): Added.  Try
        to properly handle contact lists in which the addresses of the
        list members should be hidden.
        (e_msg_composer_hdrs_to_message): Changed to extract the
        destination data from the entries and pass it along to
        set_recipients_from_destv.


2001-08-22  Jon Trowbridge  <trow@ximian.com>

        * mail-callbacks.c (ask_confirm_for_only_bcc): Provide alternative
        text for this dialog for the case when a message has only Bcc
        recipients because of a hidden contact list's addresses being
        moved from To/Cc to Bcc.
        (composer_get_message): Try to detect when our message has only
        Bcc recipients because of moving addresses around due to a hidden
        contact list, and show the dialog with the revised wording in this
        case.

svn path=/trunk/; revision=12414
2001-08-23 02:58:14 +00:00
41dcb0c01b camel_folder_create_folder can now return a heirachial tree so subscribe
2001-08-20  Jeffrey Stedfast  <fejj@ximian.com>

	* component-factory.c (storage_create_folder):
	camel_folder_create_folder can now return a heirachial tree so
	subscribe to down the tree.

svn path=/trunk/; revision=12257
2001-08-20 07:29:26 +00:00
ac4f13b93e Allow the activity to be NULL if there isn't a global_shell_client so that
2001-08-19  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-mt.c (do_op_status): Allow the activity to be NULL if there
	isn't a global_shell_client so that we don't try and report status
	updates when the shell is destroyed.

	* mail-config.c (add_shortcut_entry): Return if there isn't a
	global_shell_client.

	* component-factory.c (owner_set_cb): set the global_shell_client
	here and connect to the destroy signal.

	* mail-vfolder.c (vfolder_create_storage): Use an extern global_shell_client.

svn path=/trunk/; revision=12242
2001-08-20 04:02:10 +00:00
8c156210fe Made delete make the cursor go backwards if the user is sorting by
2001-08-19  Christopher James Lahey  <clahey@ximian.com>

	* mail-callbacks.c (delete_msg): Made delete make the cursor go
	backwards if the user is sorting by descending date.

svn path=/trunk/; revision=12236
2001-08-20 02:13:12 +00:00
4dd1972ef9 Convert the date string to UTF-8. (do_forward_non_attached): Same here.
2001-08-19  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Convert the date string
	to UTF-8.
	(do_forward_non_attached): Same here.

svn path=/trunk/; revision=12222
2001-08-19 18:47:01 +00:00
1674bd705b Change the default values for "always-sign" to false.
2001-08-18  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.c (config_read): Change the default values for
	"always-sign" to false.

	* mail-callbacks.c (open_msg): if the folder is Outbox, let the
	user edit the message(s) too I guess.

svn path=/trunk/; revision=12208
2001-08-18 20:52:25 +00:00
4267d55b9f remove a cmpiler warning
svn path=/trunk/; revision=12163
2001-08-17 17:49:40 +00:00
6b1869912e Respect the user's desire to be prompted to confirm that he wants to
2001-08-16  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (confirm_expunge): Respect the user's desire to
	be prompted to confirm that he wants to expunge the blasted
	folder. Also, don't set the usize - that's just an evil hack and
	you may find it will cut off text once the label has been
	translated.
	(create_msg_composer): In order for the security options to be
	checked when composing a new message, we must set the from account
	explicitly even though the composer hdrs sets the default from
	account and emits the signal because at that stage the composer
	hasn't yet connected to the signals and thus the bonobo menu items
	don't get set.

	* mail-config.c (mail_config_set_confirm_expunge): New.
	(mail_config_get_confirm_expunge): New.

svn path=/trunk/; revision=12141
2001-08-17 03:01:37 +00:00
3b25ec8b5e Re-added, at Ettore's request, the confirm-expunge dialog.
2001-08-15  Anna Marie Dirks <anna@ximian.com>

	* mail-callbacks.c (expunge-folders): Re-added, at Ettore's
	request, the confirm-expunge dialog.

svn path=/trunk/; revision=12071
2001-08-15 20:27:26 +00:00
634a4e12f4 Don't confirm expunge.
2001-08-16  Not Zed  <NotZed@Ximian.com>

        * mail-callbacks.c (expunge_folder): Don't confirm expunge.

svn path=/trunk/; revision=12053
2001-08-15 15:48:56 +00:00
aabe697d0b Make previous unread wrap around too.
2001-08-14  Peter Williams  <peterw@ximian.com>

	* mail-callbacks.c (previous_unread_msg): Make previous unread
	wrap around too.

svn path=/trunk/; revision=12029
2001-08-14 19:29:27 +00:00
5be8aeed4c Confirm that the user really wants to expunge. (save_msg_ok): Set the
2001-08-13  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (expunge_folder): Confirm that the user really
	wants to expunge.
	(save_msg_ok): Set the parent window here.

svn path=/trunk/; revision=11949
2001-08-13 19:55:40 +00:00
8e3b907c2e Prepend the uri with evolution: to fix bug #6916.
2001-08-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (transfer_msg): Prepend the uri with evolution:
	to fix bug #6916.

svn path=/trunk/; revision=11903
2001-08-10 22:30:14 +00:00
acdfbcd161 Since 'N' keypresses go through here now, use wrap-around selecting.
2001-08-10  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (next_unread_msg): Since 'N' keypresses go
	through here now, use wrap-around selecting.
	(previous_unread_msg): Same for 'P' here.

	* message-list.c (on_cursor_activated_idle): Stop this idle timer
	when we have multiple items selected, this keeps it from loading
	and then marking the last item in your selection list as read.
	Bug #4693.

svn path=/trunk/; revision=11895
2001-08-10 20:02:05 +00:00
a6d3ee31f3 If marking messages as unread, remove the automatic mark-as-read timer.
2001-08-10  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (mark_as_unseen): If marking messages as
	unread, remove the automatic mark-as-read timer.  Bug #4153.

svn path=/trunk/; revision=11882
2001-08-10 17:43:15 +00:00
91cc2f264e Added a g_assert_not_reached() - I'm hoping this will help us track down
2001-08-09  Jeffrey Stedfast  <fejj@ximian.com>

	* message-list.c (mlfe_callback): Added a g_assert_not_reached() -
	I'm hoping this will help us track down the "can't delete message
	sometimes" (ie bug #6637 and friends) bugs that users have been
	reporting. If herein lies the problem, then we can expect some
	crashes and some good backtraces, hopefully.

svn path=/trunk/; revision=11854
2001-08-09 23:58:52 +00:00
bfa7f88ced Save the pgp and smime always-sign options.
2001-08-09  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-account-gui.c (mail_account_gui_save): Save the pgp and
	smime always-sign options.

	* mail-config.c (account_copy): Copy the always-sign options over
	too.

svn path=/trunk/; revision=11841
2001-08-09 19:24:06 +00:00
ff41087ad4 Hide the app->window. (do_mail_print): Set the parent of the gnome-dialog
2001-08-07  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (manage_subscriptions): Hide the app->window.
	(do_mail_print): Set the parent of the gnome-dialog to be the
	folder-browser so that when evolution is closed, the print dialog
	gets destroyed. Should fix bug #4781.

svn path=/trunk/; revision=11757
2001-08-08 00:22:05 +00:00
4e7cdf4088 Hide the app->window.
2001-08-07  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (manage_subscriptions): Hide the app->window.

svn path=/trunk/; revision=11754
2001-08-07 23:36:02 +00:00
8099103dbd Use bonobo_object_unref on the storage since it's a bonobo object.
2001-08-07  Peter Williams  <peterw@ximian.com>

	* mail-callbacks.c (folder_created): Use bonobo_object_unref on the storage
	since it's a bonobo object.
	(mail_storage_create_folder): Same.
	(folder_deleted): Same.

svn path=/trunk/; revision=11749
2001-08-07 23:10:29 +00:00
7aeeb5f282 Added key accelerators to a bunch of the config options and moved the Bcc
2001-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.glade: Added key accelerators to a bunch of the
	config options and moved the Bcc and empty-subject checkboxes to
	the composer tab where they belong.

	* mail-callbacks.c (providers_config): Raise the dialog if it
	exists already.
	(manage_subscriptions): Raise the dialog if it already exists.
	(main_select_first_unread): Removed (we haven't needed this code
	in ages).
	(select_first_unread): Same.
	(save_msg_ok): If the path is empty, just return.

	* mail-local.c (mail_local_reconfigure_folder): Raise the dialog
	if it already exists.

svn path=/trunk/; revision=11719
2001-08-07 01:11:48 +00:00
739376df3b Set the message-display message to NULL if we can't get an info too.
2001-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (expunge_folder): Set the message-display
	message to NULL if we can't get an info too.

svn path=/trunk/; revision=11711
2001-08-06 21:47:58 +00:00
0b71da2cf3 Make vtrash folders on other storages with a "vtrash" type, so they get
2001-08-06  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (create_folders): Make vtrash folders on other
	storages with a "vtrash" type, so they get the little trashcan
	icon.

svn path=/trunk/; revision=11709
2001-08-06 20:32:51 +00:00
d7562e99ae Reimplement to be asynchronous and pretty, with progressive folder loading
2001-08-06  Peter Williams  <peterw@ximian.com>

	* subscribe-dialog.[ch]: Reimplement to be asynchronous and pretty,
	with progressive folder loading and all sorts of wonderful
	improvements.

	* mail-callbacks.c (manage_subscriptions): Change to reflect API
	update.

	* component-factory.c (mail_load_storages): Don't add the storage
	if it has been disabled.

	* Makefile.am (etspec_DATA): Add subscribe-dialog.etspec.
	(glade_DATA): And the glade file.

	* subscribe-dialog.etspec: New file, break out the specification
	from inside the subscribe-dialog.c

	* subscribe-dialog.glade: Update this, actually use it now.

svn path=/trunk/; revision=11706
2001-08-06 19:02:00 +00:00
7ebb69efa2 Yuck. Special case whether or not we want to expunge all the trash folders
2001-08-06  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (empty_trash): Yuck. Special case whether or
	not we want to expunge all the trash folders syncronously or
	asyncronously based on whether or not we are doing Empty-On-Exit
	or emptying trash by user request respectively.

svn path=/trunk/; revision=11701
2001-08-06 16:48:42 +00:00
d27f28ec43 forgot to commit a file
svn path=/trunk/; revision=11653
2001-08-04 19:04:21 +00:00
bd91048f01 Raise the filter-editor window if it's already created.
2001-08-02  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (filter_edit): Raise the filter-editor window
	if it's already created.

svn path=/trunk/; revision=11598
2001-08-02 21:22:30 +00:00
ca7c6e2fc0 Don't move cursors around when deleting last message and Hide Deleted
2001-08-01  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (delete_msg): Don't move cursors around when
	deleting last message and Hide Deleted Messages isn't enabled.
	Bug #5928.

svn path=/trunk/; revision=11543
2001-08-01 08:56:38 +00:00
b0d5e599ce Don't make the key url:item if we have the url, just make it url. This
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-session.c (make_key): Don't make the key url:item if we
	have the url, just make it url. This fixes bug #5339.
	(mail_session_set_password): Removed.

svn path=/trunk/; revision=11411
2001-07-25 20:04:12 +00:00
0fbf9cd43f Initialize `me' to NULL. (forward_attached): If we are only forwarding a
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Initialize `me' to NULL.
	(forward_attached): If we are only forwarding a single message,
	pass the message along as the callback data, else pass NULL.
	(do_forward_attach): Updated for changes to
	forward_get_composer().
	(do_forward_non_attached): Same.
	(forward_get_composer): Try to guess which account to forward the
	message from if the message passed in is non-NULL.

svn path=/trunk/; revision=11401
2001-07-25 16:33:44 +00:00
661e18ae52 Initialize `me' to NULL.
2001-07-25  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Initialize `me' to NULL.

svn path=/trunk/; revision=11400
2001-07-25 16:03:04 +00:00
b834d6590e If we're the last row and we're deleting, select the previous message, not
2001-07-24  Jason Leach  <jleach@ximian.com>

        * mail-callbacks.c (delete_msg): If we're the last row and we're
	deleting, select the previous message, not next, which actually
	selects nothing.  Fixes #5323.

svn path=/trunk/; revision=11391
2001-07-25 00:39:34 +00:00
49bad5e10f Do a case-insensitive comparison. (mail_generate_reply): Only resort to
2001-07-24  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (guess_me): Do a case-insensitive comparison.
	(mail_generate_reply): Only resort to the source account's
	identity if we can't find out which identity to use based on the
	recipients of the message first.

	* mail-config.c (mail_config_get_default_account): Make sure to
	return the 0th account if we don't have a default. We don't want
	to return NULL.

	* mail-callbacks.c (empty_trash): Use mail_tool_get_trash for the
	remote store trash folders.

	* mail-tools.c (mail_tool_get_trash): New convenience function.

svn path=/trunk/; revision=11353
2001-07-24 20:12:47 +00:00
fc59208aa9 Fixed the "Read" to be Read in the glade file per menesis' request.
2001-07-23  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-config.glade: Fixed the "Read" to be Read in the glade file
	per menesis' request.

	* mail-accounts.c (construct): Give the dialog a Close button
	instead of an OK button.
	(prompt_bcc_only_toggled): New.
	(threaded_list_toggled): New.
	(show_preview_toggled): New.
	(construct): Add code for the bcc-only-prompt, threaded-list, and
	show-preview checkboxes.

	* mail-ops.c (transfer_messages_transfer): If the source and
	destination folders are the same, just mark the uids as undeleted
	(in case they were marked as deleted before).

svn path=/trunk/; revision=11327
2001-07-24 00:53:24 +00:00
b4f3f0c102 [Bug #5225: No UI way to mark as unimportant]
2001-07-23  Jason Leach  <jleach@ximian.com>

	[Bug #5225: No UI way to mark as unimportant]

	* folder-browser.c (on_right_click): Do the necessary stuff to
	show or hide the correct "Mark Important" or "Mark as Unimportant"
	menu items depending on the status of messages that are selected.

	* folder-browser-ui.c: Add the MarkAsUnimportant verb here.

	* mail-callbacks.c (mark_as_unimportant): Simple function that's
	the callback for these new menu items.

svn path=/trunk/; revision=11316
2001-07-23 19:14:53 +00:00
85a02926e6 In camel:
2001-07-19  Peter Williams  <peterw@ximian.com>

	Policy change: NULL url's are no longer allowed in CamelFolderInfos. They used
	to signify that the folder was, in IMAP jargon, NoSelect; now the same effect
	is achieved by adding a "noselect=yes" parameter to the end of the URL. As far
	as I know, IMAP is the only affected provider.

	* providers/imap/camel-imap-store.c (delete_folder): New function. Implement
	folder deletion.
	(camel_imap_store_class_init): Set the delete_folder class function here.
	(get_folder_status): New function. Utility wrapper around the STATUS command.
	(create_folder): If the parent folder is NoSelect but is empty, delete it
	and recreate it as a a subfolder-containing folder. If it is NoSelect but
	contains messages, set an exception.
	(parse_list_response_as_folder_info): Always set the FolderInfo's URL, but
	add a NoSelect parameter if it isn't selectable.
	(get_folder_info_online): Change logic of removing the namespace to reflect
	URL change. Same for logic of checking unread counts.
	(get_folder_info_online): Use get_folder_status to simplify this.

	* camel-store.c (camel_folder_info_build): When creating
	dummy parents, copy the child's URL and set the NoSelect
	parameter.

In mail:

2001-07-19  Peter Williams  <peterw@ximian.com>

	Track the NoSelect changes in Camel.

	* mail-callbacks.c (create_folders): We don't need to check if
	the URL is NULL or not anymore.

	* component-factory.c (create_noselect_control): New
	function. Create a dummy control for folders that can't contain
	messages (ie \NoSelect)
	(create_view): If the URI says the folder is noselect, make a
	dummy control. FIXME: still should merge in the global UI
	elements.
	(xfer_folder): Don't allow the operation if the destination is
	NoSelect.
	(destination_folder_handle_motion): Ditto.
	(destination_folder_handle_drop): Ditto.

svn path=/trunk/; revision=11237
2001-07-19 21:35:43 +00:00
40934b5c2a Use CAMEL_VTRASH_NAME.
2001-07-17  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-local.c (init_trash): Use CAMEL_VTRASH_NAME.

	* mail-ops.c (add_vtrash_info): Use CAMEL_VTRASH_NAME.

	* folder-browser.c: turned off some debugging

2001-07-16  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (transfer_msg): Disallow vtrash for now...

svn path=/trunk/; revision=11159
2001-07-17 16:42:35 +00:00
555b09d3b4 Merged mine and Peter's entries.
2001-07-13  Jeffrey Stedfast  <fejj@ximian.com>

	* NEWS (Mail): Merged mine and Peter's entries.

svn path=/trunk/; revision=11097
2001-07-13 19:28:16 +00:00
3209f94b02 Segfault prevention here if no uid is currently loaded.
2001-07-13  Peter Williams  <peterw@ximian.com>

	* mail-callbacks.c (expunge_folder): Segfault prevention here if no uid is
	currently loaded.

svn path=/trunk/; revision=11093
2001-07-13 18:06:44 +00:00
a099cf6547 Segfault prevention here if we lose the race with
2001-07-13  Peter Williams  <peterw@ximian.com>

	* mail-callbacks.c (expunge_folder): Segfault prevention here if we lose
	the race with message_list_set_hidedeleted().

svn path=/trunk/; revision=11092
2001-07-13 17:55:27 +00:00
d1a65232c9 Force-hide all deleted messages before expunging. (expunged_folder):
2001-07-12  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (expunge_folder): Force-hide all deleted
	messages before expunging.
	(expunged_folder): Restore the user's "hide deleted messages"
	preference.

svn path=/trunk/; revision=11056
2001-07-12 19:50:59 +00:00
74042027db Only blank the mail display if the message being viewed is one of those to
2001-07-12  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (expunge_folder): Only blank the mail display
	if the message being viewed is one of those to be expunged.  Bug
	#4030.

svn path=/trunk/; revision=11052
2001-07-12 18:28:03 +00:00
6130dbd266 Make sure that the reply-to addr i non-NULL before trying to add it to the
2001-07-10  Jeffrey Stedfast  <fejj@ximian.com>

	* mail-callbacks.c (mail_generate_reply): Make sure that the
	reply-to addr i non-NULL before trying to add it to the hash
	table.

svn path=/trunk/; revision=10953
2001-07-10 16:04:07 +00:00
214d03a44a add a NULL check since that is a valid return.
2001-07-06  Larry Ewing  <lewing@ximian.com>

	* mail-callbacks.c (composer_send_cb): add a NULL check since that
	is a valid return.

svn path=/trunk/; revision=10866
2001-07-06 21:47:18 +00:00
ff91646452 Freeze and Thaw the folder.
2001-07-06  Jeffrey Stedfast  <fejj@ximian.com>

	* folder-browser.c (folder_browser_copy): Freeze and Thaw the
	folder.

svn path=/trunk/; revision=10855
2001-07-06 20:19:22 +00:00
068ae263a0 Don't free the psd here -- it will be freed on the "destroy" signal.
2001-07-06  Peter Williams  <peterw@ximian.com>

	* mail-callbacks.c (composer_postpone_cb): Don't free the psd here --
	it will be freed on the "destroy" signal.

	* mail-folder-cache.c (maybe_update): Instead of an idle, use a very
	short timeout in hopes of reducing the number of redundant updates.

	* mail-tools.c (mail_tool_uri_to_folder): Only note the folder in the
	cache if we successfully got it.

svn path=/trunk/; revision=10852
2001-07-06 18:58:48 +00:00
5616de5309 Select the very next message after deleting, not the next undeleted (it
2001-07-06  Jason Leach  <jleach@ximian.com>

	* mail-callbacks.c (delete_msg): Select the very next message
	after deleting, not the next undeleted (it can make things jump
	around in annoying ways if you are deleting many messages), bug #4032.

	* folder-browser.c: Forgot to commit the "Mark as Important" right
	click menu item.

	* message-list.c (message_list_set_folder): Setup the strikeout
	column here (after we've gotten the folder) so we can disable
	strikeouts for vtrash folders, part of bug #2224.

svn path=/trunk/; revision=10849
2001-07-06 18:02:01 +00:00
f21f291479 Unset the message being displayed when expunging. This makes expunged
2001-07-03  Joe Shaw  <joe@ximian.com>

	* mail-callbacks.c (expunge_folder): Unset the message being displayed
	when expunging. This makes expunged messages not show in the preview
	pane when they're not there anymore. Fixes #3591.

svn path=/trunk/; revision=10774
2001-07-03 23:04:35 +00:00
dd5ad61e19 If msg is NULL, fetch the message and requeue a mail_reply call. Fixes bug
2001-07-03  Joe Shaw  <joe@ximian.com>

	* mail-callbacks.c (mail_reply): If msg is NULL, fetch the message
	and requeue a mail_reply call. Fixes bug #3816.
	(requeue_mail_reply): Callback from mail_get_message().

svn path=/trunk/; revision=10772
2001-07-03 22:33:14 +00:00