Commit Graph

95 Commits

Author SHA1 Message Date
84c55f4e98 Fix even more compiler warnings and disable one for format strings 2009-06-05 14:50:42 +02:00
8771a6de35 More code cleanup. 2009-06-01 19:09:19 -04:00
6413227cef Whitespace cleanup. 2009-05-28 13:13:05 -04:00
fad4af8a3d Prefer GLib basic types over C types. 2009-05-28 12:13:23 -04:00
6f5464f34c Remove trailing whitespace, again. 2009-05-28 12:13:22 -04:00
e4fa8fe104 Fix several types of pedantic compiler warnings. 2009-05-16 12:11:55 -04:00
6e72a236dc ** BUGFIX: 573830 - g_timeout_add_seconds should be preferred to g_timeout_add
According to https://wiki.ubuntu.com/SavingTheWorld (and of course according to
the gtk docs) using g_timeout_add_seconds is preferred over g_timeout_add if a
timeout in seconds is desired.
2009-05-04 10:10:55 +05:30
c1a12789ac Bug 580893 – Kill libgnome/gnome-gconf 2009-04-30 22:54:15 -04:00
e42f276527 Bug 577929 – Consolidate marshallers
Consolidate all marshalling specifications to e-util/e-marshal.list.
This reduces code duplication and makes it slightly easier to locate
unused marshallers.
2009-04-23 10:02:07 -04:00
cfe3be08ff ** Fixes bug #572962
2009-02-24  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #572962

	* e-shell-window.c (setup_nm_support):
	Pass e_shell_dbus_initialise() the right type of object,
	and fix the incorrect function declaration.

	* e-shell-nm.c (e_shell_network_monitor):
	Go offline when we see NM_STATE_ASLEEP from NetworkManager.


svn path=/trunk/; revision=37320
2009-02-24 23:46:11 +00:00
cd622d600e Jeff Cai ** Fix for bug #563077 (Don't pass NULL to gtk_icon_info_get_filename(), fixes a crash if the gnome-settings-daemon is not running).
svn path=/trunk/; revision=36844
2008-12-08 08:09:01 +00:00
5ce1bbbbc8 Matthew Barnes <mbarnes@redhat.com> ** Fix for bug #548469 (Drop support for deprecated libnm-glib).
svn path=/trunk/; revision=36631
2008-10-17 05:18:16 +00:00
2e984bf77a Change License from GPL to LGPL.
svn path=/trunk/; revision=36541
2008-10-03 09:48:36 +00:00
879d84ab6e Coding style cleanups.
svn path=/trunk/; revision=36025
2008-08-19 15:02:36 +00:00
f19618ac7f ** Fixes bug #508732
2008-08-18  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #508732

	* shell/e-shell.c:
	Add a "crash_recovery" flag, with accessor functions for it.

	* shell/e-shell-window (init_view):
	Check and reset the "crash_recovery" flag before creating a
	new shell view.  The components can use this flag to take
	steps to recover from the previous crash.

	* shell/apps_evolution_shell.schemas.in:
	Remove the "skip_recovery_dialog" and "recovery" keys.

	* shell/Evolution-Component.idl (createView):
	Add a "select_item" boolean parameter.

	* shell/main.c:
	Kill the crash recovery dialog.  Instead just set the crash
	recovery flag in e-shell appropriately.

	* mail/mail-component.c (impl_createView):
	Add a "select_item" argument for crash recovery, which we forward
	to EMFolderBrowser as a "suppress_message_selection" flag.

	* mail/em-folder-browser.c (emfb_set_folder):
	Suppress automatic message selection if we are recovering from a
	crash.

	* addressbook/gui/component/addressbook-component.c (impl_createView):
	* calendar/gui/calendar-component.c (impl_createView):
	* calendar/gui/memos-component.c (impl_createView):
	* calendar/gui/tasks-component.c (impl_createView):
	Add a "select_item" argument for crash recovery, which these
	components do not use.

	* help/C/evolution.xml:
	Remove the bit about crash recovery.


svn path=/trunk/; revision=36009
2008-08-18 04:37:15 +00:00
c714d8efd1 ** Fixes bug #467115
2008-08-07  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #467115

	* shell/e-component-registry.h:
	Replace button and menu icon pixbufs with an icon name string.

	* shell/e-component-registry.c (query_components):
	No need to create pixbufs, just save the icon name.

	* shell/e-sidebar.c:
	Remember a default icon name rather than a default pixbuf.

	* shell/e-sidebar.c (e_sidebar_add_button),
        (e_sidebar_change_button_icon):
	* shell/e-shell-window.c (e_shell_window_change_component_button_icon):
	Take an icon name instead of a pixbuf.

	* shell/e-shell-window.c (switch_view):
	Call gtk_window_set_icon_name() instead of gtk_window_set_icon().

	* shell/e-shell-window.c (setup_widgets):
	Change XML from pixtype="pixbuf" to pixbuf="filename" and derive
	an appropriate filename from the icon name.


svn path=/trunk/; revision=35924
2008-08-07 14:29:49 +00:00
3e09622310 ** Fixes bug #542587
2008-07-20  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #542587

	* shell/e-shell-window.c: Use new EOnlineButton widget.

	* widgets/misc/e-online-button.c:
	* widgets/misc/e-online-button.h:
	New widget implements the online/offline button used in the main
	window.  The button just maintains an "online" flag and displays
	the appropriate button image for the flag.


svn path=/trunk/; revision=35777
2008-07-20 16:37:22 +00:00
c049cedd69 ** Fix for bug #542889
2008-17-14  Paolo Borelli  <pborelli@katamail.com>

	** Fix for bug #542889

	Port to the new gtk tooltip api.


svn path=/trunk/; revision=35744
2008-07-14 11:38:30 +00:00
abda2bda85 updated novell copyright notices (left others alone)
svn path=/trunk/; revision=35665
2008-06-20 22:26:57 +00:00
4503c052d0 ** Allow evolution to build with G_DISABLE_SINGLE_INCLUDES and
2008-06-06  Matthew Barnes  <mbarnes@redhat.com>

	** Allow evolution to build with G_DISABLE_SINGLE_INCLUDES and
	   GTK_DISABLE_SINGLE_INCLUDES defined.  (#536637)


svn path=/trunk/; revision=35606
2008-06-06 15:12:53 +00:00
0732374acc ** Fix for bug #525238
2008-04-07  Ondrej Jirman  <megous@megous.com>

	** Fix for bug #525238

	* e-shell-window.c: (switch_view):
	* es-event.c:
	* es-event.h:
	Add new "component.activated" event. Event is emitted whenever
	component is activated. ESEventTargetComponent contains an id
	of the component being activated.


svn path=/trunk/; revision=35332
2008-04-07 09:55:11 +00:00
1a02ed8519 Make the status bar height as large as the task bar to eliminate
2008-01-21  Matthew Barnes  <mbarnes@redhat.com>

	* e-shell-window.c (setup_status_bar):
	Make the status bar height as large as the task bar to eliminate
	"bouncing" when navigating the main menu.  Patch by Jean-Christophe
	Begue (#509509).


svn path=/trunk/; revision=34860
2008-01-21 05:16:54 +00:00
de78432343 ** Fix for bug #329712
2008-01-18  Srinivasa Ragavan  <sragavan@novell.com>

	** Fix for bug #329712

	* e-shell-window-commands.c: (update_offline_menu_item):
	* e-shell-window.c: (update_offline_toggle_status),
	(update_send_receive_sensitivity),
	(offline_toggle_clicked_callback):
	* e-shell.c: (e_shell_construct), (e_shell_save_settings),
	(set_line_status):
	* e-shell.h: Add a new state to maintian forced offline.


svn path=/trunk/; revision=34847
2008-01-18 06:53:39 +00:00
5ade9084b3 From shell/ChangeLog
2008-01-11  Changwoo Ryu  <cwryu@debian.org>

	** Fix for bug #508282

	* e-shell-window.c (switch_view): 
	* e-shell-view.c (impl_ShellView_setTitle): Mark the window title
	for translation.

From po/ChangeLog

2008-01-11  Changwoo Ryu  <cwryu@debian.org>

	** Part of fix for bug #508282

	* POTFILES.in: Add new file shell/e-shell-view.c


svn path=/trunk/; revision=34792
2008-01-10 16:17:45 +00:00
78e2089c14 ** Fix for bug #400213
2007-11-30  Milan Crha  <mcrha@redhat.com>

	** Fix for bug #400213

	* e-shell-window.c: (load_icons): Function removed.
	* e-shell-window.c: (update_offline_toggle_status):
	Do not use pixmaps and masks, load images from file, instead.


svn path=/trunk/; revision=34615
2007-11-30 10:24:16 +00:00
9e4fcb29cf ** Remove trailing whitespace from source code.
2007-11-14  Matthew Barnes  <mbarnes@redhat.com>

	** Remove trailing whitespace from source code.


svn path=/trunk/; revision=34537
2007-11-14 22:04:21 +00:00
ebf5dd8717 ** Fixes bug #492058
2007-11-02  Damien Carbery  <damien.carbery@sun.com>

	** Fixes bug #492058

	* shell/e-shell-window.c:
	* shell/e-shell.c:
	* widgets/table/e-table-header-item.h:
	* widgets/table/e-table-header-item.c:
	* calendar/gui/e-itip-control.c:
	Name the anonymous unions to build with the Sun Studio compiler.


svn path=/trunk/; revision=34485
2007-11-02 17:08:05 +00:00
5b97425db5 Warning fixes: - NULL vs 0 vs FALSE - ANSIfication of declarations - guint
2007-10-26  Kjartan Maraas  <kmaraas@gnome.org>

	* e-component-registry.c: (query_components):
	* e-component-view.c: (e_component_view_new),
	(e_component_view_new_controls), (e_component_view_set_title),
	(e_component_view_set_button_icon):
	* e-config-upgrade.c:
	* e-shell-settings-dialog.c: (e_shell_settings_dialog_new):
	* e-shell-window.c: (component_view_free):
	* es-event.c: (es_event_peek):
	* es-menu.c: (es_menu_new):
	* importer/evolution-importer-client.c:
	(evolution_importer_client_create_control):
	Warning fixes:
	- NULL vs 0 vs FALSE
	- ANSIfication of declarations
	- guint for 1-bit bitfields

svn path=/trunk/; revision=34430
2007-10-26 08:40:03 +00:00
eeb89358f6 ** Fix for bug #329823
2007-10-11  Milan Crha  <mcrha@redhat.com>

	** Fix for bug #329823

	* Evolution-Shell.idl: (setButtonIcon):
	* e-sidebar.h: (e_sidebar_change_button_icon):
	* e-sidebar.c: (struct Button), (button_new), (button_free),
	(e_sidebar_change_button_icon):
	* e-shell.h: (EMainShellFunc), (e_shell_foreach_shell_window):
	* e-shell.c: (EMainShellFunc), (e_shell_foreach_shell_window):
	* e-component-view.h: (e_component_view_set_button_icon):
	* e-component-view.c: (e_component_view_set_button_icon):
	* e-shell-window.h: (e_shell_window_change_component_button_icon):
	* e-shell-window.c: (e_shell_window_change_component_button_icon):
	* e-shell-view.c: (struct change_icon_struct),
	(change_button_icon_func), (impl_ShellView_setButtonIcon),
	(e_shell_view_class_init):
	Added support to change component's button icon.

	* mail-component.h: (mail_indicate_new_mail):
	* mail-component.c: (mail_indicate_new_mail),
	(struct _MailComponentPrivate), (impl_dispose), (impl_createView):
	New function to indicate new mails on sidebar's button and storing
	component_view in priv struct for later use.
	* em-folder-view.c: (emfv_list_done_message_selected):
	* mail-folder-cache.c: (real_flush_updates):
	Indicate changes like for plugins for new mails.


svn path=/trunk/; revision=34374
2007-10-11 14:03:13 +00:00
b32649a94c ** Fixes bug #437579
2007-10-09  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #437579

	* addressbook/conduit/address-conduit.c:
	* addressbook/gui/component/addressbook-config.c:
	* addressbook/gui/contact-editor/e-contact-editor.c:
	* addressbook/gui/widgets/eab-gui-util.c:
	* calendar/conduits/calendar/calendar-conduit.c:
	* calendar/conduits/memo/memo-conduit.c:
	* calendar/conduits/todo/todo-conduit.c:
	* calendar/gui/dialogs/alarm-dialog.c:
	* calendar/gui/dialogs/event-page.c:
	* calendar/gui/dialogs/memo-page.c:
	* calendar/gui/dialogs/task-page.c:
	* calendar/gui/e-day-view-layout.c:
	* calendar/gui/e-day-view-layout.h:
	* calendar/gui/print.c:
	* e-util/e-pilot-map.c:
	* e-util/e-plugin.c:
	* e-util/e-profile-event.c:
	* e-util/e-signature.c:
	* filter/filter-file.c:
	* mail/e-searching-tokenizer.c:
	* mail/em-folder-browser.c:
	* mail/em-format-html.c:
	* mail/em-format-view.c:
	* mail/em-format.c:
	* mail/em-mailer-prefs.c:
	* mail/em-mailer-prefs.h:
	* mail/mail-session.c:
	* mail/mail-session.h:
	* mail/mail-vfolder.c:
	* mail/message-list.c:
	* plugins/bbdb/bbdb.c:
	* plugins/bbdb/gaimbuddies.c:
	* plugins/calendar-http/calendar-http.c:
	* plugins/exchange-operations/exchange-user-dialog.c:
	* plugins/face/face.c:
	* shell/e-shell-window.c:
	* shell/e-shell.c:
	* smime/lib/e-cert-db.c:
	* tools/killev.c:
	* widgets/misc/e-cursors.c:
	* widgets/misc/e-spinner.c:
	* widgets/misc/e-unicode.c:
	* widgets/table/e-table-field-chooser-item.c:
	* widgets/table/e-table-header-item.c:
	* widgets/table/e-table-header-item.h:
	* widgets/table/e-table-header-utils.c:
	* widgets/table/e-table.c:
	* widgets/text/e-text.c:
	Fix various compiler warnings.  Patch from Milan Crha.


svn path=/trunk/; revision=34368
2007-10-10 04:54:36 +00:00
e2e5e8d754 Fix for bug #461195 from Hiroyuki Ikezoe.
Use GObject's marshalers whenever possible.


svn path=/trunk/; revision=34324
2007-09-27 20:08:55 +00:00
d440df54a8 ** Fix for bug #471791 (Move away from asserts to g_ret*)
svn path=/trunk/; revision=34159
2007-09-02 18:56:05 +00:00
8e47917e8c Update FSF address in header comments (#469886). Patch from Tobias
2007-09-02  Matthew Barnes  <mbarnes@redhat.com>

	* Update FSF address in header comments (#469886).
	  Patch from Tobias Mueller.


svn path=/trunk/; revision=34151
2007-09-02 04:19:22 +00:00
0aa26a1e49 Plugged memory leaks.
2007-07-26  Hiroyuki Ikezoe  <poincare@ikezoe.net>

	* e-shell-window-command.c: (view_statusbar_item_toggled_handler),
	(view_sidebar_item_toggled_handler):
	* e-shell-window.c: (setup_status_bar):
	* e-user-creatable-items-handler.c: (setup_toolbar_button): Plugged
	memory leaks.


svn path=/trunk/; revision=33851
2007-07-26 12:35:14 +00:00
8bebb05056 ** Fix for bug #386503 from Matthew Barnes
svn path=/trunk/; revision=33647
2007-06-03 15:07:55 +00:00
012597c56e Fix for bug #259606
svn path=/trunk/; revision=33438
2007-04-20 05:37:15 +00:00
72f0d0c000 Fix "incompatible pointer type" warnings (#360619).
2007-03-29  Matthew Barnes  <mbarnes@redhat.com>

	* calendar/gui/e-day-view.c:
	* calendar/gui/e-week-view.c:
	* calendar/gui/tasks-control.c:
	* composer/e-msg-composer-select-file.c:
	* mail/em-account-editor.c:
	* mail/em-folder-view.c:
	* mail/em-format-html-display.c:
	* mail/em-format-html.c:
	* mail/em-format.h:
	* mail/em-mailer-prefs.c:
	* mail/em-vfolder-rule.c:
	* mail/mail-ops.c:
	* mail/mail-send-recv.c:
	* mail/message-list.c:
	* plugins/bbdb/gaimbuddies.c:
	* plugins/itip-formatter/itip-formatter.c:
	* plugins/save-calendar/save-calendar.c:
	* shell/e-shell-window.c:
	* widgets/misc/e-icon-entry.c:
	* widgets/table/e-table-header-utils.c:
	* widgets/table/e-table-item.c:
	* widgets/table/e-tree-header-item.c:
	* widgets/table/e-tree-table-adapter.c:
	Fix "incompatible pointer type" warnings (#360619).


svn path=/trunk/; revision=33339
2007-03-29 17:29:46 +00:00
cba3097cad ** Fixes bug #419524
2007-03-20  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes bug #419524

	* Include <glib/gi18n.h> instead of <libgnome/gnome-i18n.h>.

	* e-util/e-xml-utils.c (e_xml_get_child_by_name_by_lang_list):
	* mail/em-migrate.c (emm_setup_initial):
	* shell/e-component-registry.c (query_components):
	* shell/e-shell-settings-dialog.c (load_pages):
	* shell/e-shell-window-commands.c (command_quick_reference):
	* tools/killev.c (main):
	Use g_get_language_names() instead of gnome_i18n_get_language_list().

	* e-util/e-util.c: Remove e_gettext().

	* e-util/Makefile.am: Remove e-i18n.h.


svn path=/trunk/; revision=33319
2007-03-20 17:23:58 +00:00
bb64d5dd74 Fixes #360815
svn path=/trunk/; revision=32897
2006-10-16 14:45:04 +00:00
7da5e3a0ca ** Fix for bug #334966
svn path=/trunk/; revision=32869
2006-10-13 17:24:56 +00:00
2b5562aee0 ** Fix for bug #343331
2006-09-28  Srinivasa Ragavan  <sragavan@novell.com>

	** Fix for bug #343331

	* e-shell-window.c: (impl_dispose): Remove the timer which seem to get
	activated after we destroy.

svn path=/trunk/; revision=32817
2006-09-28 08:48:15 +00:00
cacc7b86e1 ** Fixes #351332
2006-09-18  Matthew Barnes  <mbarnes@redhat.com>

	** Fixes #351332

	* e-shell-window.c: Fix implicit function declarations.

svn path=/trunk/; revision=32792
2006-09-18 17:26:32 +00:00
6c0397b958 Make sure default window sizes are positive numbers. Fixes bug 349967.
2006-08-23  Daniel Gryniewicz  <dang@gentoo.org>

	* e-shell-window.c:
	Make sure default window sizes are positive numbers.
	Fixes bug 349967. Committed by Andre Klapper.

svn path=/trunk/; revision=32640
2006-08-23 09:02:48 +00:00
c6612c8d03 Fix warnings at build-time, and clean up the connections to the D-Bus on
2006-07-27  Bastien Nocera  <hadess@hadess.net>

	* e-shell-nm-glib.c: (e_shell_glib_network_monitor),
	(e_shell_nm_glib_initialise), (e_shell_nm_glib_dispose):
	* e-shell-nm.c: (e_shell_dbus_dispose):
	* e-shell-window.c: (impl_dispose): Fix warnings at build-time, and
	clean up the connections to the D-Bus on exit (Closes: #332387)

svn path=/trunk/; revision=32425
2006-07-27 09:42:18 +00:00
e6ecbf0d50 Fix for #346613. Fix the problem pointed out by Johnny
2006-07-07  Li Yuan  <li.yuan@sun.com>

    * e-shell-window.c: (setup_widgets):
    Fix for #346613.
    Fix the problem pointed out by Johnny <jjohnny@novell.com>.
    When maximize Evolution, close and start Evolution sometimes,
    the sidebar grows towards right. Set the view_notebook can be expanded
    when the paned widget is resized.

svn path=/trunk/; revision=32246
2006-07-07 03:19:43 +00:00
69108085da Fix for #346613. Make the view_notebook cannot be resized shorter than its
2006-07-05  Li Yuan  <li.yuan@sun.com>

    * e-shell-window.c: (setup_widgets):
    Fix for #346613.
    Make the view_notebook cannot be resized shorter than its need.

svn path=/trunk/; revision=32237
2006-07-06 02:56:36 +00:00
3b5da8e937 reviewed by: Srinivasa Ragavan
2006-04-28  Sven Herzberg  <herzi@gnome-de.org>

        reviewed by: Srinivasa Ragavan

	* shell/apps_evolution_shell.schemas.in.in: added boolean key for the
	maximized state of the window
	* shell/e-shell-window.c: added window state saving and updated window
	size saving to work as expected (fixes bug 243962)

svn path=/trunk/; revision=31926
2006-04-28 11:19:51 +00:00
4e259838f0 Commiting patch for bug #337258.
svn path=/trunk/; revision=31873
2006-04-24 05:03:49 +00:00
1e5de972e6 Remove unused code and fix format specifiers in some cases.
2006-01-29  Kjartan Maraas  <kmaraas@gnome.org>

	* e-corba-config-page.c: (e_corba_config_page_class_init):
	* e-shell-folder-title-bar.c: (e_shell_folder_title_bar_construct):
	* e-shell-window.c: (init_view):
	* e-shell.c: (detect_version), (e_shell_construct), (e_shell_new),
	(e_shell_attempt_upgrade), (e_shell_create_window),
	(e_shell_save_settings):
	* main.c: (idle_cb):
	Remove unused code and fix format specifiers in some cases.

svn path=/trunk/; revision=31367
2006-01-30 11:49:53 +00:00
3fc81ed934 ** Fixes Bug #257654
2006-01-26  Rajeev ramanathan <rajeevramanathan_2004@yahoo.co.in>

	** Fixes Bug #257654

	* e-shell-window.c:
	* e-shell-window-commands.c: Added code to show/hide sidebar.

svn path=/trunk/; revision=31345
2006-01-30 05:17:24 +00:00