2003-03-12 Not Zed <NotZed@Ximian.com>
* camel-object.c (remove_bag): removed, it was double-freeing the
key.
(save_object): Just save the object in an array.
(camel_object_bag_destroy): first save the object bag's objects in
a list, then remove them one at a time from the bag since we can't
remove hash table entries while we're in a foreach (PITA glib
shit). For #39486.
(camel_object_bag_*): killed some warnings.
svn path=/trunk/; revision=20258
* e-shell-startup-wizard.c (start_wizard): If the wizard factory
returns NULL, we'll get a NIL wizard but no exception. Deal with
that case. (ie, try the next wizard).
(finish_func): Simplify for e-timezone-dialog changes.
(prepare_timezone_page): If there is already a timezone set in
gconf, set the map to point to it. (For connector autoconfig.)
svn path=/trunk/; revision=20257
* e-timezone-dialog/e-timezone-dialog.c: Various cleanups.
(e_timezone_dialog_get_timezone): Return an icaltimezone.
(e_timezone_dialog_set_timezone): Take an icaltimezone
(e_timezone_dialog_construct): Set a minimum size on the scrolled
window
svn path=/trunk/; revision=20255
2003-03-10 Rodney Dawes <dobey@ximian.com>
* e-calendar.c: Use GtkArrow instead of pixmaps
* e-combo-button.c: Use GtkArrow instead of pixmaps
* e-filter-bar.c: gtk_window_set_policy () is deprecated
* e-url-entry.c: Load the icon in a pixbuf instead of GdkPixmap
svn path=/trunk/; revision=20254
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_add_clicked): Use
gtk_window_set_transient_for() on the druid with the settings
dialog as the parent window.
svn path=/trunk/; revision=20253
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* e-msg-composer-attachment-bar.c: Use GnomeIconList instead of
EIconList so we don't have to maintain an exact copy/paste of
GnomeIconList ourselves. I don't udnerstand why we ever did.
* e-icon-list.[c,h]: Removed.
svn path=/trunk/; revision=20251
2003-03-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_able_toggled): New callback function to
handle the checkbox getting toggled.
(mail_accounts_treeview_new): Save the toggle renderer so we can
later connect to it's toggled signal.
(mail_accounts_tab_construct): Connect to the toggle-cell's
toggled signal. Fixes bug #39325.
svn path=/trunk/; revision=20245
2003-03-09 Rodrigo Moya <rodrigo@ximian.com>
* gui/alarm-notify/alarm-notify.c (alarm_notify_add_calendar): if we
already have the client loaded, don't remove it, just increment its
reference count.
* gui/alarm-notify/alarm-queue.c (remove_queued_alarm): added new
argument to specify whether we want the component's structure removed
if no more alarms exist, and only free the structure if TRUE.
(remove_alarms): added same new argument and pass it over to
remove_queued_alarm.
(remove_comp, obj_updated_cb): passed new argument to remove_alarms.
(procedure_notification): passed new argument to remove_queued_alarm.
(obj_removed_cb): set all freed pointers to NULL.
(notify_dialog_cb): only remove the alarm if the pointers are not NULL.
svn path=/trunk/; revision=20232
2003-03-11 Not Zed <NotZed@Ximian.com>
* mail-vfolder.c (vfolder_editor_response): Fix the response code,
because some bastard changed the filter/* code and didn't fix the
callers. Partial fix for #39165.
svn path=/trunk/; revision=20231
2003-03-11 Not Zed <NotZed@Ximian.com>
* rule-context.c (revert): go to the proper level of child node
before looking for rule sets, fix for #39165 to make 'cancel' work.
svn path=/trunk/; revision=20230
2003-03-11 Not Zed <NotZed@Ximian.com>
* gui/widgets/e-addressbook-util.c (e_addressbook_send_card_list):
re-enable in build, include e-destination.h. For #39256.
svn path=/trunk/; revision=20229
2003-03-10 Not Zed <NotZed@Ximian.com>
* component-factory.c
(factory): Removed the debug printf. Added a case for the
composer. Part of fixing #39256.
svn path=/trunk/; revision=20228
2003-03-10 Not Zed <NotZed@Ximian.com>
* Makefile.am (libevolution_mail_la_SOURCES): removed main.c from
the build.
* component-factory.c (component_factory_init): Remove, not used
anymore, causes linking problems some places.
(factory): Removed the debug printf.
svn path=/trunk/; revision=20226
2003-03-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-url-scanner.c (camel_url_addrspec_end): Doh! If inptr ==
pos + 1, then return FALSE (before it was checking for inptr ==
pos, but it will never be pos).
svn path=/trunk/; revision=20225
2003-03-07 Chris Toshok <toshok@ximian.com>
* gal/e-text/e-text.c (e_text_draw): fix drawing bugs, and disable
the stupid looking focus rect, since I can't find a theme that
uses them.
(e_text_event): force redraw in the focus-out case if the cursor
is shown (so we can erase it), and also trick ourselves into
drawing it immediately (by setting it to FALSE) in the focus-in
case.
svn path=/trunk/; revision=20223
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
All this snot just to fix bug #38925 and an attempt to fix bug
#38926 (but it seems no matter what I do, I can't work around the
bonoboness/modality/whatever of the shell's preferences dialog).
* mail-account-gui.c (sig_add_new_signature): Get the toplevel
parent GtkWindow and pass that along to
mail_composer_prefs_new_signature() so that window layering can be
done correctly.
* mail-composer-prefs.c (mail_composer_prefs_new_signature):
Simplify. We don't want to add the signature to the list until
after they have saved.
(sig_edit_cb): Pass FALSE as the is_new argument to
mail_signature_editor().
(sig_event_client): Listen for signatures being added.
(mail_composer_prefs_new_signature): Now takes a GtkWindow arg as
the first arg rather than a MailComposerPrefs arg since we don't
really need it to be a MailComposerPrefs object. We'd rather use
the first arg as the parent GtkWindow so that we can set
transience for the editor window.
* mail-signature-editor.c (mail_signature_editor): Now takes a
'parent' argument (so we can set transient_for()) and a 'is_new'
argument specifying whether the editor is editing a new signature
or not. If it is, when the user saves, it will be added to the
signature list. otherwise it won't.
(sig_name_changed): Only use the mail_config_signature_set_name()
interface if it is *not* a new signature.
(menu_file_save_cb): If is_new, then save the signature to the
config - otherwise do what we did before and set the modifications
to it and emit the CHANGED event.
* mail-config.c (mail_config_signature_new): Renamed from
mail_config_signature_add(). We no longer immediately add the
signature to the list of saved signatures.
(mail_config_signature_add): New function which adds the signature
and emits the SIG_ADDED event.
svn path=/trunk/; revision=20221
* Locations (name): Add some escapes to the newly added locations
so they get split properly.
* e-summary-weather.c (e_summary_weather_init_locations): Fetch
the Locations file from the right path. If you find an invalid
entry in the Locations file, complain with an informative
g_warning() instead of just returning FALSE.
(e_summary_weather_fill_etable): Do the same thing here.
svn path=/trunk/; revision=20220
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (on_url_requested): If the part url is a text
part, use mail_format_data_wrapper_write_to_stream(). This should
fix bug #39204.
* mail-format.c (mail_format_data_wrapper_write_to_stream): Make public.
svn path=/trunk/; revision=20219
2003-03-07 Rodrigo Moya <rodrigo@ximian.com>
* gui/alarm-notify/save.c (get_calendars_to_load): create the array
to be returned only once.
svn path=/trunk/; revision=20217
2003-03-07 Not Zed <NotZed@Ximian.com>
* camel-vee-folder.c (vee_search_by_expression): handle a null
return from search_by_expression, for bug #33786.
svn path=/trunk/; revision=20215
2003-03-07 Not Zed <NotZed@Ximian.com>
** reverted the following patch from ettore, this is a gnome 2.2
api change, and shouldn't be used yet.
* e-shell.c (impl_finalize): Use
bonobo_activation_unregister_active_server() instead of
bonobo_activatino_active_server_unregister().
(e_shell_construct): Use
bonobo_activation_register_active_server() instead of
bonobo_activation_active_server_register().
svn path=/trunk/; revision=20214
2003-03-06 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-utils.c (imap_next_word):
s/g_strncasecmp/strncasecmp/g
* camel-iconv.c: Updated to be an exact copy of e-iconv (except
names changed). We don't use this yet, but we may in the future.
* camel-url.c (camel_url_new_with_base): Here too.
* camel-sasl-kerberos4.c (krb4_challenge): Use camel_strdown()
here instead of g_strdown() since the latter has been deprecated.
* providers/imap/camel-imap-utils.c (imap_parse_body): Use
camel_strdown() since g_ascii_strdown() does not do what we
thought.
* providers/imap/camel-imap-store.c:
s/strstrcase/camel_strstrcase/g
* providers/imap/camel-imap-folder.c (do_append):
s/strstrcase/camel_strstrcase/
(handle_copyuid): Same.
* string-utils.c (camel_strdown): New function because the
g_ascii_strdown interface sucks.
(camel_strstrcase): Renamed from strstrcase.
svn path=/trunk/; revision=20213
2003-03-06 Jeffrey Stedfast <fejj@ximian.com>
* gal/util/e-iconv.c: Alias gb-2312 to gb2312 also (since iconv
doesn't have "gb-2312"). I wonder if we should capitalise GB2312?
At least my iconv lists it in all caps (although I have the
benefit of having gnu iconv which is case insensitive so I dunno).
(e_strdown, e_strup): New functions to replace
g_ascii_str[down,up]: because the glib versions return a newly
allocated string buf and that is not what we want.
(e_iconv_charset_name): Use the new e_strdown.
(e_iconv_open): Save errno.
svn path=/trunk/; revision=20212
New function to toggle the "open other user's folder" menu item
sensitivity on or off depending on whether there are any storages
that actually support that.
(storage_set_removed_storage_callback): New callback for the
EStorageSet's "removed_storage" signal; it updates the sensitivity
if necessary.
(storage_set_new_storage_callback): Likewise, new callback for the
EStorageSet's "new_storage" signal.
(e_shell_view_construct): Connect these two signal callbacks here.
Also, call update_other_users_folder_items_sensitivity() to set up
the initial sensitivity of the menu item.
(update_for_current_uri): Add a missing EStorageSetView cast here.
svn path=/trunk/; revision=20209
sensitivity of the OK button according to whether the folder name
entry is empty or not.
(show_dialog): Connect here. Pop up an error message if no user
is selected.
svn path=/trunk/; revision=20208
bonobo_activation_unregister_active_server() instead of
bonobo_activatino_active_server_unregister().
(e_shell_construct): Use
bonobo_activation_register_active_server() instead of
bonobo_activation_active_server_register().
svn path=/trunk/; revision=20198