Commit Graph

1704 Commits

Author SHA1 Message Date
8b67c6478d fix UMR.
2003-03-23  Chris Toshok  <toshok@ximian.com>

	* e-table.c (do_drag_motion): fix UMR.

svn path=/trunk/; revision=20469
2003-03-23 09:57:10 +00:00
8794fa517a Use glib macro G_GNUC_FUNCTION instead of __FUNCTION__. Thank u, Ettore.
2003-03-19  Sanshao Jiang  <alex.jiang@sun.com>

	* gal-view-collection.c (gal_view_collection_append_with_title):
	(gal_view_collection_set_nth_view): Use glib macro G_GNUC_FUNCTION
	instead of __FUNCTION__. Thank u, Ettore.

	* gal-view-instance.c (gal_view_instance_set_current_view_id): same
	(add_popup_radio_item): Fix to be compilable on other compilers,
	using gcc extension independent codes.(bug#39176)
	(add_popup_menu_item): same

svn path=/trunk/; revision=20455
2003-03-21 17:32:04 +00:00
17057abe19 [ fixes bug #39856 ] request a full redraw when we're done dragging
2003-03-21  Chris Toshok  <toshok@ximian.com>

	[ fixes bug #39856 ]
	* gal/widgets/e-reflow.c (e_reflow_update): request a full redraw
	when we're done dragging columns.

svn path=/trunk/; revision=20450
2003-03-21 10:21:45 +00:00
9e5f92c8e4 Updated to use GtkDialog instead of GnomeDialog. Also fixed bug #39550
2003-03-19  Jeffrey Stedfast  <fejj@ximian.com>

	* e-filter-bar.c: Updated to use GtkDialog instead of
	GnomeDialog. Also fixed bug #39550 while I was at it.

svn path=/trunk/; revision=20375
2003-03-19 23:42:12 +00:00
529a87dfe5 add underline_column field.
2003-03-18  Chris Toshok  <toshok@ximian.com>

	* e-cell-text.h: add underline_column field.

	* e-cell-date.c: add underline_column to the comment.

	* e-cell-size.c: add underline_column to the comment.

	* e-cell-text.c (build_layout): handle underline column.
	(ect_show_tooltip): same.
	(ect_set_property): same.
	(ect_get_property): same.
	(e_cell_text_class_init): same.
	(e_cell_text_init): same.
	(e_cell_text_new): add underline_column to the comment.

svn path=/trunk/; revision=20347
2003-03-18 20:49:59 +00:00
bc9697c7d2 add cursor_idle_id.
2003-03-18  Chris Toshok  <toshok@ximian.com>

	* e-table-item.h (ETableItem): add cursor_idle_id.

	* e-table-item.c (eti_idle_maybe_show_cursor): save off the
	cursor_idle_id.
	(eti_idle_show_cursor_cb): reset the cursor_idle_id to 0.
	(eti_dispose): remove the cursor_idle_id.  Fixes a crash in the
	evolution select-names dialog.

svn path=/trunk/; revision=20346
2003-03-18 20:49:31 +00:00
b57393ab7c add cursor_idle_id.
2003-03-18  Chris Toshok  <toshok@ximian.com>

	* e-table-item.h (ETableItem): add cursor_idle_id.

	* e-table-item.c (eti_idle_maybe_show_cursor): save off the
	cursor_idle_id.
	(eti_idle_show_cursor_cb): reset the cursor_idle_id to 0.
	(eti_dispose): remove the cursor_idle_id.  Fixes a crash in the
	evolution select-names dialog.

svn path=/trunk/; revision=20344
2003-03-18 20:29:49 +00:00
ede2b62efc mimic Gtk's sort arrows (ethi_start_drag): mimic Gtk's sort arrows
2003-03-18  Mike Kestner  <mkestner@ximian.com>

	* e-table-header-item.c (ethi_draw): mimic Gtk's sort arrows
	(ethi_start_drag): mimic Gtk's sort arrows

svn path=/trunk/; revision=20340
2003-03-18 17:33:02 +00:00
aa46ddf806 Swap OK/Cancel buttons to comply with the HIG.
svn path=/trunk/; revision=20339
2003-03-18 17:16:22 +00:00
251ffc55ad null start_path (etsm_invert_selection): null start_path
2003-03-18  Mike Kestner  <mkestner@ximian.com>

	* e-tree-selection-model.c (select_single_path): null start_path
	(etsm_invert_selection): null start_path
	(etsm_toggle_single_row): null start_path
	(etsm_real_move_selection_end): start at start_path, not cursor
	(etsm_set_selection_end): set start_path
	(e_tree_selection_model_init): null start_path

svn path=/trunk/; revision=20337
2003-03-18 16:38:30 +00:00
8bc5772286 Instead of using gtk_widget_unparent(), remove the widget from the
2003-03-17  Hans Petter Jansson  <hpj@ximian.com>

	* gal-define-views-dialog.c (gal_define_views_dialog_init): Instead
	of using gtk_widget_unparent(), remove the widget from the container
	using gtk_container_remove(). This fixes crashers where the dialog
	is being used.

	* gal-view-instance-save-as-dialog.c
	(gal_view_instance_save_as_dialog_init): Ditto.

	* gal-view-new-dialog.c (gal_view_new_dialog_init): Ditto.

svn path=/trunk/; revision=20324
2003-03-17 22:31:22 +00:00
3f486d99c6 Don't crash if there's no timezone set initially. #39783
* e-timezone-dialog/e-timezone-dialog.c (on_map_motion): Don't
	crash if there's no timezone set initially. #39783

svn path=/trunk/; revision=20313
2003-03-17 19:47:34 +00:00
cb382f6c30 save and restore expanded state so parents don't collapse when children
2003-03-14  Mike Kestner  <mkestner@ximian.com>

	* e-tree-table-adapter.c (update_node): save and restore expanded
	state so parents don't collapse when children are added to them.
	(e_tree_table_adapter_node_is_expanded): guard against null nodes.

svn path=/trunk/; revision=20303
2003-03-14 23:38:34 +00:00
0b82cc7a34 use access() like camel
2003-03-14  Mike Kestner  <mkestner@ximian.com>

	* gal/util/e-util.c (e_mkdir_hier): use access() like camel

2003-03-14  Mike Kestner  <mkestner@ximian.com>

	* gal-view-collection.c (gal_view_collection_load): check failure
	on e_create_directory call and warn.
	* gal-view-instance.c (save_current_view): check for failure and
	warn.

svn path=/trunk/; revision=20291
2003-03-14 17:19:25 +00:00
453ffef3e3 kill an unused variable
svn path=/trunk/; revision=20276
2003-03-13 18:26:09 +00:00
bbde1e136a Various cleanups. (e_timezone_dialog_get_timezone): Return an
* e-timezone-dialog/e-timezone-dialog.c: Various cleanups.
        (e_timezone_dialog_get_timezone): Return an icaltimezone.
        (e_timezone_dialog_set_timezone): Take an icaltimezone
        (e_timezone_dialog_construct): Set a minimum size on the scrolled
        window

svn path=/trunk/; revision=20255
2003-03-11 22:23:07 +00:00
c6a1e23298 Use GtkArrow instead of pixmaps Use GtkArrow instead of pixmaps
2003-03-10  Rodney Dawes  <dobey@ximian.com>

	* e-calendar.c: Use GtkArrow instead of pixmaps
	* e-combo-button.c: Use GtkArrow instead of pixmaps
	* e-filter-bar.c: gtk_window_set_policy () is deprecated
	* e-url-entry.c: Load the icon in a pixbuf instead of GdkPixmap

svn path=/trunk/; revision=20254
2003-03-11 21:22:14 +00:00
9b5ba0524e Added prototype for show_pango_rectangle()
2003-03-10  Jeffrey Stedfast  <fejj@ximian.com>

	* gal/e-text/e-text.c: Added prototype for show_pango_rectangle()

svn path=/trunk/; revision=20233
2003-03-10 15:27:21 +00:00
c8a10fa6da fix drawing bugs, and disable the stupid looking focus rect, since I can't
2003-03-07  Chris Toshok  <toshok@ximian.com>

	* gal/e-text/e-text.c (e_text_draw): fix drawing bugs, and disable
	the stupid looking focus rect, since I can't find a theme that
	uses them.
	(e_text_event): force redraw in the focus-out case if the cursor
	is shown (so we can erase it), and also trick ourselves into
	drawing it immediately (by setting it to FALSE) in the focus-in
	case.

svn path=/trunk/; revision=20223
2003-03-07 22:57:40 +00:00
34b5562c9f (destroy): Removed unused variable.
svn path=/trunk/; revision=20201
2003-03-06 17:24:48 +00:00
3de88468be Use G_GNUC_FUNCTION instead of __FUNCTION__.
* menus/gal-view-menus.c (gal_view_menus_unmerge): Use
G_GNUC_FUNCTION instead of __FUNCTION__.

* e-dropdown-button.c (menu_deactivate_cb): Removed debugging
spew.

svn path=/trunk/; revision=20200
2003-03-06 17:24:22 +00:00
5c97b1f792 fix a couple ==TRUE uses pointed out by Morten Welinder <terra@diku.dk>.
2003-03-05  Mike Kestner  <mkestner@ximian.com>

	* e-tree-model.c : fix a couple ==TRUE uses pointed out by
	Morten Welinder <terra@diku.dk>.

svn path=/trunk/; revision=20169
2003-03-05 15:21:09 +00:00
63aef14c02 i18n fix
2003-03-04  Dmitry Mastrukov  <dmitry@taurussoft.org>

	* gal/widgets/e-unicode.c : i18n fix

2003-03-04  Dmitry Mastrukov  <dmitry@taurussoft.org>

	* e-cell-date.c (ecd_get_text): i18n fix
	* e-table.c (et_real_construct): i18n fix
	* e-table-config.c (create_global_store): i18n fix
	* e-table-utils.c (et_col_spec_to_col): i18n fix

2003-03-04  Mike Kestner  <mkestner@ximian.com>

	* e-tree-selection-model.c : some cursor fixes

svn path=/trunk/; revision=20156
2003-03-04 22:09:44 +00:00
e366ce662a rewrite to store selected paths in a hashtable instead of a tree. lose the
2003-03-04  Mike Kestner  <mkestner@ximian.com>

	* e-tree-selection-model.c : rewrite to store selected paths in a
	hashtable instead of a tree.
	* e-tree-table-adapter.c : lose the hacky orig_position api since
	etsm doesn't need it anymore.

svn path=/trunk/; revision=20136
2003-03-04 06:53:46 +00:00
2ee1eb9078 Add style_set to update list properly (et_canvas_realize): Remove this as
2003-02-26  Rodney Dawes  <dobey@ximian.com>

	* e-tree.c (et_canvas_style_set): Add style_set to update list properly
	(et_canvas_realize): Remove this as it's no longer needed with support
	for the style_set implementation

svn path=/trunk/; revision=20108
2003-02-28 18:43:30 +00:00
dd2a35e673 remove alloc-based transform (et_drag_data_received): ditto
2003-02-28  Mike Kestner  <mkestner@ximian.com>

	* e-table.c (et_drag_motion): remove alloc-based transform
	(et_drag_data_received): ditto
	(et_drag_drop): ditto
	(do_drag_motion): ditto

svn path=/trunk/; revision=20100
2003-02-28 17:09:42 +00:00
f37fdf7f9b remove alloc-based transform (et_drag_data_received): ditto
2003-02-28  Mike Kestner  <mkestner@ximian.com>

	* e-tree.c (et_drag_motion): remove alloc-based transform
	(et_drag_data_received): ditto
	(et_drag_drop): ditto
	(et_hover_timeout): ditto
	(do_drag_motion): ditto

svn path=/trunk/; revision=20099
2003-02-28 17:01:34 +00:00
c003d7dec8 init column_count to column_start + 1. (item_removed): clean up the
2003-02-27  Chris Toshok  <toshok@ximian.com>

	* gal/widgets/e-reflow.c (reflow_columns): init column_count to
	column_start + 1.
	(item_removed): clean up the setting of
	reflow->reflow_from_column.
	(items_inserted): same.

svn path=/trunk/; revision=20097
2003-02-28 01:32:27 +00:00
265fea16e7 guard this so we don't try to free priv multiple times.
2003-02-27  Chris Toshok  <toshok@ximian.com>

	* e-url-entry.c (destroy): guard this so we don't try to free priv
	multiple times.

svn path=/trunk/; revision=20089
2003-02-27 23:02:46 +00:00
1de4b21c42 use gdk_event_copy and gdk_event_free to dup the event.
2003-02-27  Mike Kestner  <mkestner@ximian.com>

	* gal/widgets/e-canvas.c (emit_event): use gdk_event_copy
	and gdk_event_free to dup the event.

svn path=/trunk/; revision=20088
2003-02-27 22:24:38 +00:00
da0afe53d2 remove the grab_cancelled_check_id if it's still active.
2003-02-26  Chris Toshok  <toshok@ximian.com>

	* gal/widgets/e-canvas.c (e_canvas_dispose): remove the
	grab_cancelled_check_id if it's still active.

svn path=/trunk/; revision=20083
2003-02-27 04:13:06 +00:00
176204b94f Use g_signal_handlers_disconnect_by_func since
* e-map.c (e_map_destroy): Use
	g_signal_handlers_disconnect_by_func since
	gtk_signal_disconnect_by_data doesn't seem to work right.
	(e_map_set_scroll_adjustments): Likewise.

svn path=/trunk/; revision=20052
2003-02-25 15:39:47 +00:00
f446063c57 Same as below.
2003-02-25  Jeffrey Stedfast  <fejj@ximian.com>

	* e-dateedit.c (on_date_popup_date_selected): Same as below.

	* e-cell-date-edit.c (e_cell_date_edit_on_ok_clicked): Also
	updated to use the new GDate API from glib 2.0

	* test-calendar.c (on_selection_changed): Fixed to use glib 2.0's
	GDate API.

	* e-calendar-item.c (e_calendar_item_get_week_number): Port to
	glib 2.0's GDate API.
	(e_calendar_item_set_selection): Same.

	* e-search-bar.c (append_xml_menu_item): Use
	g_string_append_printf instead of g_string_sprintfa since the
	latter is now deprecated.
	(setup_bonobo_menus): Same.

	* e-filter-bar.c (do_advanced): Use gtk_window_set_resizable()

	* e-charset-picker.c: Fixes to make it build cleanly with
	-DG_DISABLE_DEPRECATED
	(add_charset): Escape _'s so we don't get underline weirdness due
	to GtkLabel thinking the _ means to underline the next char.
	(e_charset_picker_bonobo_ui_populate): Same here.

svn path=/trunk/; revision=20048
2003-02-25 07:03:46 +00:00
b6fadac1f1 Don't unref the GtkInvisible - instead, destroy it.
2003-02-24  Hans Petter Jansson  <hpj@ximian.com>

	* gal/e-text/e-text.c (e_text_dispose): Don't unref the GtkInvisible -
	instead, destroy it.

svn path=/trunk/; revision=20040
2003-02-24 19:07:09 +00:00
4508cf787c fix overzealous g_asserts to avoid crashes when eti->rows is already
2003-02-20  Mike Kestner  <mkestner@ximian.com>

	* e-table-item.c (eti_table_model_rows_deleted): fix overzealous
	g_asserts to avoid crashes when eti->rows is already updated.

svn path=/trunk/; revision=19982
2003-02-20 21:52:15 +00:00
4a0d26411c kill (etsm_find_node_unless_equals): use new etta_orig_position
2003-02-20  Mike Kestner  <mkestner@ximian.com>

	* e-tree-selection-model.c (etsm_orig_position): kill
	(etsm_find_node_unless_equals): use new etta_orig_position
	(update_parents): use new etta_orig_position
	(etsm_recurse_is_path_selected): use new etta_orig_position
	* e-tree-table-adapter.c (e_tree_table_adapter_orig_position): new
	(resort_node): populate orig_pos, fix sorting_map bound bug
	(create_gnode): initialize orig_pos
	(delete_node): call resort_node so orig_pos gets updated
	(insert_node): always call resort_node let it decide whether to sort

svn path=/trunk/; revision=19975
2003-02-20 19:15:14 +00:00
986f2ace07 Make libemiscwidgets, libefilterbar, and libetimezonedialog dynamic
libraries, so they can be portably linked into the (shared library)
components. (Part 1 of N.)

svn path=/trunk/; revision=19971
2003-02-20 16:48:43 +00:00
ebb7a2c191 set remap_needed
2003-02-18  Mike Kestner  <mkestner@ximian.com>

	* e-tree-table-adapter.c (move_map_elements): set remap_needed

svn path=/trunk/; revision=19930
2003-02-18 17:32:47 +00:00
0def5bcb84 make sure the row >= 0 before calling value_at to calc "strikeout".
2003-02-17  Chris Toshok  <toshok@ximian.com>

	* e-cell-text.c (build_layout): make sure the row >= 0 before
	calling value_at to calc "strikeout".

svn path=/trunk/; revision=19926
2003-02-17 21:47:52 +00:00
8be77ed0d8 make things compile on an alpha. passing NULL to a var_arg not portable.
2003-02-17  Jody Goldberg <jody@gnome.org>

	* gal/e-table/e-table-group.c (e_table_group_construct) : make things
	  compile on an alpha.  passing NULL to a var_arg not portable.
	  This seems like a better approach.

svn path=/trunk/; revision=19924
2003-02-17 19:23:16 +00:00
6f8b2d31d9 return after the e_table_model_no_change call.
2003-02-17  Chris Toshok  <toshok@ximian.com>

	* e-tree-table-adapter.c (etta_proxy_node_data_changed): return
	after the e_table_model_no_change call.
	(etta_proxy_node_col_changed): same.

svn path=/trunk/; revision=19923
2003-02-17 09:17:19 +00:00
0f7100a65c make this actually work: destroy the canvas item, memmove stuff around,
2003-02-16  Chris Toshok  <toshok@ximian.com>

	* gal/widgets/e-reflow.c (item_removed): make this actually work:
	destroy the canvas item, memmove stuff around, change
	reflow->count, etc, etc.

svn path=/trunk/; revision=19918
2003-02-17 02:58:09 +00:00
baa50a5c89 enable this function to reflow the view from a particular column onward.
2003-02-16  Chris Toshok  <toshok@ximian.com>

	* gal/widgets/e-reflow.c (reflow_columns): enable this function to
	reflow the view from a particular column onward.  This is useful
	if you have a huge model and the only changes are happening at the
	end (as is normally the case if you're appending to a large
	model.)
	(item_changed): calculate the height of the changed item here, so
	we aren't doing it as we reflow the model.  For now, reflow the
	entire model.  Further optimization can be done here.
	(item_removed): new function.  remove the item and reflow from the
	column that contained it.
	(items_inserted): calculate the heights of the new items, and
	calculate the lowest numbered column containing one of the
	inserted items.  reflow from there.
	(model_changed): calculate the heights of everything here.
	(comparison_changed): new function, clear the sorter and reflow.
	(disconnect_model): disconnect comparison_changed and
	model_item_removed.
	(connect_model): connect comparison_changed and
	model_item_removed.
	(adjustment_changed): use queue_incarnate here, instead of forcing
	the reflow model to incarnate as we scroll.  Not sure if this is
	actually the right solution, but it does make the scrollbar more
	responsive at the cost of redraw speed.

	* gal/widgets/e-reflow.h (struct _EReflow): add slots for the new
	signal ids, as well as "reflow_from_column".

	* gal/widgets/e-reflow-model.c (e_reflow_model_class_init): create
	the comparison_changed and model_item_removed signals.
	(e_reflow_model_comparison_changed): new function, emit the
	comparison_changed signal.
	(e_reflow_model_item_removed): new function, emit the
	model_item_removed signal.

	* gal/widgets/e-reflow-model.h: add comparison_changed and
	model_item_removed signals.

svn path=/trunk/; revision=19917
2003-02-17 02:38:15 +00:00
afac6edb53 guard for null paths if save_id lookup fails.
2003-02-13  Mike Kestner  <mkestner@ximian.com>

	* e-tree-table-adapter.c (*_load_expanded_state): guard for
	null paths if save_id lookup fails.

svn path=/trunk/; revision=19904
2003-02-13 19:16:56 +00:00
b88c27e9b2 don't transform based on allocation position. Position isn't absolute now.
2003-02-13  Mike Kestner  <mkestner@ximian.com>

	* e-table-header-item.c (ethi_drag_motion): don't transform
	based on allocation position. Position isn't absolute now.

svn path=/trunk/; revision=19902
2003-02-13 18:02:52 +00:00
9901ae486e kill a double unref on the pango_layout.
2003-02-13  Mike Kestner  <mkestner@ximian.com>

	* e-table-header-utils.c (e_table_header_draw_button): kill
	a double unref on the pango_layout.

svn path=/trunk/; revision=19900
2003-02-13 16:07:38 +00:00
a371f7b3fc Request a reflow on realization, so size and placement will be correct
2003-02-12  Hans Petter Jansson  <hpj@ximian.com>

	* e-table-click-to-add.c (etcta_realize): Request a reflow on
	realization, so size and placement will be correct initially.

svn path=/trunk/; revision=19899
2003-02-12 23:36:21 +00:00
1ebf9b6fd1 handle reverse searches (find_prev_in_range): reverse search impl
2003-02-12  Mike Kestner  <mkestner@ximian.com>

	* e-tree.c (e_tree_find_next): handle reverse searches
	(find_prev_in_range): reverse search impl
	(et_real_construct): kill warnings

svn path=/trunk/; revision=19897
2003-02-12 20:26:15 +00:00
ad82875fbf work around broken models that insert children before parents. bad models.
2003-02-12  Mike Kestner  <mkestner@ximian.com>

	* e-tree-table-adapter.c (insert_node): work around broken models
	that insert children before parents.  bad models.
	(e_tree_table_adapter_load_expanded_state): don't update_node
	(e_tree_table_adapter_node_set_expanded): recursively expand
	parent if the node is not visible yet.
	(e_tree_table_adapter_set_sort_info): don't resort empty trees

svn path=/trunk/; revision=19894
2003-02-12 18:02:32 +00:00
33841eb730 rewrite to use etta (find_next_in_range): helper func to search a range of
2003-02-10  Mike Kestner  <mkestner@ximian.com>

	* e-tree.c (e_tree_find_next): rewrite to use etta
	(find_next_in_range): helper func to search a range of rows
	(find_next_callback): kill

svn path=/trunk/; revision=19875
2003-02-10 18:04:25 +00:00