2003-03-21 Jeffrey Stedfast <fejj@ximian.com>
* mail-format.c (mail_format_data_wrapper_write_to_stream):
Default to the charset provied in the MimePart's Content-Type over
that of the user's mailer charset. Fixes bug #39204.
svn path=/trunk/; revision=20462
2003-03-21 Larry Ewing <lewing@ximian.com>
* mail-display.c (pixbuf_gen_idle): remember to disconnect the
destroy handler if whenever the loader is shut down.
svn path=/trunk/; revision=20449
2003-03-20 Jeffrey Stedfast <fejj@ximian.com>
* component-factory.c (owner_set_cb): Change the message_destroy
callback to just gtk_widget_destroy. No need to have a callback
simply to call this function.
(warning_response): Removed (see above).
svn path=/trunk/; revision=20447
2003-03-20 Jeffrey Stedfast <fejj@ximian.com>
* mail-composer-prefs.c (sig_add_script_response): Don't forget to
add the signature to the signature list if it is a valid script.
svn path=/trunk/; revision=20444
2003-03-20 Jeffrey Stedfast <fejj@ximian.com>
* mail-config.c (mail_config_signature_unregister_client): Make
sure we can find the registered handler before trying to remove it
from the list.
svn path=/trunk/; revision=20443
2003-03-20 Jeffrey Stedfast <fejj@ximian.com>
* mail-session.c (do_user_message): Make the 5th argument to
gtk_message_dialog_new() "%s" and move the m->prompt to arg 6 so
that we are safe if the prompt string contains any %'s. Also
connect to the response signal for the user_msg dialog and set the
callback to gtk_widget_destroy so that the user can actually close
the dialog. We also need to g_object_weak_ref() the dialog so that
we can set the global message_dialog pointer back to NULL when it
gets destroyed. Fixes bug #40043.
svn path=/trunk/; revision=20435
* mail-ops.c (build_from): Remove this since there's a function in
CamelMimeMessage to do it now.
(save_messages_save): Use camel_mime_message_build_mbox_from.
svn path=/trunk/; revision=20431
2003-03-21 Not Zed <NotZed@Ximian.com>
** for mail part of bug #38461.
* importers/evolution-outlook-importer.c (load_file_fn): dont pass
in create flag to uri_to_folder, the folder must already exist.
* importers/evolution-mbox-importer.c (folder_created_cb):
Removed, we now force the caller to create the destination folder
first.
(load_file_fn): Dont try and create a folder if it doesn't exist.
Also, use the uri directly as the destination uri, so we can
import into any folder.
(process_item_fn): If we dont have a folder, thats just an error,
return BAD_FILE.
* importers/netscape-importer.c (netscape_import_file): As below
for elm_import_file.
(import_next): similarly as for pine import_next.
(importer_cb): just record result.
(importer_timeout_fn): removed.
* importers/pine-importer.c (import_next): Similar to below for
the elm import_next.
(pine_import_file): As below for elm_import_file.
(importer_timeout_fn): removed.
(importer_cb): just record the result, and exit.
(import_next): change around to behave more like the elm importer,
cleaning up when we're done.
* importers/elm-importer.c (elm_import_file): Create the
destination folder ourselves, dont pass it onto the mbox importer.
Simplify logic, just do the import within a while loop, polling
the g main loop as necessary, remove need for idle callbacks and
other crap.
(import_next): If elm_import_file fails, then just go straight to
the next folder, stops it falling in a heap.
(import_item_idle): removed.
(importer_cb): just record result/exit.
* mail-importer.c (mail_importer_create_folder): removed.
(mail_importer_make_local_folder): new function to create a
local-only folder from a path. It runs synchronously by using a
recursive main loop.
(folder_created_cb): callback for make_local_folder.
svn path=/trunk/; revision=20379
2003-03-19 Radek Doulik <rodo@ximian.com>
* mail-composer-prefs.c (spell_load_values): changed default
language to en_us instead of en
(spell_language_button_press): new handler, ported from 1.2
(spell_setup): use spell_language_enable and
spell_language_button_press
svn path=/trunk/; revision=20356
2003-03-18 Larry Ewing <lewing@ximian.com>
* mail-callbacks.c (do_mail_print): fix leak, cleanup variable
name, and call gtk_window_set_transient_for with a parent that is
actually a GtkWindow.
(mark_as_unseen): use g_source_remove.
svn path=/trunk/; revision=20348
2003-03-18 Jeffrey Stedfast <fejj@ximian.com>
* mail-config-druid.c (mail_config_druid_new): Set the type hint
to DIALOG so that Metacity shows this window on top. Fixes bug
#39914.
svn path=/trunk/; revision=20343
2003-03-18 Not Zed <NotZed@Ximian.com>
* mail-vfolder.c (new_rule_clicked): validate rule & rule is
unique. Workaround for #39464. Should this just use
rule_context_add_rule_gui??
svn path=/trunk/; revision=20333
2003-03-18 Not Zed <NotZed@Ximian.com>
* mail-search.c (mail_search_destroy): unhook from the html engine
signals here, before we redisplay the message. Also make sure
this processing only happens once. For #39759.
(mail_search_finalise): dont unhook from signals here.
svn path=/trunk/; revision=20326
2003-03-12 Not Zed <NotZed@Ximian.com>
* mail-callbacks.c (expunge_folder): use a hack to find out if the
message-list was focussed before we desensitise it.
(expunged_folder): If the message-list was focussed before,
re-grab the focus. For bug #29564.
svn path=/trunk/; revision=20325
2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (pixbuf_gen_idle): If we fail to load the pixbuf,
don't use it (stops some g_warnings).
svn path=/trunk/; revision=20319
2003-03-17 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (do_external_viewer): Lookup the handler for the
type. If we don't have a registered handler or if the registered
handler is not meant to be handled via a bonobo component, don't
use a bonobo component.
* mail-format.c (mail_lookup_handler): If we register a new
handler that is to be handled by a bonobo component, set
handler->is_bonobo to TRUE.
svn path=/trunk/; revision=20311
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-display.c (do_external_viewer): Make sure that we don't
launch a bonobo control to view a mime-type that we handle
internally, otherwise maliciously formed HTML mail using <object>
tags could potentially launch a bonobo vontrol to view the mime
part bypassing any checks that Evolution might do on the data
normally.
svn path=/trunk/; revision=20269
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
Security vulnerability fixes.
* mail-format.c (handle_text_html, attachment_header)
(handle_image, handle_via_bonobo): Encode the result from
get_cid() so that malicious Content-Id strings cannot bypass the
user's preference to not load http images, force a bonobo control
to load passing it arbitrary data, etc.
svn path=/trunk/; revision=20268
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c (menu_file_save_cb): Rewritten to do the
same as the composer's build_message() code.
svn path=/trunk/; revision=20266
2003-03-12 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c: Various small fixes leading up to a real fix.
svn path=/trunk/; revision=20265
2003-03-11 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_add_clicked): Use
gtk_window_set_transient_for() on the druid with the settings
dialog as the parent window.
svn path=/trunk/; revision=20253
2003-03-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-accounts.c (account_able_toggled): New callback function to
handle the checkbox getting toggled.
(mail_accounts_treeview_new): Save the toggle renderer so we can
later connect to it's toggled signal.
(mail_accounts_tab_construct): Connect to the toggle-cell's
toggled signal. Fixes bug #39325.
svn path=/trunk/; revision=20245
2003-03-11 Not Zed <NotZed@Ximian.com>
* mail-vfolder.c (vfolder_editor_response): Fix the response code,
because some bastard changed the filter/* code and didn't fix the
callers. Partial fix for #39165.
svn path=/trunk/; revision=20231
2003-03-10 Not Zed <NotZed@Ximian.com>
* component-factory.c
(factory): Removed the debug printf. Added a case for the
composer. Part of fixing #39256.
svn path=/trunk/; revision=20228
2003-03-10 Not Zed <NotZed@Ximian.com>
* Makefile.am (libevolution_mail_la_SOURCES): removed main.c from
the build.
* component-factory.c (component_factory_init): Remove, not used
anymore, causes linking problems some places.
(factory): Removed the debug printf.
svn path=/trunk/; revision=20226
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
All this snot just to fix bug #38925 and an attempt to fix bug
#38926 (but it seems no matter what I do, I can't work around the
bonoboness/modality/whatever of the shell's preferences dialog).
* mail-account-gui.c (sig_add_new_signature): Get the toplevel
parent GtkWindow and pass that along to
mail_composer_prefs_new_signature() so that window layering can be
done correctly.
* mail-composer-prefs.c (mail_composer_prefs_new_signature):
Simplify. We don't want to add the signature to the list until
after they have saved.
(sig_edit_cb): Pass FALSE as the is_new argument to
mail_signature_editor().
(sig_event_client): Listen for signatures being added.
(mail_composer_prefs_new_signature): Now takes a GtkWindow arg as
the first arg rather than a MailComposerPrefs arg since we don't
really need it to be a MailComposerPrefs object. We'd rather use
the first arg as the parent GtkWindow so that we can set
transience for the editor window.
* mail-signature-editor.c (mail_signature_editor): Now takes a
'parent' argument (so we can set transient_for()) and a 'is_new'
argument specifying whether the editor is editing a new signature
or not. If it is, when the user saves, it will be added to the
signature list. otherwise it won't.
(sig_name_changed): Only use the mail_config_signature_set_name()
interface if it is *not* a new signature.
(menu_file_save_cb): If is_new, then save the signature to the
config - otherwise do what we did before and set the modifications
to it and emit the CHANGED event.
* mail-config.c (mail_config_signature_new): Renamed from
mail_config_signature_add(). We no longer immediately add the
signature to the list of saved signatures.
(mail_config_signature_add): New function which adds the signature
and emits the SIG_ADDED event.
svn path=/trunk/; revision=20221
2003-03-07 Jeffrey Stedfast <fejj@ximian.com>
* mail-display.c (on_url_requested): If the part url is a text
part, use mail_format_data_wrapper_write_to_stream(). This should
fix bug #39204.
* mail-format.c (mail_format_data_wrapper_write_to_stream): Make public.
svn path=/trunk/; revision=20219
2003-03-06 Jeffrey Stedfast <fejj@ximian.com>
* e-searching-tokenizer.c (camel_utf8_getc): Don't use __inline__
as not all platforms/compilers support this keyword.
(g): Same.
svn path=/trunk/; revision=20193
2003-03-05 Not Zed <NotZed@Ximian.com>
* component-factory.c (idle_quit): Removed old quit code.
(owner_unset_cb): Make this call synchronous. Wont cover all
cases but should be ok most of the time.
svn path=/trunk/; revision=20167
2003-03-04 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (composer_get_message): Go back to using
e_destination_get_address() but use the camel-address parser on
the strings to make sure they are non-empty. Fixes bug #37854.
svn path=/trunk/; revision=20137
2003-03-03 Jeffrey Stedfast <fejj@ximian.com>
* mail-signature-editor.c (menu_file_save_cb): Use 'filename' when
creating the uri rather than using the uninitialised 'uri'
variable to create itself. Fixes bug #38864.
svn path=/trunk/; revision=20125
2003-03-03 Not Zed <NotZed@Ximian.com>
* mail-session.c (do_user_message): Do the same as below for
request_password, so we dont leave a mainloop lying around.
2003-03-03 Jeffrey Stedfast <fejj@ximian.com>
* mail-session.c (request_password): Don't connect to the response
signal if we are in the main thread - instead just use the return
value from gtk_dialog_run and then call pass_response() with the
response value.
svn path=/trunk/; revision=20122
