Commit Graph

568 Commits

Author SHA1 Message Date
91c10248f8 Fixes for bug #39813
2003-03-20  Jeffrey Stedfast  <fejj@ximian.com>

	Fixes for bug #39813

	* e-msg-composer.c (composer_finalise): Don't unregister the
	signature event handler here.
	(destroy): Unregister it here instead.

svn path=/trunk/; revision=20442
2003-03-20 20:24:40 +00:00
079d44f566 Change the logic to attach text parts when appropriate. (map_default_cb):
2003-03-19  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (add_attachments_handle_mime_part): Change the
	logic to attach text parts when appropriate.
	(map_default_cb): Grab the focus of the To entry widget. Fixes bug
	#39800. Fixes another #warning too.

svn path=/trunk/; revision=20371
2003-03-19 21:28:14 +00:00
e88c74b97d Change the logic to attach text parts when appropriate.
2003-03-19  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (add_attachments_handle_mime_part): Change the
	logic to attach text parts when appropriate.

svn path=/trunk/; revision=20367
2003-03-19 20:28:44 +00:00
e31a8b9678 e_msg_composer_hdrs_get_subject() now returns const so don't g_free() it
2003-03-18  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (do_exit): e_msg_composer_hdrs_get_subject()
	now returns const so don't g_free() it :-)
	(map_default_cb): Same as above. Also, the subject entry no longer
	derives from GnomeCanvas so eliminate the now unneeded casting to
	grab the focus of the subject widget.
	(e_msg_composer_get_subject): Return a const char * now.

	* e-msg-composer-hdrs.c (create_headers): Make the subject entry
	into a GtkEntry so we don't have to worry about i18n and other
	EEntry bugs anymore. Fixes numerous bugs (including #39924).
	(e_msg_composer_hdrs_set_subject): Use gtk_entry_set_text().
	(e_msg_composer_hdrs_to_message_internal):
	e_msg_composer_hdrs_get_subject() now returns const.
	(e_msg_composer_hdrs_get_subject): Return a const char *.
	(entry_changed): e_msg_composer_hdrs_get_subject() now returns
	const.

svn path=/trunk/; revision=20350
2003-03-18 22:11:02 +00:00
e88e730bb6 Default the composer's title to "Create a message". Fixes bug #39696.
2003-03-13  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (create_composer): Default the composer's title
	to "Create a message". Fixes bug #39696.

svn path=/trunk/; revision=20283
2003-03-13 23:04:34 +00:00
c15a1c9677 Use GnomeIconList instead of EIconList so we don't have to maintain an
2003-03-11  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c: Use GnomeIconList instead of
	EIconList so we don't have to maintain an exact copy/paste of
	GnomeIconList ourselves. I don't udnerstand why we ever did.

	* e-icon-list.[c,h]: Removed.

svn path=/trunk/; revision=20251
2003-03-11 16:48:53 +00:00
4e98841191 add send_cb/save_draft_cb arguments. (impl_Composer_send): use the local
2003-03-11  Not Zed  <NotZed@Ximian.com>

        * evolution-composer.c (evolution_composer_new): add
        send_cb/save_draft_cb arguments.
        (impl_Composer_send): use the local send_cb.
        (evolution_composer_init): dont init send, save-draft signals
        here.
        (evolution_composer_new): init signals here, fix params to
        composer_construct().
        (evolution_composer_factory_init): remove, part of mailer now.
        (factory_fn): same.
        (finalise): disconnect from callbacks first.

        * evolution-composer.h: add send_cb/save_draft_cb to composer object.

2003-03-10  Not Zed  <NotZed@Ximian.com>

        * evolution-composer.c (finalise): from destroy.
        (evolution_composer_class_init): gtkobject->gobject stuff.
        (evolution_composer_new): remove old redundant stuff.

svn path=/trunk/; revision=20227
2003-03-10 06:35:54 +00:00
4a28f62c6c Don't allow the returned charset to be NULL. (get_file_content): Make sure
2003-03-04  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset_setting): Don't
	allow the returned charset to be NULL.
	(get_file_content): Make sure there is buffered data before trying
	to convert it to UTF-8.

svn path=/trunk/; revision=20139
2003-03-04 18:31:35 +00:00
76f925a77b disconnect any signal handlers on the accounts object. For bug #37873.
2003-03-04  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-hdrs.c (destroy): disconnect any signal handlers
        on the accounts object.  For bug #37873.

svn path=/trunk/; revision=20135
2003-03-04 05:27:53 +00:00
e5f2139df7 Same as below.
2003-02-25  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c: Same as below.

	* e-msg-composer-attachment-bar.c: Go back to using
	e_iconv_charset_name().

svn path=/trunk/; revision=20059
2003-02-25 20:54:19 +00:00
afea60336c Make sure the url is != NULL? I can't think of anything else in this code
2003-02-24  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (drag_data_received): Make sure the url is !=
	NULL? I can't think of anything else in this code that could
	possibly cause bug #38382.

svn path=/trunk/; revision=20046
2003-02-24 22:15:26 +00:00
4b4eb5589a Fixed a memory leak.
2003-02-24  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (pixbuf_for_mime_type): Fixed a
	memory leak.

svn path=/trunk/; revision=20044
2003-02-24 19:57:54 +00:00
1247dfa0f3 Don't save the HTML format setting to gconf. This option menu is meant for
2003-02-22  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_set_send_html): Don't save the
	HTML format setting to gconf. This option menu is meant for a
	per-essage setting (ie. once the composer closes, the next
	composer will again use the default and not what the user chose
	last time).

svn path=/trunk/; revision=20004
2003-02-23 04:17:03 +00:00
d201fdec5a build libcomposer as a shared library so it can be linked into
* Makefile.am: build libcomposer as a shared library so it can be
        linked into libevolution-mail.so without portability problems

svn path=/trunk/; revision=19992
2003-02-21 19:05:27 +00:00
74171b6c89 Same as below.
2003-02-20  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset_setting): Same as
	below.

	* e-msg-composer-attachment-bar.c (get_default_charset): Use
	camel_charset_canonical_name() rather than e_iconv_charset_name()
	as the latter will be removed shortly.

svn path=/trunk/; revision=19979
2003-02-20 21:46:51 +00:00
1907e1a2d7 default_account is now a string value, not an int.
2003-02-18  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_from_account):
	default_account is now a string value, not an int.
	(create_from_optionmenu): Same.
	(header_new_recipient): Use g_signal_connect_data() instead of the
	now deprecated gtk_signal_connect_full().

svn path=/trunk/; revision=19934
2003-02-18 20:50:23 +00:00
50ff525b79 clean up
* Makefile.am: clean up

        * e-msg-composer.c (autosave_manager_query_load_orphans): #include
        string.h
        (menu_file_send_cb): s/gtk_signal_emit/g_signal_emit/

        * e-msg-composer-attachment.c: #include string.h
        (e_msg_composer_attachment_edit): s/E_GLADEDIR/EVOLUTION_GLADEDIR
        * e-msg-composer-attachment-bar.c: #include string.h
        (pixbuf_for_mime_type): s/ICONSDIR/IMAGESDIR/

        * e-msg-composer-hdrs.c: #include string.h

        * e-msg-composer-select-file.c (run_selector): Remove unused var

        * evolution-composer.c: #include string.h
        (evolution_composer_init): Remove unused var
        * listener.c: #include string.h
        (listener_new): Remove unused var

svn path=/trunk/; revision=19804
2003-02-06 15:50:31 +00:00
999cf94d61 Split out the mailto handling code from here so we can use it in the
2003-02-05  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): Split out the
	mailto handling code from here so we can use it in the drag-n-drop
	code too.
	(drag_data_received): If we find a mailto: url in the
	text/uri-list drop, pass that off to handle_mailto() so it can
	fill in the fields for us.

svn path=/trunk/; revision=19768
2003-02-05 20:16:44 +00:00
a5e82f72f8 updated for e scroll frame --> gtk scrolled window
svn path=/trunk/; revision=19736
2003-02-04 19:03:02 +00:00
3625118596 ops, build
ops, build

svn path=/trunk/; revision=19713
2003-02-03 19:17:22 +00:00
5b0dc680a2 Just use gnome_vfs_get_mime_type_from_name().
2003-02-03  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c: Just use
	gnome_vfs_get_mime_type_from_name().

svn path=/trunk/; revision=19712
2003-02-03 19:10:40 +00:00
3238b44d77 Give gnome_vfs_get_uri_from_local_path a full path.
2003-02-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c (update_mime_type): Give
	gnome_vfs_get_uri_from_local_path a full path.

svn path=/trunk/; revision=19702
2003-02-02 02:20:48 +00:00
8644df4c44 If the subject or body components of the mailto url are not in UTF-8,
2003-01-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_new_from_url): If the subject
	or body components of the mailto url are not in UTF-8, convert
	them to UTF-8.

svn path=/trunk/; revision=19662
2003-01-28 04:04:51 +00:00
143ba4162a Fixed a #warning by converting the filename into a uri before passing it
2003-01-27  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment.c (update_mime_type): Fixed a #warning
	by converting the filename into a uri before passing it into
	gnome_vfs_get_mime_type() since that function really needs a uri.

2003-01-22  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-hdrs.c (init): Get the list of accounts here and
	ref the account-list.
	(destroy): Unref the accounts list here.
	(create_from_optionmenu): Connect to the added/changed/removed
	account-list signals here.
	(account_added_cb): New callback function that adds the newly
	added account to the from-dropdown menu.
	(account_changed_cb): New callback that changes the label for the
	account that got changed in the dropdown menu.
	(account_removed_cb): Removes the account from the from dropdown
	menu.

svn path=/trunk/; revision=19654
2003-01-27 18:05:56 +00:00
c968436720 (iconsdir): Remove, this is now defined in
configure.in.

svn path=/trunk/; revision=19621
2003-01-24 18:15:10 +00:00
cf7ef09cd0 Load the view menu states from gconf. (e_msg_composer_set_send_html): Save
2003-01-23  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (e_msg_composer_load_config): Load the view
	menu states from gconf.
	(e_msg_composer_set_send_html): Save the setting via gconf instead
	of bonobo-config.
	(e_msg_composer_set_view_from): Same.
	(e_msg_composer_set_view_replyto): Here too.
	(e_msg_composer_set_view_cc): Again here.
	(e_msg_composer_set_view_bcc): And finally here.
	(setup_ui): Fixed a #warning - use gconf instead of bonobo-conf.
	(destroy): No need to sync/destroy the bonobo-conf db, we don't
	use it anymore.

svn path=/trunk/; revision=19606
2003-01-23 22:02:44 +00:00
1ac51fc577 *** empty log message ***
svn path=/trunk/; revision=19555
2003-01-22 20:09:10 +00:00
f4a030d2fa Updated to use EAccountList and iterators. (evolution_composer_init):
2003-01-17  Jeffrey Stedfast  <fejj@ximian.com>

	* evolution-composer.c (impl_Composer_set_headers): Updated to use
	EAccountList and iterators.
	(evolution_composer_init): Updated to use EAccount.

	* e-msg-composer.c (from_changed_cb): Updated to use the EAccount
	object.
	(e_msg_composer_new_with_message): Same.
	(e_msg_composer_get_preferred_account): Updated to return an
	EAccount object.
	(set_editor_signature): Updated to use an EAccountIdentity pointer.
	(get_signature_html): Same.

	* e-msg-composer-hdrs.c (create_from_optionmenu): Updated to use
	EAccount and EAccountList foo.
	(destroy): Same here.
	(e_msg_composer_hdrs_set_from_account): Here too.
	(e_msg_composer_hdrs_get_from): Updated.

svn path=/trunk/; revision=19511
2003-01-17 23:32:07 +00:00
2224fbc745 mail_config_get_signature_list now returns a GSList.
2003-01-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (signature_cb): mail_config_get_signature_list
	now returns a GSList.
	(setup_signatures_menu): Same.
	(set_signature_gui): Here too.

svn path=/trunk/; revision=19498
2003-01-16 20:49:18 +00:00
c0e8918f76 (do_exit): Make dialog HIG compliant
[Discard/Cancel/Save].

svn path=/trunk/; revision=19471
2003-01-14 22:50:36 +00:00
eb4f1afd89 don't pass NULL to bonobo_widget_set_property.
2003-01-09  Chris Toshok  <toshok@ximian.com>

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_set_to): don't pass
	NULL to bonobo_widget_set_property.
	(e_msg_composer_hdrs_set_cc): same.
	(e_msg_composer_hdrs_set_bcc): same.

svn path=/trunk/; revision=19383
2003-01-10 01:05:48 +00:00
fef77b9924 need to ref/sink "new" so that the g_object_unref doesn't spew a warning.
2003-01-09  Chris Toshok  <toshok@ximian.com>

	* e-msg-composer-hdrs.c (e_msg_composer_hdrs_new): need to
	ref/sink "new" so that the g_object_unref doesn't spew a warning.

svn path=/trunk/; revision=19368
2003-01-09 19:12:30 +00:00
32e9ba1991 Icons are now in $(datadir)/evolution/images
instead of $(datadir)/images/evolution.

svn path=/trunk/; revision=19291
2003-01-08 22:34:03 +00:00
d22be5639f Use gconf to get the default account index.
2003-01-08  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-hdrs.c (create_from_optionmenu): Use gconf to get
	the default account index.
	(e_msg_composer_hdrs_set_from_account): Same.

svn path=/trunk/; revision=19286
2003-01-08 18:45:38 +00:00
47ad4c65d3 use the composer's charset gconf key
svn path=/trunk/; revision=19274
2003-01-08 06:14:52 +00:00
235dc4e759 New convenience function. (attach_to_multipart): Use
2003-01-07  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer-attachment-bar.c (get_default_charset): New
	convenience function.
	(attach_to_multipart): Use get_default_charset().

svn path=/trunk/; revision=19270
2003-01-08 01:31:21 +00:00
a7c452fa57 Convenience function. (get_file_content): Use the convenience function to
2003-01-07  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (composer_get_default_charset): Convenience
	function.
	(get_file_content): Use the convenience function to get the
	default charset setting.
	(best_charset): Same.
	(e_msg_composer_new): Use gconf to get the send_html setting.
	(e_msg_composer_new_post): Same.

svn path=/trunk/; revision=19269
2003-01-08 01:27:05 +00:00
b4c4834eaa remove idldir definition. (It's defined in configure.in now)
* Makefile.am: remove idldir definition. (It's defined in
	configure.in now)

svn path=/trunk/; revision=19242
2003-01-06 14:19:06 +00:00
5eb3475aa2 fixed to build with -DG[TK]_DISABLE_DEPRECATED
svn path=/trunk/; revision=19208
2003-01-02 20:51:32 +00:00
6221468fa0 fixes
svn path=/trunk/; revision=19206
2003-01-02 20:05:58 +00:00
aed127b4f4 Use camel_text_to_html(). (e_msg_composer_new_from_url): Same.
2002-12-16  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (get_signature_html): Use camel_text_to_html().
	(e_msg_composer_new_from_url): Same.

	* evolution-composer.c (impl_Composer_set_body): Use
	camel_text_to_html().

svn path=/trunk/; revision=19127
2002-12-16 19:23:18 +00:00
0bf2d899d8 Fix for bug #33295
2002-12-07  Jeffrey Stedfast  <fejj@ximian.com>

	Fix for bug #33295

	* e-msg-composer-attachment.c: Change the parent_class to a
	GObjectClass pointer instead of a GtkObjectClass pointer.
	(e_msg_composer_attachment_edit): Ref the attachment object so
	that if the attachment is removed while it is still being edited,
	the attachment object will still exist and therefor foil the
	user's attempt to make Evolution crash when they close the
	properties dialog for this attachment.
	(close_cb): Unref the attachment object.

svn path=/trunk/; revision=19053
2002-12-07 18:44:46 +00:00
6e5686598a Get rid of the unused exception variable.
2002-12-03  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c (message_rfc822_dnd): Get rid of the unused
	exception variable.

svn path=/trunk/; revision=18997
2002-12-03 18:45:47 +00:00
aececffc14 removed warning about e_notice. its used too much, its here to stay.
2002-11-27  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (save): removed warning about e_notice.  its
        used too much, its here to stay.

        * *.[ch]: run fix.sh over everything.

svn path=/trunk/; revision=18973
2002-12-02 03:07:59 +00:00
ec93568b79 removed merge conflicts
svn path=/trunk/; revision=18970
2002-12-01 18:52:52 +00:00
b625bdfa46 s/g_str[n]casecmp/str[n]casecmp
2002-12-01  Jeffrey Stedfast  <fejj@ximian.com>

	* e-msg-composer.c: s/g_str[n]casecmp/str[n]casecmp

svn path=/trunk/; revision=18969
2002-12-01 18:52:28 +00:00
66442571c9 properly chain finalise.
2002-11-26  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (composer_finalise): properly chain finalise.

svn path=/trunk/; revision=18918
2002-11-26 06:39:18 +00:00
8896a36925 Remove the window size setting. (e_msg_composer_attachment_bar_new): Move
2002-11-25  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (init): Remove the window size
        setting.
        (e_msg_composer_attachment_bar_new): Move the window size setting
        here.  Also set icon width based on 15 approximate characters, so
        the icon text is more readable.

svn path=/trunk/; revision=18906
2002-11-25 02:22:38 +00:00
2fd9ea3c7e rewrote most of this. Just use gtkfileselection directly, no
2002-11-22  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-select-file.c: rewrote most of this.  Just use
        gtkfileselection directly, no e-file-selector, much
        smaller/simpler.

2002-11-21  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-attachment-bar.c (remove_attachment): fix
        g_signal_emit params, detail in wrong spot.
        (add_common): Same.

        * e-icon-list.c (icon_new_from_pixbuf): remove the
        'use_broken_event_handling' set.
        (emit_select): Add detail to signal emit.
        (text_changed): Same.

        * e-msg-composer.c (subject_changed_cb): Duh!  dont free subject &
        simplify logic a little.

svn path=/trunk/; revision=18904
2002-11-25 00:12:09 +00:00
7d4c791a79 Duh! dont free subject & simplify logic a little.
2002-11-21  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer.c (subject_changed_cb): Duh!  dont free subject &
        simplify logic a little.

2002-11-20  Not Zed  <NotZed@Ximian.com>

        * e-msg-composer-hdrs.c (entry_changed): duh, emit the signal
        using an initialised value(!).

svn path=/trunk/; revision=18873
2002-11-20 23:46:04 +00:00