2001-10-19 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Update to reflect API
changes to e_msg_composer_add_message_attachments().
(do_forward_non_attached): Same.
(providers_config): Oops, pass a GdkWindow instead of a GtkWindow.
svn path=/trunk/; revision=13812
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* subscribe-dialog.h (subscribe_dialog_show): Helper macro.
* subscribe-dialog.c (subscribe_dialog_run_and_close): Removed.
* mail-callbacks.c (check_send_configuration): Don't use
gnome_dialog_run_and_close() here, we can easily get away with
just using a gtk_widget_show().
(providers_config): Don't use a gnome_dialog_run_and_close() here
either. No longer need to use e_gnome_dialog utils.
(manage_subscriptions): Don't run_and_close().
svn path=/trunk/; revision=13732
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (check_send_configuration): Don't use
gnome_dialog_run_and_close() here, we can easily get away with
just using a gtk_widget_show().
(providers_config): Don't use a gnome_dialog_run_and_close() here
either.
svn path=/trunk/; revision=13727
2001-10-15 Larry Ewing <lewing@ximian.com>
* mail-callbacks.c (mail_generate_reply): don't apply the body
text in replys since we will just replace it anyway.
svn path=/trunk/; revision=13683
2001-10-11 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (addrbook_sender): Listen for "destroy" events
from the control, so that we don't leave stray windows laying
around. (Bug #9101)
svn path=/trunk/; revision=13609
2001-10-11 Jeffrey Stedfast <fejj@ximian.com>
* component-factory.c (free_storage): Make sure the
service/storage are non-NULL.
* mail-callbacks.c (e_gnome_dialog_parent_destroyed): Call
gtk_main_quit.
(send_receive_mail): Don't use e_gnome stuff since this doesn't
need to be run using gnome_dialog_run_and_close().
(composer_send_cb): Same.
(edit_msg): Here too.
(resend_msg): And here.
(search_msg): Same.
(filter_edit): Here too.
(filter_edit): Don't use e_gnome_dialog_set_parent() because we
don't do gnome_dialog_run_and_close on this dialog.
(e_gnome_error_dialog_parented): Removed.
(e_gnome_ok_dialog_parented): Removed.
svn path=/trunk/; revision=13583
2001-10-10 Larry Ewing <lewing@ximian.com>
* mail-callbacks.c (mail_generate_reply): use new function to copy
the attachments from the source message. This still isn't perfect
but it should avoid the problems with headers being transfered.
This makes images in replies work again.
svn path=/trunk/; revision=13564
2001-10-09 Jeffrey Stedfast <fejj@ximian.com>
* folder-browser-ui.c (folder_browser_ui_add_message): Create a
chaqrset picker submenu in the View menu.
* mail-format.c (mail_format_raw_message): Pass the mail-display
to get_data_wrapper_text.
(get_data_wrapper_text): Use the user's override charset if one is
provided, otherwise user the user's default charset.
(handle_text_plain): Pass along the mail-display to
get_data_wrapper_text.
(handle_application_pgp): Same.
(handle_text_enriched): Here too.
(mail_get_message_body): Pass NULL as the mail-display to
get_data_wrapper_text since we don't have access to a
mail-display.
* mail-display.c (mail_display_set_charset): New function to set a
charset on the maildisplay. Once set, the message is redisplayed
using the new charset.
(mail_display_destroy): Free the charset.
* folder-browser.c (folder_browser_charset_changed): New callback
for when a user overrides the message charset.
svn path=/trunk/; revision=13530
* mail-callbacks.c (e_gnome_dialog_set_parent): Use
gtk_signal_connect_while_alive here so
e_gnome_dialog_parent_destroyed doesn't get called on an
already-destroyed dialog.
* mail-config-druid.c (*_prepare): Record which page we're
currently in.
(*_changed): Only update the druid buttons if we're the current
page. Fixes a problem that could make it impossible to get beyond
the first page of the setup wizard.
svn path=/trunk/; revision=13522
* mail-callbacks.c (mail_generate_reply): Revert the change to use
e_msg_composer_new_with_message. That has unwanted side effects.
(This commit re-breaks replying to HTML messages with inline
images.)
svn path=/trunk/; revision=13518
2001-10-05 <NotZed@Ximian.com>
* folder-browser.c: reformatted the menu tables so they're a bit
more bloody readable.
* mail-folder-cache.c (mail_note_store): Hook into
subscribed/unsubscribed events. Only 'add/remove' folders from
the add/removed events if we aren't subscribed, otherwise use the
subscribed events. Rest of fix for #11831
svn path=/trunk/; revision=13472
2001-10-05 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (e_gnome_dialog_set_parent): New convenience
function that not only sets the gnome-dialog's parent window but
also makes sure that the gnome-dialog closes when it's parent
closes.
(e_gnome_warning_dialog_parented): New conmvenience wrapper around
the libgnomeui version that also does the same thing as
e_gnome_dialog_set_parent.
(e_gnome_error_dialog_parented): Same.
(e_gnome_ok_dialog_parented): And again...
(e_gnome_ok_cancel_dialog_parented): And once again.
svn path=/trunk/; revision=13464
2001-10-05 Larry Ewing <lewing@ximian.com>
* mail-callbacks.c (mail_generate_reply): use
e_msg_composer_new_with_message rather than e_msg_composer_new.
This way we bring in all the attachment of the message we are
replying to.
svn path=/trunk/; revision=13444
2001-10-04 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (providers_config): Set the parent window as
the fb. This fixes bug #11723.
(filter_edit): Do the same thing here too and also to the warning
dialog.
(edit_msg): Set the parent on the warning dialog.
(resend_msg): And here.
(search_msg): Here too.
(confirm_expunge): Set the parent window on the dialog here too.
(save_msg_ok): Same here.
svn path=/trunk/; revision=13425
2001-10-04 <NotZed@Ximian.com>
* mail-callbacks.c (configure_folder): If we're accessing a
vfolder uri, then popup the vfolder editor instead of trying the
mail local one.
* mail-vfolder.c (vfolder_edit_rule): Edit a vfolder by name.
svn path=/trunk/; revision=13419
2001-10-02 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (transfer_msg): Pass an empty flags argument to
mail_transfer_messages - destination folder should already be
created by this point.
* folder-browser.c (message_list_drag_data_received): Pass an
empty flags argument to mail_transfer_messages.
(selection_received): Same.
* component-factory.c (xfer_folder): Pass the CREATE flag to
mail_transfer_messages() so that the dest folder gets created.
(destination_folder_handle_drop): Update for mail-ops API change.
* mail-ops.c (mail_transfer_messages): Now takes a dest_flags
argument that it passes along to mail_tool_uri_to_folder when
opening the destination folder.
svn path=/trunk/; revision=13357
2001-09-26 Jon Trowbridge <trow@ximian.com>
* mail-display.c (html_button_press_event): Decode our URL before
extracting the address to pop up contact info.
* mail-format.c (write_address): When writing out a mailto: link,
make sure we construct a valid URL w/ correct encoding. Make sure
our address is properly quoted, if necessary.
svn path=/trunk/; revision=13160
2001-09-25 Jeffrey Stedfast <fejj@ximian.com>
* mail-mt.c (pass_got): Only cache the password for the service if
it has an entry in the account database. Fixes bug #10875.
svn path=/trunk/; revision=13111
* mail-callbacks.c (mail_storage_create_folder, folder_created,
create_folders): All made redundant by new mail-folder-cache
code.
(delete_folders, folder_deleted): Uh, code that isn't used
anywhere. Removed.
* component-factory.c (storage_create_folder): Dont call
folder_created, let the folder_created event handle the update.
* mail-ops.c (mail_scan_subfolders): Remove, no longer used.
svn path=/trunk/; revision=13059
* mail-callbacks.c (create_folders): Pass the actual unread
message count, not just whether or not it's > 0. Fixes ximian
9089.
svn path=/trunk/; revision=12979
2001-09-19 <NotZed@Ximian.com>
* General cleanup of mail debug printfs.
* mail-folder-cache.[ch]: Completely rewritten. Removed all calls
to the old code everywhere they were used. Nuff said.
* folder-browser.h: Add shell_view to folder_browser & api to set
it.
* folder-browser-factory.c (control_activate): Set the shell-view
on the folder_browser.
(control_deactivate): And clear it here.
* folder-browser.c (folder_browser_destroy): Unhook from changed
events on the folder before giving it away.
(got_folder): Hook onto the folder-changed events.
(folder_changed): Event hook proxy for folder_changed events
(main_folder_changed): And the main code version.
(update_status_bar): And the one that actually does the work.
(on_selection_changed): Also call update_status_bar() to update
the selection count.
(folder_browser_set_shell_view): Implement function to set the
shell_view on the folder_browser.
(folder_browser_destroy): Release the shell_view here too.
* mail-tools.c (mail_tool_uri_to_folder): Dont 'note' the new
folder if its from a file: url, this is handled by hte local store
(yeeruughck).
* mail-local.c (mls_init):
(free_info):
(mls_finalise): Setup init/finalise funcs for the folderinfo hash.
(local_storage_removed_folder_cb): re-enable.
2001-09-18 <NotZed@Ximian.com>
* mail-local.c (MailLocalStore): Add a hash table to store
uri<>folderinfo data.
(mail_local_store_add_folder): Add a new folderinfo to our hash.
(mail_local_store_remove_folder): Remove a folder by uri.
(storage_listener_startup): Add this store to those monitored by
the folder tree.
svn path=/trunk/; revision=12974
2001-09-13 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (composer_get_message): Fixed double-freeing of
EDestination vector when sending html mail to people who don't
necessarily want it. Fixes bug #9848.
svn path=/trunk/; revision=12821
2001-09-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Don't use
new_with_sig_file, that function no longer exists.
(forward_get_composer): Same here.
svn path=/trunk/; revision=12754
2001-09-10 Jeffrey Stedfast <fejj@ximian.com>
* mail-callbacks.c (mail_generate_reply): Pass along the right
string, this fixes bug #9518.
svn path=/trunk/; revision=12736
* mail-callbacks.c (composer_get_message): Fix obvious dumb
mistake in previous commit that made it *always* complain you had
invalid recipients.
svn path=/trunk/; revision=12733
2001-09-09 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (composer_get_message): Complain if we are
trying to send to invalid recipients. (Bug #8875)
svn path=/trunk/; revision=12721
2001-09-08 Jon Trowbridge <trow@gnu.org>
* mail-callbacks.c (ask_confirm_for_unwanted_html_mail): Added.
Shows a (hopefully) informative dialog warning you that some
recipients might not want HTML mail (who are listed), and gives
the option to cancel sending. (FIXME: The wording of this dialog
could use some work.)
(composer_get_message): Check if we are sending HTML to someone
who might not want it, and raise the dialog if we are. Use our
new destination-vector based api when talking to the composer.
Touch our destinations here, boosting their use scores. This is
the right place for this to happen --- closer to the end of the
sending process, where incorrect/artificial use score inflation is
less likely to occur.
* mail-config.c (config_read): Added
/Mail/Format/confirm_unwanted_html key. This flag determines
whether or not we want to see the warning dialog when we send HTML
mail to contacts who don't want it. Default is TRUE.
(mail_config_write_on_exit): Write out the confirm_unwanted_html
key.
(mail_config_get_confirm_unwanted_html): Added.
(mail_config_set_confirm_unwanted_html): Added.
svn path=/trunk/; revision=12712
2749 - Message text not included in reply, but html attachment is
4294 - "forward inline" should quote the same headers as the
normal mail display
6100 - Reply to a forwarded email displays email headers
7255 - Replying to HTML message
7527 - replying to forwarded message w/ attachments does the wrong
thing
* mail-format.c (mail_get_message_rfc822): New function to get
message headers and body together, for inline forwards, or replies
containing attached messages.
(mail_get_message_body): Redo this to always return HTML, but keep
the "want_plain" flag, to decide whether to return HTML that looks
like HTML or HTML that looks like plain text. Use
mail_get_message_rfc822 to handle attached message/rfc822 parts.
Don't include the text of vcard or icalendar attachments. Don't
fail to include text parts just because we found an HTML part.
(Since we're always returning HTML now, this doesn't cause
problems any more.)
* mail-tools.c (mail_tool_quote_message): Simplify greatly.
mail_get_message_body always returns HTML now, and we let it take
care of prepending "> "s too. We then let GtkHTML deal with
converting the HTML to plain text if the user wants to reply in
plain text.
(mail_tool_forward_message): Simplify this a ton too: parts of it
are moved into mail_get_message_rfc822 and parts are now
unnecessary.
* mail-callbacks.c (do_forward_non_attached): Call
mail_tool_forward_message here always, and let it do the "> "
quoting in the "quoted" case, so that we get the headers too when
forwarding quoted. Related to bug #4294.
svn path=/trunk/; revision=12657
2001-08-29 Jon Trowbridge <trow@ximian.com>
* e-msg-composer.c (e_msg_composer_get_message_draft): Pass
in FALSE as the 'sending' arg to e_msg_composer_get_message.
(build_message): Added a 'sending' arg, which is passed to
e_msg_composer_get_message.
(e_msg_composer_get_message): Added a 'sending' arg,
which gets passed directly on to build_message.
* e-msg-composer-hdrs.c (e_msg_composer_hdrs_to_message): Added
a "sending" arg, which should be TRUE if the message is being
sent now (rather than being autosaved, etc.). The address
use scores are only updated when sending. (Bug #8332)
Removed obsolete (#if 0/#endif-ed) code.
2001-08-29 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (composer_get_message): When calling
e_msg_composer_get_message, pass in TRUE for the 'sending' arg.
(Part of the fix for bug #8332)
svn path=/trunk/; revision=12518
2001-08-27 Jon Trowbridge <trow@ximian.com>
* mail-callbacks.c (mail_generate_reply): Check if we are trying
to reply to a message with no From: field, and try to do something
graceful in that case. (Bug #7028)
* mail-display.c (ebook_callback): Add paranoid checks for the
case of a message with a From: field. (Also maybe bug #7028)
svn path=/trunk/; revision=12490
2001-08-27 Jeffrey Stedfast <fejj@ximian.com>
* mail-tools.c (mail_tool_make_message_attachment): Remove
X-Evolution* headers.
(mail_tool_remove_xevolution_headers): New function to convenience
removing the X-Evolution headers.
(mail_tool_restore_xevolution_headers): New convenience function
to restore the X-Evolution headers.
(mail_tool_destroy_xevolution): New function to cleanup the
structure.
(mail_tool_forward_message): Remove and restore the X-Evolution
headers here too.
svn path=/trunk/; revision=12484
