2002-07-14 Rodrigo Moya <rodrigo@ximian.com>
* evolution-storage.c (impl_Storage_getFolderAtPath): no need to
convert the value returned by e_folder_tree_get_folder to a
GNOME_Evolution_Folder, since it already is, and duplicate it before
returning.
svn path=/trunk/; revision=17461
2002-07-14 Chris Toshok <toshok@ximian.com>
* e-shell.c (folder_selection_dialog_folder_selected_cb): set
corba_folder.customIconName so we don't crash.
(impl_Shell_selectUserFolder): remove the default_type parameter
to fix a compiler warning.
svn path=/trunk/; revision=17451
* evolution-storage.c (impl_Storage_asyncDiscoverSharedFolder):
dup the listener, for consistency with the other signals
svn path=/trunk/; revision=17444
2002-07-12 Peter Williams <peterw@ximian.com>
* Makefile.am (eshellinclude_HEADERS): Install some headers
that weren't getting installed.
svn path=/trunk/; revision=17439
* e-shell-folder-title-bar.c (e_shell_folder_title_bar_set_icon):
Allow a NULL icon [remove the precondition].
* e-shell-view.c (update_folder_title_bar): Only unref the
folder_icon if not NULL.
svn path=/trunk/; revision=17426
* e-summary-preferences.c (set_selected_folders): Actually pass
the evolution URI, not the path, in Folder.evolutionUri (since now
the shell StorageSetView implementation has been fixed to handle
this field properly).
* evolution-storage-set-view.c
(impl_StorageSetView__set_checkedFolders): Handle
Folder.evolutionUri as a URI, not as a path. Also use
e_free_string_list().
svn path=/trunk/; revision=17425
* e-shell-folder-title-bar.c: Remove some `#if 0'ed broken code.
New members title_icon and title_button_icon in struct
EShellFolderTitleBarPrivate. Remove member icon_widget. New
static global variable empty_pixbuf.
(init): Initialize these new members to NULL. Don't initialize
icon_widget anymore since it's gone.
(e_shell_folder_title_bar_construct): Create the title_button_icon
and pack it into the title_button_hbox. Also, create the
title_icon and pack that one as well. Retouched some of the
hardcoded padding values.
(size_allocate_icon): Rewritten to use the title_icon and return
the allocated space like size_allocate_navigation_buttons.
(e_shell_folder_title_bar_set_icon): Remove bogus const from the
@icon arg. Ref the pixbuf, and update the two pixmap widgets from
it. If @icon is NULL, use the empty_pixbuf.
(impl_destroy): Renamed from destroy().
(realize): Removed.
(unrealize): Removed.
(impl_size_allocate): Renamed from size_allocate().
(class_init): Call it.
(add_icon_widget): Removed.
(new_empty_pixbuf): New.
(new_empty_pixmap_widget): New.
(size_allocate_navigation_buttons_and_title_icon): Renamed from
size_allocate_navigation_buttons; set up the title_icon too.
* e-shell-view.c (update_folder_title_bar): Unref the folder_icon
after using it.
* e-icon-factory.c (e_icon_factory_get_icon): Ref the returned pixbuf.
svn path=/trunk/; revision=17419
* gui/component/addressbook-storage.c (load_source_data): Pass
zero as the @sorting_priority to evolution_storage_new_folder().
(addressbook_storage_add_source): Likewise.
* subscribe-dialog.c (recursive_add_folder): Pass zero as
@sorting_priority to evolution_storage_new_folder().
* mail-folder-cache.c (real_flush_updates): Pass zero as
@sorting_priority to evolution_storage_new_folder().
* evolution-test-component.c (setup_custom_storage): Pass
@sorting_priority to evolution_storage_new_folder() so we test it.
Also make /FirstFolder have an "inbox" custom icon.
* e-local-storage.c (new_folder): Pass zero as @sorting_priority
to evolution_storage_new_folder().
* evolution-storage.c (evolution_storage_new_folder): New arg
@sorting_priority; put it in the CORBA folder struct.
* evolution-shell-client.c
(impl_FolderSelectionListener_selected): Copy the sortingPriority
as well.
* e-folder.c (e_folder_to_corba): Set sortingPriority.
* e-corba-storage-registry.c
(impl_StorageRegistry_getFolderByUri): Set sortingPriority in the
new CORBA Folder struct.
* e-corba-storage.c (impl_StorageListener_notifyFolderCreated):
Set the custom_icon if folder->customIconName is not an empty
string. Likewise, set the sorting_priority
* Evolution-common.idl: New member sortingPriority in struct
Folder.
* e-storage-set-view.c (folder_sort_callback): Sort according to
the sorting_priorities.
* e-folder.c: New member sorting_priority in EFolderPrivate.
(init): Init to zero.
(e_folder_set_custom_icon): Emit "changed" if required.
(e_folder_set_sorting_priority): New.
svn path=/trunk/; revision=17404
* gui/component/addressbook-storage.c (load_source_data): Pass
NULL @custom_icon_name to evolution_storage_new_folder().
(addressbook_storage_add_source): Likewise. [Note we could be
passing a nice custom here. ;-)]
* subscribe-dialog.c (recursive_add_folder): Pass NULL for
@custom_icon_name to evolution_storage_new_folder().
* mail-folder-cache.c (real_flush_updates): Pass NULL for
@custom_icon_name to evolution_storage_new_folder().
* evolution-test-component.c (setup_custom_storage): Pass NULL for
@custom_icon_name to evolution_storage_new_folder().
* e-local-storage.c (new_folder): Pass the custom_icon_name here
to evolution_storage_new_folder().
* evolution-shell-client.c
(impl_FolderSelectionListener_selected): Set customIconName here
too.
* e-folder.c (e_folder_to_corba): Set customIconName too.
* e-corba-storage-registry.c
(impl_StorageRegistry_getFolderByUri): Set customIconName. Also,
use e_safe_corba_string() to clean up the code a bit.
* evolution-storage.c (evolution_storage_new_folder): New arg
@custom_icon_name.
* Evolution-common.idl: New member customIconName in struct
Folder.
svn path=/trunk/; revision=17397
* e-shortcuts-view-model.c (get_icon_for_item): If the
custom_icon_name is not NULL, return the pixbuf for it.
* e-storage-set-view.c: #include "e-icon-factory.h".
* e-shortcuts-view.c (impl_shortcut_dropped): Pass the
custom_icon_name.
(get_shortcut_info): New arg @custom_icon_name_return.
(rename_shortcut_cb): Pass the custom_icon_name here.
* e-shell-view-menu.c (new_shortcut_dialog_folder_selected_cb):
Pass the custom_icon_name for the folder's shortcut.
* e-shell-folder-commands.c (e_shell_command_add_to_shortcut_bar):
Pass the custom_icon_name for the folder's shortcut.
* e-corba-shortcuts.c (impl_add): Use the customIconName member in
struct ::Shortcuts::Shortcut.
(shorcut_list_to_corba): Set the customIconName member on the
returned shortcuts.
(impl_get): Likewise.
* Evolution-Shortcuts.idl: New member customIconName in struct
Shortcut.
* e-shortcuts.c (shortcut_item_new): New arg @custom_icon_name;
initialize the member in EShortcutItem from it.
(shortcut_item_update): New arg @custom_icon_name; set the
custom_icon_name from it. Also remove some braindeadness from
this code.
(update_shortcut_and_emit_signal): New arg @custom_icon_name.
(load_shortcuts): Load the custom icon name from the XML
[eg. <item name="foo" type="mail" icon="inbox">].
(save_shortcuts): Save the custom icon name in the XML.
(e_shortcuts_add_shortcut): New arg @custom_icon_name.
(update_shortcuts_by_path): Pass the custom_icon_name to
update_shortcut_and_emit_signal().
(e_shortcuts_update_shortcut): New arg @custom_icon_name; pass it
to update_shortcut_and_emit_signal().
(e_shortcuts_add_default_group): Pass "inbox" as the
custom_icon_name for the inbox shortcut, and NULL for the other
shortcuts.
* e-shortcuts.h: New member custom_icon_name in EShortcutItem.
svn path=/trunk/; revision=17394
* main.c (main): Call e_icon_factory_init().
* e-local-storage.c (setup_folder_as_stock): New arg @icon_name;
if not NULL, set up a custom icon for the folder.
(setup_stock_folders): Set up custom icons for inbox and outbox.
* e-storage-set-view.c (get_pixbuf_for_folder): If the folder has
a custom icon, return the custom icon.
* e-folder.c: New member custom_icon_name.
(init): Initialize to NULL.
(destroy): Free.
(e_folder_get_custom_icon): New.
(e_folder_set_custom_icon): New.
svn path=/trunk/; revision=17391
* e-shortcuts-view.c (toggle_large_icons_cb): Change the group
icon size using e_shortcuts_set_group_uses_small_icons() instead
of changing it on the widget directly.
(toggle_small_icons_cb): Likewise.
(group_change_icon_size_callback): New, callback for the
"group_change_icon_size" signal on the EShortcuts object.
(e_shortcuts_view_construct): Connect. Also, initialize the icon
sizes in the icon bars from the EShortcuts object.
* e-shell-view.c (e_shell_view_load_settings): Don't set the
shortcut group icon modes here anymore.
* e-shortcuts.c: New member use_small_icons in struct
ShortcutGroup.
(shortcut_group_new): Init to FALSE.
(e_shortcuts_set_group_uses_small_icons): New.
(e_shortcuts_get_group_uses_small_icons): New.
(class_init): Install "group_change_icon_size" signal.
(save_shortcuts): Save the icon size per-group
here, i.e. <group title="foo" icon_size="small">.
(load_shortcuts): Set the icon size from the group's definition
here.
* e-shortcuts.h: New signal "group_change_icon_size" in
EShortcutsClass.
svn path=/trunk/; revision=17386
* e-storage-set-view.c (impl_tree_drag_drop): Invoke
e_folder_dnd_bridge_drop().
* e-folder-dnd-bridge.c (find_matching_target_for_drag_context):
New arg @atom_return. Return the GdkAtom associated with the type
through it.
(e_folder_dnd_bridge_drop): New.
svn path=/trunk/; revision=17362
* gui/component/addressbook-component.c (add_creatable_item): New
arg @tooltip; pass it to
evolution_shell_component_add_user_creatable_item() [which now has
a @tooltip arg].
* gui/component-factory.c (add_creatable_item): New arg @tooltip.
Pass it to evolution_shell_component_add_user_creatable_item(),
which now has a @tooltip arg.
(create_object): Added tooltips.
* component-factory.c (create_component): Pass a tooltip to
evolution_shell_component_add_user_creatable_item.
* e-shell-user-creatable-items-handler.c: New member tooltip in
struct MenuItem.
(ensure_menu_items): Initialize the tooltip member.
(shell_view_view_changed_callback): Set the tooltip for the "New"
button.
(ensure_menu_xml): Set up the tooltip here as well.
* evolution-shell-component.c: Add tooltip member to struct
UserCreatableItemType.
(user_creatable_item_type_new): New arg @tooltip.
(evolution_shell_component_add_user_creatable_item): New arg
@tooltip.
(impl__get_userCreatableItemTypes): Put the tooltip in the struct
as well.
* e-shell-user-creatable-items-handler.c (setup_toolbar_button):
Create a GtkTooltips object and attach it to the combo_button
using gtk_object_set_data().
(shell_view_view_changed_callback): Set up a tooltip for the
button, according to the default.
* Evolution-ShellComponent.idl: Add a tooltip member to struct
UserCreatableItemType.
svn path=/trunk/; revision=17343
* e-shell.c (e_shell_prepare_for_quit): Remove debugging message.
* e-shell-view.c (setup_verb_sensitivity_for_folder): Set
sensitivity of /commands/AddFolderToShortcutBar,
/commands/OpenFolder and /commands/OpenFolderInNewWindow too,
depending on whether the node that was right-clicked can be opened
as a folder.
* e-storage-set-view.c (popup_folder_menu): Pop up the right-click
menu even if we are not clicking on a folder with a proper
handler.
svn path=/trunk/; revision=17337
(init): Initialize to FALSE.
(e_shell_prepare_for_quit): Set preparing_to_quit to TRUE on
entering, and set it to FALSE on return.
(view_delete_event_cb): Don't call e_shell_prepare_for_quit() if
preparing_for_quit is TRUE.
svn path=/trunk/; revision=17336
* evolution-storage-set-view.c
(impl_StorageSetView__get_checkedFolders): Set release for the
CORBA path sequence to TRUE.
* evolution-shell-component.c
(fill_corba_sequence_from_null_terminated_string_array): Set
release for the CORBA sequence to TRUE so it gets freed properly.
(impl__get_externalUriSchemas): Likewise for the returned
uri_chema_list.
* e-shell-offline-handler.c (duplicate_connection_list): Set
release for the connection sequence to TRUE.
* e-shell-config-offline.c (config_control_apply_callback): Set
release for the path sequence to TRUE.
* e-corba-storage-registry.c
(impl_StorageRegistry_getStorageList): Set release for the storage
sequence to TRUE.
* evolution-storage.c (impl_Storage__get_folderList): Set release
for the folder sequence to TRUE.
svn path=/trunk/; revision=17062
* e-folder-list.c (e_folder_list_construct): Use
bonobo_object_ref() instead of bonobo_object_client_ref() as the
former only refs the CORBA object [Sigh].
* e-shell-config-autocompletion.c
(e_shell_config_autocompletion_create_widget): Don't unref the
shell_client here, as we need it. :-)
svn path=/trunk/; revision=17046
* e-shell-view-menu.c (command_about_box): Connect
about_box_event_callback() to the "key_press_event" signal as
well. This way the about box is closed when you press a key too.
[#25349]
svn path=/trunk/; revision=17044
2002-05-28 Chris Toshok <toshok@ximian.com>
* e-folder-list.c (e_folder_list_set_items): skip folders that
aren't valid uri's.
(e_folder_list_get_items): didn't update this to track the change
in model columns. bad toshok.
svn path=/trunk/; revision=17028
2002-05-24 Chris Toshok <toshok@ximian.com>
[ fixes 90% of #25047 ]
* e-folder-list.c (get_folder_for_uri): shamelessly lifted from
evolution-folder-selector-button.c.
(create_display_string): modeled again after
evolution-folder-selector-button.c, so we can give a little more
context (and make the table look like the folder selector
buttons.)
(SPEC): add a pixbuf column, also remove the sorting behavior.
(columns): add a pixbuf column and another string column (for the
display string).
(add_clicked): create the display string and get the proper
pixbuf, and insert both.
(edit_clicked): removed.
(update_buttons): remove edit button handling from here.
(e_folder_list_init): remove the hooking up of button-edit's
"clicked" signal.
(e_folder_list_construct): get a reference to the storage registry
so we can look up folders.
(e_folder_list_set_items): analogous change to add_clicked - get
the display string and pixbuf and insert them.
* glade/e-folder-list.glade: remove the edit button.
* glade/e-shell-config-default-folders.glade: remove the
frame/vbox, since we embed it in a notebook and the tab has the
title already.
* e-shell-config.c (config_control_factory_cb): the only config
control we deal with here now is the folder settings control.
* e-shell-config-default-folders.c
(e_shell_config_default_folders_create_widget): rename
e_shell_config_default_folders_create_control to this, return the
widget, and take the config control to use as an arg.
* e-shell-config-offline.c (e_shell_config_offline_create_widget):
make an analogous change here as with
default_folders_create_widget.
* e-shell-config-default-folders.h
(e_shell_config_default_folders_create_widget): track change to
prototype.
* e-shell-config-offline.h (e_shell_config_offline_create_widget): same.
* GNOME_Evolution_Shell.oaf.in: remove the DefaultFolders and
OfflineFolders controls and add a FolderSettings_Control.
* Makefile.am (evolution_SOURCES): add
e-shell-config-folder-settings.[ch] and
e-shell-config-autocompletion.[ch].
* e-shell-config-folder-settings.[ch]: new files, embed (after a
fashion) the default folder, offline, and autocompletion UI's in a
notebook.
* e-shell-config-autocompletion.[ch]: Basically copy over and
shell-ize the addressbook autocompletion config control so it can
be embedded more easily with the other folder settings.
svn path=/trunk/; revision=17000
* e-shortcuts-view.c (rename_group_cb): Set the view type from the
original group, thus preserving the small-icon/large-icon state.
Fixes#6732.
svn path=/trunk/; revision=16991
* main.c (show_development_warning): Add a toggle to avoid
displaying the dialog again. Don't display the dialog at all if
the /Shell/skip_warning_dialog_1_1 bonobo-conf key is set to
FALSE.
(warning_dialog_clicked_callback): Set
/Shell/skip_warning_dialog_1_1 according to the state of the check
button.
svn path=/trunk/; revision=16986
* e-shell.c (impl_Shell_selectUserFolder): No more @default_type
arg to e_shell_folder_selection_dialog_new().
* e-shell-view-menu.c (command_goto_folder): No more @default_type
arg to e_shell_folder_selection_dialog_new().
(command_new_shortcut): Likewise.
* e-shell-importer.c (import_druid_finish): No more @default_type
arg to e_shell_folder_selection_dialog_new().
* e-shell-folder-commands.c (e_shell_command_move_folder): No more
@default_type arg to e_shell_folder_selection_dialog_new().
(e_shell_command_copy_folder): Likewise.
* e-shell-folder-selection-dialog.c: Removed default_type member
in EShellFolderSelectionDialogPrivate.
(e_shell_folder_selection_dialog_new): Removed @default_type arg.
(e_shell_folder_selection_dialog_construct): Likewise.
(impl_clicked): Just pass the first of the allowed types to
e_shell_show_folder_creation_dialog() for the default type.
* evolution-shell-client.c (user_select_folder): No more
@default_type arg to the ::userSelectFolder CORBA method.
* Evolution-Shell.idl (selectUserFolder): Remove arg
@default_type.
svn path=/trunk/; revision=16983
* main.c (view_map_callback): New callback for when the first
created view in the shell gets mapped.
(new_view_created_callback): New callback for when the first view
of the shell gets created.
(show_development_warning): New function to display a warning
about the fact that Evolution is unstable.
(idle_cb): Call show_development_warning() here unless the
EVOLVE_ME_HARDER environment variable is set.
* e-shell.c (class_init): Add the "new_view_created" signal here.
(create_view): Emit the signal here.
* e-shell.h: New signal "new_view_created".
svn path=/trunk/; revision=16977
* e-shell-user-creatable-items-handler.c: New member
default_menu_item in EShellUserCreatableItemsHandlerPrivate.
(ensure_menu_items): Set ->default_menu_item.
(get_default_action_for_view): When no default item is specified,
just return ->default_menu_item.
svn path=/trunk/; revision=16976
* e-shell.c (e_shell_prepare_for_quit): Only refuse quitting if
the result is CANCEL. This way we allow quitting if one of the
components has crashed or something else otherwise goes wrong.
Fixes#25093.
* evolution-shell-component-client.c
(result_from_async_corba_result): Handle
GNOME_Evolution_ShellComponentListener_CANCEL.
svn path=/trunk/; revision=16974
2002-05-21 Christopher James Lahey <clahey@ximian.com>
* e-corba-storage.c (async_open_folder_idle): Do async_open_folder
in an idle callback.
* e-shell-shared-folder-picker-dialog.c (user_clicked),
glade/e-shell-shared-folder-picker-dialog.glade: Added a select
names button here.
svn path=/trunk/; revision=16964
