callisto-debian/evolution
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a potential uninitialized argument in e-plugin-python.c.

Browse Source 
if (PyCallable_Check (priv->pClass))
		pInstance = PyObject_CallObject (priv->pClass, NULL);

	pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);

'pInstance' may be uninitialzed in call to PyObject_CallMethod().

Found by the Clang Static Analyzer.
This commit is contained in:
Matthew Barnes
2010-01-15 21:51:35 -05:00
parent cae22334fa
commit 0d17115d2c
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/plugin-python/e-plugin-python.c
View File

@ -101,7 +101,7 @@ plugin_python_invoke (EPlugin *plugin,
EPluginPython *plugin_python;
EPluginPythonPrivate *priv;
PyObject *pModuleName, *pFunc;
PyObject *pInstance, *pValue = NULL;
PyObject *pValue = NULL;
plugin_python = E_PLUGIN_PYTHON (plugin);
priv = plugin_python->priv;
@ -144,10 +144,12 @@ plugin_python_invoke (EPlugin *plugin,
if (priv->pClass) {
if (PyCallable_Check (priv->pClass))
pInstance = PyObject_CallObject (priv->pClass, NULL);
if (PyCallable_Check (priv->pClass)) {
PyObject *pInstance;
pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);
pInstance = PyObject_CallObject (priv->pClass, NULL);
pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);
}
} else {